Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Mar, 2015 22 commits
  3. 27 Mar, 2015 18 commits
    • skonig's avatar
      Re-enable mouse lock · c13a5f6f
      skonig authored 
      BUG=471290
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/1036413002

Cr-Commit-Position: refs/heads/master@{#322680}
      c13a5f6f
    • hashimoto's avatar
      Let sqlite use fdatasync() on Linux-based systems · 195310ab
      hashimoto authored 
      fdatasync() should be faster than fsync().

From sqlite3.c:
/*
** We do not trust systems to provide a working fdatasync().  Some do.
** Others do no.  To be safe, we will stick with the (slightly slower)
** fsync(). If you know that your system does support fdatasync() correctly,
** then simply compile with -Dfdatasync=fdatasync
*/

BUG=469071

Review URL: https://codereview.chromium.org/1035903002

Cr-Commit-Position: refs/heads/master@{#322679}
      195310ab
    • lazyboy's avatar
      <webview> Implement clear http cache API. · cbff2a79
      lazyboy authored 
      HTTP cache clearing methods have been refactored into a
separate class: StoragePartitionBrowsingDataRemover in
http://crrev.com/1033013003/

One method was exposed in WebCacheManager so we can
clear renderer/ cache for a given render process.

<webview> already has a set of data it can clear, this
CL adds "cache" to that set, similar to chrome.browsingData
API.

BUG=406437
Test=Load a <webview> in a chrome app, e.g.
the browser sample app:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser

Open inspector for the webview: from chrome://inspect,
switch to Apps, and inspect the tab that says "Google"
under "Browser sample". Switch to network tab in that inspector so you can monitor http requests.

Visit some page in the <webview>, for my test case,
I visited http://www.google.ca
Now look at the network tab for image requests (cause it
should be much simpler), e.g. nav_logo_195.png
Reload the page couple of times, observer the status code
for the image request, it should say 304 OK.

Now open the app's inspector: Same as above, but inspect "Browser sample"
instead. Call <webview> clear cache api from its console:

document.querySelector('webview').clearData(
  {since: 1},
  {cache: true},
  function() { window.console.log('clear complete'); })

Expect "clear complete" message to show in app's console.
Now reload the page one more time and check the same
image's request, it should say 200 OK instead of 304.

Review URL: https://codereview.chromium.org/1021073002

Cr-Commit-Position: refs/heads/master@{#322678}
      cbff2a79
    • dyen's avatar
      Enable gpu_times for android. · b2512c28
      dyen authored 
      The gpu_times metric has been known to be flaky but it seems that the
flakiness only affects desktop devices. Enable it on android only.

R=nednguyen@chromium.org
BUG=455292

Review URL: https://codereview.chromium.org/1041963002

Cr-Commit-Position: refs/heads/master@{#322677}
      b2512c28
    • erg's avatar
      html_viewer: Run with a cookie jar. · 617e549e
      erg authored 
      Ever since https://codereview.chromium.org/710803002/, we haven't been
exposing a cookie jar or a clipboard to html_viewer. This looks like an
accident during refactoring.

BUG=

Review URL: https://codereview.chromium.org/1037423002

Cr-Commit-Position: refs/heads/master@{#322676}
      617e549e
    • dfalcantara's avatar
      Add method for killing Tasks with the same Tab ID · 0c6fe288
      dfalcantara authored 
      Makes a method similar to DocumentUtilities.finishOtherTasksWithData(), but
specifically for killing tasks with the same DocumentTab ID.

BUG=445136

Review URL: https://codereview.chromium.org/1044513002

Cr-Commit-Position: refs/heads/master@{#322675}
      0c6fe288
    • maruel's avatar
      Roll tools/swarming_client/ to 13e7c88b5a9494467259603486f001694ea85721. · 934aaca0
      maruel authored 
      $ git log 53ef01328..13e7c88b5 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-03-26 maruel Add bot_delete command and add DELETE support to utils/net.
2015-03-24 maruel Print a proper error when the target directory exists.
2015-03-23 vadimsh Do not import oauth2client.crypt since it fails on bots.
2015-03-23 maruel Fix enumeration when using '&' in the url.
2015-03-23 maruel Do not print an exception if stdout is closed early.
2015-03-20 vadimsh Add support for service account.
2015-03-20 vadimsh Simplify authentication related code.
2015-03-20 maruel Do not hang if a grand children outlives the children process.

Add whitelist for pyasn1, it's BSD licensed.
Add whitelist for rsa, it's Apache v2.0 licensed.

R=vadimsh@chromium.org,phajdan.jr@chromium.org,thestig@chromium.org
BUG=471372

Review URL: https://codereview.chromium.org/1036243002

Cr-Commit-Position: refs/heads/master@{#322674}
      934aaca0
    • dnicoara's avatar
      [Ozone-Drm] Pick pending buffer over current buffer when modesetting · 294fce9a
      dnicoara authored 
      Buffers are expected to be scheduled/released in FIFO order. When
enabling a display we want to re-use a buffer to avoid flashes. As
such we need to make sure that the buffer used for modesetting is the
last buffer queued.

BUG=chrome-os-partner:38267

Review URL: https://codereview.chromium.org/1041823002

Cr-Commit-Position: refs/heads/master@{#322673}
      294fce9a
    • rdevlin.cronin's avatar
      [Extensions] Replace the developer_private.js extern with the autogenerated one · 5ed47247
      rdevlin.cronin authored 
      Automatic extern generation has gotten to the point where it yields a better
result than the somewhat hand-modified version (Yay!). Use the generated one
in the closure compiler externs.

BUG=469920

Review URL: https://codereview.chromium.org/1010083008

Cr-Commit-Position: refs/heads/master@{#322672}
      5ed47247
    • reddaly's avatar
      Allows all packaged apps to use the chrome.mdns API, and removes whitelist... · 68ea4900
      reddaly authored 
      Allows all packaged apps to use the chrome.mdns API, and removes whitelist that restricts the set of service type that can be discovered.

R=mkwst@chromium.org,mfoltz@chromium.org
BUG=426500

Review URL: https://codereview.chromium.org/668983003

Cr-Commit-Position: refs/heads/master@{#322671}
      68ea4900
    • paulmeyer's avatar
      Added myself to some guestview-related OWNERS files. · 5f681cc5
      paulmeyer authored 
      Review URL: https://codereview.chromium.org/1041973002

Cr-Commit-Position: refs/heads/master@{#322670}
      5f681cc5
    • ananta's avatar
      Fix a crash seen in Desktop Chrome Windows while displaying a bubble · 00a39f50
      ananta authored 
      It is not clear as to how this crash occurs. From the callstack, the crash occurs in the context of a bubble getting
created and before it is initialized. In the context of the bubble creation, DesktopNativeWidgetAura instantiates the IME
COM objects which instantiate a local COM server. This causes the main UI loop to be reentered and the bubble is resized in
this context. The WidgetObserver OnWidgetBoundsChanged method in the BubbleDelegateView gets invoked which crashes while
dereferencing the top level widget as it has not been initialized yet.

It is unclear as to how the WidgetObserver is set up here. From the code the BubbleDelegateView observer is setup after the
bubble is initialized, i.e in the BubbleDelegateView::CreateBubble function after the bubble is created.

Fix is to delay the initialization of the IME on Windows until we receive the first IME message or an input
language change notification

BUG=454375
TEST=None at the moment, as it is unclear as to how this crash can happen.

Review URL: https://codereview.chromium.org/1037103004

Cr-Commit-Position: refs/heads/master@{#322669}
      00a39f50
    • danakj's avatar
      Revert of Add switch (for cast_shell) to defer creation of GPU process.... · 6ab2e52d
      danakj authored 
      Revert of Add switch (for cast_shell) to defer creation of GPU process. (patchset #8 id:140001 of https://codereview.chromium.org/1038783002/)

Reason for revert:
Breaking mac browser tests?

http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/436

BrowserGpuChannelHostFactoryTest.AlreadyEstablished (run #1):
[ RUN      ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished
[35311:27139:0327/154011:20111614311426:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process.
[35311:27139:0327/154011:20111614504937:ERROR:browser_gpu_channel_host_factory.cc(134)] Failed to launch GPU process.
../../content/browser/gpu/gpu_ipc_browsertests.cc:179: Failure
Value of: event
  Actual: false
Expected: true
[  FAILED  ] BrowserGpuChannelHostFactoryTest.AlreadyEstablished, where TypeParam =  and GetParam() =  (215 ms)

Original issue's description:
> Add switch (for cast_shell) to defer creation of GPU process.
>
> For context - on Chromecast, we have the following scenario:
> * We support running in the background (i.e. not rendering anything)
>   with our service running in the browser process to listen for incoming
>   cast connections.
> * We cannot acquire any GPU resources (e.g. a GL context or surface)
>   during this time as another external application needs it, and it's a
>   global resource.
>
> We have supported starting up in the foreground and switching to this
> mode for a long time.
>
> But now, we need to support starting up in this mode.  In other words,
> we need to bring up the browser process and run our cast receiver
> service, but we cannot run any of the GPU process's initialisation
> code until an incoming cast arrives.
>
> BUG=internal b/19898960
>
> Committed: https://crrev.com/db7efe6dfbda08faa1e55cda4441b43dac005733
> Cr-Commit-Position: refs/heads/master@{#322655}

TBR=enne@chromium.org,nasko@chromium.org,piman@chromium.org,sievers@chromium.org,halliwell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=internal b/19898960

Review URL: https://codereview.chromium.org/1043603002

Cr-Commit-Position: refs/heads/master@{#322668}
      6ab2e52d
    • skia-deps-roller's avatar
      Roll src/third_party/skia 5cffba8:d8b34c2 · 1f496c60
      skia-deps-roller authored 
      Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5cffba8..d8b34c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1037293003

Cr-Commit-Position: refs/heads/master@{#322667}
      1f496c60
    • dtseng's avatar
      Enable chrome.automation.getDesktop on all aura platforms. · 35b188a9
      dtseng authored 
      - on Chrome OS, continue to enumerate all Aura windows when building the desktop tree via the Ash shell.
- on all other Aura platforms, lazily hook up top level windows that have been created in our object cache. This works by only presenting cached windows as children of the desktop node. Since serialization walks up the tree, we are guaranteed windows in the cache whenever a descendant view has an event fired upon it.

- allow ChromeVox to traverse the desktop automation tree on all platforms.

TEST=build ChromeVox webstore extension. Run it on linux chromium. Verify views-based UI reads.

Review URL: https://codereview.chromium.org/1003283002

Cr-Commit-Position: refs/heads/master@{#322666}
      35b188a9
    • reveman's avatar
      content: Remove non-thread-safe use of WeakPtrs. · fc8a910c
      reveman authored 
      Instead of avoiding to send IPC from ChildDiscardableSharedMemoryManager
dtor, make sure ThreadSafeSender instance is still valid at the
time dtor is called.

BUG=471246

Review URL: https://codereview.chromium.org/1035313002

Cr-Commit-Position: refs/heads/master@{#322665}
      fc8a910c
    • nyquist's avatar
      Add OWNERS file for the Java-part of Chrome sync code. · db35cf90
      nyquist authored 
      The Chrome sync code is implemented both in C++ and Java, and spread over the
//sync top level folder and through //chrome/browser/sync. In addition, there's
another part that lives in the Java-part of the directory tree:
//chrome/android/java/src/org/chromium/chrome/browser/sync

This CL adds a set of natural owners for that folder to help with the review
process.

BUG=None

Review URL: https://codereview.chromium.org/1039583002

Cr-Commit-Position: refs/heads/master@{#322664}
      db35cf90
    • danakj's avatar
      views: Move TopContainerView paint recursion to PaintChildren. · bdc4b62d
      danakj authored 
      Currently this class recurses to browser_view_->frame()->GetFrameView()
in OnPaintBackground. Instead, do this recursion in PaintChildren
so that it has access to the the recursion data to be passed through
PaintChildren.

R=sky
BUG=466426

Review URL: https://codereview.chromium.org/1036403002

Cr-Commit-Position: refs/heads/master@{#322663}
      bdc4b62d