Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 25 Aug, 2018 27 commits
  3. 24 Aug, 2018 13 commits
    • rbpotter's avatar
      WebUI Polymer 2 migration: Re-enable interactive_ui_tests · 8ed19ab9
      rbpotter authored 
      These tests were disabled by https://crrev.com/c/1176206 because
they were reported as flaky on debug builds. Based on the
flakiness dashboard, it appears the failures were timeouts on the
Win10 Tests x64 (dbg) bot. interactive_ui_tests is marked as
experimental on this bot due to crbug.com/840369. The
webui_polymer2_interactive_ui_tests suite is expected to have the same
behavior, so it should also be marked as experimental on this bot.

Remove the tests from the blacklist, as they should pass on other bots.

Bug: 875443
Change-Id: Ib5b3c99cf589b1ab9994346460e95ed746533ba6
Reviewed-on: https://chromium-review.googlesource.com/1187729Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586066}
      8ed19ab9
    • Wez's avatar
      Check that TaskScheduler is not leaked between tests, or test-cases. · 31890108
      Wez authored 
      This is a reland of a2a4e75d with a
work-around for cronet_tests' sharing libbase.so with libcronet.so in
component builds.

- Move some APIs off of base::TestSuite, that we unnecessarily public.
- Rename the various internal TestEventListeners to express purpose.
- Add CheckForLeakedGlobals check, and DisableCheckForLeakedGlobals API.
  The latter is called by the content::ContentTestSuiteBase, since the
  various browser- and ui-tests running under that suite base run more
  like the browser itself, and so are expected to let global singletons
  leak.

If tests fail or flake due to this patch, then this indicates that the
test is actually leaking global state that may break other tests if they
happen to run in the same process, leading to hard-to-diagnose flakes.

There are two main failure cases:
If the test directly or indirectly uses TaskScheduler, but does not
create a ScopedTaskEnvironment, then please add one to the test, or to
the test base-class, as appropriate, to fix it.
If the test suite cannot be fixed in this way then please add a call to
DisableCheckForLeakedGlobals(), with a comment linking to a bug for the
issue.

TBR: gab, sky, mef
Bug: 875486, 877355, 744567
Change-Id: Iaea38d24ede271c248a3abb0b3f7ee931c2538f5
Reviewed-on: https://chromium-review.googlesource.com/1187783Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586065}
      31890108
    • Steven Holte's avatar
      Restore UKM field dropped by a revert. · 495fae94
      Steven Holte authored 
      This field was dropped by a revert, but we have data for it, so re-add the description.
https://crrev.com/d38f4e3c1225c36574911f6fdeecdb1b236dd054

Change-Id: Ie68bc76ced75a1d6269b252801cda76baa5de9ff
Reviewed-on: https://chromium-review.googlesource.com/1188765Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586064}
      495fae94
    • Matt Mueller's avatar
      Move RegisterPathProvider() from ContentTestSuite to ContentTestSuiteBase · e0a83f96
      Matt Mueller authored 
      Fixes network_service_content_browsertests RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler
failing to find the utility service process exe on Windows, like:
[FATAL:utility_process_host.cc(263)] Check failed: false. Unable to get utility process binary name.

Bug: 876947
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia7f51366e4b4db27ec8c3bbee3d57866c1bd67b9
Reviewed-on: https://chromium-review.googlesource.com/1185628
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586063}
      e0a83f96
    • Steve Kobes's avatar
      Fix feedback loop in extension popup autosizing. · b9a57018
      Steve Kobes authored 
      FrameViewAutoSizeInfo should not add hypothetical vertical scrollbar
space when we already have a real vertical scrollbar.

The real scrollbar is included in the LayoutView's preferred width
(since crrev.com/397112).  If the redundant accomodation makes the
scrollbar detectably unnecessary, the next autosize reduces the width,
making it appear again.

The autosized FrameView now accomodates exactly one vertical scrollbar
in this scenario, instead of infinitely bouncing between two and zero.
The scrollbar could actually be removed even at this size, but the code
isn't smart enough to detect that.

Bug: 838150
Change-Id: I23dce5a37faed33de978e1d2182009a2fe0c6fd1
Reviewed-on: https://chromium-review.googlesource.com/1188767Reviewed-by: default avatarStefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586062}
      b9a57018
    • Joe Downing's avatar
      Decouple LocalInputMonitor sub-classes from ClientSessionControl · da1eb5e5
      Joe Downing authored 
      This change decouples the mouse/keyboard input monitors from
ClientSessionControl and allows them to be used for other purposes.

Bug: 877176
Change-Id: Idcefa8a8dd1d36bb57f83b8a27d8aba90981466f
Reviewed-on: https://chromium-review.googlesource.com/1189027Reviewed-by: default avatarJamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586061}
      da1eb5e5
    • Scott Little's avatar
      Update TestExpectations for flaky tests on Win7. · 75a4d21e
      Scott Little authored 
      The flaky tests are:

external/wpt/editing/run/delete.html?1-1000
external/wpt/editing/run/delete.html?1001-2000
external/wpt/editing/run/delete.html?3001-4000
external/wpt/editing/run/delete.html?4001-5000
external/wpt/editing/run/delete.html?5001-6000
external/wpt/editing/run/delete.html?6001-last
external/wpt/editing/run/forward_delete.html?1-1000
external/wpt/editing/run/forward_delete.html?1001-2000
external/wpt/editing/run/forward_delete.html?2001-3000
external/wpt/editing/run/forward_delete.html?3001-4000
external/wpt/editing/run/forward_delete.html?4001-5000
external/wpt/editing/run/forward_delete.html?5001-6000
external/wpt/editing/run/forward_delete.html?6001-last

external/wpt/editing/run/delete.html?2001-3000 isn't in this list since
it's already disabled elsewhere in this TestExpectations file.

TBR=foolip@chromium.org

Bug: 877104
Change-Id: I01dd8218bddc9c1c726da03a062a714fc4f1f56c
Reviewed-on: https://chromium-review.googlesource.com/1188896Reviewed-by: default avatarScott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586060}
      75a4d21e
    • Sergey Ulanov's avatar
      Disable cast ozone platform on Fuchsia. · 6bd34501
      Sergey Ulanov authored 
      Scenic is the only ozone platform usable on fuchsia. Previously,
when compiling with is_chromecast=true the cast platform was enabled,
so cast_shell wasn't compiling properly.

Bug: 877264
Change-Id: If40c4ad28678015a2e357f86336cf56e1c484ac7
Reviewed-on: https://chromium-review.googlesource.com/1187654Reviewed-by: default avatarMichael Spang <spang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586059}
      6bd34501
    • Chong Zhang's avatar
      NetworkService: Migrate Clear-Site-Data · fdbb7e9d
      Chong Zhang authored 
      This patch copied 'clear_site_data_throttle.h/.cc' into
'clear_site_data_handler.h/.cc' with the following differences:
1. The new handler will be called through the |NetworkServiceClient|
   pipeline to work with Network Service.
2. The new handler doesn't have special handling for Service Worker.
  * The assumption is that the response from network process
    (NetworkServiceClient) won't be modified by Service Worker.
3. The new handler won't defer console messages for navigations. Future
   works could fix this to match current behavior (marked as TODO).
4. The new handler will always defer the request if it has
   'Clear-Site-Data' header, and resume after the browser finished
   processing.

We have to duplicate the codepath because
|NetworkServiceNetworkDelegate| currently doesn't work without Network
Service, and the new handler interface has no information about Service
Worker.

This patch fixed all Clear-Site-Data related tests (10 browser tests
and 2 layout tests).

crbug.com/876931 tracks remaining non-Canary blocking TODOs.

Bug: 721398
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I065140ab49ab3647cba0e64717440d0f1bf42095
Reviewed-on: https://chromium-review.googlesource.com/1170200
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarMartin Šrámek <msramek@chromium.org>
Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586058}
      fdbb7e9d
    • skia-chromium-autoroll's avatar
      Roll src/third_party/skia 1118cfdbdcc2..92bc476c8c49 (14 commits) · 765de895
      skia-chromium-autoroll authored 
      https://skia.googlesource.com/skia.git/+log/1118cfdbdcc2..92bc476c8c49


git log 1118cfdbdcc2..92bc476c8c49 --date=short --no-merges --format='%ad %ae %s'
2018-08-24 herb@google.com Rearrange templates to get ios to compile
2018-08-24 scroggo@google.com Revert "Reland "Switch SkCodec to use skcms" plus fixes"
2018-08-24 robertphillips@google.com Fix drawRect
2018-08-24 herb@google.com Have GPU and RemoteGlyphCache share mask position code
2018-08-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 8ca60805916f..337bd6984078 (2 commits)
2018-08-24 liyuqian@google.com Remove gclient sync from calmbench
2018-08-24 herb@google.com Add back tight scaler context managment
2018-08-24 allanmac@google.com Cut-and-paste typo was limiting concurrency
2018-08-24 scroggo@google.com Reland "Switch SkCodec to use skcms" plus fixes
2018-08-24 brianosman@google.com Reland "match sRGB primaries with skcms"
2018-08-24 ethannicholas@google.com fixed skslc's nested conditional break detection
2018-08-24 herb@google.com Reorganize TrackLayerDevice and move processGlyphRunForMask
2018-08-24 robertphillips@google.com Suppress failing Vulkan test on IntelHD405
2018-08-24 kjlubick@google.com [PathKit] Write more complete docs and clean up API to be consistent


Created with:
  gclient setdep -r src/third_party/skia@92bc476c8c49

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@chromium.org

Change-Id: Ib5356de96cb02bd534c76b2a390ef6212fdb6144
Reviewed-on: https://chromium-review.googlesource.com/1188924Reviewed-by: default avatarskia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586057}
      765de895
    • Dimitri Glazkov's avatar
      Push deps on buildbot/filters down to test.gni. · c95e6dde
      Dimitri Glazkov authored 
      This clarifies dependency on test filter data, since
it is only used by the "test" template.

Also, it paves the path for building v8 on Fuchsia
standalone: the "fuchsia_package_runner" template
can be used directly in v8 repo, and in v8-only
checkout.

Change-Id: Ibe171c48ee818cc5b722294f682f83c3ae240908
Reviewed-on: https://chromium-review.googlesource.com/1180731Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Dimitri Glazkov <dglazkov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586056}
      c95e6dde
    • John Z Wu's avatar
      Catch EvalError thrown by element.js in translate. · cdc60729
      John Z Wu authored 
      CSP can prevent eval and will cause this error:
"refused to evaluate a string as javascript because 'unsafe-eval'"

This fails silently on iOS so we need to catch it.

Bug: 686364
Change-Id: I5de275576670846dffc29f9f2c3916259196e70f
Reviewed-on: https://chromium-review.googlesource.com/1183944Reviewed-by: default avatarDavid Roger <droger@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586055}
      cdc60729
    • Brandon Wylie's avatar
      [EOC] Capture UMA metrics for page view time · 4bad1cdf
      Brandon Wylie authored 
      Bug: 875088
Change-Id: Ic5edb56d0621c6685d6cb1cfe03f54e57990c068
Reviewed-on: https://chromium-review.googlesource.com/1182670
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: default avatarRobert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: default avatarFilip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586054}
      4bad1cdf