- 04 Mar, 2020 40 commits
-
-
Rune Lillesveen authored
Also add xiaochengh@ as an owner. Change-Id: Ia059c2d17768e286a330157bf7009c3bbe949fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083171Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746885}
-
Elly Fong-Jones authored
This change introduces a new method WidgetDelegate::WindowWillClose() to allow WidgetDelegates to hook into the Widget lifecycle *after* the decision that the widget will definitely close has been made but *before* any internal state of the Widget has actually begun to destroy. This change then has DialogDelegate use that new hook to implement the close-callback behavior, rather than having the close callback come via DialogClientView. Before this change: 1. [user presses Accept on a dialog] 2. DialogClientView::ButtonPressed() 3. DialogClientView::AcceptWindow() 4. DialogDelegate::Accept() [returns true] 5. Widget::CloseWithReason() 6. NonClientView::CanClose() 7. DialogClientView::CanClose() 8. DialogDelegate::Close (!) [returns true] After this change: 1. [user presses Accept on a dialog] 2. DialogClientView::ButtonPressed() 3. DialogDelegate::AcceptDialog() 4. DialogDelegate::Accept() [returns true] 5. Widget::CloseWithReason() 6. WidgetDelegate::WindowWillClose() This returns ClientView::CanClose() to being a pure predicate, at least for DialogDelegate, rather than a method that has side-effects. Other subclasses of ClientView still have issues with mixed behavior in this regard. This also centralizes the logic for delivering Accept/Close/Cancel callbacks inside DialogDelegate, which removes some complexity from DialogClientView. Bug: 1011446 Change-Id: I96519d6fa4c374de4f06de22c30c4ab5ac03d98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071037Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#746884}
-
Will Harris authored
BUG=961831 Change-Id: Iaf98c71732e029d68cc6e97d5f9911676a154bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079649Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746883}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5ff1de5384c5..2e6cd9c400d1 git log 5ff1de5384c5..2e6cd9c400d1 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 amaiorano@google.com Subzero: don't assert about lack of atomic load/store on x86 2020-03-04 amaiorano@google.com Fix Regres regression post CMake var renaming Created with: gclient setdep -r src/third_party/swiftshader@2e6cd9c400d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I72a13bbc81fee9c81ab3e8ba7d9a5b49c9e37e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746882}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/420ad1af1ef1..589b41e743db git log 420ad1af1ef1..589b41e743db --date=short --first-parent --format='%ad %ae %s' 2020-03-04 kthelgason@webrtc.org Change ownership of encoded data buffer in H264 encoder. Created with: gclient setdep -r src/third_party/webrtc@589b41e743db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I74d8c06434c250b0b3fdfa666147e0a117622a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087937Reviewed-by:
-
Joshua Pawlicki authored
This covers the --server, --uninstall, and --ua paths. --service and --install are not changed in this CL. Change-Id: I68f0dfd9e27f89bac0b27f1fd3c3a0a4b9807564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081525 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746880}
-
Stephen McGruer authored
This test is blocking the WPT importer, because it fails with non-deterministic output which means the expected text never matches. Just mark it as failing to unlock the importer. TBR=robertma@chromium.org Bug: 1058403 Change-Id: I00cdc0e3e7b819673cc3fb4110e54440789470a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087420Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746879}
-
Stephen Roe authored
This saves log_listener output from blink web tests running on Fuchsia to the system.log file in the test output isolate, for better debugging of errors inside the Fuchsia VM. Bug: 1055553 Change-Id: I7c3ce011dfd11d381532511bbe53e505e785284d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086052Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#746878}
-
Tim van der Lippe authored
All devtools startup tests have been removed and replaced by end-to-end-tests in the front_end repository. This allows us to remove the support from the backend that handled the bootup of startup tests. R=yangguo@chromium.org Bug: 1044632 Change-Id: I5b0744019d91043dbd6b2b5c04458ff1471da767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087763 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#746877}
-
Anna Malova authored
- Convert OnUpdatedRTTAvailableCallback - Convert ShouldNotifyRTTCallback Bug: 1007815 Change-Id: Ic76b0c5ee815359ccdd98c32588fb5dc9b2a5539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087625 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746876}
-
Ana Salazar authored
Bug: 1049705 Change-Id: I70e9dbd7a312bbd2f0418733d14ab0857db0e432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086257Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746875}
-
Stephen Chenney authored
The "base" attribute was mistakenly added to the Blink.*.UpdateTime metrics in a recent CL. It prevents the metric being suggested in the UMA dashboard, and leads to a warning message on the histograms. Bug: 1058113 Change-Id: I7454a132623c8bc42fbda5d8896aa8e6dd4c2382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085294 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#746874}
-
Collin Baker authored
If RootView::OnMousePressed() receives a mouse press that is handled by a child view, than a subsequent double-click mouse press that is *not* handled, it should still report it as handled to the caller. My previous CL crrev.com/c/2029087 broke this behavior, always reporting a double-click as handled regardless of whether the first click was handled. This CL fixes it and adds regression test coverage. Fixed: 1055674 Change-Id: Ib2289a47b94ffa268160face6d4b6ebaf0dc504c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086259Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#746873}
-
Anna Malova authored
Bug: 1007815 Change-Id: If634796e8d7496aa378d65eb4ca00e93407f3944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087628 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Jarryd Goodman authored
Align formatting with origin representation used on settings pages. Also fix link to sorted AllSites frorm storage pressure alert. Bug: 997258 Change-Id: Ie3122dfb4e431a2d9ab225812d02d036632b161b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086324Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746871}
-
Xing Liu authored
We will work on a new feature related to this, so extend the expiration date here. Bug: 1057675 Change-Id: Ie6d8994a3b2f4004f3341b247c30828206dae1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086320Reviewed-by:
-
Piotr Bialecki authored
Follow-up to https://crrev.com/c/1994304. Bug: 1058055 Change-Id: I6813a612eebb36b9e747803d241d3066359eb0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085847 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#746869}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/74e0991a6bbc..040b65bece28 Created with: gclient setdep -r src-internal@040b65bece28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If6064dc905dce1d51105342a8714692a504798b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087942Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746868}
-
Min Qin authored
This will allow download in public chromium build to work on Q with MediaStore. BUG=1052490 Change-Id: I31476292b92c7a5882fa4ad80cc60b29f6b14dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057806Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746867}
-
Leonid Baraz authored
Changed namespace from media:: to policy:: for IntervalMap<...> and Interval<..> No functionality changes Bug: b/144279234 Change-Id: I1ebf9f005e779d813c0a25b777f9d02fa995d70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080790Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746866}
-
Colin Blundell authored
This CL moves knowledge of the //chrome-level AutofillAssistant out of ExternalNavigationHandler.java and into ExternalNavigationDelegateImpl.java via the ExternalNavigationDelegate interface. This change is a step toward componentization of ExternalNavigationHandler.java for sharing with WebLayer. Via this change, we also eliminate knowledge of //chrome's Tab object from ExternalNavigationHandler. The bulk of this change is in the tests, as ExternalNavigationHandlerTest had several tests of the functionality that this CL moves. We split those tests across the test of the handler and the test of the delegate impl: the tests in the handler now test that the handler behaves as expected when the intent is/is not handled by the the delegate in this case, while the delegate impl tests test that the behavior of the production method is as expected (i.e., these tests contain the bulk of the logic that was previously in the handler-level tests of the production code). Change-Id: If950a3fac701744af4610173e5c221bdb8a8a7c1 Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081418 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#746865}
-
Matt Menke authored
This is what we're planning on shipping, so seems best to have default behavior match that. Alone, this flag has no effect aside from fully populating NetworkIsolationKeys. In order for that to change behavior, flags to enable respecting NIKs at other layers have to be enabled. Bug: 993801 Change-Id: I6647b813ddf32262bf59a84a0219e3a13489096f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087895Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746864}
-
David Tseng authored
When arrowing by line (up/down) through a text area and encountering a blank line in braille before: - braille would not correctly clear the previous line contents - e.g. "Testing testing one" "Testing testing" would remain displayed even though the caret was on the second (blank) line. after: Arrowing by line results in - blank display - a blinking cursor over the first cell Change-Id: I1cd770644f78c60e2c4cf4d074da5c048aff9e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085155 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#746863}
-
Yuly Novikov authored
1. Due to performance improvements we don't need as many shards now. 2. '\*' in filter was needed only on command line, launcher uses just '*'. TBR=kbr Bug: angleproject:4426, angleproject:4421 Change-Id: I97b1345cbfa592931f0f3dead05397b9f6b1c029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086299Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#746862}
-
Jonathan Backer authored
Bug: 1019787 Change-Id: Ib78e2b969d9fe27ec63895e7ecb8f8ea755d0309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087423Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746861}
-
Donn Denman authored
Temporarily disable the whole test suite due to multiple recent flakes. TBR=twellington@chromium.org BUG=1058362 Change-Id: Ie51fe66053cf346c2c8202635b7c5c11ad6d9f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088007Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746860}
-
Julie Jeongeun Kim authored
This is a reland of 99fe56da It doesn't change anything since it's reverted due to the precursor CL, 52dbe8bb. The precursor CL is relanded at https://crrev.com/2071164. Original change's description: > Convert FrameMsg_EnforceInsecureRequestPolicy to blink RemoteFrame mojom > > This CL converts FrameMsg_EnforceInsecureRequestPolicy to method on > blink RemoteFrame mojom. It also updates the unit test with > intercepting RemoteFrame and removes checking the IPC message. > > BUG=1047284 > > Change-Id: I9578c49cfcc08b3a682ec2899627dc6503965654 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038513 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#743924} Bug: 1047284 Change-Id: I9f76888894caf55bd3c664b4fe4eb8254a778223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081717 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#746859}
-
Xinghui Lu authored
Previously, verdict_cache_manager is managed by services_delegate. This is not a typical way of managing objects keyed by a profile. In this CL, make verdict_cache_manager a child class of keyed_service. Also introduce verdict_cache_manager_factory as a keyed service factory to manage it. Bug: 1058179,1057937 Change-Id: Ia43d05c3f05f597770e906b1c6e20e8626fc7021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085632Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746858}
-
Brandon Wylie authored
Clients aren't expecting it and fail. Bug: 1058198,1015174 Change-Id: I8b06b1f47a963e5f3a300f2bc35311f64a43f2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086260Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746857}
-
Xiaohan Wang authored
This already exists in EmePromiseSystemCode and EmeTimeToResolvePromise but somehow got missed in EmePromise. Change-Id: Ibfd3cda5b19ef732c9393ebcdfbd99857a7059d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085708Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746856}
-
Kurt Horimoto authored
crrev.com/c/2005903 was an incomplete solution because the util functions generating the keyboard accessory views was only called once per OmniboxCoordinator's lifetime. This CL updates the coordinator to observe the voice search availability and reconfigure the keyboard accessory views when availability changes. Bug: 998524 Change-Id: Ica88b4690fac0ada1be6cc77bb6ca911f5a245e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075045Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746855}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fd4f5cda74d..fb875c61cf00 git log 0fd4f5cda74d..fb875c61cf00 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 taylori@google.com Merge "perfetto-ui: Fix thread state colors" Created with: gclient setdep -r src/third_party/perfetto@fb875c61cf00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I332fdeb99c434691a78e4868c341926b6aad8320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087940Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8800de8931b3..4eb885a01e2c git log 8800de8931b3..4eb885a01e2c --date=short --first-parent --format='%ad %ae %s' 2020-03-04 gabriel.luong@gmail.com Migrate Console and SegmentedRange tests into Ninja build 2020-03-04 gabriel.luong@gmail.com Rename Console.ts to Console_test.ts and SegmentedRange.ts to SegmentedRange_test.ts 2020-03-04 tvanderlippe@chromium.org Generate InspectorBackendCommands.js on presubmit 2020-03-04 mathias@chromium.org Support emulating vision deficiencies 2020-03-04 tvanderlippe@chromium.org Generate SupportedCSSProperties.js on presubmit Created with: gclient setdep -r src/third_party/devtools-frontend/src@4eb885a01e2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1003700,chromium:1011811,chromium:1056614 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib01838c63e7928913ae596ff280cf8a9fba0fbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087943Reviewed-by:
-
Gang Wu authored
https://chromium-review.googlesource.com/c/chromium/src/+/2063037 moved code to ShareImageFileUtilsTest.java, and removed file from build file, but forgot to delete this file. Change-Id: I00715dad85a69a73df5555097970ad0bc489c893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076524Reviewed-by:
-
Nina Satragno authored
Enable the WPTs on the CI. Fixed: 1054809 Change-Id: I4029d8aa5f5a1cf1a8130c9331d528b4b9707add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079340 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746851}
-
Henrique Nakashima authored
This allows caching int-typed field trial parameters for use before native is loaded. Bug: 1041865, 1012975 Change-Id: I9192d5fc7ee27dd617843e3afc5355d274d6e48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086255Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746850}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f283eb209ad..27a813089d83 git log 3f283eb209ad..27a813089d83 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 xiaoxuan.liu@arm.com Vulkan: Re-enable RobustResourceInitTest.Texture test Created with: gclient setdep -r src/third_party/angle@27a813089d83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0e5f67e9418758e29adb3ac542e2237473f59dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087936Reviewed-by:
-
Stephen Chenney authored
There are too many Blink.UpdateTime events, resulting in significant "sampling" by the UKM system which in turn leads to way low client counts. Fix it by emitting two samples per page load: once before First Contentful Paint and one after, chosen uniformly at random within in period. Modify the test to test the new approach as best can be done. Design Doc (chromium.org): https://docs.google.com/document/d/1P49GrDe3mDDV9Q1yUm27ioWE4m1_Zz1FwRwVwGQh-ZI/edit?usp=sharing Bug: 1014195 First pass at updating sampling. Change-Id: I4461015346d506adf5d01bc65e14538d05f2b798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083686Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#746848}
-
Connie Wan authored
The primary feature change is in the group header. See inline comments for an issues I had with the editor bubble: the text field, which automatically gets focus when the bubble opens, would also spawn a context menu. There isn't a single event (in the sense of a keyboard event or mouse event) that catches this, so I had to manually work around stopping the propagation. Bug: 1056362 Change-Id: I8ca7f10bc4b05ece0ed1eb52be61a0341210e182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079835 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746847}
-
Alexandre Frechette authored
This reverts commit d65a5ea7. Reason for revert: Causing build failures in `blink_web_tests on ATI GPU on Mac Retina` and `blink_web_tests on Intel GPU on Mac`. Original change's description: > [DevTools] Support vision deficiency emulation in CDP > > This patch makes it possible to emulate various vision deficiencies, > including color vision deficiencies and blurry vision, in the Blink > Renderer. The various deficiencies can be triggered by the new > Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools > Protocol. > > Design doc: https://goo.gle/devtools-cvd > > Bug: chromium:1003700 > Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746715} TBR=caseq@chromium.org,vogelheim@chromium.org,mathias@chromium.org,futhark@chromium.org Change-Id: I596637b0b55eb04bd9adc99d3ef76b820eaf2fff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088013 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#746846}
-
