- 27 Sep, 2020 29 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601185204-f94c687281888552298caf7544ad9515cd75dc6d.profdata to chrome-mac-master-1601207727-a01abff7a6bd2da6f6116384bec1a348a3a7afe9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: Icdf5d06d39e72feecdaf424c4a3080f0f2623b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811052}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601185204-ea08500963e5ec1d97fc799611c84c5499e59042.profdata to chrome-linux-master-1601207727-0dd0eb0febc74c41e7a623fe044ff01ea199dede.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I360a4e2bed07474701c46c26b4779d36a159e44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aaed4d13394f..d6aeaf33afbe 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b973b8986bf6bb1f9b70d7d11a444c6b2b5475c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433887Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8143fd83dbbd803046e308580bfd178cf2d41b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433886Reviewed-by:
-
Jinsuk Kim authored
user_education/ is used as a shim allowing the classes in chrome/android::chrome_java to use feature_engagement component. This CL modularizes it under chrome/browser/user_education so that toolbar/ can use it without relying on chrome_java. Bug: 1127732 Change-Id: I33d2e4851914f743f72540181f1cc222f2c6d70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422060 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811048}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3db8535d3a9..111de34102c7 2020-09-27 marinaciocea@webrtc.org Revert "Delete the non-const version of the EncodedImage::data() method." 2020-09-26 deadbeef@webrtc.org Fix for OnSctpInboundPacket being called after transport destruction. 2020-09-26 tommi@webrtc.org Move win32 files to a new "win32" target to avoid cyclic dependencies. 2020-09-25 peah@webrtc.org Clean up the AVX2 activation in the gni file 2020-09-25 ricebin@google.com Allow clients to provide custom scheduler to AudioModule 2020-09-25 peah@webrtc.org Reland "Activating AVX2 support by default" 2020-09-25 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator min consecutive speech frames (1/3) 2020-09-25 alessiob@webrtc.org AGC2 VAD probability: instant decay / slow attack 2020-09-25 nisse@webrtc.org Delete the non-const version of the EncodedImage::data() method. 2020-09-25 peah@webrtc.org Revert "Activating AVX2 support by default" 2020-09-25 alessiob@webrtc.org AGC2 VadWithLevel(::LevelAndProbability) renamed + injectable VAD 2020-09-25 tommi@webrtc.org Make MessageHandler be a pure virtual interface. 2020-09-25 peah@webrtc.org Activating AVX2 support by default 2020-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 063275b4..0957d98f (810396:810507) 2020-09-25 kwiberg@webrtc.org Fix RoboCaller::Send perfect forwarding If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127774 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I663abdef701485f79a495a4af0f3ff1790095b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433884Reviewed-by:
-
Nazerke authored
This CL adds a view controller for the TabStrip and adds it as a property to TabStripCoordinator along with other its required properties. Bug: 1128249,1130401, 1130400 Change-Id: I891ee1f2d5551aba7ce39c7fa68d8dfe0c56ac3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421108Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#811046}
-
Jinsuk Kim authored
Triggering requests may come after the action delegate is nulled out when the activity is being destroyed, which can cause crashes for swipes on the rendered pages. This CL checks the situation and ignores the requests accordingly. Bug: 1131424 Change-Id: I4914ef220638ea69cf1522aa2ac974c73ed89ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428512 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811045}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25acdad71bae..fab653f821de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I89d643f0b2e5de2e01ae36b24708b2650e9619f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433078Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811044}
-
Satoshi Niwa authored
If launchParams.searchQuery is set, 1) Performs a search at Files app start up. 2) Select the first root directory that contains one or more query-matched files. Also did refactoring around DirectoryModel.createDirectoryContents_(...) - Split createDirectoryContents_ into 2 functions isSearchDirectory(...) and createScannerFactory() - Removed all DirectoryContents.createFor*(...) functions. For now we expect that the searchQuery param is used only when Files app is launched as Android file picker. 1) and 2) are required by DocumentsUI CTS (See go/arc-r-documents-ui) Bug: 1126742 Test: atest DocumentsTest#testGetContentWithQuery_matchingFileShowing Change-Id: I1a76a93ee7fbf7ce7ae3fdd2a3dc408311bbd12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408502Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811043}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I04c734f74b61a785b0c37210bbd1a13e3c5d5ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431418Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811042}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601161893-c98711c556128fe090127be76465e02b263358c0.profdata to chrome-linux-master-1601185204-ea08500963e5ec1d97fc799611c84c5499e59042.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ife984df8eebe63c740bb5f4d05fbab3b39dde6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433717Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601161893-754a2aafc98ad7a6afd910c0b7dd36e782bfe76d.profdata to chrome-mac-master-1601185204-f94c687281888552298caf7544ad9515cd75dc6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I71738c95f8aab7edf3702c5ee5d3e14f69bb0b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433714Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c28560a53906..aaed4d13394f 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icaf177c0eb6a6b14ddd3517252c0391f836683cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433797Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eabce08bb2f2..0922403dcdc6 2020-09-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: Ic33d94ece81c8cb3f5a95c4809d608467c9c5cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433796Reviewed-by:
-
Pavel Yatsuk authored
This is a basic implementation of MessageQueueManager. MessageQueueManager: - maintains a queue of messages and a mapping from message key objects to MessageStateHandlers. - shows the message at the head of the queue - hides and dismisses the message when it gets dismissed through the API BUG=1123947 R=lazzzis@chromium.org Change-Id: Ifa3fbba6162323bdc79305796472fdaea0829ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416740 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#811037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie72832249a82eace947bf1ffe9927e72f675252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433603Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ddef7a04a2d3..ed2b465f8607 2020-09-27 jiawei.shao@intel.com Report more detailed error information for the failures of mapAsync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2913a4925ec804aa90f6c658f35c3f387fe4b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1815d86a224b..d0e7ed37fc4e 2020-09-27 cstout@chromium.org [spirv-remap] Fix undefined behavior in hashing (#2403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I7eefd643d430a39345a3081b3bf3dce49b96c457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7950eb55c076..c28560a53906 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9be59235f9aefa0e3ef20acb6674e13014cc8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433785Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601143179-1807d013279f571b26d42737d0da6c008dd25766.profdata to chrome-mac-master-1601161893-754a2aafc98ad7a6afd910c0b7dd36e782bfe76d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib976d6e3040067f412fa44b4903e8043f42b968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433599Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601143179-7e0fff784977a232da08a71c4f8ef38f5aa5597c.profdata to chrome-linux-master-1601161893-c98711c556128fe090127be76465e02b263358c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I452d22410810f73db2b1b1e48dfbeb3348e6723c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433597Reviewed-by:
-
Claude van der Merwe authored
The following changes are made: 1. WifiSyncFeatureManager is injected into FeatureStateManager. 2. PerformSetFeatureEnabledState relies on WifiSyncFeatureManager to set enable/disable Wifi Sync, which acts as a global toggle. 3. GetEnabledOrDisabledState relies on WifiSyncFeatureManager to get the enabled/disabled state for Wifi Sync. 4. Add fakes for WifiSyncFeatureManager to be used in feature_state_manager_impl unittests Bug: 1117619 Change-Id: I68e6cad0e9d878d4029dea9cfeedc52dcee4a4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419451 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#811030}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dff9331631e4..6f521921351e 2020-09-26 syoussefi@chromium.org Vulkan: Use one triangle for full-screen utils 2020-09-26 syoussefi@chromium.org Revert "Add a small unit test that dumps system info." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I62e4b00da2b954fa5539d79b8e5698e9315ccabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433531Reviewed-by:
-
Reilly Grant authored
On systems with both the built-in serial driver and a third-party driver the same port can be enumerated more than once. This difference is visible to the user in the device path shown in the chooser but was previously ignored when constructing a persistent ID for the port. This patch replaces the generic persistent ID field with the individual components that are available on each platform. This should make it easier to modify these rules over time as the components won't be opaque to SerialChooserContext. This is a breaking change which will cause previously granted persistent permissions to be ignored. On macOS the name of the USB driver (the parent of the BSD serial port) is now included in the set of fields used to identify a device in order to differentiate between USB devices with otherwise have the same USB vendor ID, product ID and serial number. Bug: 1127535 Change-Id: If1b06ab82a975976e1e3b7d2075216f11afda5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413176 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811028}
-
Antonio Gomes authored
Some constants in ash_constants.h are used in BrowserNonClientFrameViewAsh. In order to make this class available to lacros, these constants need to be factored out, once lacros chrome can not link to ash symbols. The following constants are moved: ash::kDefaultFrameColor ash::kResizeAreaCornerSize ash::kResizeInsideBoundsSize ash::kResizeOutsideBoundsSize ash::kResizeOutsideBoundsScaleForTouch now under the `chromeos` namespace. Also, CL adds a README.md to chromeos/ui directory. This is phase 2.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org Change-Id: I01cf20ed5a77f752fee2c72df0d5cb0cf42125a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429441Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#811027}
-
Kyle Horimoto authored
Bug: 1132577 Change-Id: I8b74aabd4153f18ad823ac4d5384a2c0d47afa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433063 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811026}
-
Mei Liang authored
crrev.com/c/2399314 uses a focusable PopupWindow for accessibility support. The focusable PopupWindow catches the system back button event and dismisses the PopupWindow directly without going through the TabSelectionEditorMediator#hide, where it updates the TabSelectionEditorProperties#IS_VISIBLE property from true to false. The TabSelectionEditorProperties#IS_VISIBLE remains to be true. Then TabSelectionEditorMediator#show is called again to show the TabSelectionEditor has no effects. Since there is no property change, the binder will not get triggered. This CL fixes the issue by setting the TabSelectionEditorMediator#hide as a Runnable to the TabSelectionEditorProperties, then binding it to the TabSelectionEditorLayout and triggering the Runnable when the PopupWindow is dismissed. Everything introduced in this CL is gated by by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout". Most of the code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The changes in following files can't be verified by the tool, but it is expected and no-op without the flags: * The new property in TabSelectionEditorProperties Bug: 1132478 Change-Id: I774d13714445e76da9c9ef4573412b62bf042039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432969 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#811025}
-
Claude van der Merwe authored
WifiFeatureManager adds global enable/disable functionality for Wifi Sync V2. WifiFeatureManager asynchronously enables/disables WIFI_SYNC_HOST for a synced device on the back-end, and provides retry logic if the network request fails by storing the last pending request in prefs. Bug: 1117619 Change-Id: Ide945c00e5eb060dd86b11b31e1a830aa1fde3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419332 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
-
- 26 Sep, 2020 11 commits
-
-
Sharon Yang authored
Make sure video decoding is only enabled when the feature flag HARDWARE_VIDEO_DECODER is set. Bug: 1004461 Change-Id: I1fca519539a508c6b59e8997db11d1efe112940e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363174 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811023}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_PLo7f0AOfM Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I40c8d6cccc9e42457047f9dd79f74ab568e91596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426967 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811022}
-
Yuly Novikov authored
Cover GTX 1660 in addition to Quadro P400. TBR=bsheedy Bug: 1060024 Change-Id: Ic94428628ec6fa7fc3c53f92651850225626046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433309Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811021}
-
Ben Pastene authored
With crrev.com/c/2432127, every CrOS HW test has the --flash arg embedded into the generated wrapper script. So some tests now have '--flash' show up twice on their cmd line. This'll fix that. This also removes the unrelated but old "--vm-logs-dir" arg that's no longer used. Bug: 1132373 Change-Id: If595fdb4ab4f747c547082d7a210be17c9ecd431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432851 Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#811020}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc972dc72cd9..25acdad71bae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Id8c207ce58e07e642f59d0e3ccca91fce3cd323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433519Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc4e3cf24f9b..dff9331631e4 2020-09-26 jmadill@chromium.org Add Skia Gold CIPD package to DEPS. 2020-09-26 cclao@google.com Vulkan: Move mReadOnlyDepth out of FramebufferDesc 2020-09-26 cclao@google.com Vulkan: Use DepthStencilReadOnly when it is read only. 2020-09-26 jmadill@chromium.org Add a small unit test that dumps system info. 2020-09-25 syoussefi@chromium.org Vulkan: Workaround vkCmdClearAttachment bug on Pixel 2020-09-25 jmadill@chromium.org Enable Vulkan SystemInfo on more platforms. 2020-09-25 syoussefi@chromium.org Vulkan: Make UtilsVk not contribute to occlusion queries 2020-09-25 ynovikov@chromium.org Skip BootAnimationTest.DefaultBootAnimation on Win NVIDIA Vulkan 2020-09-25 timvp@google.com Vulkan: Link PPO during draw validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* Change-Id: I018e6f8c72d7ea2ed7890fa76364da281148d9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433508Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5b4d110a2b90..0081a12803bf 2020-09-26 brucedawson@chromium.org Miscellaneous fixes to post_build_ninja_summary.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941669 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I05b5c2c4f08bfbcda0d48702da2f969ed6307342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433518Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2bf6561211e0ef1be91c8f4a06b2dfcd4505f475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433516Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601120384-3673cc2f8767c2ae76b18a20724f2e99ef5174cb.profdata to chrome-mac-master-1601143179-1807d013279f571b26d42737d0da6c008dd25766.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I70094780c52c621236a5d69dbff41741988413f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433517Reviewed-by:
-
Keishi Hattori authored
NOT_DESTROYED() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected. NOT_DESTROYED() should be the first statement for all methods on LayoutObject and its subclasses. Bug: 1030176 Change-Id: If20c810b925ed0a9bd6df36ea75dc4bdd3b0b147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426210 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#811014}
-
Xianzhu Wang authored
When we switch on "create layers after paint" and back, the contents of the original GraphicsLayer::CcLayer() and RasterInvalidator which are not used during "create layers after paint" may not be valid. Invalidate them to ensure correct rendering. Bug: 1132218 Change-Id: Ia717e8202e2627cedbc9e5305619223a5a833f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432766Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811013}
-
