- 19 Jan, 2018 9 commits
-
-
Yuichiro Hanada authored
When seeing a reserved keyboard shortcut, exo display server sends keyboard leave/enter event with pressed keys information instead of key events. only one IME is enabled. Bug: 801088 Test: Manual. Confirm that Ctrl-Space is sent to Android apps when Change-Id: I207434b45690f231601cb6187e35a806f8c69f89 Reviewed-on: https://chromium-review.googlesource.com/866655Reviewed-by:David Reveman <reveman@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#530360}
-
Renee Wright authored
Bug: 775360 Change-Id: I27ee051b48ca02cd6021638fb6a269a584b41384 Reviewed-on: https://chromium-review.googlesource.com/872692Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#530359}
-
Sorin Jianu authored
TBR: creis Bug: 803641 Change-Id: I72aec7f22a7e9af818e9b27576a378095b8d4f46 Reviewed-on: https://chromium-review.googlesource.com/875189Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530358}
-
Daniel Bratell authored
The GetLocalState() method in cryptauth clashes with another GetLocalState() in jumbo builds, and since there is only one caller off this one, it might as well be inlined. Bug: 746957 Change-Id: I63e33c5c94930cd0dfeaa27c1421ce81c9865feb Reviewed-on: https://chromium-review.googlesource.com/873922Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#530357}
-
Eric Lawrence authored
Update entries in the HSTS preload list. TBR=palmer@chromium.org Change-Id: Idee0e0204f0027747fab7db2f45e7338a7c00bd3 Reviewed-on: https://chromium-review.googlesource.com/874600Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#530356}
-
Patti authored
r530031 converted all the icons used in Page Info to vectors. Delete all the unused permissions icons that were previously used. Bug: 535074, 647551 Change-Id: Ic4e6648f61751ffa16a7afeb6f61f8a9088cdd3b Reviewed-on: https://chromium-review.googlesource.com/872471Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530355}
-
Hector Carmona authored
This will make the code/error association very explicit by keeping the code snippet near the stack trace inside the error that is being investigated. See bug for screenshots/video. Bug: 800994 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7a781bd304b498edf2a5b19d58635824a54a575b Reviewed-on: https://chromium-review.googlesource.com/861915 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530354}
-
Anna Maria authored
Adds UKMs for how a user landed on a webpage in VR browsing, and whether they used fullscreen functionality while there. Bug: 795967 Change-Id: Id7968a622b12bbea4365e77f0956c0d566b2b25f Reviewed-on: https://chromium-review.googlesource.com/861224Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#530353}
-
Findit authored
Revert "cros: Manual revert rename TabletPowerButtonController to ConvertiblePowerButtonController and create PowerButtonUtil." This reverts commit 790d637d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 530295 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc5MGQ2MzdkZDk4MWEwNTJhY2MxYTNmNDNhYzU0OWEwMjY0M2IwM2EM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/3814 Original change's description: > cros: Manual revert rename TabletPowerButtonController to > ConvertiblePowerButtonController and create PowerButtonUtil. > > changes in this cl, > Since we will put the logic of power button menu in > TabletPowerButtonController instead of creating a new controller. > Reverting related previous cls, > 1. Revert rename TabletPowerButtonController to ConvertiblePowerButtonController. > Related cl, > https://chromium-review.googlesource.com/c/chromium/src/+/852518 > 2. Revert the creating of PowerButtonUtil. > Related cl, > https://chromium-review.googlesource.com/c/chromium/src/+/852905 > > Bug: 799524 > Change-Id: I4883c7eb9f4b73fad9e8d862fbc106aee22072d4 > Reviewed-on: https://chromium-review.googlesource.com/874911 > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: min c <minch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530295} Change-Id: I973eeb163c50b1eab4ace70f0171d5f3f948a16d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799524 Reviewed-on: https://chromium-review.googlesource.com/874952 Cr-Commit-Position: refs/heads/master@{#530352}
-
- 18 Jan, 2018 31 commits
-
-
Christopher Cameron authored
Re-wrapping the CVPixelBufferRefs's IOSurface in pristine CVPixelBufferRefs makes a bug where frames repeatly flash incorrect content go away. There is no clear or documented reason why this should be required. Rather, it seems more intuitive to use the VTDecompressionSession CVPixelbufferRefs directly. This was observed only in a single fairly consistent repro case, so it is not clear that this indeed fixes the issue -- there was still occasionally a single flashed incorrect frame even with this fix in place. It may be that this fix makes the underlying issue less frequent, or it may be that this fix makes it so that a single "bad" CVPixelBuffer that we inevitably encounter (say, due to some peculiarity of the decoder) does not get repeatedly reused. This fix to increases fullscreen hardware decode video power consumption from 1.57W to 1.65W, entirely due to an increase in CPU power consumption. If this does indeed fix the bug, I consider this to be an acceptable price. This fix has no appreciable effect on non-fullscreen video power consumption. Bug: 702369 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibd5f937695bbd7bb9c16084c3b23dc1968ee83c4 Reviewed-on: https://chromium-review.googlesource.com/867413 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530351}
-
Wei-Yin Chen (陳威尹) authored
Larger margin between controls, larger touchable area of seeker, and fixed drop-down menu with all items. Bug: 803117 Change-Id: Ic8b5b534aa684f09a5e28ad20685387fabc3eb23 Reviewed-on: https://chromium-review.googlesource.com/874753 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#530350}
-
Sammie Quon authored
Steps to reproduce in bug. Caused because the calculation is correct, but no relayout when minimized window gets reactivated. This cl will relayout the non client view which will layout the client view with the correct bounds. Also replaced some duplicate code in the test file with an already made function. Test: CustomFrameViewAshTest.* Bug: 802920 Change-Id: I0ca99fb837a5ddb0d6b78d2c22d1fb00e7b62230 Reviewed-on: https://chromium-review.googlesource.com/872095Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#530349}
-
Joel Hockey authored
Change-Id: Idba043f64ba464ca16ea72facac1a01d31574e7f Reviewed-on: https://chromium-review.googlesource.com/874972Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#530348}
-
Albert J. Wong authored
Also clean up some of the flag descriptions. Bug: 801006 Change-Id: I0641961e896db4af7f92171fa8bc78080c9e6f28 Reviewed-on: https://chromium-review.googlesource.com/874815 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530347}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4aadb7086420..27d718ebb298 $ git log 4aadb7086..27d718ebb --date=short --no-merges --format='%ad %ae %s' 2018-01-18 thestig Add jumbo build support for fxge and pwl. 2018-01-18 dsinclair Move XFA_IsCreateWidget to CXFA_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I98a691c3127b6a6fcd74637383b98c32c89217c6 Reviewed-on: https://chromium-review.googlesource.com/875135 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530346}
-
Maksim Ivanov authored
When extracting flags from command line, use the last occurrence of the end sentinel instead of the first one. This bulletproofs against potential injection of extra sentinel switches (although these should be sanitized by session_manager now), which could fool Chrome into not restarting when it's necessary due to extra flags. Also avoid crash/UB in case the sentinels come in reversed order. BUG=707539 TEST=new unit tests Change-Id: I5c20b1990e0b71e07076ec89285fccd52f1dc190 Reviewed-on: https://chromium-review.googlesource.com/844776 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#530345}
-
Daniel Bratell authored
Two files both used identical helper functions, GetBrowser(). This patch moves that function to a common utility file so that there is only one. This was noticed while doing jumbo compilation experiments, where the double GetBrowser() ended up in the same translation unit. Bug: 746957 Change-Id: I8ceaab0d4bd08395821b296dbd1bbda13c1aef78 Reviewed-on: https://chromium-review.googlesource.com/873921Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#530344}
-
Yuri Wiitala authored
FrameSinkVideoCaptureDevice is the glue between VIZ screen video capture and the video capture stack. Later changes will use this as the common base implementation to provide VIZ-based tab, desktop, and browser window capture. This change only introduces new implementation, but it is not activated/ connected to anything yet (other than content_unittests). Bug: 754872 Change-Id: Ib1648d61ec87adea042b29178eb3b0c7652008b2 Reviewed-on: https://chromium-review.googlesource.com/872390 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530343}
-
Tom Sepez authored
General-purpose (e.g. server_manager) switches can remain in zygote. Bug: 781334 Change-Id: I9750fb85fd7a2368c2d66b109e3afd07807d2d61 Reviewed-on: https://chromium-review.googlesource.com/875126Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#530342}
-
Bill Budge authored
This reverts commit be714803. Reason for revert: breaks unit test https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20(32)%20Tests/29093 Original change's description: > [partition_alloc] Allow 2 GiB direct mapped allocations. > > - Raises the limit of direct mapped allocations. WASM needs > to be able to allocate 2GiB regions. > > Bug: chromium:801604 > Change-Id: I559e55d2474623805eabae64f5b1f3dfe35a7acb > Reviewed-on: https://chromium-review.googlesource.com/868844 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530294} TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org Change-Id: Ic9335529ebdb824b3f9e6ae972cb0489f6dc24ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:801604 Reviewed-on: https://chromium-review.googlesource.com/875151Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530341}
-
Weidong Guo authored
Changes: Add metric to record the time used to process SetMirrorMode API, types of display mirror mode and ranges of the number of displays in mirror mode. Bug: 802311 Change-Id: Icad93a833ec23a4aab2ffbfeda2e20d632c05b5e Reviewed-on: https://chromium-review.googlesource.com/868491Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530340}
-
Sorin Jianu authored
TBR: creis Bug: 803627 Change-Id: I1dd28f78f6c4a7e375a53c152b0c4e4c4ab798f2 Reviewed-on: https://chromium-review.googlesource.com/875199 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530339}
-
Mitsuru Oshima authored
Ash's ResizeHandleWindowTargeter uses the container's targeter to relax the touch region for resize. This CL implements the same logic for ClinentControlledShellSurface (ARC++) BUG=b/72121897 TEST=covered by unit test. manual Change-Id: Ica9f7a2c3f6b1f43708d26ce823a05356d9dd950 Reviewed-on: https://chromium-review.googlesource.com/872122 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530338}
-
Ilya Sherman authored
The reordering of calls will be helpful for loading the safe seed (when appropriate). The remaining changes are purely cleanup. R=asvitkine@chromium.org Bug: 727984 Change-Id: I0959546546987d28d69e1a170f7c97f5f82ad5a0 Reviewed-on: https://chromium-review.googlesource.com/865440 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#530337}
-
Peter Collingbourne authored
This lets us static_cast to OfflinePageModel in OfflinePageModelFactory::GetForBrowserContext without needing to know which derived class we are dealing with. This fixes a CFI bad cast error in the test suite where StubOfflinePageModel (which is an OfflinePageModelImpl) was being casted to OfflinePageModelTaskified. Bug: 469376 Change-Id: I4d53e8e788a53eb4f1ce27d31cc3b34c57c621a5 Reviewed-on: https://chromium-review.googlesource.com/874602Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530336}
-
Marijn Kruisselbrink authored
Rather than returning an index and expecting later calls with that same index these methods now return an object with a Populate method you can call. Bug: 803585 Change-Id: I8e96237400414a9f4eeba148b1c932296ec1ebcd Reviewed-on: https://chromium-review.googlesource.com/874723 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#530335}
-
Adithya Srinivasan authored
Adds a command line arg "--suite" that allows us to run a subset of suites. This allows us to test a change with a particular subset of suites and use a large pageset_number without causing the bots to timeout. Change-Id: I99b7d18117c034f335e36ce54b6b216b58516a8e Reviewed-on: https://chromium-review.googlesource.com/869132Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#530334}
-
David Trainor authored
Add the ability to set specific text used in the ListMenuButton content description. This will incorporate the specified text in the generated content description string. BUG=782375 Change-Id: Ic40f680dc27efa7de52fe8e6aaca0c3ef6330012 Reviewed-on: https://chromium-review.googlesource.com/872258 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530333}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:803449,chromium:803241 Change-Id: I3bd1652d994c45d83e386522ee1fa8cf47d3efa9 Reviewed-on: https://chromium-review.googlesource.com/874596Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530332}
-
Alex Newcomer authored
This CL includes: - New feature flag (omitting the chrome://flags for now per pm request) - Added functionality to Shelf MVC with tests. - Added new state to ShelfButton. - Added new field to ShelfItem. Flow: - ShelfController now observes MessageCenter. - ShelfController sends the Notification ID to the ShelfModel. - ShelfModel updates the appropriate ShelfItem. - ShelfView::OnShelfItemChanged handles updating the icons indicator. About the two new maps in ShelfModel: - We need the NotificationId->AppId map because when the Notification is deleted, we lose the ability to look up the Notification's AppId. - We need the AppId->NotificationId map so an app can look-up all of its notifications. Bug: 801014 Change-Id: Ic4ad751bbff97b3c9dc96e5af5421f6979cec933 Reviewed-on: https://chromium-review.googlesource.com/862167Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530331}
-
Tibor Goldschwendt authored
Change-Id: Iba5277ca72e01c503a2bb24f3219b4c19e5ce89a Reviewed-on: https://chromium-review.googlesource.com/862290Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530330}
-
crystallambert@chromium.org authored
Clarified language for icon sizes on line 59. Bug: Change-Id: I0b22f3c44aa1c142264e034193cc70b496855074 Reviewed-on: https://chromium-review.googlesource.com/653768Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#530329}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //chrome/browser/remoting. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Change-Id: I78a995a4e57c8c2111c09239cb85225f7f84ee2e Reviewed-on: https://chromium-review.googlesource.com/874030Reviewed-by:Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#530328}
-
Ryan Landay authored
In InputMethodController, the beforeinput and input events are fired separately for most (all?) commands, so our JavaScript event test case should be checking separately that they both have the correct inputType. Change-Id: I13e2abf23af657fc2ecd5c0427d8bc57fc6fbeb8 Reviewed-on: https://chromium-review.googlesource.com/872611 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#530327}
-
Sorin Jianu authored
TBR: creis Bug: 803628 Change-Id: Ieece385b25dd5976704b490f35425b3955759ad5 Reviewed-on: https://chromium-review.googlesource.com/875173Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530326}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I9d51ea3c2f961b7d704745f70b7c57fd1b702180 Reviewed-on: https://chromium-review.googlesource.com/857813 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#530325}
-
Tarun Bansal authored
Currently, data use ascriber treats completed requests as different from destroyed requests. Bug: 781189 Change-Id: I38d256eb92b48ab9072234e69154e1ca1834adca Reviewed-on: https://chromium-review.googlesource.com/869751Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#530324}
-
Jinho Bang authored
Should use std::make_unique directly instead of using base::MakeUnique since August[1]. So, this change removes usages of base::MakeUnique in //chromecast. This change removes `#include "base/memory/ptr_util.h"` if it's no more used in files. (Might not remove if base::WrapUnique is used) This change also adds `#include <memory>` header except the following two cases: - Not add the header if the file contains the <memory> header - Not add the header if the related header contains <memory> header (The style guide[2] says that foo.cc can rely on foo.h's includes) Confirmed no additional lint errors(by `git cl lint`) after this change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/616016 [2] https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Bug: 755727 Change-Id: I64d44049e6778913ae7d6b4d83862d2ded4b105d Reviewed-on: https://chromium-review.googlesource.com/874031Reviewed-by:Sergey Volk <servolk@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#530323}
-
Daniel Nicoara authored
Adds more flexibility in setting vsync to a custom value. Also fixed propagation of --cast-initial-screen-[width,height] flags. Bug: b/72119055 Test: Ran on device with flag set and verified that the GPU process uses the overwritten value. Change-Id: I9b15223bf2763e7ee8ef0560595738c52bd87c43 Reviewed-on: https://chromium-review.googlesource.com/874910 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#530322}
-
Henrik Grunell authored
Bug: 802173 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I385214a72e4eeab4a5b092acc169f19b731923da Reviewed-on: https://chromium-review.googlesource.com/870450 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530321}
-