GitLab

Nothing to show in 'Other Bookmarks' when the folder is empty and not
visible in the bookmarks bar. So, prevent moving selection to the
hidden 'Other Bookmarks' folder to avoid a crash.

BUG=275284

Review URL: https://chromiumcodereview.appspot.com/22887030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221813 0039d316-1c4b-4281-b951-d872f2087c98

Configure Views constrained web dialogs to be closed when interstital
WebUI is displayed (e.g. for SSL warnings prior to page load). Affects
these dialogs:

 * print preview
 * SSL certificate viewer (Chrome OS only)
 * profile sign-in confirmation dialog

BUG=240575
R=sky@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/23819028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221810 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23814006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282464
TBR=ygorshenin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23571009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221808 0039d316-1c4b-4281-b951-d872f2087c98

This is direct port of the current content.  No editing yet.

R=eliben@chromium.org

Review URL: https://codereview.chromium.org/23463019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221807 0039d316-1c4b-4281-b951-d872f2087c98

Add -W to SHPINXOPTS to make warnings into error.

Add presubmit check that makes sure sphinx is happy
with the content.

Use 2 spaces to indent code.

Add a missing document.

Fix document links in examples.rst.

Use 'out' for build product data to be constent with
chrome and native_client.

Add 'all' target so that 'make' on its own will work
(I'm lazy)

R=binji@chromium.org, eliben@chromium.org

Review URL: https://codereview.chromium.org/23531031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221806 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/23583040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221805 0039d316-1c4b-4281-b951-d872f2087c98

The "dimmer" cannot be parented by the shelf, but it needs to overlay it. The existing OnBoundsChanged call will only detect size changes since the position relatively to its parent never changes. Therefore the shelf's window needs to be observed as well to get absolute location changes.

BUG=285415
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/24011002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221804 0039d316-1c4b-4281-b951-d872f2087c98

These assets where added when working on RequestAutoComplete dialog
and are no longer needed.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23536037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221803 0039d316-1c4b-4281-b951-d872f2087c98

We're seeing crashes in history::VisitDatabase::GetStartDate coming from
HistoryBackend::ExpireHistoryBetween where db_ is NULL. This change
mitigates this by two avenues: first_recorded_time_ is cleared when the
DB is closed (so that no other code that checks it blows up), and
GetStartDate is no longer called by ExpireHistoryBetween when db_ is
NULL.

Evidence suggests that this bug is responsible for browser crashes at
shutdown that result in a corrupt profile dialog on the next launch.

BUG=275916, 273832, 165282, 107613, 36588
R=brettw@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23861005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221802 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the scrollbar layer animation is triggered at the end of every scroll
gesture. However, as not every scroll gesture actually scrolls a layer, this may
trigger extraneous animations, e.g., when the user overscrolls, or presses and
lifts their finger without scrolling.  Only trigger the scrollbar animation at
the end of a scroll gesture if the gesture caused the layer to scroll.

BUG=285771

Review URL: https://chromiumcodereview.appspot.com/23978008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221801 0039d316-1c4b-4281-b951-d872f2087c98

Adding an early return in setSelection to match BaseInputConnection.
Adding clipping in setComposingRegion to match BaseInputConnection.

BUG=286348

Review URL: https://chromiumcodereview.appspot.com/23566019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221800 0039d316-1c4b-4281-b951-d872f2087c98

This is a binary-only CL for adding the printer icon, since the commit queue
doesn't handle binary files

BUG=286157
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/23480039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221799 0039d316-1c4b-4281-b951-d872f2087c98

- When initializing the WebContents for Android pull the
WindowId from the TabModel and push it to the SessionTabHelper.

BUG=277135
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23792002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221798 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221796 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an interface for DesktopMediaPickerModel
(DesktopMediaPickerModelInterface). It allows the model to be
faked/mocked/stubbed in unittests.

BUG=237907

Review URL: https://chromiumcodereview.appspot.com/23447012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221795 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 220228 "FFmpeg roll for M31."
> 
> Causing compile failure on "Google Chrome ChromeOS"
> http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/57680
> 
> > FFmpeg roll for M31.
> > 
> > BUG=none
> > TEST=asan media_unittests, ffmpeg_regression_tests + manual.
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23172019
> 
> TBR=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/23753002

Builder has been upgraded to handle gcc 4.6+ constructurs.

TBR=hashimoto@chromium.org
BUG=263385,281764

Review URL: https://codereview.chromium.org/23703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221794 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Use-after-free heap errors caught by asan.
See bug 286483.

> Make AppShimHostManager a RefCountedThreadSafe.
> 
> This prevents a crash when Chrome shuts down immediately and 
> AppShimHostManager is destructed before InitOnFileThread is run.
> Note this means AppShimHostManager can stay around longer than
> BrowserProcessPlatformPart during initialization.
> 
> Review URL: https://chromiumcodereview.appspot.com/20065004

BUG=286483,242941
TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/24052002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221793 0039d316-1c4b-4281-b951-d872f2087c98

Configure the collected cookies dialog to be closed when interstital
WebUI is displayed (e.g. for SSL warnings prior to page load).

BUG=240575
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23432007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221792 0039d316-1c4b-4281-b951-d872f2087c98

Comment is not applicable anymore.

BUG=none
TEST=none
R=pkotwicz@chromium.org
TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/24050002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221791 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=*ResizerTest.*

Review URL: https://chromiumcodereview.appspot.com/23645008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221790 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where, when using two thumbnails in the same iframe, they would be reordered if their visibility changed. This would only happen on the second and further NTPs, perhaps on relayout by Chrome.

This changes it so that they are superposed, which is how it should have been all along. Putting position: absolute will make both anchor on body.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23619019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221789 0039d316-1c4b-4281-b951-d872f2087c98

This CL updates the version of PPB_Audio and PPB_Audio_Callback.

BUG=240900
TEST=updated test_audio.{h,cc}

Review URL: https://chromiumcodereview.appspot.com/22320004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221788 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/22006002/ moved the apps-v2 class from
the <body> to the <html> node, but did not update the CSS.

BUG=263090
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/23899005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221787 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/23716005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221786 0039d316-1c4b-4281-b951-d872f2087c98

This includes updating the (already asynchronous) calls in MobileActivator and MobileSetupUI to retrieve the complete set of service properties so that we do not need to cache some infrequently used properties.

BUG=252553
For test files:
TBR=armansito@chromium.org, pneubeck@chromium.org

Review URL: https://codereview.chromium.org/23441025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221785 0039d316-1c4b-4281-b951-d872f2087c98

It looks like some disabled unit tests could easily be enabled again just by extending the MockMediaInternals class.

BUG=23533039
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/23533039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=none, no functional change
R=asanka@chromium.org, erg@chromium.org

Review URL: https://codereview.chromium.org/23522023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221783 0039d316-1c4b-4281-b951-d872f2087c98

Discrepancy is a measure for the largest area of jank in a series of time stamps.

Inverse RMS frame time is a generalization of frames/second that penalizes longer frame times. We can switch to the inverse of another generalized mean with a higher exponent if we want to penalize long frame times even more.

R=nduca@chromium.org, tonyg@chromium.org, klobag@chromium.org, vangelis@chromium.org
BUG=280627, 281544

Review URL: https://chromiumcodereview.appspot.com/23506030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221782 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a few tests were broken by minor changes in behavior 
introduced in http://crrev.com/220164.

BUG=281730
TEST=MediaSourcePlayerTest.StartTimeTicksResetAfterDecoderUnderruns
     and MediaSourcePlayerTest.ReadFromDemuxerAfterSeek pass now.

Review URL: https://chromiumcodereview.appspot.com/23620012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221781 0039d316-1c4b-4281-b951-d872f2087c98

Compile error:

render_text_unittest.cc(1662) :error C2039: 'Range' : is not a member of 'ui'

Revision 221776 change collided with revision 221762, which moved Range
from ui to gfx namespace.

> RenderTextWin: Break runs between any two characters that are not in the same code block
> 
> BUG=278913
> 
> Review URL: https://chromiumcodereview.appspot.com/23522018

TBR=ckocagil@chromium.org

Review URL: https://codereview.chromium.org/23707025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23458018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278913

Review URL: https://chromiumcodereview.appspot.com/23522018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221776 0039d316-1c4b-4281-b951-d872f2087c98

Generate passwords only for the forms that autofill server classifies one of its fields as ACCOUNT_CREATION_PASSWORD.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23432002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221773 0039d316-1c4b-4281-b951-d872f2087c98

This is required for EthernetEAP, because that one will not show up in the network list of NetworkStateHandler.

BUG=126870

Review URL: https://chromiumcodereview.appspot.com/23902011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284817
R=creis@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/23448003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221771 0039d316-1c4b-4281-b951-d872f2087c98

Adds a flag to about:flags to make the "Add to Homescreen"
menu item visible.  Requires a downstream patch to actually put
the menu item in.

BUG=286156

Review URL: https://chromiumcodereview.appspot.com/23676005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221770 0039d316-1c4b-4281-b951-d872f2087c98

find_unused_resources.py thinks that resources defined in third party
libraries are all unused. This updates the script to ignore those
resources.

BUG=149661
R=bulach@chromium.org, cjhopman@chromium.org

Review URL: https://codereview.chromium.org/23591017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=257093, 257098

Review URL: https://chromiumcodereview.appspot.com/23536030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221768 0039d316-1c4b-4281-b951-d872f2087c98

Previously we use a central trace-event buffer to store trace events
from all threads, which needs a lock. Measurement showed that on
Android the lock contributes over 50% of the total overhead of
trace event.

Use thread-local trace-event buffers so that in most times trace
events can be handled lock-free.

TraceLog::Flush() now may asynchronously call the callback.

TODO: Now for a message loop running a blocking task, async flush
doesn't work. The async flush will timeout and finish without
collecting the last batch of such thread if any.

On Nexus 4 this patch can reduce the average overhead of trace_event
from 15~20us to about 5~8us for a busy app. Note the numbers are not
very accurate because
- the time tick seems 30us on Android. The average number may be just
a result of increased percentage of trace events whose overhead < 30us.
- there are differences in the measurement method of the overhead
because of the change of the code structure.

BUG=264667
TEST=Updated existing tests: TraceEventTestFixture.DataCapturedOnThread
and TraceEventTestFixture.DataCapturedManyThreads. Existing unit/browser
tests using trace_event should still pass.
R=nduca, dsinclair
TBR=phajdan.jr (for base/test/trace_event_analyzer_unittest.cc)

Review URL: https://chromiumcodereview.appspot.com/22962004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221766 0039d316-1c4b-4281-b951-d872f2087c98