GitLab

BUG=b:111367421
TEST=CtsVerifier, not sure whether it verifies anything though

Change-Id: I5c3e23cd9958f775ec9ad87580c973fdc3554b89
Reviewed-on: https://chromium-review.googlesource.com/c/1279297Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#599676}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a56b72d4cdcb..4edc5a93c0aa


git log a56b72d4cdcb..4edc5a93c0aa --date=short --no-merges --format='%ad %ae %s'
2018-10-15 hidehiko@chromium.org chromite: Add more tast coverage.


Created with:
  gclient setdep -r src/third_party/chromite@4edc5a93c0aa

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8fecdbda7166258e693c7d041b059f5576f7b425
Reviewed-on: https://chromium-review.googlesource.com/c/1280411Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599675}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5bc30788fd8a..339d23275d07


git log 5bc30788fd8a..339d23275d07 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 jbolz@nvidia.com Enable precompiled headers for MSVC (#1969)
2018-10-15 33432579+alan-baker@users.noreply.github.com Memory access checks for vulkan mem model (#1909)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@339d23275d07

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iaba11bdd8e69eb12278a585a4e649f0228aff971
Reviewed-on: https://chromium-review.googlesource.com/c/1280414Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599674}

Delete some usage of "namespace test" in components/viz/* that got added
back in the year or so since we originally decided to not use it.

Bug: 893850
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic4a0c134c6c7dd66d4f1eb89526155111c1f2a10
Reviewed-on: https://chromium-review.googlesource.com/c/1276546
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599673}

ArcNotificationContentView adds a pre-target handler, but it never removes it.
I'm going to add some DCHECKs to ensure there are no pre-target handlers when
an object is destroyed, so this needs to be fixed.

BUG=867035
TEST=none

Change-Id: I9a0f6ee48a44df5c65ca82db31137a14c7ec66ba
Reviewed-on: https://chromium-review.googlesource.com/c/1280848Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599672}

Bug: 832676
Change-Id: Ifbd5d17e8901a9e44f8ff2180459a950648d2fda
Reviewed-on: https://chromium-review.googlesource.com/c/1280791Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599671}

This reverts commit 01e91776.

Reason for revert: breaks official builds (see crbug/895206).

Original change's description:
> [bundles] Add getter for whether build is a bundle, activate O split fix
> 
> Add BundleUtils class, which has a method to check whether current build
> is a bundle. Use that getter to activate split APK - WebView workaround
> for Android O.
> 
> Bug: 889954
> Change-Id: I443584edf8bd55a6c7e2b5d0664dc943466159d4
> Reviewed-on: https://chromium-review.googlesource.com/c/1261969
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599509}

TBR=yfriedman@chromium.org,torne@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 889954, 895206
Change-Id: I2dbc1a7073397d26babc4e4238084148651d67df
Reviewed-on: https://chromium-review.googlesource.com/c/1280433Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599670}

BUG: 894261
Change-Id: Id707ba8a8782a23a41a7dc4680cbc2538e1d3df1
Reviewed-on: https://chromium-review.googlesource.com/c/1278156Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599669}

This reverts commit e767fb51.

Reason for revert: crbug.com/895337

Original change's description:
> Automated Commit: LKGM 11160.0.0 for chromeos.
> 
> BUG=762641
> TBR=achuith@google.com
> 
> Change-Id: I20f03272b5b8fffca13ebaafac94237c2668ef51
> Reviewed-on: https://chromium-review.googlesource.com/c/1280144
> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
> Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#599586}

TBR=achuith@chromium.org,3su6n15k.default@developer.gserviceaccount.com

Change-Id: I269fc123a9171afdf0b5077948f7d46b2a226bbd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 762641
Reviewed-on: https://chromium-review.googlesource.com/c/1281052Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599668}

CastTouchEventGateTest adds a pre-target handler, but it never removes it.
I'm going to add some DCHECKs to ensure there are no pre-target handlers when
an object is destroyed, so this needs to be fixed.

BUG=867035
TEST=none

Change-Id: I2b3804ba9a96288d209958af7c8703e99732d32b
Reviewed-on: https://chromium-review.googlesource.com/c/1281044Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599667}

The move ctor of NGExclusionSpaceInternal has `noexcept` keyword on its
declaration, but doesn't have it on its definition. That causes a
compile error on the C++17 mode build.
This CL adds `noexcept` to the definition too. Plus, adds `noexcept` to
move assignment for the consistency.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I16f7f69f6d0a7f513659f57f131aee1e4d7414af
Reviewed-on: https://chromium-review.googlesource.com/c/1280083Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599666}

Since many people may be using incognito to browse "sketchy" sites,
we'd like to detect sync password reuse in incognito profile.
Meanwhile, this CL also makes sure Chrome don't leak any browsing
history related data to the original profile.

More specifically, for incognito profile:
1. Chrome will send PhishGuard password reuse ping to SB backend:
   -Anonymous ping, same behavior as in regular profile.
2. show model warning if the returned verdict is PHISHING or LOW_REPUTATION
   -same behavior as in regular profile.
3. Chrome will NOT cache verdicts
4. Chrome will NOT show the change password card in chrome://settings
5. Chrome will NOT set user at-risk.

Change-Id: Iac0a7872d79438e8204b8fc24eba6d8d1201e606
Bug: 893715
Reviewed-on: https://chromium-review.googlesource.com/c/1277815Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599665}

Adding perf tests for transferable data. Measures sending transferable
data to a worker from the main thread, from the main thread to a worker,
and the roundtrip time. Transferable data for this test is an image
represented as an array buffer.

Change-Id: Ie9f05a5301398b2f11677a2a57c985992b64541a
Reviewed-on: https://chromium-review.googlesource.com/c/1275365Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599664}

There was a Cocoa and MacViews version with a common superclass;
this removes the Cocoa version and folds the superclass into the
MacViews subclass which is the only one that remains.

This also reverts 027233cd as
that hack was only needed while we linked against the 10.10 SDK
and we no longer do so.

BUG=891699

Change-Id: Iefdd30268f1e0b52ee1ecd71bdb252e5b8b5c631
Reviewed-on: https://chromium-review.googlesource.com/c/1277578
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599663}

These are the first two pseudo-USS types outside the UI thread, which
requires some extra plumbing. Around 100 LoC must be invested to add
support for a variant of the controller that allows construction and
destruction of bridge and processor in the model thread.

In addition, pseudo-USS relies on a directory-like storage
implemented with ModelTypeStore, which needs some quirks to be
supported outside the UI thread: namely, the store factory must be
allowed to run on any thread, and the destruction sequence must be
refcounted, in particular for ModelTypeStoreBackend, since the
destruction order across backend sequences is not deterministic.

Bug: 870624
Change-Id: I6dbe210277e75f7662a2b744031595c90beb1c62
Reviewed-on: https://chromium-review.googlesource.com/c/1278639
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599662}

https://swiftshader.googlesource.com/SwiftShader.git/+log/810f3db..71e256c

BUG=chromium:881334

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Iae687a76f335d7514dcddcb5c5db07f2fa9f6928
Signed-off-by: Nicolas Capens <capn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1280785Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599661}

A newly filed bug will be used to track code cleanup.

Bug: 895455
Change-Id: If38fcc9311b441e68b43970a0baee8375750e3cd
Reviewed-on: https://chromium-review.googlesource.com/c/1280673Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599660}

Bug: 894043
Change-Id: Idcfd3f4d430c7bce4c13448c80996128ca831f72
Reviewed-on: https://chromium-review.googlesource.com/c/1265815
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599659}

BUG=chromium:881300,chromium:852302
TEST=Pass capture_unittests with/without vivid enabled on amd64-generic
     VM, and verify vivid is used when it's enabled.
TEST=Pass capture_unittests on teemo (a Chromebox), and verify it
     doesn't wait for camera.

Change-Id: I2a11a848639eba426daa4db2f8d22b90c01e08b9
Reviewed-on: https://chromium-review.googlesource.com/c/1260806Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599658}

In chasing a bug I decided to restructure things slightly, including adding
some CHECKs. I don't expect this to impact anything.

BUG=867035
TEST=none

Change-Id: I86bf2d672d886a3944607bbba053e79769d43351
Reviewed-on: https://chromium-review.googlesource.com/c/1278814Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599657}

Fix up the tests so that they run correctly with base::LaunchUnitTests().
Add the unit test exe to the buildbot configs.

Bug: 789588
Change-Id: Ib0ccf2bf965071e6afe2638db1fe3e565799c3e4
Reviewed-on: https://chromium-review.googlesource.com/c/1274456
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599656}

Change-Id: I82bca85f027b47e538fb4ceb1893cbdcf23352d6
Reviewed-on: https://chromium-review.googlesource.com/c/1279957
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599655}

https://skia.googlesource.com/skia.git/+log/c6a17104ad68..11dd1ab3b9e9


git log c6a17104ad68..11dd1ab3b9e9 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 jvanverth@google.com Check for legit bounds in SkTriangulateSimplePolygon
2018-10-15 bsalomon@google.com Abort DRAW_IMAGE_SET in SkPicturePlayback if count is negative
2018-10-15 reed@google.com removed unused LEGACY_VULKAN_INTERFACE
2018-10-15 reed@google.com remove unused SK_LEGACY_SRGB_GAMUT code
2018-10-15 bsalomon@google.com Outset texture coordinates similarly to positions in GrTextureOp
2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5378e14284e6..a2d15d1a268c (1 commits)
2018-10-15 kjlubick@google.com Remove nvpr from CanvasKit
2018-10-15 bsalomon@google.com Make TextureOp request vertex space for meshes at once.
2018-10-15 reed@google.com remove dead code from SK_SUPPORT_LEGACY_THREADED_DAA_BUGS
2018-10-15 mtklein@google.com String -> const char* where possbile


Created with:
  gclient setdep -r src/third_party/skia@11dd1ab3b9e9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I18618c3cc981302bcef5dfaf5f6306bfb172a769
Reviewed-on: https://chromium-review.googlesource.com/c/1280412Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599654}

Bug: 866123
Change-Id: I4483a80d0c81f1634c5867f62a22c43af355d162
Reviewed-on: https://chromium-review.googlesource.com/c/1277812Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599653}

EnsureComputedStyle is meant to be used on elements not rendered, but
queried for ComputedStyle like in getComputedStyle. Update the lifecycle
before getting the ComputedStyle in this media controls test instead.

Change-Id: I7024c7d02f0603097f5b912ced953c14aef7342d
Reviewed-on: https://chromium-review.googlesource.com/c/1280723Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599652}

NativeViewHost does not safely handle the case where it is added and
then removed from a view hierarchy without ever being added to a
Widget. Instead it crashes. This CL fixes the crash.

Bug: None
Change-Id: Ib25f754386b6512973861c4603c1f1a91a0cdb1a
Reviewed-on: https://chromium-review.googlesource.com/c/1277687
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599651}

Originally all clean up was conditioned on
_webState->GetView().superview == self, which looks wrong. So I removed
the condition except for [_webState->GetView() removeFromSuperview].

It may not cause any issues in practice, though.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2ce98cc4b568c6b450d20c5193f5eaebad7cde96
Reviewed-on: https://chromium-review.googlesource.com/c/1280088Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599650}

This reverts commit 6eb8d7a9.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Update V8 to version 7.2.6.
> 
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/dcefe396..1012874a
> 
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
> 
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
> 
> TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
> 
> Binary-Size: autoroller
> Change-Id: Id014a51675cc07ae4c845216ec9020c48efd1e36
> Reviewed-on: https://chromium-review.googlesource.com/c/1280608
> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#599633}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I41cb8252e26bf6d1f5d73e9d2ca18d7d31fda55e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1280209Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599649}

- Moves all the TabModel observer infoBar related code from BVC to the infoBarCoordinator.
- Makes infoBarCoordinator conform to the SigninPresenter protocol.
- Plumbs a dispatcher a tabModel to the infoBarCoordinator.

Bug: 892376
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I002fa94a09566770117f1a30c7c6d656e0fba559
Reviewed-on: https://chromium-review.googlesource.com/c/1265501Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599648}

It should probably wait until the page finishes loading before selecting
the new url in the omnibox.

Bug: 893843
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1546b567755a6878cf0d3239a77f3485f05cb6b1
Reviewed-on: https://chromium-review.googlesource.com/c/1278813Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599647}

Bug: 878390
Change-Id: I3602b3669ea7f37c694b0badd5ed9f461ffc048d
Reviewed-on: https://chromium-review.googlesource.com/c/1276548
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599646}

If the brand code persisted in local prefs is empty, reinitialize to correct.

Bug: 846033, 893451
Change-Id: I49cc299374d8530d3a46aee93cb7cb2518ff1dee
Reviewed-on: https://chromium-review.googlesource.com/c/1272447Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599645}

Previously, any %-escaped characters would be unescaped when parsing
a cookie's domain attribute, leading to a potential security
vulnerability. This change disallows % characters in the cookie domain
by failing to get the cookie domain if the domain string contains a %
character.

Bug: 721833
Change-Id: Ie55d5228eea33920cfa3792c5bf63989498e769d
Reviewed-on: https://chromium-review.googlesource.com/c/1277583Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599644}

Clean up code for clear browsing data dialog.

Changes:
 - Remove template elements and add hidden
 attribute instead
 - Clean up tests
 - Remove argument from strings ($1 -> #)

Bug: 893696
Change-Id: I0650a0a6fe0bd08884480f6eb4b53e379ba4ebba
Reviewed-on: https://chromium-review.googlesource.com/c/1276771
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599643}

Change-Id: Ie294e13bd2b4eaf14343e328b0d5fb2b22a30251
Bug: 864701
Reviewed-on: https://chromium-review.googlesource.com/c/1278616Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599642}

https://skia.googlesource.com/skia.git/+log/646d917d3c71..c6a17104ad68


git log 646d917d3c71..c6a17104ad68 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 jvanverth@google.com Fix YUVA index check


Created with:
  gclient setdep -r src/third_party/skia@c6a17104ad68

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: Iea21440fd140dac0ccacc9ab6cfb521792222c2d
Reviewed-on: https://chromium-review.googlesource.com/c/1280407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599641}

Change-Id: I89277f10b282e324464014a0c1917b6168c79928
Reviewed-on: https://chromium-review.googlesource.com/c/1280615Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599640}

BUG=874836
R=rkaplow@chromium.org

Change-Id: Icf5c0b87a82dd8a9da5af02411727c103e4494b8
Reviewed-on: https://chromium-review.googlesource.com/c/1259662Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599639}

It was using SigninManager API. Migrated to IdentityManager so it could
eventually make use of the identity service.

By the way, PrivetNotificationsFactory was lacking the dependency with
the SigninManagerFactory. Adding the new one with
IdentityManagerFactory instead.

BUG=890784

Change-Id: I0a3c3eb44ea28e8e388728b3e4e58841873057e4
Reviewed-on: https://chromium-review.googlesource.com/c/1278791
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599638}

This patch is just a code simplification by applying conversion logic.

Bug: 853874
Change-Id: I3f9db03fa3b140856b388599ac65ed4ca0dadc98
Reviewed-on: https://chromium-review.googlesource.com/c/1278918Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#599637}