GitLab

This unions different types of rare-data which are mutually exclusive.
They fall into (3) categories at the moment:
 - block-data (inflow block which which doesn't establish a new
   formatting context).
 - table-cell-data (display: table-cell).
 - custom-data (display: layout(foo)).

This keeps the actual structs within the union private such that nobody
messes around with uninitialized "things".

This saves ~28bytes of RareData size. (+/- 4 bytes for bad math).

Change-Id: I1af5445222d82d8a0ac5dac5573602b807751857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758654
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693835}

Ran `./tools/clang/scripts/upload_revision.py 6964027315f70c6817217d8dba0368fd3a274ba3`.

Also add a temporary workaround for a pre-existing-but-now-triggered msan false positive.

TBR=thestig

Bug: 998158,998966
Change-Id: I638cc88d9d7b161c42cf849acbf6a3e0fd95d9b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773745
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693834}

The `updateUI`'s options parameter should be optional. No behavioral
changes are required.

Bug: 1000785
Change-Id: I0d84ce1e985911e8e0db16311678aa93d8db886e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787281
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693833}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/offline_pages.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=chili@chromium.org

Bug: 891670
Change-Id: Ie41dd4e6a7e49c643df9a45421b6f7fef1b57c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786822
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693832}

- Add a flag for the 'Use Camera' button in the 'Add Credit Card' view.
- The button directs the user to a credit card scanner that uses the camera to scan a credit card number.

Bug:989432

Change-Id: I431e8c915cdf3a745f470a2ab1ecc4552e761311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787550Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Cr-Commit-Position: refs/heads/master@{#693831}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ui/base/x.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=thomasanderson@chromium.org

Bug: 891670
Change-Id: I5f3900a36d951e5c999e5a27f02d4a076dc1578b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787178
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693830}

This reverts commit 85d4a0fa.

Reason for revert: most likely wrong culprit?

Original change's description:
> Revert "Backport some tests in /remoting to SingleThreadTaskEnvironment"
> 
> This reverts commit afa2cbc7.
> 
> Reason for revert: non_viz_browser_tests failed because of:
> OAuth2Test.SetInvalidTokenStatus
> 
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/6325
> 
> Original change's description:
> > Backport some tests in /remoting to SingleThreadTaskEnvironment
> > 
> > These tests were previously migrated from single-threaded MessageLoop to
> > a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
> > part of crbug.com/891670.
> > 
> > //base OWNERS decided in retrospect that it was better to keep a
> > single-threaded option for TaskEnvironment and introduced
> > SingleThreadTaskEnvironment. This CL retrofits that decision for
> > /remoting.
> > 
> > This CL is a no-op if it passes CQ.
> > 
> > This CL was uploaded by git cl split.
> > 
> > R=​jamiewalch@chromium.org
> > 
> > Bug: 891670
> > Change-Id: Id50cc3412d6fbec3e5c71672bf74f6abf0f7332d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786679
> > Auto-Submit: Gabriel Charette <gab@chromium.org>
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#693548}
> 
> TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org
> 
> Change-Id: Ibe96ffa6ddf39371dc64c6ad7236ec366f9331c4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 891670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787279
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693613}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,gab@chromium.org,olka@chromium.org

Change-Id: Idb489a187fcfb8343079c83f66088c6b6c8b5091
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787184Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693829}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ash.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=jamescook@chromium.org

Bug: 891670
Change-Id: Ia6c9e5450e044adca6f225e44796d5f58923e893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787101
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693828}

Previously, it was possible that the RenderFrameHost was destroyed before
attempted access by OfflinePageAutoFetcher::Create().

The fix is to avoid passing a task runner, which would PostTask().

Bug: 1000002
Change-Id: Ibb3859e9a859442cd80ef04d483c5c4ea37d01f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782695Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693827}

This CL provides expand and contract animations for views that are being
shown or hidden. It should cover the needs of the identity chip and
butter.

Still to do:
 - Move animating_layout_manager to ui/views/layout
 - Rename flex_layout_types_internal to something more appropriate
 - Implement slide and fade animations
 - Handle multiple views being added/removed at once more cleanly
 - Allow per-child-view transition rules instead of a per-layout default

Bug: 1000131
Change-Id: Ia73475e9eda7e72c118a02160b3fc7234474ee83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782040Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693826}

Change-Id: Ia7ae936644266d98abe9be88341e81fb3fc2eb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786138Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Marc-André Decoste <mad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693825}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/d460d6b1cb96..baa5dc24258b

$ git log d460d6b1c..baa5dc242 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 jonathan.wright Add Arm NEON implementation of h2v2_merged_upsample
2018-07-19 jonathan.wright Add Arm NEON implementation of h2v1_merged_upsample

Created with:
  roll-dep src/third_party/libjpeg_turbo

Change-Id: I869c7d101395df111340cf70fe0d18793a9a5311
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785622Reviewed-by: Jonathan Wright <jonathan.wright@arm.com>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693824}

Fixed regression introduced in #1693175 (https://chromium-review.googlesource.com/c/chromium/src/+/1693175/4/third_party/blink/renderer/devtools/front_end/ui/Toolbar.js) which kept
toolbar buttons from showing their keyboard shortcuts
in the tooltip.

Bug: chromium:999195
Change-Id: I0d0259f19a4abc45d3fe57df419319866e311688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782172
Commit-Queue: Jan Scheffler <janscheffler@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693823}

BackendMigrator logic requires resetting sync metadata for specific
datatype. For regular datatypes, corresponding logic lives inside
ModelAssociationManager and DataTypeManager, which don't have access
to Nigori's ModelTypeController. For Directory implementation of Nigori
this logic implemented through Directory::PurgeEntiesWithTypeIn().

We can detect required migration, because call of
Directory::PurgeEntiesWithTypeIn() plumbed through SyncEngineBackend.
We just restart ModelTypeController for Nigori and this triggers call
of NigoriSyncBridge::ApplyDisableSyncChanges().

We keep in-memory state of explicit passphrase key loaded from the
prefs, because we need it for future support of BackendMigrator for USS
Nigori. It's safe, because if we stop due to disabling sync, we will
also clear corresponding pref and we should not worry about in-memory
state of the bridge, since we won't continue use the same instance.

This is not perfect solution, and we need to try a better one. But for
now all alternatives too intrusive (getting rid of ModelTypeController
for Nigori or moving it into the UI thread).

This CL allows passing Migration*ClientTest with enabled USS
implementation of Nigori.

Bug: 922900
Change-Id: I9f7b218dec46ebfcc21ad8093b73e3c019fd438f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784606
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693822}

Bug: 1000716
Change-Id: I25013ba77c03a05357f787c4ecec540d0e54ddd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787348Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693821}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c3c41d20e9c..b6f7d201f629


Created with:
  gclient setdep -r src-internal@b6f7d201f629

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I1f8f1a69a03552d6b82baff70314479e20ab1dd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787350Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693820}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/autofill/core/browser/payments.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=jsaul@google.com

Bug: 891670
Change-Id: I860dba930b082a4d094da8ad0e7bb00d6a6237d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786828
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#693819}

In certain variants of the dialog, we make a recommendation to change
the leaked password. We want this to be emphasized.

Bug: 986317
Change-Id: I369a3b9a1e21acb8e51f43f6f4980d2645bf60f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781583
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693818}

https://skia.googlesource.com/skia.git/+log/b0e2347fedfc..76500e5d0a62

git log b0e2347fedfc..76500e5d0a62 --date=short --no-merges --format='%ad %ae %s'
2019-09-05 csmartdalton@google.com Clean up GrGLIRect
2019-09-05 bsalomon@google.com Fix profile width check in GrRectBlurEffect.
2019-09-05 jvanverth@google.com Reland "Add launch screen to iOS apps"

Created with:
  gclient setdep -r src/third_party/skia@76500e5d0a62

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jlavrova@google.com

Bug: chromium:995308
Change-Id: I0c05029acb56eb3f10d11d51d6ad4a3f6d0930ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787846Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693817}

This fixes the tests run by the android bfache fyi bot. It currently tries to
run browser_tests when it should instead run android_browsertests,
content_shell_test_apk and chrome_public_test_apk.

Bug: 976218
Change-Id: If0abf33ec48a14c3cb1d3024e43ad2f9a0b18f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787541Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693816}

This CL changes the error message shown to the user if the DevUI DFM
fails to install. The text is approved by UX. The formatting matches
that of chrome://dino (desktop version, instead of the more fancy
Android version). Styles are flattened for simplicity.

Bug: 927131
Change-Id: I30cd76f27aaadd821655d6a4716f7be2ea2c664c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785081
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693815}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromeos/components/tether.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 891670
Change-Id: I6f698c1eda62dffb5167e82b122e1c6b18c57bea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787215
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693814}

Currently a save dialog will return in a read-only file handle
if the site is configured to not be allowed to prompt for
write access. Modify the logic before triggering
the file chooser to reject this attempt

Bug: 990988
Change-Id: I0a63a64ce4605fed6c83c67df60027b09a9b3329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753986
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693813}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromeos/services/network_config.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 891670
Change-Id: I344d2168d15d303bab24507d348c85bdda2782ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786851
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693812}

https://android.googlesource.com/platform/external/perfetto.git/+log/2dc5f73698ee..1ed60ee797b6

git log 2dc5f73698ee..1ed60ee797b6 --date=short --no-merges --format='%ad %ae %s'
2019-09-05 treehugger-gerrit@google.com Merge "Never start data-source twice."
2019-09-05 eseckler@google.com Merge "proto: Add Tracks for TrackEvents"
2019-09-05 rsavitski@google.com Merge "protozero packed repeated field encoding/decoding"
2019-09-05 lalitm@google.com Merge "trace_processor: add strongly typed column wrapper classes"
2019-09-05 tneda@google.com Merge "perfetto-ui: Adding triangle pointer to current search result"

Created with:
  gclient setdep -r src/third_party/perfetto@1ed60ee797b6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I71525903c9f435789e4e607f6d44eb3d709ca348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787843Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693811}

Bug: chromedriver:3042
Change-Id: I8ebec3e58904e63926aa276902c7a92559c8ab66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785681Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693810}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/chromeos/network.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=khorimoto@chromium.org

Bug: 891670
Change-Id: I04efc7575adafc026c094f9e8d255708f4ecb804
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786897
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693809}

This feature allows tracking frame throughput during video playbacks.
This frame sequence tracker is a special case in that its tracking
process occurs in video_frame_submitter, unlike most other frame
sequence trackers that operate mainly in layer_tree_host_impl.

Sample tracing report:

https: //drive.google.com/file/d/1B9AZCsbLmOyIzIFxFGzDOgINISx7p3lk/view?usp=sharing
Bug: chromium:986300
Change-Id: I9a41861e59bbe16d652b49de6b802ccc89833906
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755978
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693808}

Currently, the ungrouped tab is appended to the end of the entire tab
list in grid tab switcher. However, a more ideal setting would be the
ungrouped tab show right next to the tab from which it is ungrouped.
This CL fixes this issue.

Bug: 999396
Change-Id: I19b9ed4cdb029fc71ff175b079745f451657d895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778858Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693807}

Supports different folder images per app list config.
The folder items icon sizes and spacing change depending on the app list
configuration (i.e. screen size), in a way that simply scaling down the
folder icon for kLarge/kShared config down to the desired folder icon size
will not produce the correct folder icon layout.

To address it, add support for per-config icons to app list item
metadata.
Also, icon getters in app list item now take the app list config type
(by default, they return unscaled kShared config icon), which enables
apps grid items to fetch the icon for the correct configuration type.

For now, these are only used for folder icons (generated in ash), but
eventually they can be used to provide differently sized app list item
icons from chrome (so original icon better matches the target size).
For now, the icons provided from chrome are resized when needed.

(For non kShared configurations, this assumes that folder icon
size/layout is the same for all configuration instances with the same
type).

BUG=998207,996808

Change-Id: I2650c4de25a42f98cfa2f13aa6a1ec1ed580890f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777142
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693806}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/content/renderer/media.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=hbos@chromium.org

Bug: 891670
Change-Id: Id30d6abf1228394025cf994fc3a92a7a31b3ecd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787182
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693805}

Before this CL, we had a non-standard res structure for
1. showing larger splash screen icons, and
2. allowing unsigned WebAPK API to have control over
   their use of adaptive icons.

After this CL, the res folder structure will be changed
to integrate adaptive icon.

Bug: 977173
Change-Id: Ib3deb834e0118db1d0c7f03428724427bdc058e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715100
Commit-Queue: Henry Jian <hzjian@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693804}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/dc5858f0a40a..df4a44889317

git log dc5858f0a40a..df4a44889317 --date=short --no-merges --format='%ad %ae %s'
2019-09-05 saklein@chromium.org build_target_util: Fix error inheritance, add test.

Created with:
  gclient setdep -r src/third_party/chromite@df4a44889317

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I92c7395ac0a4d6e931d5180364f2d1f9a09ec54b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787847Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#693803}

For images without any alternative text, there is no point to add it
into the accessibility tree as it will only be recorded as an image.
We could safely ignore such image as it doesn't convey any extra
information.

One such case is the Chrome logo icon on HaTS bubble. We don't need to
link it into accessibility tree.

BUG=979530

Change-Id: I55d1dceb33f5d55241470a5cbd8ff66be9dca877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783672Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693802}

Change-Id: I1f83bb6b5ff7d4f00bc801e5532c90c9285f5b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786834
Auto-Submit: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693801}

Now that Badges logic will be used when in Incognito, it should not be
tied to the Infobar feature flag, which won't be rolled out to 100%
soon.

Bug: 976901
Change-Id: I94ece69646370de01672ba10c2ef15aad60e2fcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783226
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693800}

Change-Id: Id7f2bcd69b2343b9bb9b40ad037f7e570aaa71e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783481Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693799}

In order to help determine why this test occasionally fails, log
warnings when the test is calling OnTestComplete(false) with the reason
why the test has failed.

Bug: 999421
Test: Logs show up when test modified to fail (as locally is passes)
Change-Id: Ie1395e5ffef724f367a727cfbe841226d8e2c076
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785739Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693798}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/components/nacl.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=dschuff@chromium.org

Bug: 891670
Change-Id: I09fc82283cdca72baef38002dfb03aa4a88b2a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786983
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693797}

Change-Id: Ie819f96caf6342403cfcf7fedfcad765795fe53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785638Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#693796}