- 04 Feb, 2020 40 commits
-
-
jonross authored
Updating the Pixel Wrangler docs section on extending the rotation. Making them more general for modifying the rotation. With a portion about swapping. Change-Id: Ief4c3ffc86f87fe924e94900c16b017f38e9ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037327Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#738363}
-
Lukasz Anforowicz authored
This CL makes sure that a correct request_initiator_site_lock is used when a URLLoaderFactory is pushed to a renderer process during a ReadyToCommit->DidCommit transition window. In particular, during that window it is incorrect to use |last_committed_origin_| (see the bug for details). Bug: 1047436 Change-Id: If696a326f162585f42ab0a0ecbe8f8f42f07f5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026168 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738362}
-
W. James MacLean authored
The CL https://crrev.com/737514 fixes an issue with the PDF viewer extension not loading if another extension injects an additional iframe into the top-level HTML document for the PDF. Not caught in the bug description is the fact that PostMessaging support is also broken; that was discovered (and fixed) while writing the accompanying test. Bug: 1046795 Change-Id: I650518162e24e5d961e45b471bfb1518e9b7531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037343 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738361}
-
Xinghui Lu authored
For GAIA password pings, it is currently gated by SB for >=M79 versions. However, since we are not showing warnings to the users, these pings should instead be gated by SBER. Bug: 1048440 Change-Id: I248b78388cb2aff093c67e774e31ee0c711c3499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036286 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#738360}
-
Ahmed Mehfooz authored
Need this to ensure the quick settings widget is always activated when focus is transferred from the message center widget. Bug: 1048127 Change-Id: I6d142ea37bf270712d609024a0d0e09bd5a5d295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036274 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738359}
-
Kevin Bailey authored
The previous a11y change: https://chromium-review.googlesource.com/c/chromium/src/+/1955161 didn't work well on Windows. I'm just reverting it since I don't have time to look into a proper fix. This had minor conflicts, which may cause an issue merging to M81. Bug: 1045192 1045199 Change-Id: Idbf00425dcfc8a3a516cd60a8c5338c1faea3e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036806Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738358}
-
David Van Cleve authored
This reverts commit 6fbca674. Reason for revert: This was a short-term bandaid pending a riskier but architecturally better fix that has now landed (crrev.com/c/2023047 by Lukasz). Original change's description: > Revert URLPattern wildcard to again match some invalid URLs > > This is a partial revert of r715320, which changed > URLPattern::MatchesURL to decline to match all invalid > (!GURL::is_valid) URLs. This was an inadvertent behavior change; > it wasn't clear what the intended behavior was in this case. > > Reverting this seems to resolve crbug.com/1041880, a bug involving > some PDF loads from blob: URLs getting stuck as gray boxes. While > r715320 was originally made to resolve a crash---namely, MatchesURL > would crash on URLs with empty paths---the follow-up commit r718423 > adds logic that will still suffice to prevent this crash (this > is tested by ExtensionURLPatternTest.WildcardMatchesPathlessUrl and > ExtensionURLPatternTest.NonwildcardDoesntMatchPathlessUrl). > > Changes: > - URLPattern: revert the behavior change and update documentation > to reflect that intended behavior is actually to allow the wildcard > '<all_urls>' pattern to match invalid URLs > - URLPattern tests: update to reflect the intended new behavior > > Bug: 1041880 > > R=devlin > > Change-Id: I4f4571c70d0f0dbd7b52cdadbf96a7ea6854cfe0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022251 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735510} R=rdevlin.cronin@chromium.org CC=creis@chromium.org,lukasza@chromium.org Bug: 1046397 Change-Id: I3fd02ac96e3120eb15e1e8bf43ce7dad8185aa03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036792Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#738357}
-
Mitsuru Oshima authored
Use WeakPtr in PresentationCallback to avoid use-after-scope Bug: 1043465 Test: run 100 times and no flaky Change-Id: Iae88d5449c7ae22a05c1b968b938ee0cbdce4c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036873 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#738356}
-
Xiaohui Chen authored
Moving libassistant shutdown a little bit earlier in the shutdown process to help it finish shutdown. Bug: 950146 Test: locally run and logout/shutdown Change-Id: Ic0d3b2ca0bf0cc06702c71fb02659854540a0863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036256 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
Previously code was sending CopyOutputRequest from ChildFrame only if the root renderer submitted frame, which is incorrect. This CL addresses the issue. Bug: 805739 Change-Id: Ic1f1243fe0d9b660773a9dbd753a09218880f72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037638Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738354}
-
Nick Diego Yamane authored
This is the main part of the patch series migrating PlatformEvent to ui::Event in Aura/X11. Design doc [1] describes in details such effort. In this CL, Aura/X11 code which deals with ui::PlatformEvent is factored to deal with ui::Event instead, which is currently a fundamental difference between Aura/X11 and Ozone/X11. To accomplish it, this patch does: 1. Refactor X11 PlatformWindow impl's dispatching logic to handle both ui::Event (auto translated from XEvent and routed through PlatformEventDispatcher API) and raw XEvents (X-specific events routed through XEventDispatcher API). This makes it more similar to X11WindowOzone, which also made it possible to; 2. Cleanup ui::XWindow code guarded by USE_X11, which consisted of key/mouse/touch/scroll events handling, which is now handled at X11EventSource level, i.e: XEvents are translated and routed through {X,Platform}EventDispatcher infra. 3. Convert former PlatformEventDispatcher impls which deals with X11-specific events into ui::XEventDispatchers; 4. Refactor some testing support code to make it work with this new event flow scheme (i.e: X11-specific events routed through XEventDispatcher instead of PlatformEventDispatcher, etc). Even though this touches many files, the delta for each file is usually small and trivial (e.g: PlatformEventDispatcher => XEventDispatcher). The core changes are in X11Window and in some testing code. This should not cause behavioral changes, but a single browser/interactive test became flaky and was disabled for now (actually most tests from that test suite are flaky and conditionally disabled for ozone configs, what possibly points out to issues in the event processing pipeline when ui::Event are used), the proposal for this is to further investigate and address it in a separate CL. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 965991 Change-Id: I10539b8f94a5f0d4857735087ddaf5efd73f9b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022280Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#738353}
-
Yann Dago authored
Bug: 958893 Change-Id: Ie23f403e063cacdfd11cbc9a43e25aefdfc52a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037713Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#738352}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2406f9218a3..25cf469a112f git log a2406f9218a3..25cf469a112f --date=short --first-parent --format='%ad %ae %s' 2020-02-04 nifong@google.com Move Make functions for corner and discrete path effects into namespaces. 2020-02-04 mtklein@google.com remove misleading Uniforms apis 2020-02-04 mtklein@google.com thread alloc through to color filters 2020-02-04 jvanverth@google.com Set NSError on compilation/link timeouts. 2020-02-04 mtklein@google.com run .skps on PDF bots 2020-02-04 kjlubick@google.com [canvaskit] Fix flaky test Created with: gclient setdep -r src/third_party/skia@25cf469a112f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I238ec7558815abe8201ccc04e5516e205f5848a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037619Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738351}
-
Changwan Ryu authored
The Android framework does this some time after installation, and we need to run this by default to closely emulate the real behavior. Bug: 1048411 Change-Id: I80e10f72a8901a42ca0d397649c6a8fbd29198dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036526Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#738350}
-
Ovidio Henriquez authored
This change refreshses the expiration for DiscoverySession.Stop.Outcome. This histogram will be analyzed to determine if its still worth keeping or not. Bug: 1043698 Change-Id: Ib441ed452900ec9e6ad1498b13352b66db555508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036310 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#738349}
-
Regan Hsu authored
This CL breaks AddPeopleStrings in browser string provider into smaller string providing functions that provide for specific People settings polymer elements. Shared components will have their providing function inside the shared string provider, and OS exclusive components will have their provided function inside the os string provider. IDS_SETTINGS_SYNC_SIGN_IN_PROMPT_WITH_ACCOUNT in both chromium settings and chrome os settings strings are deleted since they are no longer used, and so is IDS_SETTINGS_USE_DEFAULT_SETTINGS. Also, people strings that were located incorrectly in AddPeopleStrings are moved to the correct function. Bug: 967888 Change-Id: I2f8b94e6903a0ed413786195f467d8d49c7942ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026111 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#738348}
-
Jamie Walch authored
I previously thought that the cursor was always part of the captured screen on Mac, but it turns out that's only true if curtain mode is active. This CL makes creating of a composing capturer conditional on the curtain mode setting, which should give the correct beheviour for both remote support and uncurtained remote access. Bug: 1048774 Change-Id: I28cc01b0b615794e06cd31308c10a40af550e0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036546 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#738347}
-
Megan Jablonski authored
If the language model doesn't return a target language, fall back to UI language and then accept language list. In the very worst case default to a target of English. Record uma on the target language origin. Bug: 1041387 Change-Id: Ifd42f6a30fa0ba01cd04f714d595661bcedd2a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032513Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#738346}
-
Fabrice de Gans-Riberi authored
By default, on POSIX, FileEnumerator keeps track of previously visited directories by inode. On Fuchsia, this was not working properly because all files under the /pkg directory have inode 1. To work around this issue, the SHOW_SYM_LINKS flag was used. This flag makes FileEnumerator always parse through SymLinks on POSIX platforms. Since Fuchsia does not support SymLinks, this CL makes the SHOW_SYM_LINKS flag have no effect on Fuchsia and tweaks the FileEnumerator behavior to never keep track of inodes on Fuchsia. Bug: 1033230 Change-Id: I2bb7a25b3e49f394323bfb14e1e5132dda92ca12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967970 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#738345}
-
Ted Meyer authored
This reverts commit 5be12bf8. Reason for revert: Fixing the issue, and running on more trybots Original change's description: > Revert "Call MFShutdown in places where MFStartup is called" > > This reverts commit abf9a1f5. > > Reason for revert: Broke tests on Win7 dbg, see linked bug > > Original change's description: > > Call MFShutdown in places where MFStartup is called > > > > Bug: 1012527 > > Fixed: 1012527 > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332 > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738063} > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1012527 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738130} TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#738344}
-
mark a. foltz authored
https://chromium.googlesource.com/media_router.git/+log/7835fcd45668..d4389c097c61 $ git log 7835fcd45..d4389c097 --date=short --no-merges --format='%ad %ae %s' 2020-02-04 mfoltz [Cast Extension] Fix mr.InternalMessageListener to use sender.origin. Created with: roll-dep src/chrome/browser/resources/media_router/extension/src R=takumif@chromium.org Bug: 1047285 Change-Id: Ieb414c70d4ad25844a4d4634ec24710670d7d9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036884Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738343}
-
nancy authored
kAppServiceShelf will be removed in M82 release, so this is the pareparing for that. I will follow up to remove more stuff, then finally remove that flag. BUG=1016159 Change-Id: I3da4b9e304a182e742f58cf59fc548818fefb13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037172Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/11701ad0ea8f..a779c4ef526e git log 11701ad0ea8f..a779c4ef526e --date=short --first-parent --format='%ad %ae %s' 2020-02-04 rwkeane@google.com mDNS: Add Network Interface to A and AAAA records 2020-02-04 jophba@chromium.org Rename TraceCategory struct to match style guide Created with: gclient setdep -r src/third_party/openscreen/src@a779c4ef526e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib2d05d4e2f80012a838229138e309476badb5619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037621Reviewed-by:
-
Guillaume Jenkins authored
The Windows native spell checker integration is almost ready to launch. This CL adds an entry to field trial testing data in preparation for the dev experiment. Bug: 978460, 463364, Change-Id: I3e5fd4af68d94445afa1cd1208ee65d2b5d742ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001243 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#738340}
-
Roman Sorokin authored
Bug: none Change-Id: I9bdd56da027f499c223052b17cfc2c5ae06711ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036063 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#738339}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e5038be70414..4a19a53d5a89 git log e5038be70414..4a19a53d5a89 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 wl@gnu.org * src/truetype/ttinterp.c (TT_RunIns): Adjust loop counter (#57732). Created with: gclient setdep -r src/third_party/freetype/src@4a19a53d5a89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ia3677e7def7ee6d754153c76100ed56710e5a73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036819Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738338}
-
Andrew Grieve authored
Revert "Android: Fix gn gen failure for official builds when check_android_configuration is not set" This reverts commit 0182397a. Reason for revert: Breaks errors showing up in local builds Note: I can't repro any gn gen failures with this reverted. Original change's description: > Android: Fix gn gen failure for official builds when check_android_configuration is not set > > Was hitting this locally: > 2019-10-22 04:06:38 -0400 ERROR at //chrome/android/BUILD.gn:2339:11: Assignment had no effect. > 2019-10-22 04:06:38 -0400 "monochrome_public_bundle.android_manifest.failed" > 2019-10-22 04:06:38 -0400 ^------------------------------------------------- > > Bug: 1011227 > Change-Id: I850fc129d8c2e1c7190266735f2fab97f7efebc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873240 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708221} TBR=agrieve@chromium.org,mheikal@chromium.org Bug: 1011227, 1048319 Change-Id: I5968e52f00891fd91377403d830d76b41766610b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037329Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738337}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ddee0f34e4cb..59a29e3c4f03 git log ddee0f34e4cb..59a29e3c4f03 --date=short --first-parent --format='%ad %ae %s' 2020-02-04 amaiorano@google.com Regres: fix no env-vars for deqp on Windows Created with: gclient setdep -r src/third_party/swiftshader@59a29e3c4f03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibe725a6d2051e22eb572e1c314c675a57823846b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037693Reviewed-by:
-
Henrique Nakashima authored
This reverts commit 628f57c2. Reason for revert: Breaks ChromeCustomTabsConnectionTest (crbug.com/1048438). Might have broken other things. Will reland a fixed version. Original change's description: > ChromeBrowserInitializer offers runNowOrAfterFullBrowserStarted(). > > Instead of runNowOrAfterNativeInitialization(), the method should > enqueue tasks to run when full browser starts, and not when native is > started. There is a distinction - reduced mode means native is started > but full browser, which includes Profiles, isn't. > > This fixes a crash when transitioning from reduced mode to full browser > if a task that uses Profile was scheduled with > runNowOrAfterNativeInitialization(). Now, it will only run after the > transition, rather than immediately. > > Also change hasNativeInitializationCompleted() to > isFullBrowserInitialized() and update clients. All but DownloadMetrics > are meant to run in full browser, so that should actually revert their > behavior back to what it was before reduced mode was introduced. > > DownloadMetrics still checks if native was loaded, which includes in > reduced mode. > > Bug: 1045945, 1014098 > Change-Id: Icdeed1ad6a1999fe518c551c404285170a7118e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032049 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737823} TBR=mthiesse@chromium.org,hanxi@chromium.org,hnakashima@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045945, 1014098 Change-Id: Ia9f37440cd2c39fc73d74cae8dc52572a01fe742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037644 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#738335}
-
Sahel Sharify authored
This is a reland of 08e5b730. The cl got reverted because of the added test failing on ChromeOS_Chrome_Linux build. Original change's description: > [Payments]Don't show "add card" button when basic card is not requested. > > This is a Desktop only change to ensure that the "add card" button is > shown in payment method window only when the "basic card" method is > supported. > > Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735978} TBR=rouslan@chromium.org Change-Id: I90d4febb944d48cfe009c0c0e1511f9d493d1762 Bug: 1046514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037639Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738334}
-
Takumi Fujimoto authored
Prior to this CL, CastActivityManager instantiated CastActivityRecord for non-local routes, regardless of whether it's for flinging or mirroring. This CL fixes that issue, instantiating a no-op MirroringActivityRecord instead. Bug: 1037967 Change-Id: Icfd45c150be9f9de107ca8a62487cfe1cd80a283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033656Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#738333}
-
Becca Hughes authored
Since we have the aggregate watchtime in seconds it will be easier if we store the watchtime in seconds, especially since we don't need millisecond level accuracy. BUG=1024351 Change-Id: I985d6f9d42c1d7ccf3eb9ba88c0dba1bc14e93e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037633 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738332}
-
Rouslan Solomakhin authored
Before this patch, a null payment method section or unselected payment instrument could result in a NullPointerException inside of the isMicrotransactionUiApplicable() method in PaymentRequestImpl. This patch null-checks the payment method section and the selected payment instrument before accessing them. After this patch, isMicrotransactionUiApplicable() will not throw NullPointerException. Bug: 1046938 Change-Id: I14335effa84c5ca44a2de960f63e25fe3eb5ee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033676 Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738331}
-
Amy Huang authored
Currently on windows some binary sizes are too large, and compressing debug info sections solves the issue. Linux has zlib while windows does not, so this change downloads and builds zlib and uses it to build llvm. BUG=1004965 TEST=None Change-Id: I74f2700e14855e3e74c73753c16df7195b3944f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846781 Auto-Submit: Amy Huang <akhuang@google.com> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Amy Huang <akhuang@google.com> Cr-Commit-Position: refs/heads/master@{#738330}
-
Danyao Wang authored
Bug: 996468 Change-Id: I6027b0693d1ab516a7c3a9b94df82d8ca3c4ef49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035303 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has consented to browser sync. The supervised user feature isn't coupled to browser sync consent. Switch to using the "unconsented" primary account. On Chrome OS this account always exists for the logged-in user account, whether or not the user consented to browser sync. On Android, it is always equivalent to the primary account. See go/cros-sync-mock and go/cros-primary-account for details. Bug: 1042400 Test: updated existing unit tests Test: add user and signin works with both parent and child accounts webui for parent controls works, webui for child account setup works Change-Id: Ic45dd82bb3d5e3cbd53d32bc5b68abec677ba636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026176 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#738328}
-
Mihai Sardarescu authored
This CL is a follow-up to CL http://crrev/c/2033252 and it extracts the sign-in EarlGrey2 tests to a separate test module. It also re-enables the tests. Bug: 1045478 Change-Id: Ifff26f5a4821a086d5722c168152a80aafc61cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035992Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738327}
-
Vikas Soni authored
Remove the flags to disable AImageReader on android media path. This is because AImageReader has been enabled by default on chrome starting M76. Change-Id: Iddb8d112095d59479d337feae4abee59289690f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036354Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738326}
-
Saman Sami authored
Relands https://crrev.com/c/2016327 but avoids calling BufferQueue::GetCurrentBuffer() in GLOutputSurfaceBufferQueue due to issues with empty swaps. Plumb mailbox for the primary plane to OverlayProcessorOzone and use SharedImageInterface to obtain the corresponding NativePixmap. Bug: 756454,1047030 Change-Id: I78466b2225b2d4402b853f9f7cbade485144b18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036430 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#738325}
-
Bo Liu authored
The effective process importance is computed from many inputs that can change independently. An undesired case happens when one change causes a binding to be dropped, but a closely-followed subsequent change adds the binding back. This causes the process to temporarily drop the binding which then can cause the OS to kill the process. Use a herustic to delay calls to drop bindings to avoid situations like this. To be conservative, only use apply this delay on the initial one second of the process to avoid wider impact. Bug: 1045059 Change-Id: I73462cf3c43140416871ef7abef3d77a419ca5a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031305Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738324}
-
