- 13 Aug, 2018 40 commits
-
-
Gauthier Ambard authored
The FindInPage activity should only be shown when the FindInPage action is doing something. This CL adds a BOOL to know if the page can be searched. It is used to display the activity or not. Bug: 871260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c Reviewed-on: https://chromium-review.googlesource.com/1172287 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582590}
-
Friedrich Horschig authored
This CL reworks the way autofill suggestions are communicated to the keyboard accessory. Instead of setting an additional view, they behave like all other actions. The old accessory adjusted its layout based on the website's layout. This was removed for now - the system-wide setting is used instead. Side effect: This seems to resolve most known crashes. Known issues: - chip elevation has no effect pre-Lollipop (TODO) Old bugs: - inconsistent state of scrollview most likely solved (--> no scrollview, no inconsistent state) - flaky tests passed 30/30 locally times but reenabling will happen separately (issue 854224, might still flake on bots) Demo video: https://drive.google.com/open?id=1aJbjtTZPP-hPZu2FYA_qHRHqaeHkfWCq Bug: 853772, 834976 Change-Id: I53ed7a18a72e72f72bae45906ac9bb5ee06992e3 Reviewed-on: https://chromium-review.googlesource.com/1170771Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582589}
-
Gauthier Ambard authored
This CL adds dynamic for the IdentityPicker, making sure that the name and email can spread on multiple lines and respond nicely when the font is increased. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea05b977c7a6f6fe199c0e8d4e6325ac05936ef0 Reviewed-on: https://chromium-review.googlesource.com/1172423Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582588}
-
Javier Ernesto Flores Robles authored
Marks LinkOfTextWithCalloutNone and LinkOfTextWithCalloutOverride as flaky. Bug: 873662,873660 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e TBR: eugenebut@chromium.org Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e Reviewed-on: https://chromium-review.googlesource.com/1172684Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582587}
-
Alex Clarke authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 Our usage pattern is unfortunate for existing queues such as base::circular_deque. We tend to fill up an empty queue and then drain all those tasks until it's empty. This means the queue yo-yos in size which confuses the memory reclamation schemes of most queues. As an optimisation we introduce a deque specialised for TaskQueueManager's usage patterns. For performance (memory allocation isn't free) we don't automatically reclaim memory when the queue becomes empty. Instead we rely on the surrounding code periodically calling MaybeShrinkQueue, ideally when the queue is empty. We keep track of the maximum recent queue size and rate limit how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary churn. This yields a nice win on our microbenchmark: Patch: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 Average 35812.1871 35430.24471 35636.02188 36204.63076 ToT: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 Average 37942.951 37481.78685 36983.47337 36634.15632 Percentage improvement 5.61570422 5.473437399 3.643388159 1.172472933 NB the reason the improvement goes down with the number of queues is because we're saving malloc overhead in the queue, but a constant number of tasks are posted across N queues. This means the more queues we have in this test, the less loaded the queues are individually. Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 Reviewed-on: https://chromium-review.googlesource.com/1169043Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582586}
-
A Olsen authored
InstallAttributes and the "Chrome" Schema both have few deps and are needed in Chrome OS settings code, in code that should be servicified. See go/ash-settings-split. However, getting a useful instance of either class currently means depending on chrome/browser to get browser_process and all of its global services. This CL makes InstallAttributes and the Chrome Schema singletons that can also be obtained directly, and so removes one of the dependencies on chrome/browser from the Chrome OS settings code. Bug: 446937 Change-Id: If8b1d8e4e9851464278d4b3e25562bc0eea8a41c Reviewed-on: https://chromium-review.googlesource.com/1141947 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582585}
-
Gauthier Ambard authored
This CL adds a way to dismiss the IdentityChooser popup using the escape gesture. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0b64c28787ed651596e936aa806ed42b94e50db Reviewed-on: https://chromium-review.googlesource.com/1172431Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582584}
-
Patrik Höglund authored
Changes: Major changes All code has been reformatted to be consistent. A .clang-format file and format.sh script has been added that can be use to verify and enforce consistent formatting. An automated check on code formatting is now part of travis build. Other changes PR #409 - Compatibilty with LibreSSL PR #406 - Fix unprotect when pktlen < (2*mki_size + tag_len) PR #405 - Prevent potential double free PR #404 - Add back extern to global variables PR #403 - Set gcm IV directly with EVP_CipherInit_ex PR #401 - Fix memory access issue in srtp_get_session_keys() PR #398 - Fix memory access fixes when invalid profiles where used PR #391 - Return NULL when allocating memory of size zero PR #390 - Bitvector of length zero is not valid PR #385 - Treat warnings as errors on travis builds PR #388 - Moved externs from crypto_kernel into its own header PR #379 - Fixed several compiler warnings from Firefox builds PR #377 - Removed variable init code in rdbx which never gets used PR #381 - Added error in case the platform is not detected PR #376 - Add coverity scan to travis builds PR #374 - Add a big endian build on travis PR #373 - Fixed buffer size issue in test/srtp_driver.c PR #372 - Make rtp_decoder compile on MinGW PR #367 - Rename configure.in to configure.ac PR #365 - Replace calls to free() with srtp_crypto_free() PR #364 - Add valgrind to travis and fix leaks in tests PR #363 - Change smtp_crypto_alloc to initialize memory to zero PR #354 - Fix potential leak if cloning of stream fails PR #340 - Fix potential leak in srtp_add_stream() PR #323 - Fix running test in out of source builds Issue #316 - Remove VERSION file Bug: webrtc:9560 Change-Id: I83b5bd5bcaa01f1cb8b29dbfd24566b307a9a275 Reviewed-on: https://chromium-review.googlesource.com/1169813Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#582583}
-
Miguel Casas authored
This CL renames /image/canvas_resource/ in some method parameter names. This is prob a leftover of earlier times when CanvasResourceDispatcher used a StaticBitmapImage -- now it uses a CanvasResource. Bug: 839970 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0575eafd326738e8a52e5801e689b5280f3ff0ec Reviewed-on: https://chromium-review.googlesource.com/1167911Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#582582}
-
Elad Alon authored
Bug: 775415 Change-Id: Ic08dd3bb772eff7e6c6884e0191c25b441500f02 Reviewed-on: https://chromium-review.googlesource.com/1142157 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#582581}
-
Ryan Daum authored
This reverts commit 64356c22. Reason for revert: Downstream breakage on device. Original change's description: > [chromecast] Detect screen enter/exit and corner holds. > > - Adds detection and dispatch of screen entry/exit events. > - Adds detection of a finger press and hold in the corner. > - Better handling of multiple-finger events on the screen. > > Bug: internal b/112073644 > Bug: internal b/112314035 > Test: unit test and manual > Change-Id: Id2155f8e432428ee63f3457274f1507ce1edee53 > Reviewed-on: https://chromium-review.googlesource.com/1165795 > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> > Commit-Queue: Ryan Daum <rdaum@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582196} TBR=alexst@chromium.org,kpschoedel@chromium.org,rdaum@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/112073644, internal b/112314035 Change-Id: I8fc29ab7b2a7629803d1b45eff6b84bb582698c6 Reviewed-on: https://chromium-review.googlesource.com/1172562Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582580}
-
Xida Chen authored
This reverts commit a0de839e. Reason for revert: As it is mentioned in crbug.com/869375: Know that these are not real crashes but being a top crash this may result in suppression of other crashes Original change's description: > [Debugging] Add instrumentation in TouchActionFilter > > From the stack trace of the current crash report, we are not able to > tell the gesture sequence, which makes it hard to debug. > > This CL adds a CrashKeyString in TouchActionFilter, and push necessary > events into that string. When it crashes, we should be able to retrieve > the gesture sequence from that crash key. > > Bug: 869375 > Change-Id: Ieb7cf0839e4a062c23ec48cbaca72bd641f28a30 > Reviewed-on: https://chromium-review.googlesource.com/1165586 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581676} TBR=dtapuska@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869375 Change-Id: I033b2b1bd646c1310593e612322e4bb2d5c503d2 Reviewed-on: https://chromium-review.googlesource.com/1172522Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582579}
-
Mohamed Amir Yosef authored
Favicon code has been removed intentionally to make earlier patches simpler and focused on the core skeleton of the processor. This CLs fills in the missing pieces when handling remote updates and processing local changes by adjusting the favicon code. Bug: 516866 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I955f011c687b3165956510a0245363bcea8d34ec Reviewed-on: https://chromium-review.googlesource.com/1052767 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582578}
-
Sam Zackrisson authored
- Adds a second (currently no-op) toggling of AEC2 and AECM, to allow for upstream changes in WebRTC (removing the EchoControlMobile API). - Localizes the creation of a webrtc::AudioProcessing::Config to avoid overwriting settings. Shortly, this will be the only way to toggle AECs in APM. Bug: webrtc:9535 Change-Id: I019408ec7e5b5e91afddfe854d607126ee065fdb Reviewed-on: https://chromium-review.googlesource.com/1152914Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#582577}
-
Fredrik Söderquist authored
external/wpt/svg/text/reftests/text-multiline-001.svg external/wpt/svg/text/reftests/text-multiline-002.svg external/wpt/svg/text/reftests/text-multiline-003.svg => crbug.com/366558 external/wpt/svg/text/reftests/text-inline-size-001.svg external/wpt/svg/text/reftests/text-inline-size-002.svg external/wpt/svg/text/reftests/text-inline-size-003.svg external/wpt/svg/text/reftests/text-inline-size-005.svg external/wpt/svg/text/reftests/text-inline-size-006.svg external/wpt/svg/text/reftests/text-inline-size-007.svg external/wpt/svg/text/reftests/text-inline-size-101.svg external/wpt/svg/text/reftests/text-inline-size-201.svg => crbug.com/366553 external/wpt/svg/painting/reftests/markers-orient-001.svg => crbug.com/872697 (pending testfix) TBR=schenney@chromium.org BUG=366553,366558,872697 Change-Id: Ib75f5c0cda767108745618ab508a6a8730e3b1b1 Reviewed-on: https://chromium-review.googlesource.com/1172430Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582576}
-
Javier Ernesto Flores Robles authored
Test is failing on non tablet iOS 10 devices and it is flaky on all iOS 11 ones. Bug: 873633,873632 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie95325a3256021a401c3f8055d5e71f6dc40a590 Reviewed-on: https://chromium-review.googlesource.com/1172358Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582575}
-
Mugdha Lakhani authored
This will be required to implement match() and matchAll() on BackgroundFetchRegistration in a follow-up CL. Bug: 869918 Change-Id: I9ed88076488a035f313b9d16e0f41b3c168a0a09 Reviewed-on: https://chromium-review.googlesource.com/1169465Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582574}
-
Ramin Halavati authored
Preferences related to unified consent are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I733657f359b34369fcef0559660cd14c74bfb181 Reviewed-on: https://chromium-review.googlesource.com/1172131Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582573}
-
Michael Lippautz authored
- Move temporary visitor scope to test infrastructure - Factor out integration tests that are independent from visitors Bug: chromium:843903 Change-Id: I3850cc48fe1b9186691722f3241e9de27cd0a29e Reviewed-on: https://chromium-review.googlesource.com/1172294 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582572}
-
Ian Clelland authored
This just implements the infrastructure required for generating and sending reports with the Reporting API, and making them visible to ReportingObservers. Adding violation reporting to individual features will be handled in follow-up CLs. Bug: 867471 Change-Id: Iabfaebe00ae5a768d1b952a90aac1712aec5e158 Reviewed-on: https://chromium-review.googlesource.com/924475Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#582571}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ecdeaeda. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22691 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc alexander.shalamov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor bajones@chromium.org: external/wpt/gamepad chongz@chromium.org: external/wpt/pointerlock external/wpt/touch-events dcheng@chromium.org, scottmg@chromium.org: external/wpt/domparsing eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI garykac@chromium.org: external/wpt/keyboard-map garykac@chromium.org, joedow@chromium.org: external/wpt/keyboard-lock hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline jsbell@chromium.org: external/wpt/IndexedDB external/wpt/resources jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI external/wpt/webstorage kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading kpaulhamus@chromium.org: external/wpt/webauthn ksakamoto@chromium.org: external/wpt/resource-timing mcasas@chromium.org: external/wpt/mediacapture-record mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity mlamouri@chromium.org: external/wpt/mediasession external/wpt/remote-playback external/wpt/screen-orientation nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents ortuno@chromium.org: external/wpt/bluetooth panicker@chromium.org: external/wpt/page-visibility external/wpt/user-timing panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store rijubrata.bhaumik@intel.com, mcasas@chromium.org: external/wpt/html-media-capture rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request tdresser@chromium.org: external/wpt/navigation-timing timvolodine@chromium.org: external/wpt/battery-status yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I70a939515749e77646e0c697dfa888bedbe1a202 Reviewed-on: https://chromium-review.googlesource.com/1172209 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582570}
-
Anders Hartvoll Ruud authored
When retrieving values via attributeStyleMap.get/getAll, produce the correct CSSStyleValue subclass according to the registration of the custom property. R=futhark@chromium.org Bug: 641877 Change-Id: If564fb039506a22162ad2521479fcb1c3de9336c Reviewed-on: https://chromium-review.googlesource.com/1172291Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#582569}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c500e36711d5..a745cdf1c11f git log c500e36711d5..a745cdf1c11f --date=short --no-merges --format='%ad %ae %s' 2018-08-13 lalitm@google.com perfetto: fix string view unittest for Chromium autoroller 2018-08-12 primiano@google.com UI: Initial clean up and improvements 2018-08-10 dproy@google.com Fix hover for chrome slices 2018-08-10 primiano@google.com Add StringView class and switch trace processor to use it Created with: gclient setdep -r src/third_party/perfetto@a745cdf1c11f The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8dd67c02eca58c773700485b29a7008a1a3a7bba Reviewed-on: https://chromium-review.googlesource.com/1172382Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582568}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/553b6f68e1dc..af1759587922 git log 553b6f68e1dc..af1759587922 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 nisse@webrtc.org Refactor RtpReceiverImpl, extracting CSRC book-keeping to its own class 2018-08-13 asapersson@webrtc.org Add initial support for RtpEncodingParameters max_framerate. Created with: gclient setdep -r src/third_party/webrtc@af1759587922 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0984c59dd627c52ccad8d87f269a64b07e9cde59 Reviewed-on: https://chromium-review.googlesource.com/1172383Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582567}
-
Elad Alon authored
Bug: None Change-Id: Ied9165ff9f0cfb3cc411150ba50b09f2bf67cc04 Reviewed-on: https://chromium-review.googlesource.com/1144937 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#582566}
-
Fredrik Söderquist authored
TBR=schenney@chromium.org BUG=863355 Change-Id: Ib58518bb68af39fb5e106cb0da0f08df5e6a832a Reviewed-on: https://chromium-review.googlesource.com/1172361Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582565}
-
Maks Orlovich authored
Add an adapter for making migrating standalone executables that need both legacy and NetworkService APIs easier This lets one easily create a SharedURLLoaderFactory wrapping an existing URLRequestContextGetter. It should be used for standalone executables only --- things within the Browser should request the SharedURLLoaderFactory from Profile/StoragePartition/SystemNetworkContextManager as appropriate. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1a66d2bcad6307ee87014dc2d3134e673da5d16c Reviewed-on: https://chromium-review.googlesource.com/1150661 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582564}
-
Thomas Tangl authored
The UnifiedConsentService needs a SyncService that is not NULL, otherwise it will crash. To fix this, the UnifiedConsentServiceFactory only creates a UnifiedConsentService if the SyncService is not NULL. Bug: 872451 Change-Id: I3f7c196273ce5cade9b2f1c88c410eae13569bf7 Reviewed-on: https://chromium-review.googlesource.com/1172301 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#582563}
-
Peter Wen authored
These folks have left Chrome or Google. Removing them to make it clear that these directories need more OWNERS (dgn@, aberent@, shenghuazhang@, sgurun@). Add mlamouri@ to replace removed //third_party/android_media OWNERS. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4cf85a5dace5bdd4929d12617e5e12f11a58ca11 Reviewed-on: https://chromium-review.googlesource.com/1160771Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582562}
-
Yuta Kitamura authored
It's possible to reach here even if Scheduler() just returns nullptr. Bug: 873207 Change-Id: I6664ccaa75fbcb31e4f9e75099d85404f8db8059 Reviewed-on: https://chromium-review.googlesource.com/1172178Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#582561}
-
Balazs Engedy authored
Bug: 849323 Change-Id: Ia5ed52ee21c634a018c8652f7dc3380673852956 Reviewed-on: https://chromium-review.googlesource.com/1169212Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582560}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90f466a6cfab..35bc74d6d139 git log 90f466a6cfab..35bc74d6d139 --date=short --no-merges --format='%ad %ae %s' 2018-08-13 jiawei.shao@intel.com ES31: Support atomic functions on D3D11 - Part II Created with: gclient setdep -r src/third_party/angle@35bc74d6d139 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie8c92f0d6a30925e284276d25418b9ae83880193 Reviewed-on: https://chromium-review.googlesource.com/1172244Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582559}
-
Mohamed Amir Yosef authored
Since the BookmarkSyncServiceFactory doesn't start the BookmarkUndoService, it should use it only if it exists. This was the case already in non-ios factory. https://cs.chromium.org/chromium/src/chrome/browser/sync/bookmark_sync_service_factory.cc?l=38&rcl=46520ae13478333fe882e79041b667e5a3112796 However, by mistake, it was created in iOS factory which caused tests to fail here: https://chromium-review.googlesource.com/c/chromium/src/+/1052767 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5f205fa575773b3382b1e4c90ac4afa19d41d77a Reviewed-on: https://chromium-review.googlesource.com/1171231Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582558}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 641877 Change-Id: Ia249aedc2abe7f249c28ab57732edfaf6c552f2e Reviewed-on: https://chromium-review.googlesource.com/1172295Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#582557}
-
Mathieu Perreault authored
Receives the data from sync and puts it in the AutofillTable. Wires the getter/setters all the way to PersonalDataManager. Bug: 870936 Test: components_unittests Change-Id: Ic6f262e63e529f42d8f7225042f0a007273e7ab7 Reviewed-on: https://chromium-review.googlesource.com/1170847Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582556}
-
Jan Wilken Dörrie authored
This change restricts the usage of WriteWithoutResponse to macOS. On macOS this is required for performance reasons, but on other platforms this can lead to misbehavior. This results in requests not being handled correctly. Bug: 763303 Change-Id: I5b609fd70eafdf4b9abad680218a9e04ac302703 Reviewed-on: https://chromium-review.googlesource.com/1167515 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582555}
-
Fergal Daly authored
The parser currently yields every 500ms unless it encounters a script tag. We will experiment with different values and observe the impact. https://goo.gl/zwQWyW Change-Id: I1dcec74fb41e438393e505323707c00d76b49d15 Reviewed-on: https://chromium-review.googlesource.com/1148172 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#582554}
-
Vasilii Sukhanov authored
Bug: 869343 Change-Id: Ic3506c14a51fca41a8c5ee84587d5947976178df Reviewed-on: https://chromium-review.googlesource.com/1172343 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#582553}
-
Yi Su authored
Add a helper function that returns text for tabs count: (-inf, 0] => "" (0, 100) => "num" [100, +inf) => ":)" Bug: 835801 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ica4607b10dbd1f241d4e5a07c32128a1f4607db8 Reviewed-on: https://chromium-review.googlesource.com/1172297Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582552}
-
Morten Stenshorne authored
TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I93fc321f19c2721b1bcaaee706a22969154b3911 Reviewed-on: https://chromium-review.googlesource.com/1172349 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#582551}
-