- 24 May, 2019 40 commits
-
-
Alexei Filippov authored
Change-Id: Ie940ec04243b1a4382cd557c8d9b462d6a2fab0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628250Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#663008}
-
Michael Lippautz authored
Increase live byte counter on transitioning an object from unmarked to marked state. This results in an accurate live byte counter after marking and even before sweeping is started. In future, this values is communicated to V8 to allow computing a global limit indicating when the next GC should be started. Performance-wise, this only shifts the accounting work from the sweeper to the marker. Both still run on the main thread. Delta in reland: - Fix and test for crasher when trying to adjust marked bytes. Bug: 948807, 966456 Change-Id: I2d92c530c8e4c3b2d054580df5daf1822be0aa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627041 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#663007}
-
Elly Fong-Jones authored
The rest of this code is going away too. Bug: None Change-Id: I4a3dc9d4a000ac9d9830e5e50d057085313ad1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626537 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#663006}
-
Johannes Kron authored
RTP timestamp was recently added to RTCRtpContributingSource in the WebRTC specification. This CL reflects that change. Bug: chromium:965994 Change-Id: Iba76a2b90547e7ca70bb04dd556914c7f36ea3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625106 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#663005}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7f4af8aae5e..583fc3036847 Created with: gclient setdep -r src-internal@583fc3036847 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=yukishiino@google.com,lgrey@google.com,masonfreed@google.com,rsorokin@google.com Change-Id: I20f3c38dba278e7b35ab9df5a87ea15c94e09dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628531Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#663004}
-
Wei Lee authored
This CL adds getCameraFacing() API for CCA to get camera facing. Bug: None Test: Manually Change-Id: Ic400ed3012416f6d22f61fb553f9a74e7a1c24dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624425Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#663003}
-
Kuo Jen Wei authored
Bug: 965933 Test: On HALv1 device the CCA function normally without resolution settings menu. On HALv3 device the CCA is able to capture with specified resolution from resolution settings menu. Change-Id: If22961c55a052a7a6061c62569d88aca69e332d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626063 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Ken Rockot authored
This adds an ack response to TracedProcess.ConnectToTracingService and defers internally registering the PID with PerfettoService until the ack is received. This ensures that an unresponsive or otherwise defunct service cannot indefinitely block tracing for other services in the same process. Also changes chrome_renderer instance registration back to a mode where it never reports a PID (as opposed to implicitly reporting its PID is the same as the browser's). This adheres to subtle but valid expectations in tracing code that services reporting a given PID are actually running in that process. Bug: 962918 Change-Id: I71273f8ba954f580c1375e9b0ce2ab6c148b69b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626991 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#663001}
-
Hayato Ito authored
This is a preparation CL for https://crrev.com/c/1628495 so that it has a nice diff. Bug: 623464 Change-Id: I3adcb0796ea619804f61a7cc2a69821300b2bf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628627 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#663000}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I87d46ce9b72344e72511a50ffba4668ba2c2e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662999}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/27ec91958501..66e46037d74f git log 27ec91958501..66e46037d74f --date=short --no-merges --format='%ad %ae %s' 2019-05-24 johnkslang@users.noreply.github.com Merge pull request #1772 from mattparks/patch-2 Created with: gclient setdep -r src/third_party/glslang/src@66e46037d74f The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I99b8c4a4190794072c0e1ebd07983137a5e6e61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628549Reviewed-by:
-
Nikunj Bhagat authored
Change-Id: I4cd59c9a8e245ea3af4fcdb0bdd602f066c6fef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610310Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662997}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8a2441d37d80..032c7152644d git log 8a2441d37d80..032c7152644d --date=short --no-merges --format='%ad %ae %s' 2019-05-24 swiftshader.regress@gmail.com Regres: Update test lists @ 8a2441d3 Created with: gclient setdep -r src/third_party/swiftshader@032c7152644d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I666a0b64a14fadd83a9e3dfd4988ac130b69ec29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628552Reviewed-by:
-
Dominic Battre authored
Bug: 966041 Change-Id: I4cdcf0b5631dd71004d162f77ef028f794e09eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625119Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#662995}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/65790b717589..441284b3fb3e git log 65790b717589..441284b3fb3e --date=short --no-merges --format='%ad %ae %s' 2019-05-24 dberris@chromium.org Pinpoint: align table header text left Created with: gclient setdep -r src/third_party/catapult@441284b3fb3e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:966146 TBR=eyaich@google.com Change-Id: I1b824a2625c9b1fc6e9a418ffe078742f5305d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628553Reviewed-by:
-
Danil Chapovalov authored
That allows to use chromium's implementation of the webrtc::TaskQueueFactory explicitly instead of through the global variable Bug: webrtc:10284 Change-Id: Id79d63fd9710d72cfe17497ef91b615999350cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627381Reviewed-by:
-
Hayato Ito authored
This is a preparation CL for https://crrev.com/c/1614723. As per the review comment [1], we can use FrameTreeNode id, instead of WebContentsGetter, in WebContentsGetterRegistry because we can get WebContentsGetter from FrameTreeNode id, as well as to know whether the frame is mainframe or not from the id. WebContentsGetterRegistry is now renamed to FrameTreeNodeIdRegistry. [1] https://crrev.com/c/chromium/src/+/1614723/12/content/browser/web_contents/web_contents_getter_registry.h#16 Bug: 623464 Change-Id: Ifab7727f6a6b74408f815e5b853d75d39c515f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623611 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Navigating to a URL and waiting for that to complete requires sync primitives. Change-Id: Iae111ac9ee2521de4054f82829f030f797cfaac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627358Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#662991}
-
Timothy Loh authored
This reverts commit 38cccb45. Reason for revert: ExtensionWebRequestApiTest.WebSocketRequestAuthRequired failing on linux-chromeos-dbg non_network_service_browser_tests e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12545 Original change's description: > [websocket] Split interface mojom::WebSocketClient > > This CL splits the interface to two parts so that WebRequestProxyingWebSocket or > extensions proxy only handshake of WebSocket: > > interface WebSocketHandshakeClient { > OnStartOpeningHandshake(WebSocketHandshakeRequest request); > OnFinishOpeningHandshake(WebSocketHandshakeResponse response); > OnAddChannelResponse(string selected_protocol, string extensions); > }; > > interface WebSocketClient { > OnDataFrame(bool fin, WebSocketMessageType type, array<uint8> data); > OnFlowControl(int64 quota); > OnDropChannel(bool was_clean, uint16 code, string reason); > OnClosingHandshake(); > OnFailChannel(string reason); > }; > > Performance gain of receive-arraybuffer-1MBx100.html: > Mine: 1050 ms > ToT : 1221 ms > > Bug: 865001, 942989 > Change-Id: Ia364afd96005a77b1dadf2c95896be5a12827f13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599819 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662937} TBR=kinuko@chromium.org,ricea@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org,karandeepb@chromium.org Change-Id: I8f974173d329d77258ba5b4ad45a4cb1f283bba0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865001, 942989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628497Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#662990}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4eb107dc89cf94a4d1462db8a731388270a18fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628548Reviewed-by:
-
Koji Ishii authored
This patch adds |PostLayoutChildren()|, and use it for the fix made at r661990 (crrev.com/c/1621796). When subtree layout occurs, ancestors of the subtree root may keep the reference to the old fragments. The new collection |PostLayoutChildren()| returns the latest fragments. Changing all uses of |Children()| to this does not work: 1. Some callers expect fragments being built during the layout, not the latest post-layout. Simply replacing breaks such callers. 2. This collection is not as fast as I wish it to be. Need to optimize/cache |IsRelayoutBoundary()| before using this in more performance critical work. 3. The best way to handle this situation isn't clear yet. Instead of this on-the-fly replacement, we may want to find all refences and patch them, as we tried in crrev.com/c/1622907. Maybe we need to support more generations. This is an architectual decision to be discussed more. This addition makes it easier to apply to other places if needed, and makes merging easier if we need to after the branch point, but where to apply is in future investigation. Bug: 965639 Change-Id: Idd4b539e88465cf0b810ae249fdcb87c0b19ae45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624010Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662988}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45750efbcdf2..b7f4af8aae5e Created with: gclient setdep -r src-internal@b7f4af8aae5e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I7af11b23662c4c33c1719319106420e44cda7f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628264Reviewed-by:
-
Jay Harris authored
Bug: 906508 Change-Id: I7a1484874fd2afe1d7b4603b0de1ae6f20d08bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624066 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#662986}
-
Kuo Jen Wei authored
Bug: None Change-Id: Ifbbbe1ad0c5f50ea7454e1256b0ba8f9cdce2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624365Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e794ddc8a662..431ef2fdd373 git log e794ddc8a662..431ef2fdd373 --date=short --no-merges --format='%ad %ae %s' 2019-05-24 minkyu.jeong@samsung.com Add support for EXT_blend_minmax Created with: gclient setdep -r src/third_party/angle@431ef2fdd373 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I8a3c4976ac8d14931b8307fe1bb57ce662d5265e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628547Reviewed-by:
-
Tsuyoshi Horo authored
The existing SXG prefetch browsertests doesn't check the typical cross origin SXG loading behavior involving sender and distributor and publisher. This CL adds PrefetchedSignedExchangeCache_CrossOrigin, and PrefetchAlternativeSubresourceSXG_CrossOrigin tests. Bug: 935267 Change-Id: I3017c08c2096d2dba42227894db3519e542eae9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627846Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662983}
-
Luciano Pacheco authored
Conversion done manually. Added static method "decorate" since it isn't using cr.ui.define anymore. This is the same idea used in FileTable, ComboButton, ProgressCenterItemElement and DirectoryTree. Manually tested "refresh" button triggering its command. Bug: 778674 Change-Id: Ib01207f6336d9f003d6c6d159ca4cc20ebab7e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626843 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#662982}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c1c0d6d8ad74..316f3ac13b51 git log c1c0d6d8ad74..316f3ac13b51 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 sukhanov@webrtc.org Datagram Transport Integration Created with: gclient setdep -r src/third_party/webrtc@316f3ac13b51 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I16523a8fc4f0f365f4a317eb003c655e4086e9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627584Reviewed-by:
-
Tsuyoshi Horo authored
Data URL for cert-url had been supported. But after crrev.com/c/1577483 which landed in 76.0.3774.0, Chrome failes to load the data URL when NetworkService is enabled. To fix this issue, this CL change SignedExchangeCertFetcher to use DataURLLoaderFactory when the cert-url's scheme is "data:". Bug: 966736,939871 Change-Id: I352caf29e54f288371f18266597f5374ab7ca2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628488Reviewed-by:
-
Donna Wu authored
This CL changed //services/device/public/cpp/test:test_support to //services/device/public/cpp:test_support or conciseness, and merged separated target ":serial" to the main "mojom" target of services' public mojo interfaces as it has no special requirement and it's not a good practice to keep a transitive dependency through public_deps. Bug: null Change-Id: I2bcd95e23d6c776f442675b74e2b3d1275ef598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614425 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#662979}
-
Alan Cutter authored
This CL changes the default action in a PWA install confirmation dialog to be nothing. Before this change it was cancel. This is in the interest of consistency with other situations where we don't want "do security sensitive action" to be the default and for accessibility concerns. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=392968&signed_aid=sk4b6UZkAkZ9U6T9qqwovw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=395017&signed_aid=jecG6nW4xOnmcpJS4uDMYA==&inline=1 Bug: 957848 Change-Id: Id2b39cac3685891db5605b12aeaa2d069236316a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626842 Commit-Queue: Jay Harris <harrisjay@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#662978}
-
Jay Harris authored
We weren't taking the TopContainer's (where the window close buttons live) height into account. This adds the result of GetTopInset to GetWindowBoundsFromClientBounds on ChromeOS, which other platforms were doing already. In addition, it ensures that the FrameHeader is correctly setup, so the size constraints will be correct. Before and After screenshots for opening a 480x300px popup Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394786&signed_aid=1sRqzN7-EINNjSfsWHhj6A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=394787&signed_aid=EIwCu-QkBAjpW1dGVHvu_Q==&inline=1 A second CL (https://chromium-review.googlesource.com/c/chromium/src/+/1626441) fixes a separate but related bug and adds tests to ensure this does not regress. Bug: 777854 Change-Id: Ia4f9170a5bf538fd40bd1ce34056a5693f773047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626909 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#662977}
-
Noel Gordon authored
There are no #include <files> present in the build (piex) directory so the "-I ." flag does nothing anymore, remove it. Bug: 935285 Change-Id: I7aa2c4c30f417c8a9930edf1f9e57badadcb71c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627836Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662976}
-
Tetsui Ohkubo authored
When ExoRawGamepadInfo is enabled, exo sends raw gamepad scancode to ARC instead of Web Gamepad keycode, and it's remapped in Android. (See https://crrev.com/c/1612857) This CL makes the similar change to analog sticks. In order to do that, Exo also has to forward motion range information to ARC, so it adds new Wayland events, axis_added and activated. This is a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepadInfo to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: If713d4b28bff934ee2d3beba54d3cc15995f6825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624385 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 5/23) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#662975}
-
Yoshifumi Inoue authored
This patch makes |HarfBuzzRunGlyphData| four byte smaller by omitting structure alignment padding to reduce memory usage for Windows. Note: Linux doesn't insert padding after |unit16_t|. In rude estimation, we can reduce: number_of_character_in_page × 4 byte per page. Example: https://en.wikipedia.org document.body.innerText.length = 9681 Thus, we can reduce 38,724 byte. Before this patch: +----------+----------+ +0 | utin16_t | padding | +----------+----------+ +4 | bit field | +----------+----------+ +8 | float advance | +----------+----------+ ... sizeof(HarfBuzzRunGlyphData)==20 After this patch: +----------+----------+ +0 | bit field | +----------+----------+ +4 | float advance | +----------+----------+ ... sizeof(HarfBuzzRunGlyphData)==16 Bug: 965564 Change-Id: I73cae1096d74168ead1e2e48251dc2d50597e7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627832 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
With this change, specifying port in the manifest URLPattern works even for CORS bypassing rules. Bug: 936900 Change-Id: I3744b65307c923c9c593efef7a41a651ab67d494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619530 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662973}
-
May Lippert authored
This change: 1) Creates a new os_a11y_page that has the non-OS bits removed 2) Makes a11y_page show the link to the store if OS settings is enabled to have parity with Win/Mac/Linux BUG=950007 Change-Id: I54acaefbc4b000ba3c5523c03cf92645ce3acee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626028 Auto-Submit: May Lippert <maybelle@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662972}
-
Yang Guo authored
R=jshin@chromium.org Bug: chromium:938223 Change-Id: Ifa6392cd4d657e76d87f6a9f96c8ad610291cfef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520406 Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662971}
-
Tetsui Ohkubo authored
Linux's input_absinfo offers axis information of gamepad devices. In order to improve gamepad support in ARC++, we need this information in Exo. To do that, we have to subclass ui::InputDevice and add ui::GamepadDevice. This is based on another example of subclassing ui::InputDevice, which is ui::TouchscreenDevice. Design doc: go/arc-improved-gamepad TEST=manual BUG=b:130597086 Change-Id: I7656740f77dce035856cc5a847472d5e10e0f1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624285 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#662970}
-
Victor Fei authored
- Implemented firing property changed event for UIA_AriaPropertiesPropertyId and associated unit and browser dump tests for the following AriaProperties: - dropeffect - grabbed - Added internal blink representation for aria-grabbed and aria-dropeffect and associated tests. - Removed support for aria attributes: - channel - secret - tabindex from AXPlatformNodeWin::ComputeUIAProperties since these attributes do not exist in the WAI-ARIA spec, even though they are referenced in the UIA spec. - Documentation on UI Automation AriaProperties (see the second table's last column for AriaProperties properties): https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification Bug: 928949 Change-Id: I2243479a212353410145e210b0992a07306106e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576280Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#662969}
-
