Commits · cdd18485a0572c51bdae4cbd169773dd214f4ea1 · eriksson monteiro / tangled

25 Nov, 2019 40 commits

Use new downcast helper for blink::HTMLAreaElement · cdd18485

Abhijeet Kandalkar authored Nov 25, 2019

This CL has goal to use IsA<HTMLAreaElement>(element) in place of
IsHTMLAreaElement(element)

Bug: 891908
Change-Id: Ie3f3eeae304c0ae607531816c2d9782c0fdf365b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930537Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718763}

cdd18485

Roll src/third_party/flatbuffers/src/ 9bf9b18f0..136d75fa6 (221 commits) · 9dd60457

Sky Malice authored Nov 25, 2019

https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/9bf9b18f0a70..136d75fa6580

$ git log 9bf9b18f0..136d75fa6 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 dbaileychess Changed null checks in test. Removed verifier pointer usage (#5634)
2019-11-19 31897320+vglavnyy Add testing of C++ with sanitizers (CI-Docker) (#5631)
2019-11-19 i add namespace prefix in FLATBUFFERS_MAX_BUFFER_SIZE (#5629)
2019-11-15 malarkannan.invention Support for python grpc - continuing the work from the pull request #4270 #4705 (#5613)
2019-11-14 dbaileychess Removed idl_gen_general.cpp and move contents to code_generators.cpp (#5625)
2019-11-14 dbaileychess Lua cleanup (#5624)
2019-11-14 dbaileychess [C++] Adds basic schema evolution tests (#5611)
2019-11-11 dbaileychess [C++, C#, Java] Separated C# and Java generators into their own classes (#5618)
2019-11-11 Captfrozenberg add check for root_type specified for json schema generation (#5622)
2019-11-12 messense [Rust] Bump smallvec version to 1.0 (#5621)
2019-11-11 dbaileychess Ran src/clang-format-all.sh (#5617)
2019-11-07 aardappel Improved pull request & clang-format instructions.
2019-11-07 derekbailey Change monster_extra generation to use flatbuffers::unique_ptr (#5612)
2019-11-07 derekbailey [C++] Refactor to conform to Google C++ style guide (#5608)
2019-11-04 aardappel Fixed deprecated method in GRPC Java test.
2019-11-04 aardappel Fixed Apache license not using canonical version.
2019-11-04 even.rouault include/flatbuffers/base.h: fix no_sanitize issue with old clang (#5610)
2019-11-04 dbaileychess [C++, Java, C#, TypeScript, JavaScript] Skip generation of mutable union types (#5599)
2019-11-04 even.rouault flatbuffers.h: fix documentation warning (#5607)
2019-11-04 dbaileychess Add Lua FlatbufferBuilder Clean() method to enable reuseable builders (#5606)
2019-11-04 paulovictor.pinheiro [Kotlin] Fix union vector accessor after change in Java API (#5605)
2019-11-04 paulovictor.pinheiro [flatc] Remove an always true condition for flexbuffers (#5604)
2019-11-04 llchan [Go] Add UnPackTo functions (#5598)
2019-10-31 me [Go] Object API support (#5339)
2019-10-28 freaken Rust: Add idiomatic iterator for Vector type (#5579)
2019-10-28 even.rouault Fix typos in comments (#5590)
2019-10-28 dbaileychess C++ verifier for evolved union fields should return true (#5586)
2019-10-28 dbaileychess Add ByteBuffer copy for vector of bytes in Java (#5587)
2019-10-28 freaken Rust: Fix Copy and Clone impls for a few generic types (#5577)
2019-10-22 31897320+vglavnyy Add `--clean-first` to the cmake-build command (travis) (#5574)
2019-10-19 ojaslandge Fix Follow implementation for bool (#5554)
2019-10-19 31897320+vglavnyy Fix issue #5557 (#5573)
2019-10-18 bjornharrtell Avoid intentional unsigned integer overflow getting caught by sanitizers (#5572)
2019-10-18 bharat.tak Python: Add forceDefaults opt to python Builder (#5564)
2019-10-17 jaceks Java: Don't annotate vector-of-tables item getters with @nullable. (#5562)
2019-10-17 aardappel Fixed warnings generated by recent JSON sorting feature.
2019-10-18 ishinberg0 [Java] byte buffer factory returned buffer capcity is used instead of the requested size (#5558)
2019-10-17 gunter.burchardt #5544 Fix of Array of table is not sorted if Create<type>Direct() is used (#5546)
2019-10-15 BrianHarris Fix build with gcc version 7.4.0 (#5570)
2019-10-10 aardappel Fixed JSON parser not sorting vectors of tables/structs with key.
2019-10-04 paulovictor.pinheiro [FlexBuffers][Java] Cache size of Sized objects in FlexBuffers (#5551)
2019-09-30 paulovictor.pinheiro Fix issue #5542 (#5543)
2019-09-30 aardappel Fixed Android STLPort related error.
2019-09-30 hkmix Fix namespaced struct/field name collision detection (#5540) (#5545)
2019-09-27 paulovictor.pinheiro [flac] Add FlexBuffers option for generating data (#5519)
2019-09-26 rw Update Rust versions under test from 1.30.1 to 1.37.0 (#5538)
2019-09-26 29380294+mjvk Adds XOPEN_SOURCE for PATH_MAX and POSIX 1993 for stat (#5529)
2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Add override Key::toString (#5533)
2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Fix wrong access to a string using Reference::asString(). (#5532)
2019-09-23 31897320+vglavnyy Fix Mutate() methods of Array<scalar/struct> (override 5508) (#5526)
(...)
2019-04-16 31897320+vglavnyy Add logging of warnings from the flatc compiler (#5289)
2019-04-11 aardappel Fixed VS2010 build.
2019-04-11 aardappel Allow Set() methods to handle reference types
2019-04-12 31897320+vglavnyy Fix the proto-enum leaking issue (#5286)
2019-04-12 31897320+vglavnyy Detect leak with sanitizer (#5283)
2019-04-09 31897320+vglavnyy Add basic test for enum defaults (#5280)
2019-04-09 31897320+vglavnyy Part of #5265, neutral changes (#5281)
2019-04-09 31897320+vglavnyy Enable MSVC assert report box [Abort|Retry|Ignore] if a debugger is present (#5279)
2019-04-06 lee0906 Add files generated by CMake to git ignore (#5278)
2019-04-06 lee0906 [C++]Sync the sample monster.fbs file with the tutorial (#5277)
2019-04-05 matthew Ensure we don't subtract with underflow getting enum names (#5246)
2019-04-05 wolfviking0 Add method GenerateTextFromTable issue #5249 (#5266)
2019-04-05 krojew Fix for build break in c# vector of unions (#5271)
2019-04-04 unexge Fix typo in Go tutorial (#5274)
2019-04-02 31897320+vglavnyy Add compile-time checking of numerical limits in C++ code. (#5270)
2019-03-28 16469394+tymcauley Update grammar to reflect required type signature for enum declarations. (#5269)
2019-03-25 AustinSchuh Add missing test data file to BUILD file (#5264)
2019-03-25 laszlocsomor Bazel CI: fix bad value in yml (#5262)
2019-03-25 nickkuznetsov Fix a warning on compiling with clang (#5258)
2019-03-25 lp.cordier Add inequality operator (inspired from #263) (#5257)
2019-03-22 lee0906 [C++] Changes in the flathash program (#5255)
2019-03-22 ashayshirwadkar12 Fixed tutorial markdown file (#5248)
2019-03-21 aardappel Further fixes to make minireflect compatible with old behavior.
2019-03-19 31897320+vglavnyy Unify line ending rules in '.editorconfig' and '.gitattributes' (#5231)
2019-03-18 aardappel Fixed vector_delimited excluding delimiter
2019-03-18 aardappel Fixed shadowing warning in older gcc for vector_delimited
2019-03-14 aardappel Made ToStringVisitor backwards compatible with older behavior.
2019-03-11 aardappel Made JS enum declarations compatible with google closure
2019-03-11 aardappel Disabled constexpr for hashing functions.
2019-03-12 31897320+vglavnyy Narrows template ascii routines to prevent a possible signed overflow in generic code. (#5232)
2019-03-11 25543498+RandyStevens Fix typo in dart documentation (#5230)
2019-03-11 aardappel [C++] Object API: document custom string type requirements,
2019-03-09 bspeice [Rust] Don't use inner attributes for `allow` (#5212)
2019-03-08 freaken Small usability tweaks to the rust codegen. (#5213)
2019-03-08 16469394+tymcauley Fix rust crate for big-endian targets (#5229)
2019-03-07 aardappel Removed -Wc++98-compat-extra-semi for compatibility with older clang.
2019-03-07 AustinSchuh Bazel ci (#5228)
2019-03-04 aardappel Fixed vector of union JSON parsing.
2019-03-06 25088801+jean-airoldie [Rust] Fixed codegen documentation for Tables (#5227)
2019-03-05 davidn [Go] Add mutation functions for vector elements (#5221)
2019-03-04 42381407+ll-antn Clean-up nested_parser on all paths (#5179) (#5184)
2019-03-04 laurent.stacul [Fix #5112] flatc generates constructors with memset for non-trivial types (#5222)
2019-03-01 5284924+csukuangfj [doc] fix typos in doc. (#5217)
2019-02-27 naure Rust: Fix lifetime in union _as_ accessors (#5140)
2019-02-26 kulikov.alexey90 Java: Calculation of vtable and vtable size moved to the __init method. (#5210)
2019-02-26 kulikov.alexey90 Java: Removed unused duplicate of bytebuffer from "Table#__string" method. (#5211)
2019-02-26 iskandarov_egor Lua library: fix vtable reuse. (#5214)
2019-02-25 aardappel Attempting to make travis not kill the Android build.
2019-02-25 marcus IterateValue: Use ReadScalar instead of unportable reinterpret_casts (#5209)
2019-02-25 bwelling Fix incorrect code generation on Solaris Sparc. (#5208)

Created with:
roll-dep src/third_party/flatbuffers/src

Change-Id: I46bd259878ab27cade6323fb31a56b86edd56cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928296Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718762}

9dd60457

Roll src/third_party/perfetto 9a1a942e18ee..a8c56ef52145 (2 commits) · 0c30fd43

chromium-autoroll authored Nov 25, 2019

https://android.googlesource.com/platform/external/perfetto.git/+log/9a1a942e18ee..a8c56ef52145

git log 9a1a942e18ee..a8c56ef52145 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 lalitm@google.com Merge "trace_processor: take into account asc/desc for eliminating constraints"
2019-11-25 lalitm@google.com trace_processor: update metrics to stop using ref/ref_type

Created with:
gclient setdep -r src/third_party/perfetto@a8c56ef52145

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:135177627
Tbr: perfetto-bugs@google.com
Change-Id: Icc3625f6ebc30854da6ab5664e09ad7d3cebd4dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718761}

0c30fd43

[iOS] Enable non-modal dialogs by default. · 99b8b2c4

Kurt Horimoto authored Nov 25, 2019

TBR=eugenebut@chromium.org

Bug: none
Change-Id: Iac187c621250cbcacf46ea7f90e8b8bfe30b5621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924964Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718760}

99b8b2c4

[duet] Use default background color for IPH · ddd999ac

Gang Wu authored Nov 25, 2019

In dark mode, the IPH background and the text color in tab switcher are
same, so the button is not visible.

Bug: 1028032
Change-Id: Iaff4b4a1b3d1f693be29fec3aa2ce3b87b1fd175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934512
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718759}

ddd999ac

extensions: fix error bubble crash · ffa08552

Elly Fong-Jones authored Nov 25, 2019

This crash is caused by the following code in GenerateMessages():

  std::vector<base::string16> message;
  std::transform(external.begin(), external.end(), message.begin(),
                 [](const auto& extension) { ... });
  std::transform(forbidden.begin(), forbidden.end(), message.begin(),
                 [](const auto& extension) { ... });

Here, 'message' is empty so message.begin() doesn't point to a valid
location, which causes a crash when std::transform() tries to assign to
it. There is another bug too - the second std::transform() invocation
reuses message.begin(), so it will overwrite messages produced by the
first invocation.

This change:
1) Fixes both bugs mentioned above
2) Adds unit test coverage of this logic

Bug: 1028003
Change-Id: I2cbd660a5d5beb56a910a8c1a8ba239818c235f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933952
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718758}

ffa08552

Remove string param for zero state search result page a11y name · 9dcdcf58

Toni Barzic authored Nov 25, 2019

Leftover from the earlier version of CL:1925769, when the string
contained the number of shown results.

BUG=1028036

Change-Id: Ie036e2cb13a992bf93667139d6dd4f73175f2078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934508
Auto-Submit: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718757}

9dcdcf58

Update //docs/android_dynamic_feature_modules.md · f430b278

Tibor Goldschwendt authored Nov 25, 2019

Change-Id: I5bc9d4c7de8d6078e50919fac14660832a19f2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903723Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718756}

f430b278

[fuchsia] Change all Scenic Presents to Present2s · 4f0db2a2

Felipe Archondo authored Nov 25, 2019

Bug: fuchsia:41855
Change-Id: I3d8798424fe92ef298d7a2e4a7c17ddb10398aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927043
Commit-Queue: Felipe Archondo <felipearchondo@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718755}

4f0db2a2

Roll src-internal d0f4dbab33c4..f70aafdb1ad2 (2 commits) · 88b27665

chromium-internal-autoroll authored Nov 25, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0f4dbab33c4..f70aafdb1ad2

Created with:
gclient setdep -r src-internal@f70aafdb1ad2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None,chromium:None
Tbr: jbudorick@google.com
Change-Id: I7bcf12c7c3f10468fc60b587eed1872c66abfddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933378Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718754}

88b27665

[Chromecast] Fix non-starting video · ab92a63a

Ken MacKay authored Nov 25, 2019

"Ready for playback" signal was not sent in all the needed cases.

Bug: internal b/145057846
Change-Id: Id063e85922e60a5abcc4f85fc4b51ac3f79459db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933453
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718753}

ab92a63a

Added myself as payment's owner. · 94459cb9

Sahel Sharify authored Nov 25, 2019

Change-Id: Idac3787790fd8aa4959f1509bcc9836fa69e5c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934514
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718752}

94459cb9

Refactor update_client::ActionRunner. · 2fe49a05

Sorin Jianu authored Nov 25, 2019

The idea here is to remove the hardcoded dependencies specific to
the recovery component, and allow future extension of the action runners
so that handling actions defined by embedders such as //chrome/updater
becomes possible.

The improved recovery component is fully functional for Windows only.
The macOS implementation is missing an action handler, and it is not
registered anymore on macOS. macOS is still using the original
recovery component.

Future dependent CLs will land before this issue can be resolved:
* The kitchen sink update_client::Configurator contains functions related
to injecting recovery component specific objects such as unpacking key
hashes and elevators. These function can be removed.
* Tests for the recovery component ActionHandler class can be written
as part of the unit_tests.

Bug: 1027610
Change-Id: I4d62515b810a2f3b0e85566a2c3596f986cb3041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929863
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718751}

2fe49a05

Content tests fix for append frame origin to network isolation key by default · 0b2b0ab0

Shivani Sharma authored Nov 25, 2019

This CL fixes content tests so that they work if append frame origin to
network isolation key is enabled by default. BeginNavigation now expects the
correct frame origin in the NIK and WebContentsSplitCacheBrowserTestEnabled
disables AppendFrameOriginToNetworkIsolationKey since
WebContentsSplitCacheWithFrameOriginBrowserTest already tests with the feature
enabled.

Bug: 1026388
Change-Id: If855a1e2d6dd4137e9ae0d6273f057c8760f6c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928644Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718750}

0b2b0ab0

Roll src/third_party/angle 04e074d1aae0..34e5a96edc3e (1 commits) · 6659ce26

chromium-autoroll authored Nov 25, 2019

https://chromium.googlesource.com/angle/angle.git/+log/04e074d1aae0..34e5a96edc3e

git log 04e074d1aae0..34e5a96edc3e --date=short --no-merges --format='%ad %ae %s'
2019-11-25 jmadill@chromium.org Fix header typo in rapidjson.

Created with:
gclient setdep -r src/third_party/angle@34e5a96edc3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic8e421b636ececc4617309ef267034609cbdcf82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932473Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718749}

6659ce26

Re-enable DeleteService_HandleHeld test · 492c7591

Sven Zheng authored Nov 25, 2019

crrev.com/c/1919544 is the potential fix for the test.
I have to enable the test to see if it really can fix
the test and then enable more disabled tests.

Bug: 956016
Change-Id: I9448cb928edf50e131e8c1c5886e7d26437b0aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928129Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718748}

492c7591

PM: Add workers to chrome://discards graph view. · 09cd2aed

Sigurdur Asgeirsson authored Nov 25, 2019

Bug: 993033
Change-Id: I391a119d1bd8c9bb6c3c398129920f5e0949ce13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928619Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718747}

09cd2aed

Update mixed content autoupgrade docs · 0ca73f4f

Carlos IL authored Nov 25, 2019

Change-Id: I89348845e26f7f898466b0ec748050469ea4256e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931583
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718746}

0ca73f4f

aw: Enable some features dependending on viz · 98c0b7b7

Vasiliy Telezhnikov authored Nov 25, 2019

This CL updates feature status and WebPreferences to enabled
OffscreenCanvas and SurfaceLayer video for webview if VizForWebview
enabled.

Bug: 805739
Change-Id: I4043c5edd7cd59d72b1a48207eb8eae4cbeb7bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925217
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718745}

98c0b7b7

Enabled LargeImages and Snippets by default. · 0b2c3fde

Jonathan Freed authored Nov 25, 2019

Bug: 985510
Change-Id: I215fd8efbae4286568bda3fa62f9db6a0bbe4cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929642Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718744}

0b2c3fde

Move screenshot ImageEditor implementation to //chrome/browser · 06f6a7f6

Kristi Park authored Nov 25, 2019

Moves non-DFM specific code from //chrome/android/modules/image_editor
to //chrome/browser/image_editor. Only DFM module code should be in
//chrome/android/modules.

Bug: 1024586
Change-Id: Ic0b54482032ef8bc4392e3f18e22fa1660f250ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928299
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718743}

06f6a7f6

Convert //ui to not depend on set_sources_assignment_filter() · 3d95aeaf

Sylvain Defresne authored Nov 25, 2019

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Convert BUILD.gn files below //ui to instead use conditional
to include source files only on the platformn where they are
used.

The conversion was done by using a modified version of gn that
display all files filtered by set_sources_assignment_filter()
and updating the BUILD.gn files manually to explicitly add the
source files only on the platform that used them.

This CL was uploaded by git cl split.

Bug: 1018739
Change-Id: I1c7df4cea9a1a5ba04514f9cae5f200f2a7b29ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930804
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718742}

3d95aeaf

Cros: Add drag metrics for the hotseat · 10711994

Ana Salazar authored Nov 25, 2019

Hotseat can be dragged between the hidden and extended state.
This change logs the presentation time and the maximum latency for this
interaction.

Bug: 10221769
Change-Id: Iedaedd06a66b2c0f3e5d411bb365c30550948536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930098
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718741}

10711994

Pulls Assistant[Card|Text]Element out of AssistantUiElement. · 3c1f13ad

David Black authored Nov 25, 2019

Part of a multi-CL effort to make AssistantUiElements scale better and
simplify adding of new types for developers.

This CL just separates AssistantCardElement and AssistantTextElement
from AssistantUiElement. Follow-up CLs will remove usage of
AssistantCardElementView/AssistantTextElementView from most existing
sites, having existing sites instead rely on shared base class APIs.

See bug for more details.

Bug: b:145003512
Change-Id: I5930b8ee1d1e2f2b94604cbb13ed5d38772aabd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930087Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#718740}

3c1f13ad

Smart Lock: Remove unused switches file. · b487b27d

James Hawkins authored Nov 25, 2019

The one switch, kForceLoadEasyUnlockAppInTests, is unused.

Bug: none
Test: none
Change-Id: I5e645f78385838cac829a3a3fcc2eb84462f4dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932700
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718739}

b487b27d

Permit auto-open of ZIP and RAR files · 38620bf0

Eric Lawrence authored Nov 25, 2019

In Chrome 73, a regression was introduced that acccidentally blocked
users from choosing to auto-open files with .ZIP and .RAR extensions.
This CL resolves the problem by explicitly copying the |auto_open_hint|
from the |default_file_type| to each of the affected file types.

Bug: 946558
Change-Id: I19e81ec7298f1d589de52edd2d47cce0fddd1d63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932239Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#718738}

38620bf0

Disable freezing from TabManager if it's enabled in PerformanceManager · adf3238a

Sebastien Marchand authored Nov 25, 2019

Change-Id: I46f7726e035c6e98050564dfd6841c602c66a376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924912
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718737}

adf3238a

[WebLayer] Allow running instrumentation tests with support APK · 394413fe

Clark DuVall authored Nov 25, 2019

http://crrev.com/c/1926920 changed the the instrumentation tests to run
using the webview provider loading path, which matches what will happen
in production. Unfortunately, the test infrastructure to change the
WebView provider does not work on some versions of Android, which means
the tests may fail when running locally on those versions. This
introduces another instrumentation test target which runs the tests
using the WebLayer support APK:

  $ autoninja -C out/Default weblayer_support_instrumentation_test_apk
  $ out/Default/bin/run_weblayer_support_instrumentation_test_apk

Change-Id: I25cedf2fab171208dc0d029eef6e220e6e994686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931111Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718736}

394413fe

arcvm: Move arc::FileSystemStatus to a dedicated header · 62af016c

Yusuke Sato authored Nov 25, 2019

This is to make ArcVmClientAdapter more testable. Other than the
move, there's no real code change.

BUG=b:123309049
TEST=try, git cl lint

Change-Id: Ie330fd4dc8d717fd4a91478dcb1dfac801a481c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931389Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718735}

62af016c

Add prefix to empty param tests. · 8133379a

Ilia Samsonov authored Nov 25, 2019

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=mahmadi@chromium.org

Bug: 1023677
Change-Id: I5c49a910c959b316e084d66c6545bd3822b8f76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926861
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#718734}

8133379a

Revert "[quickview] Update QuickView test for transparent <webview> background" · 6d759ef9

Owen Min authored Nov 25, 2019

This reverts commit 1f0c003f.

Reason for revert: This CL may be responsible for
QuickView/FilesAppBrowserTest.Test/openQuickViewBackgroundColorText
failure on multiple chromeos trybot.

Example build:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9640


Original change's description:
> [quickview] Update QuickView test for transparent <webview> background
> 
> Fix test after CL:1933859, now the background color is transparent.
> 
> No-try: true
> No-presubmit: true
> Bug: 742944
> Change-Id: Ib9af5c847f5453394d8f2062f3bd97f9d2a1c901
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933864
> Reviewed-by: Austin Tankiang <austinct@chromium.org>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718538}

TBR=noel@chromium.org,adanilo@chromium.org,austinct@chromium.org

Change-Id: I5470aebf89c4baf897d96fd802c9ff47674476a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 742944, 1028247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932174Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718733}

6d759ef9

[WebLayer] Remove weblayer tests from mojo bots · 1cec5d9c

Clark DuVall authored Nov 25, 2019

These are already running on the CQ and main waterfall, I don't think we
need them on the mojo fyi bot anymore.

Change-Id: I0cf015b560efc612831e1d18b9221f89bdba2d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930171
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718732}

1cec5d9c

Fix presubmit check for uses of Bind, Callback, and Closure. · a737d760

Erik Staab authored Nov 25, 2019

The excluded paths argument takes an iterable of strings and
since a string was being passed in it iterated over each character,
including a single '^', which matches all paths.

Bug: 714018
Change-Id: I3798d205bd94a356575c514e2161b935c3f843d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932037Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718731}

a737d760

Fix under-invalidation of background-clip: text · 514d41fc

Xianzhu Wang authored Nov 25, 2019

We need to invalidate the object having background-clip:text on
any text geometry change of descendant. Now we just fully invalidate
the object on any reason needing check of paint invalidation.

Bug: 670292
Change-Id: I67e1e2132d839ed758d93263f411fdbc46bd3e14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932465
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718730}

514d41fc

Even snazzier dump_colors output. · 1e351f3b

Peter Kasting authored Nov 25, 2019

Old output:

ID:                                  kColorAccent Light: ff1a73e8 Dark: ff8ab4f8
ID:                       kColorAlertHighSeverity Light: ffd93025 Dark: fff28b82
ID:                        kColorAlertLowSeverity Light: ff188038 Dark: ff81c995
ID:                     kColorAlertMediumSeverity Light: fff29900 Dark: fffdd663
ID:            kColorBorderAndSeparatorForeground Light: ffdadce0 Dark: ff3c4043
...

New output:

ID                                                Light     Dark
------------------------------------------------- --------- ---------
kColorAccent                                      #ff1a73e8 #ff8ab4f8
kColorAlertHighSeverity                           #ffd93025 #fff28b82
kColorAlertLowSeverity                            #ff188038 #ff81c995
kColorAlertMediumSeverity                         #fff29900 #fffdd663
kColorBorderAndSeparatorForeground                #ffdadce0 #ff3c4043
...

Bug: 1003612
Change-Id: I868894f2c08420eba2d7bf7db533610ae3f24204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931752
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718729}

1e351f3b

Make SourceStream::ClearDataReadyCallback() cancel · eab211bb

Min Qin authored Nov 25, 2019

scheduled DownloadFileImpl::StreamActive() callback.

DownloadFileImpl::StreamActive() will post a task to call itself to
yield the task runner to others.
However, if before the task is posted, a Pause() and a Resume() is
also posted, the Pause() and Resume() will be executed before the
StreamActive(). Resume() will call StreamActive(), and possibly clearing
the stream handle in the SourceStream object if all the body is read.
This causes the StreamActive() call that is posted after the Resume()
to crash.

This CL fixes the issue by making the Task posted by StreamActive()
cancelable. So that in Pause(), the callback will be canceled and no
longer be executed after Resume() is called.

An alternative solution is in DownloadFileImpl::Resume(), we don't call
StreamActive() if the method is already posted.

BUG=1009839

Change-Id: I97d5c2be4fc18b69afbcee29500677c84376aef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933633
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718728}

eab211bb

Roll src/third_party/swiftshader afc52b0b26d7..a59e70ec48ac (3 commits) · df0ca338

chromium-autoroll authored Nov 25, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/afc52b0b26d7..a59e70ec48ac

git log afc52b0b26d7..a59e70ec48ac --date=short --no-merges --format='%ad %ae %s'
2019-11-25 awoloszyn@google.com Fix vkQueuePresentKHR is pResults is not null.
2019-11-25 swiftshader.regress@gmail.com Regres: Update test lists @ d44d6151
2019-11-25 kadam@inf.u-szeged.hu ExecutionEngine: add preliminary support for COFF ARM64

Created with:
gclient setdep -r src/third_party/swiftshader@a59e70ec48ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:b/144766511,chromium:893460
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I6002eac0e3b5267a20f197e35ab230784257a846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934427Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718727}

df0ca338

Smart Lock: Remove NotificationController interface. · 386f301b

James Hawkins authored Nov 25, 2019

It is an unnecessary layer of indirection that is not used.

Bug: none
Test: none
Change-Id: I9463c2da11894b9e9d65606f5de9ea9a99570818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932702
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718726}

386f301b

Use new downcast helper for blink::HTMLParamElement · b5aefd57

Abhijeet Kandalkar authored Nov 25, 2019

This CL has goal to use IsA<HTMLParamElement>(element) in place of
IsHTMLParamElement(element)

Bug: 891908
Change-Id: Ie5459bae0af773d261ffe7c3c310a8e83c7a994a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930542
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718725}

b5aefd57

Move HistoryAdapter*Test[s] to be junit tests instead of instrumentation. · 7e2509b3

Ted Choc authored Nov 25, 2019

The HistoryAdapter tests were showing up with very long run times on
the bots, but I couldn't repro locally the times.  But, it doesn't
appear these tests need to be instrumentation at all, so moving
to junit to make them much faster regardless.

BUG=1023426

Change-Id: I8ca72c3d09e63dcb18e9e57a740efc248ba9c55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931645Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718724}

7e2509b3