GitLab

The motivation is that I want to add a certain include_dir to all targets (to
use libc++ on OS X), _except_ for NaCl targets, since these have their own
bundled C++ standard library already.  Checking for nacl_untrusted_build almost
works, but a handful nacl targets didn't set that yet.  Fix this.  No intended
behavior change.

BUG=400091

Review URL: https://codereview.chromium.org/1332163005

Cr-Commit-Position: refs/heads/master@{#348815}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a66e7c8..2a2b03e

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1344743002

Cr-Commit-Position: refs/heads/master@{#348814}

BUG=491027
R=dmazzoni@chromium.org, dtseng@chromium.org

Review URL: https://codereview.chromium.org/1315703004

Cr-Commit-Position: refs/heads/master@{#348813}

We needed to set a grit define to build the blink_resources target
properly. We were doing this via a global define that affected all
targets, but now we're doing this with a local define instead.

R=rtoy@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1338193003

Cr-Commit-Position: refs/heads/master@{#348812}

R=brettw@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Review URL: https://codereview.chromium.org/1332133002

Cr-Commit-Position: refs/heads/master@{#348811}

Fixes a few errors that all look similar to:
third_party/llvm-build/Release+Asserts/include/c++/v1/map:1365:17: error:
    no matching function for call to object of type
    const content_setting_bubble::compare_button'
            if (__tree_.value_comp().key_comp()(__k, __nd->__value_.__cc.first))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm:573:16:
    note: in instantiation of member function 'std::__1::map<NSPopUpButton *,
          content_setting_bubble::MediaMenuParts *,
          content_setting_bubble::compare_button>>>::operator[]' requested here
    mediaMenus_[button] = menuParts;
               ^
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h:43:8:
    note: candidate function not viable: 'this' argument has type
    'const content_setting_bubble::compare_button', but method is not marked
    const
  bool operator()(NSPopUpButton *const a, NSPopUpButton *const b) {
       ^
No behavior change.

BUG=400091
TBR=bauerb

Review URL: https://codereview.chromium.org/1341533007

Cr-Commit-Position: refs/heads/master@{#348810}

The current weak reference wiring for PopupWindowTouchHandleDrawable is awkward
and fragile. Move the weak ref accounting to its native object counterpart,
using the JNI boundary as a consistent reference lifetime checkpoint.

BUG=528365

Review URL: https://codereview.chromium.org/1341013002

Cr-Commit-Position: refs/heads/master@{#348809}

SurfaceFactory::SubmitCompositorFrame might call glFlush. So calling it
during "kModeSync" stage (which does not allow GL) might result in extra
kModeProcess. Instead, submit the frame in "kModeDraw" stage to avoid
unnecessary kModeProcess.

BUG=527113

Review URL: https://codereview.chromium.org/1341533005

Cr-Commit-Position: refs/heads/master@{#348808}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8359a7..a66e7c8

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1341183002

Cr-Commit-Position: refs/heads/master@{#348807}

By default, the bots run `mb -v`, which dumps a lot of output,
especially when generating isolates for GN. This patch cleans
up a lot of the output so that we log a minimal subset most of the
time and more on errors (but -v will still dump everything).

In the common (non-error) case, this means that we'll get only 1-2
lines of output per MB invocation.

In addition, this patch removes the --quiet flag (which was never used)
and the RunGNIsolate() function, which was never called, and fixes
a minor but annoying issue where we would list the same dependency
multiple times in the analyze results.

R=thakis@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1342563002

Cr-Commit-Position: refs/heads/master@{#348806}

LayerTreeHostCommonTest.RenderSurfaceWithUnclippedDescendantsClipsSubtree.

clip parent is set in the test. We also need to explicitly
set clip_children of clip parent. The test crashes with this
change. The fix is to set unclipped surface of a clip node
to be equal to the negation of ancestor clips subtree.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1339923006

Cr-Commit-Position: refs/heads/master@{#348805}

Also split SCRIPT_LOADED state into two: SCRIPT_LOADED and THREAD_STARTED.

blink side change: http://crrev.com/1344493005

BUG=531345

Review URL: https://codereview.chromium.org/1342733002

Cr-Commit-Position: refs/heads/master@{#348804}

BUG=530370
R=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/1337643002

Cr-Commit-Position: refs/heads/master@{#348803}

Now that we have minigbm in third_party we can set ozone_platform_gbm=1 by default.

BUG=530712
TEST=tryjobs for linux_chromium_chromeos_ozone_rel_ng,
  cast_shell_linux

Review URL: https://codereview.chromium.org/1336023002

Cr-Commit-Position: refs/heads/master@{#348802}

BUG=517168

Review URL: https://codereview.chromium.org/1320293005

Cr-Commit-Position: refs/heads/master@{#348801}

BUG=531677

Review URL: https://codereview.chromium.org/1339603005

Cr-Commit-Position: refs/heads/master@{#348800}

Android Tests (trial)(dbg) now wipes chrome specific data during
provisioning device. But some cases show that "adb ls" is not outputing
the 4-column result (e.g.,
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28trial%29%28dbg%29/builds/4693/steps/provision_devices/logs/stdio).
This CL is to add more log to the Ls function, in order to get more
detailed information of such weird cases.

BUG=514449

Review URL: https://codereview.chromium.org/1336823004

Cr-Commit-Position: refs/heads/master@{#348799}

Ensure Keypad Events on Mac have the correct keycode associated with
them by avoiding the character conversion code and doing the
correct check based on the mac KeyCode value.

For example '0' as a Keypad character was producing the exact
same keycode as '0' as an alpha numeric key because it was
compared via the text conversion function first.

This code is taken from the WebInputEventFactory.mm in blink.

BUG=493833

Review URL: https://codereview.chromium.org/1331383004

Cr-Commit-Position: refs/heads/master@{#348798}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/21216be..c8359a7

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1341023003

Cr-Commit-Position: refs/heads/master@{#348797}

methods which were previously available only in Impl class:
 - GetEntryCount
 - GetItemAtIndex
 - GetCurrentEntryIndex

BUG=None

Review URL: https://codereview.chromium.org/1342953002

Cr-Commit-Position: refs/heads/master@{#348796}

This fixes the bug where overscroll actions that update the scroll view
content inset trigger a relayout of the contained view.

BUG=none

Review URL: https://codereview.chromium.org/1342023002

Cr-Commit-Position: refs/heads/master@{#348795}

This is hitting the same bug as ExtensionApiTest.ContentScriptExtensionProcess
(and a few others) where the iframe in the extension page never fully loads in
the test.

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1347533002

Cr-Commit-Position: refs/heads/master@{#348794}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/13dcae4..21216be

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1340133008

Cr-Commit-Position: refs/heads/master@{#348793}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/200a784..13dcae4

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1342013002

Cr-Commit-Position: refs/heads/master@{#348792}

BUG=520456

TEST=
1. Launch chrome, Sign in to chrome and  add/import a supervised user.
2. In the signed in user, click on avatar icon in top R.H.S and select 'Exit and childlock' option (Switch person window opens).
3. In Switch person window, double click on locked user (Sign in overlay opens).
4. Click on close button of Sign in overlay and observe.
5. The browser should not crash.

Review URL: https://codereview.chromium.org/1320893003

Cr-Commit-Position: refs/heads/master@{#348791}

Includes Some minor fixes to the JS

BUG=none

Review URL: https://codereview.chromium.org/1341463002

Cr-Commit-Position: refs/heads/master@{#348790}

Request focus for re-auth webview after re-auth dialog is showing.

BUG=520046.

Review URL: https://codereview.chromium.org/1336853003

Cr-Commit-Position: refs/heads/master@{#348789}

R=garykac@chromium.org
BUG=471916

Review URL: https://codereview.chromium.org/1341993002

Cr-Commit-Position: refs/heads/master@{#348788}

  In order to roll GN a6029a4c..4c8f3e38 (r341627:r348227) and pick up
  the following changes:

  a88eb18a Throw errors for nested targets in GN.
  d9838e11 Make gyp_flag_compare.py work on Windows
  63a4d153 Fix sbox_validation_tests & Make isolate_driver.py include the executable itself
  789ee894 gn: fix documentation typo
  3473904f Update reference doc page for GN.
  d2cb7552 GN: Fix bootstrap script on Mac.
  7c8964f3 Revert of Fix sbox_validation_tests & Make isolate_driver.py include the executable itself (patchset #3 id:90001 of https://codereview.chromium.org/1245873002/ )
  c6649f2e Fix sbox_validation_tests & Make isolate_driver.py include the executable itself
  5591967b tools/gn: Remove fallback to direct_dependent_configs.
  fe59edcf [GN] move gn doc to proper place
  ba7a73dd Annotate GN executables and shared_libraries with sanitizer deps.
  6aeaa45a GN get_label_info support toolchains for target_out_dir.
  7693bf2b Sync GN unit tests with GYP, add checking script.
  28fccd5c Revert of Sync GN unit tests with GYP, add checking script. (patchset #3 id:40001 of https://codereview.chromium.org/1289423004/ )
  b2f72715 Sync GN unit tests with GYP, add checking script.
  7a694fe1 Fix various stray bugs in the GN auto-roller, and repair the DEPS file.
  83dc1610 Remove remaining legacy SplitString calls.
  f51a763e tools/gn: Remove includes of basictypes.h.
  b35ddf50 clang/win: Try to fix 64-bit build after https://codereview.chromium.org/1261953003.
  e3305701 clang/win: Try to fix build after https://codereview.chromium.org/1261953003.
  c9b8dabc Fix gn bootstrap.
  693c6056 Fix some crashes in GN.
  2a087637 Pull ICU, rename component build GN variables.
  d79f1ac6 Reference written files relatively when possible.

R=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1327363003

Cr-Commit-Position: refs/heads/master@{#348787}

BUG=526268
TBR=jam@chromium.org
Previous Review URL: https://codereview.chromium.org/1326443006

Review URL: https://codereview.chromium.org/1333173004

Cr-Commit-Position: refs/heads/master@{#348786}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dfec292..200a784

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1340183002

Cr-Commit-Position: refs/heads/master@{#348785}

This doesn't even compile:

../../base/logging.h:523:23: error: invalid operands to binary expression ('basic_ostream<char, std::char_traits<char> >' and 'gfx::BufferUsage')
  ss << names << " (" << v1 << " vs. " << v2 << ")";
  ~~~~~~~~~~~~~~~~~~~ ^  ~~

BUG=530712
TEST=cast_shell_linux tryjob with gbm enabled by default

Review URL: https://codereview.chromium.org/1346513002

Cr-Commit-Position: refs/heads/master@{#348784}

Actually, disable all substitutions be default. They're not likely to be
useful for the omnibox.

Since linking to the 10.10 SDK, the omnibox on Mac has started
smartquotifying input. It also replaces "--" with an em-dash. These are
unlikely to be desired for URL or search input, so this restores the old
behavior.

BUG=528014
TEST=Type a quote (") or two dashes (--) in the Omnibox on Mac and wait
a second. It shouldn't get replaced by a different character.

Review URL: https://codereview.chromium.org/1320093005

Cr-Commit-Position: refs/heads/master@{#348783}

Revert of [Telemetry] Refactor Chrome devtools tracing (patchset #2 id:20001 of https://codereview.chromium.org/1338033002/ )

Reason for revert:
This CL fails on mojo perf bots. For Chrome, Telemetry waits for Chrome for the devtools port number. But for mojo, telemetry gives the port number to mandoline. Revert for now, will work on a fix.

See https://code.google.com/p/chromium/issues/detail?id=531755

Original issue's description:
> [Telemetry] Refactor Chrome devtools tracing
>
> Platform-level tracing doc:
> https://docs.google.com/document/d/1Uv8SzOq2ugvzLiOcP85g7qPiaxwsn4tgOdxpe3YjUkM/edit?usp=sharing
>
> BUG=515323
>
> Committed: https://crrev.com/cbecca3af4042fbf593dead4c12cfdd22cfd2310
> Cr-Commit-Position: refs/heads/master@{#348740}

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=515323

Review URL: https://codereview.chromium.org/1343883002

Cr-Commit-Position: refs/heads/master@{#348782}

This factors the irt_* toolchain definitions using a template to reduce
copied boilerplate.  It also switches the ARM build to use arm-nacl-clang
rather than arm-nacl-gcc, which matches what the GYP build does now.  Many
of the compilation flags are still not at all right, but this is enough
for the build of the IRT to complete successfully.

BUG=531702
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1341143002

Cr-Commit-Position: refs/heads/master@{#348781}

If an extension is disabled after it is uninstalled, the extension is not enabled
when it is reinstalled. ThemeService was disabling theme extensions after they
were uninstalled if the extension was uninstalled as a result of the
NOTIFICATION_BROWSER_THEME_CHANGED notification. This bug was causing installing
a theme via the Chrome Web Store to sometimes not work.

BUG=468280
TEST=ThemeServiceTest.UninstallThemeOnThemeChangeNotification

Review URL: https://codereview.chromium.org/1319073005

Cr-Commit-Position: refs/heads/master@{#348780}

This patch moves the render_font_warmup_win files into a common
location so that other content processes, especially PPAPI can
share the code. This is needed as a warmup to pushing win32k lockdown
to other content processes.

BUG=523278

Review URL: https://codereview.chromium.org/1326623002

Cr-Commit-Position: refs/heads/master@{#348779}

This CL puts a little extra space between the list and the buttons.
It also makes the items paper-icon-items so they line up better.

BUG=531750

Review URL: https://codereview.chromium.org/1338363003

Cr-Commit-Position: refs/heads/master@{#348778}

Cr-Commit-Position: refs/heads/master@{#348777}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f26e8c0..dfec292

Sheriffs: In case of breakage, do NOT revert this roll, revert the
offending commit in the blink repository instead.

NOTRY=true
TBR=hayato@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1332213004

Cr-Commit-Position: refs/heads/master@{#348776}