Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 09 Mar, 2020 7 commits
    • Rachel Carpenter's avatar
      Revert "Enable kHelpAppV2 by default." · cde06465
      Rachel Carpenter authored 
      This reverts commit 25d52129.

Reason for revert: Launch being punted to M83.

Original change's description:
> Enable kHelpAppV2 by default.
> 
> For M82.
> Launch bug: https://crbug.com/1042109
> 
> Bug: 1012578
> Change-Id: I76e80ed1f8afc5a34f76fbad30ebef731fd84ff0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076738
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Rachel Carpenter <carpenterr@google.com>
> Cr-Commit-Position: refs/heads/master@{#744935}

TBR=tapted@chromium.org,alemate@chromium.org,carpenterr@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1012578
Change-Id: Ia50fb959b29c97d5e839fd67ecb5a562fadb45d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089537Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Commit-Queue: Rachel Carpenter <carpenterr@google.com>
Cr-Commit-Position: refs/heads/master@{#748074}
      cde06465
    • Rachel Wong's avatar
      [settings logging] Log shared features. · 4f75e719
      Rachel Wong authored 
      This change implements logging of features that are shared by all quick
settings logging functions.

- Audio feature was previously only logged for a volume change,  but has
been moved to become a shared feature.
- There is also some reordering of the header file for readability
reasons.

Bug: 1014839
Change-Id: I4fc6cc9dc4d76acae5450894ec49258320b02d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087300Reviewed-by: default avatarJia Meng <jiameng@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748073}
      4f75e719
    • Raul Tambre's avatar
      hasher: Alias long for Python 3 compatibility · 073c54bd
      Raul Tambre authored 
      The L suffix was removed in Python 3. Fortunately this can be simply removed.
The long type was also removed in Python 3, where int does the same thing. Simply alias long to int on Python 3.
Works on both now Python 2 and 3 now, producing the same results as before.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_names.py", line 33, in <module>
    import hasher
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\hasher.py", line 26
    return uint32_t(long.__rshift__(self, other) & ((1L << 32) - 1))
                                                      ^
SyntaxError: invalid syntax

Bug: 941669
Change-Id: Ib0369ebce8c3bd843ebbbe24188fbe941fa1a2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093471
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748072}
      073c54bd
    • Trent Apted's avatar
      Split the closure typecheck target for chrome://media-app into index/app. · 4635dd1d
      Trent Apted authored 
      Currently there is only one typechecking pass for chrome://media-app.
This means the two JS contexts are being typechecked together, and the
compiler doesn't complain if receiver.js uses function signatures in
launch.js even though they are isolated from each other.

Create one type check target for each .html file, listing the .js
files included in each (via script tags).

Bug: 996088
Change-Id: I7d24a54a1869a535721ef162ec15d268b3b00171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091092Reviewed-by: default avatarPatti <patricialor@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748071}
      4635dd1d
    • Hiroki Sato's avatar
      Clean up ARC a11y standard action lookup. · fef162d0
      Hiroki Sato authored 
      This CL adds HasStandardAction in arc accessibility util.

Bug: none.
Test: unit_test
Change-Id: I1380f1f89647bbe2b39dedc3da0f28ffb3fd90b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091098Reviewed-by: default avatarSara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748070}
      fef162d0
    • Raul Tambre's avatar
      json5_generator: Fix Python 3 dictionary usage · cfc9baf5
      Raul Tambre authored 
      iteritems() was removed in Python 3. items() does the same on both.

Traceback (most recent call last):
  File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 79, in <module>
    json5_generator.Maker(FeaturePolicyFeatureWriter).main()
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main
    writer = self._writer_class(args.files, args.output_dir)
  File "../../third_party/blink/renderer/build/scripts/make_feature_policy_helper.py", line 15, in __init__
    super(FeaturePolicyFeatureWriter, self).__init__(
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 276, in __init__
    self.json5_file = Json5File.load_from_files(
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 140, in load_from_files
    return Json5File(file_paths, merged_doc, default_metadata,
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 124, in __init__
    self._process(doc)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 155, in _process
    entry = self._get_entry(item)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 197, in _get_entry
    self._validate_parameter(self.parameters[key], value)
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 218, in _validate_parameter
    elif not _is_valid(valid_values, value, valid_keys):
  File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 106, in _is_valid
    for key, val in value.iteritems()])
AttributeError: 'dict' object has no attribute 'iteritems'

Bug: 941669
Change-Id: I5a60c0b54584a743ec86e51902e061af08c59c8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093213
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748069}
      cfc9baf5
    • Jia's avatar
      [cros search service] Add case-insensitive exact match to TokenizedStringMatch · 9b15a507
      Jia authored 
      We're consolidating exact & fuzzy string match to be both supported by
the search service. In this cl, we add case-insensitive exact match to
TokenizedStringMatch and remove it from app_search_provider. Note, fuzzy
string match already performs case-insensitive exact match internally.

Bug: 1018613
Change-Id: Ia7d17352e3b263ab09fac1e590748a08d7b16eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089534Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748068}
      9b15a507
  3. 08 Mar, 2020 33 commits