GitLab

The SearchProvider may mark some suggestions to be prefetched based on
instructions from the suggest server. Currently we prefetch it only if such a
match ranks sufficiently highly. This cl allows to prefetch the suggestion
regardless of its autocomplete rank if allow_prefetch_non_default_match field
trial is enabled.

BUG=386203

Review URL: https://codereview.chromium.org/324273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278668 0039d316-1c4b-4281-b951-d872f2087c98

- Consolidates FFmpegAudioDecoder and OpusAudioDecoder unittests
since they were identical anyways.
- Extends the AudioFileReader unittests to perform packet consistency
checks between seeks.
- Extends the new consolidated tests for WAV, FLAC, MP3, and AAC.
- Adds decoded output consistency checks using MD5 for all files.
- Removes old tests which end up duplicating efforts.
- Expands tests for bad decoder configs and buffers w/o timestamps.
- Expands tests to include AudioDiscardHelper usage.

BUG=381356
TEST=shiny new tests!

Review URL: https://codereview.chromium.org/311373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278667 0039d316-1c4b-4281-b951-d872f2087c98

With this change, nested filesystems mounted onto isolated context
can remember its original filesystem id, that unblocks the issue 370782
of drag-and-drop support in chromeos::FileSystemBackend.

BUG=370782, 386062
TBR=kaznacheev, benwells, dmichael, sky

Review URL: https://codereview.chromium.org/341043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377636
TEST=manually test

Review URL: https://codereview.chromium.org/332973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278665 0039d316-1c4b-4281-b951-d872f2087c98

- Finch field trial parameter
- Command-line flag to force the feature off
- OmniboxFieldTrial::EnableAnswersInSuggest(), which considers command-line flags and field trial settings.

BUG=386638

Review URL: https://codereview.chromium.org/348433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278664 0039d316-1c4b-4281-b951-d872f2087c98

R=piman

Review URL: https://codereview.chromium.org/340863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278663 0039d316-1c4b-4281-b951-d872f2087c98

If the local machine's network is unavailable, there's no poin in attempting to
make connections. This change simplifies the connection listening logic and
drops connection attempts while it is known that the network is unavailable.

BUG=376556

Review URL: https://codereview.chromium.org/336473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379862

Review URL: https://codereview.chromium.org/339413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278661 0039d316-1c4b-4281-b951-d872f2087c98

linux (exclude cros).

BUG=362679

Review URL: https://codereview.chromium.org/347653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278659 0039d316-1c4b-4281-b951-d872f2087c98

The notion of Unready types is also introduced for those types which control whether
they should run, and therefore for which a configuration (which might
involve network access) should not even be performed.

BUG=368834

Review URL: https://codereview.chromium.org/312163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278658 0039d316-1c4b-4281-b951-d872f2087c98

Android stl library has bugs related to std::set ->
https://code.google.com/p/android/issues/detail?id=69153

This change allow this code to compile on android.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/335903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/336263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278656 0039d316-1c4b-4281-b951-d872f2087c98

This includes the sanitized paths of all loaded modules and an
indication for those that host active LSPs.

BUG=386156

Review URL: https://codereview.chromium.org/323953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278655 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a part of the series that enables raster
and eviction iterators in cc. In particular, this patch
actually starts using the iterators that have landed
previously. There should be a perf improvement for the
manage tiles case. Other than that, there should be no perf
impact.

This patch's main contribution is that it opens the door for
more optimizations to be done in the future. As well, it
simplifies the logic we have in tile manager.

BUG=329686
R=enne, reveman

Review URL: https://codereview.chromium.org/246673005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380916

R=pkasting@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/314013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278653 0039d316-1c4b-4281-b951-d872f2087c98

Introduce QUIC_VERSION_20: allowing endpoints to set different
stream/session flow control windows. Two new tags kSFCW, kCFCW for
stream flow control window and session (connection) flow control windows
respectively. kIFCW is still used for older versions <= QUIC_VERSION_19.
kIFCW has the same value as kCFCW.

Most of this CL is copy/paste code for setting/getting the new tags. New
values are set in quic_client_bin.cc (and quic_stream_factory.cc), and
processed in quic_session.cc and reliable_quic_stream.cc

rtenneti: When merging into Chromium, you should add something like:

config.SetInitialStreamFlowControlWindowToSend(kInitialReceiveWindow);
config.SetInitialSessionFlowControlWindowToSend(kInitialReceiveWindow);

just before *session = new QuicClientSession(...) in quic_stream_factory.cc

Introduce QUIC_VERSION_20: allowing endpoints to set different
stream/session flow control windows.

Merge internal change: 69557631
https://codereview.chromium.org/339803004/


Added SetUserAgentID method to QuicClient which calls crypto_config_'s
set_user_agent_id method.

The following is the internal CL description.

Add command line flags to allow enabling QUIC UDP proxying based on
Chrome version modifers (canary/dev/beta/stable) included in the CHLO
UAID.

Command line flags to allow QUIC UDP proxying for specific Chrome
versions.

Merge internal change: 69473619
https://codereview.chromium.org/346853003/


Refactoring QuicClient so it doesn't own the epoll server it uses.

We'll be using QuicClient to health check backends for UdpProxying, so
it'll need to use the siloed internal server's EpollServer.

Refactoring quic client to not own the epoll server

Merge internal change: 69460313
https://codereview.chromium.org/344053002/


Fix a bug where QUIC ack frames were not bundled with crypto stream
frames when there was a missing packet.

Moved the code to ensure Crypto stream frames weren't sent with other
retransmittable frames from CryptoStreamFrame into QuicPacketGenerator.

Merge internal change: 69415222
https://codereview.chromium.org/342983004/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/341083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278652 0039d316-1c4b-4281-b951-d872f2087c98

This seems to be the cause for gfs failures on ios simulator dbg

See:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16784

> Use ImageSkiaSource to create ImageSkia from ImagePNGReps
>  gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly.
> 
> BUG=381601
> TEST=covered by test.
> R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org
> 
> Review URL: https://codereview.chromium.org/340613004

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/347983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278651 0039d316-1c4b-4281-b951-d872f2087c98

Partial appends could cause the MP4StreamParser to emit buffers in
non-monotonically increasing timestamp order because of how we process
trun boxes. This patch makes sure that processing of trun boxes is
deferred until we have all the sample & aux_info data before emitting
samples. This prevents the parser from emitting samples in such a way
that will break downstream code. This is a minimal impact fix to
avoid bad behavior at the expense of buffering more data.

BUG=None
TEST=All MP4StreamParserTests that do partial appends now verify the fix.

Review URL: https://codereview.chromium.org/348623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278650 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/338853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278649 0039d316-1c4b-4281-b951-d872f2087c98

Lots of policy tests inherit from that class to reuse common setup code.
The recent work on cloud policy for extensions wired a new class to some
of the existing ones that posts a cleanup task to the IO thread, and
DeviceSettingsTestBase wasn't mocking that thread; so these tests started
leaking at shutdown.

The TestBrowserThreadBundle sets up the UI and FILE threads that the tests
were expecting as well as the other common threads, which makes these tests
more robust.

TBR=pastarmovj@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/348713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368514

Review URL: https://codereview.chromium.org/340953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278647 0039d316-1c4b-4281-b951-d872f2087c98

XK_ISO_Level3_Latch key was treated as a character key.  This CL treats the key as same as AltGr (XK_ISO_Level3_Shift).

Note: Apostrophe key in Latvian keyboard layout (apostrophe variant) is assigned to XK_ISO_Level3_Latch.

BUG=375670
TEST=Done manually.

Review URL: https://codereview.chromium.org/321153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278646 0039d316-1c4b-4281-b951-d872f2087c98

Some applications need access to dev channel APIs before they will
become stable. As written, this change only performs whitelisting for NaCl
apps; I don't think we have any need for enabling this in the non-NaCl case.

I need to find a good way to test this.

BUG=383937
R=dmichael@chromium.org, jln@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/338523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278645 0039d316-1c4b-4281-b951-d872f2087c98

There are two places we check to see if we need uninstall-install. The first is on startup when the extension system is ready (in response to the ExtensionSystem::ready() OneShot timer). If the extension is currently pending, then we'll check again when we get the notification that the extension has installed when OnExtensionInstalled is called.

The function MaybeUninstallHotwordExtension does a series of checks to determine if we should uninstall the extension based on pending installs and previous vs. current locale. If an uninstall is necessary, it kicks it off. 

Upon Uninstall, OnExtensionUninstalled is triggered. When OnExtensionUninstalled is triggered for the hotword extension, it will reinstall it and update the previous locale (language). If the user goes in to try to uninstall the hotword extension manually, this change will also force it to be reinstalled.

This will trigger a second call to OnExtensionInstalled. To prevent a loop, we use HotwordService::uninstall_pending_ to prevent another uninstall attempt.

This CL also removes the dependency on the deprecated NOTIFICATION_EXTENSION_INSTALLED as a side effect.

Several unittests were added to the unittest suite to test various parts of the uninstall-install pipeline. In order to have access to the extension system during tests, the HotwordServiceTest now extends ExtensionServiceTestBase.

BUG=345806

Review URL: https://codereview.chromium.org/330193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278644 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This is causing the following error when running gyp_chromium with disable_nacl=1:

Traceback (most recent call last):
  File "./build/gyp_chromium", line 314, in <module>
    gyp_rc = gyp.main(args)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 527, in main
    return gyp_main(args)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 503, in gyp_main
    options.circular_check)
  File "/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 129, in Load
    params['parallel'], params['root_targets'])
  File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 2759, in Load
    RemoveLinkDependenciesFromNoneTargets(targets)
  File "/chromium/src/tools/gyp/pylib/gyp/input.py", line 1483, in RemoveLinkDependenciesFromNoneTargets
    if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError: '/chromium/src/components/nacl.gyp:nacl_loader_unittests#target'


Original issue's description:
> Isolate nacl_loader_unittests
> 
> Isolate the Linux-only nacl_loader_unittests.
> 
> BUG=384515
> TBR=maruel
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278620

TBR=vadimsh@chromium.org,mseaborn@chromium.org,maruel@chromium.org,jln@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384515

Review URL: https://codereview.chromium.org/348803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278643 0039d316-1c4b-4281-b951-d872f2087c98

This is causing failures on  Linux Chromium OS ASan LSan Tests (3), see
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1905


> Wire up component cloud policy to device local accounts.
> 
> This enables policy-for-extensions running in Public Sessions, and for
> extensions running as Kiosk Apps too.
> 
> TBR=bartfab@chromium.org
> BUG=224596
> 
> Review URL: https://codereview.chromium.org/341043005

TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/343103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278642 0039d316-1c4b-4281-b951-d872f2087c98

Parse full names more intelligently with a rough port of the Android contact name splitter. Only does Western names well; CJK are TODO.

Save and sync the full name separately from the name pieces.

BUG=241886

Review URL: https://codereview.chromium.org/310463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278641 0039d316-1c4b-4281-b951-d872f2087c98

Pass in a set of requested favicon pixel sizes to the HistoryService instead of a desired size in DIP and a set of desired scale factors.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/336423006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/342983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278639 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278638 0039d316-1c4b-4281-b951-d872f2087c98

This is for supporting uploading files from those file systems
(MTP, providedFS) to web pages, by a workaround before the
long term solution resolving the issue crbug/126902 comes.

BUG=383207
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/339323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278637 0039d316-1c4b-4281-b951-d872f2087c98

Result: 283628 => 128506 bytes (155122 bytes: 54%)

R=newt@chromium.org

Review URL: https://codereview.chromium.org/334053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181082,181680,222880,222887,241932,243137,255718,290364,290405,290440,290443,290559,293033,332329
NOTRY=true

Review URL: https://codereview.chromium.org/343113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278634 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278633 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the bug of html-inliner (see the bug for detail).

BUG=383189
TBR=bratell@opera.com, pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/345873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278632 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the flakiness should have been fixed in r277688

BUG=248873,248500,294196

Review URL: https://codereview.chromium.org/345733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309468
TBR=hajimehoshi@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/343073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278630 0039d316-1c4b-4281-b951-d872f2087c98

Includes some minor refactoring: merges launcher_item_util.cc into
ash:shelf_util.cc

BUG=385161
R=ben@chromium.org, skuhne@chromium.org

Review URL: https://codereview.chromium.org/332163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278629 0039d316-1c4b-4281-b951-d872f2087c98

Note: This file is just documentation, and not for actual use. It was
already previously actually removed from the bindings.

TBR=sky@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/347563007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278628 0039d316-1c4b-4281-b951-d872f2087c98

Make event filtered by viewInstanceId instead of instanceId for guests.

BUG=

Review URL: https://codereview.chromium.org/333713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278627 0039d316-1c4b-4281-b951-d872f2087c98