- 09 Nov, 2020 40 commits
-
-
Christian Dullweber authored
Create a transition to animate changes in height when switching between PageInfo subpages. Video: https://crbug.com/1077766#c92 Bug: 1077766 Change-Id: I5fb7392db017951e80cce162d11e17240b3eacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517454 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825285}
-
Ted Meyer authored
Bug: 1136730 R=andrescj Change-Id: I60f2704313adfae0f76ce0d1c55e30051a48267b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506770 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#825284}
-
Kenichi Ishibashi authored
ServiceWorkerScriptCacheMap uses ServiceWorkerResourceMetadataWriter which can be disconnected when the Storage Service disappears. To abort metadata writing gracefully, this CL sets a disconnection handler to invoke callbacks. Since callbacks need to be accessible from both the disconnection handler and OnMetadataWritten() we need to hold callbacks in ServiceWorkerScriptCacheMap instead of passing the ownership of them to OnMetadataWritten(). Bug: 1133143 Change-Id: I0ae2846821372b1f28fddc5d4ac9564ded6ee585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520477 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825283}
-
Mohammed Abdon authored
This CL introduces OnlineLoginHelper which will be used in authenticating Gaia and SAML users in loginscreen and SAML users in lockscreen. Bug: 1102942 Change-Id: Ie0e41b30e4e6cfb8f027d729be24bcd5b8169151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466422Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#825282}
-
Jan Wilken Dörrie authored
This change updates the guidance on top of values.h to prefer base::flat_map<std::string, base::Value> over base::DictionaryValue. Bug: 646113 Change-Id: Ib02ad787068b3f89ae56ea13c4044338eb703437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509576Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#825281}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6f7099debb9e6459fb419b99dd28cf77fdacbc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526180Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825280}
-
arthursonzogni authored
'file:' is special, because it produces a non opaque origin, uses port= = 0, and the conversion from/blink blink preserves port == 0. Previous patch: https://chromium.googlesource.com/chromium/src/+/a444094dd1d17b48a5a93629ac864a5c43671287 provided a different expectations for origins with (port == 0). When this happens, blink replace zero by DefaultPortForPrototocol(scheme): - http => 80 - https => 443 - ws => 80 - wss => 443 - ftp => 21 - ftps => 990 - _ => 0 So when the scheme is "file", zero is replaced by zero and the transformation can be reversed. Fixed: 1143052 Bug: 1144091 Change-Id: I8368cba6fa341a67b579ccfd9c972aace9e1e2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510052 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#825279}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4075f123..22679f90 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f2ceee733c6b24bc8852ee969a582ae70f4dd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825278}
-
Shik Chen authored
Since we migrated CCA to SWA, there is no .crx bundle anymore. Bug: b:172341870 Test: CQ Change-Id: I4fe3cee4ed969e9047d2b432e0d65797d2761e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525960 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#825277}
-
Clemens Arbesser authored
Also slightly refactors trigger script shutdown to ensure that metrics are correct. Bug: b/172548211 Bug: b/171792264 Change-Id: I9687dbf5497a1a15f1267444f478162b07d04373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517453 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Lukasz Suder <lsuder@chromium.org> Cr-Commit-Position: refs/heads/master@{#825276}
-
Victor Hugo Vianna Silva authored
No behavior is changed. Bug: None Change-Id: Ide3e55a5c72a2c25e9a9921b7bee3eb9032e4022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523209 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#825275}
-
Clemens Arbesser authored
This is currently not yet wired up to the android UI, but is otherwise fully functional. There are some smaller follow-ups that I extracted from this CL: - Update to metrics enums - Wiring it up to android Bug: b/171776026 Change-Id: I7a05d97ccabb8c2bbaa3bb574d74772e9c4dbfb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517696 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Luciano Pacheco authored
The use of matchBottomLine() function was removed in: https://codereview.chromium.org/1491543002 Fix var/let violations pointed out by the presubmit. Change-Id: I94bc7853623ec73e54c066030bca60da37e5795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525880 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825273}
-
Gyuyoung Kim authored
This CL replaces all uses of blink::Manifest::ShareTarget::Method with blink::mojom::ManifestShareTarget_Method in order to reduce type conversion between them. Bug: 919392 Change-Id: Id248941c750f0dd0b627c556e58a561a93ec8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521883 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825272}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65040af1001b..ed0b4d1e07fb 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I076f009fb15086b2317cec22e6e73daf4e839a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825271}
-
Austin Tankiang authored
Bug: 1115025 Change-Id: If7943f16b862323a26f60e36f374b2fbcd41c3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525565 Commit-Queue: Austin Tankiang <austinct@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825270}
-
Luciano Pacheco authored
Rename the test FilesAppEntryTypes because the flake was due to the dep `:files_app_entry_types_unittest.m` being commented out, which is fixed in this CL. Change js_test_gen_html() build rule to use `invoker.js_module` instead of `forward_variables_from()` because when there was multiple files in the same build target, it was failing with this error: ``` ERROR at //ui/file_manager/base/gn/js_test_gen_html.gni:117:39: Clobbering existing value. forward_variables_from(invoker, [ "js_module" ]) ^---------- The current scope already defines a value "js_module". forward_variables_from() won't clobber existing values. If you want to merge lists, you'll need to do this explicitly. ``` Bug: 1146484 Change-Id: Ifcf3105ef5f63d6d2e9e2ec9ce8cad7813b4cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525473 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: -
Harvey Yang authored
Updating with CL:2386879, this commit adds SensorServiceNewDevicesObserver to support sensors that are setup after iioservice starts, and let iioservice notify sensor clients that new sensors are available. This commit also adds the implementation of the new method in the fake class. BUG=b:172414309 TEST=builds Change-Id: Ib2bfba1038dc737336424699bfabf02b6ae68941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523131Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825268}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee0ce9858cbc..cffe7e631c4e 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a4f272b3 to 083976a7 (536 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3dfaeeb00271 to d4439824c554 (28 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Test: Test: Test: Capture Clash of ClansTest: Test: angle_end2end_tests.exeTest: Test: angle_perftests --gtest_filter="*clash_of_clans*" Change-Id: I9fa84e51de5c3fd8f7464fef222631d3de74dc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524758Reviewed-by:
-
Yunke Zhou authored
Bug: 1141030 Change-Id: Ie530eeeb8c6f17a6df7fd2e5b81ebd81a85f039f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520839Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 70da33e0. Reason for revert: recipe was rolled to internal repo in https://crbug.com/1144638#c28 Original change's description: > Revert "Reland "[DEPS] update luci-go"" > > This reverts commit f19f9e01. > > Reason for revert: crbug/1144638 The changes have worked for webrtc, but is causing failures for iOS official bots. We'll wait for the autoroll and ensure that CL is in place before re-landing this if that's okay. > > Original change's description: > > Reland "[DEPS] update luci-go" > > > > This reverts commit 94863f6a. > > > > Reason for revert: > > https://crrev.com/c/2518615 fixed the previous issue. > > > > Original change's description: > > > Revert "[DEPS] update luci-go" > > > > > > This reverts commit 1585878b. > > > > > > Reason for revert: > > > https://crbug.com/1144638 > > > https://crbug.com/webrtc/12126 > > > > > > Original change's description: > > > > [DEPS] update luci-go > > > > > > > > Bug: 1142713 > > > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#822547} > > > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > > > Bug: 1142713, 1144638, webrtc:12126 > > > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#823859} > > > > TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1142713 > > Bug: 1144638 > > Bug: webrtc:12126 > > Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824332} > > TBR=tikuta@chromium.org,mbonadei@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713 > Bug: 1144638 > Bug: webrtc:12126 > Change-Id: I33f3cf4b84818a8abbf5d468fb9165543af5f434 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522982 > Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org> > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825019} TBR=tikuta@chromium.org,mbonadei@chromium.org,seblalancette@chromium.org,jeffyoon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I004fc735b04272bd604016af450ff387e6f63191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524810 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#825265}
-
Alan Cutter authored
This CL moves the filtering of apps by: - feature_name - user_type, - disable_if_arc_supported - disable_if_tablet_form_factor from ParseConfig() into PostProcessConfigs(). This is to be able to share that logic with apps added to GetPreinstalledWebApps(). There are no behavioural changes in this CL aside from minor fixups in ExternalInstallOptions::operator==() and its operator<<(). Bug: 1058265 Change-Id: I6a2f3d89f076269e612d0806fb9e3abd37536d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520559 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#825264}
-
Chris Hall authored
AXNodeObject::Language was returning the full meta tag value "en, fr" instead of only the first element "en" when computing the language value for kRootWebArea. A value containing comma is not a valid BCP47 language tag. [1] specifies the DOM lang attribute should be a valid BCP47 language tag, whereas a comma separated list is instead a language priority list. I'm not sure if this necessarily applies to our accessible interface, but it seems like the closest spec and this behaviour is consistent with our other return values. [1] https://html.spec.whatwg.org/multipage/dom.html#language AX-Relnotes: n/a. Change-Id: I0e7b2826e3cca0b9392a4add39c99244018e9dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505291 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#825263}
-
Bartek Nowierski authored
Bug: 1121427 Change-Id: I722ab107fd29489bf23f47f30a97d09622e5ae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517220 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825262}
-
Glen Robertson authored
This should be checked by the implementations in Android and CrOS instead. Bug: 1146394 Change-Id: I16985812c281fa922a95394890cb75bbaf2c17a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524624 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#825261}
-
Takashi Toyoshima authored
misc/link-rel-prefetch.html and css/mask-image-loading.html use the same server logging infra, network-simulator.php, and the access logs for them are sometime mixed and randomly failed due to that. This patch updates link-rel-prefetch.html not to depend on the server logs as we can verify the behavior via client side callbacks. Bug: 1140244, 1140251 Change-Id: I092e092c7c9310b815b09419a206b1517ebd21f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521975 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#825260}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfe647c02fb4..ee0ce9858cbc 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 2b6b0f45ff05 to 3e17e33724b4 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I56a01f70e9b1a616452e8374c75da620128d2fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525042Reviewed-by:
-
Hitoshi Yoshida authored
This CL refines back-send-referrer test again. https://crrev.com/c/2501881 updated the test to work with back-forward cache, but introduced strange states and it turned out not working with the latest implementation of BF cache test infrastructure. This CL cleans it up, and make it work again with BF cache. Change-Id: I28862271f540e61830e9df948bbb0b282c55e2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509641Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#825258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bb6ca4c0c230..65040af1001b 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I27bc2e55d0b8a8542e02792536a7840c54fdd5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524755Reviewed-by:
-
Luciano Pacheco authored
Reland of CL:2503909, I've tested locally as described in crbug.com/1144470#c3 and it's fixed. The change to fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/2519177/2..3 Add a new PAK file for resources in Files app and companion apps like Audio Player, to host the generated JS modules. Change ChromeComponentExtensionResourceManager to also load the resources from this new PAK file. This was refactored to not depend on file_manager_resource_util.h any longer, which allowed to remove this util. Rename Audio Player optimize_webu() to "build" to follow the convention. This is a preparation for converting these apps to JS modules. Bug: 1133186, 1030998, 1144470 Change-Id: Ic803e5f071cde0ac31713578a6f17e74a07c5465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519177Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#825256}
-
Wei Lee authored
This CL fixes a bug that the pinned status might be lost after migrating CCA to SWA. Bug: 1144678 Test: Manually Change-Id: I9bf2fd846645a77d8b7a47cbd7b9afc043950943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516659 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#825255}
-
Luciano Pacheco authored
Add the HTML import for IronButtonState and IronControlState because these become the JS import after the conversion. These are used by the `auto_imports` in the BUILD.gn. Move the <link> tag inside the <template> because this is enforced by polymer_modulizer() this requires changing from rel="import" to normal rel="stylesheet" which in turn requires to changed the URL to request the CSS. Remove build target "closure_compile_externs" because it had empty sources and externs_list, thus not checking anything. Bug: 1133186 Change-Id: I96b7e475b7099465186f94615f2564c2548adddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520480Reviewed-by:
-
Darren Shen authored
During the handling of a key event, an IME may call SetComposition. IMF will delay the processing of SetComposition until the key event is handled. However, when a call to SetComposition("") is delayed, it is run as ClearComposition() when the key event is handled. This can cause issues because SetComposition("") has different behaviour from ClearComposition(). Specifically, SetComposition("") deletes any selected text, whereas ClearComposition doesn't. The root cause is that the code uses empty composition text to indicate that there's a pending ClearComposition. So it's impossible to distinguish between a pending SetComposition("") from a ClearComposition(). Fix this by putting the pending composition into an Optional, so that nullopt means ClearComposition and anything else is SetComposition. Bug: b/172284307 Change-Id: Iec39e8124eab6bd897d543f66f1a4bdb71b3fe78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520556Reviewed-by:Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#825253}
-
Takashi Toyoshima authored
Remove remained Blink CORS dead code from ThreadableLoader. Even after this change, we still have some duplicated code in the class. I will remove it in the next CL as it won't change visible behavior, but it changes the timing for an error detection. Let's keep this change containing only mechanical changes though some of them are still a little complicated. Bug: 1053866 Change-Id: Iaa02a6682dda02f88b6a824a4542b6dc1608129e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522277 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825252}
-
Rakina Zata Amni authored
This reverts commit a79726df. Reason for revert: This is suspected to break some network-related tests Original change's description: > Fix CertVerifierService initialization in some unittests > > The manual resetting of the CertVerifierServiceFactory in between > unit_tests seems not to work on Android. So, refactor the > initialization code to look like the Storage Service's, using > SequenceLocalStorage to reset the CertVerifierServiceFactory > between unit tests. > > Bug: 1015134, 1094483 > Change-Id: Ic13f67274cecd49450279da401fb4cd29c9b1e94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520377 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825141} TBR=jam@chromium.org,mpdenton@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015134, 1094483, 1146899 Change-Id: I4903c4c8fa157f0e47cefd32cfb679fe144d050e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524812 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
This reverts commit aae065c3. Reason for revert: Need to revert a parent change (crrev.com/c/2524812) Original change's description: > Enable Cert Verifier Service by Default > > Bug: 1015134, 1094483 > Change-Id: Ie7c2c5e1c32fa7066c56241966385e1b25fcf61f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505748 > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825181} TBR=jam@chromium.org,mpdenton@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015134, 1094483, 1146899 Change-Id: I5fc021f589657d471749e909b7b2449336c9db3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525465 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Nazerke authored
This CL fixed the tabStrip position in the fullscreen. Bug: 1128249,1139770 Change-Id: I56fa6f03c758f9103e55e74a0069b79103c39d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519976 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825249}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I4ec409b13fad245e50d590f3106cf58f5d4e58cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524824Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825248}
-
Jinsuk Kim authored
HomepageManager is referenced in toolbar/ for mostly its static util methods. This CL injects the method references of them instead to the classes from ToolbarManager. Bug: 1127732 Change-Id: I2b863ede270ee17ad992c88f2ce02fa23f969fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519349 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#825247}
-
Kenichi Ishibashi authored
ServiceWorkerInstalledScriptReader owns a ServiceWorkerResourceReader which can be disconnected when the Storage Service disappears. Set a disconnection handler that calls CompleteSendIfNeeded() to abort script reading gracefully. Bug: 1133143 Change-Id: I94b83798834f4287798df5e24e670309961af7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519682Reviewed-by:
-
