- 16 Apr, 2018 40 commits
-
-
dpapad authored
Latest compiler version does not include Chrome's externs by default. They need to be explicitly included. Change log: https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925 chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9 chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 BUG=831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9 Reviewed-on: https://chromium-review.googlesource.com/1006182Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551058}
-
Derek Cheng authored
Race condition introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/724724 The crash is caused by a race condition, where the the renderer attempted to register another PresentationController to PresentationServiceImpl while there is still a (soon-to-be invalid) one already. When we moved the PresentationController implementation from PresentationDispatcher to blink::PresentationController, we are now creating/destoying the PresentationController across navigation (instead of having it long-lived in the PresentationDispatcher / RenderFrameImpl). The fix is to close all message pipes / Reset() in PresentationServiceImpl when a Mojo connection error is detected. This way, the PresentationServiceImpl will be in a clean state when the renderer connects to it again. This also fixes PresentationReceiver's behavior of obtaining a connection to PresentationService and immediately dropping it after calling SetReceiver(), which would let to Reset() getting called with this patch. To merge back to 66 (if possible) and 67. Bug: 832176 Change-Id: Ic7cd2601a107024143936fa9e1ae197505e4cf64 Reviewed-on: https://chromium-review.googlesource.com/1011289Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551057}
-
Mitsuru Oshima authored
added UpdateImmersiveMode() which updates the immersive mode with the latest status and use it everywhere. This fixes the issue with activation. BUG=832765 TEST=covered by unit test. Change-Id: If1842e523d601dfba40973f5bf62459a7f7f86a6 Reviewed-on: https://chromium-review.googlesource.com/1012993 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#551056}
-
Erik Chen authored
This CL is a refactor and has no intended behavior change. This CL: * Creates a new class Supervisor in components/heap_profiling. This class presents a single interface for tests and consumers of the Heap Profiling Service. * Moves end to end test logic into components/heap_profiling. * Leaves the emit metrics, save to file, and upload in background logic in ProfilingProcessHost. This refactor is necessary in order to expose this shared logic [previously located in chrome/] to Android WebView. The changes in this CL are tested by the end to end tests in ProfilingTestDriver. Change-Id: I3fda597b210522404203ac9cf932f7bccd76cad7 Bug: 827545 Reviewed-on: https://chromium-review.googlesource.com/1008366 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Ken Rockot <rockot@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551055}
-
zork@chromium.org authored
Bug: 761901 Change-Id: I4ca3d5613c6a9fe903032405bf4681b345dee784 Reviewed-on: https://chromium-review.googlesource.com/1003285Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#551054}
-
Hidy Han authored
Change-Id: Ifee3b9eb5710bb1a873016015563cd33c3d9576e Reviewed-on: https://chromium-review.googlesource.com/1008734Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Hidy Han <hidyhan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551053}
-
Yilong Yao authored
Bug: NONE Test: NONE Change-Id: I30d29d8d03c5c04e46b62caa48659fc3a5749f40 Reviewed-on: https://chromium-review.googlesource.com/1013288 Commit-Queue: Yilong Yao <yilongyao@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#551052}
-
Lei Zhang authored
Replace two rects and a bool with a struct of two rects inside base::Optional. Change-Id: Ie0fe4353809d6d22eafdfc5ae9d488cb1af092ea Reviewed-on: https://chromium-review.googlesource.com/1013258Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551051}
-
Avi Drissman authored
This reverts commit dcffdac6. Reason for revert: Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328 Original change's description: > Fix alpha-unpremultiply overflow in WebGL+toDataURL > > This change fixes a regression that was introduced in > https://chromium-review.googlesource.com/c/chromium/src/+/780279 > Fixing the issue by switching sensitive use cases back to using > SkImage::readPixels for safely performing the unpremul conversion > > BUG=826878 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Ie4bc9ced4d7175ab308529f7dd7119f93378e34c > Reviewed-on: https://chromium-review.googlesource.com/1003320 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550979} TBR=junov@chromium.org,fserb@chromium.org,xlai@chromium.org Change-Id: Ib53e4ac4573894ff93424b50af6314a51fee217a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826878 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1014321Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551050}
-
https://chromium.googlesource.com/catapult.git/+log/dc1e62593e6c..0371983030f2 $ git log dc1e62593..037198303 --date=short --no-merges --format='%ad %ae %s' 2018-04-16 simonhatch Dashboard - Refactor /migrate_test_names Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I184b1b4db929d388bf7c291d204484f4aff30a15 Reviewed-on: https://chromium-review.googlesource.com/1014197Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551049}
-
Xiaocheng Hu authored
LayoutText has two NG utility functions PositionForCaretOffset() and OffsetForCaretPosition() with type-based branching code. This patch extracts the LayoutBR handling into LayoutBR overrides for better code health. Change-Id: Ieca60f177c68944a74cfc30fe6bdc444012eca6e Reviewed-on: https://chromium-review.googlesource.com/1011629Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551048}
-
Allen Vicencio authored
Changes WriteFile to return without calling D-Bus when attempting to write from an empty buffer. Bug: chromium:757625 Change-Id: I386a571347ccf84785147ae91edea515b84a507a Reviewed-on: https://chromium-review.googlesource.com/1005776Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#551047}
-
Andrii Shyshkalov authored
TBR=ehmaldonado@chromium.org No-Try: True Change-Id: Icab6f6d500a10a48b1916901b638b9ff929128bf Reviewed-on: https://chromium-review.googlesource.com/1014341 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#551046}
-
Zhongyi Shi authored
- Change the API for MockQuicData::AddRead() and MockQuicData::AddWrite() to always take explicit IoMode. - Deprecate the following methods as those are confusing to consume: MockQuicData::AddSynchronousRead() and MockQuicData::AddAsyncWrite(). Bug: 832803 Change-Id: Ie2dc096820988c47c8a75082ce2baacd1d32c3ae Reviewed-on: https://chromium-review.googlesource.com/1012700Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551045}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d88eaf5315d4..82e2ac9a251e $ git log d88eaf531..82e2ac9a2 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 yhong lib/portage_util: Remove unused method. Created with: roll-dep src/third_party/chromite BUG=chromium:795449 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I67bdb12c05e5d242da7c0f3e3e8a1ddf1ea21d80 Reviewed-on: https://chromium-review.googlesource.com/1014195 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551044}
-
Theresa authored
Use the native page's margin to translate the canvas used to capture the bitmap used in the tab switcher. Without explicitly considering margin, the snapshot is actually shorter than the tab content, causing the content to "jump" when entering and exiting the tab switcher. BUG=832588 Change-Id: Ifdd871369341877c80214fbe767a602ee1f80d23 Reviewed-on: https://chromium-review.googlesource.com/1013132Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#551043}
-
Corentin Wallez authored
BUG=chromium:815092 Change-Id: I31ba1343a53f3e0ca13442f24f6332d130fddf43 Reviewed-on: https://chromium-review.googlesource.com/1013858Reviewed-by:
-
Corentin Wallez authored
After the LUCI migration it is superseeded by angle.try. Also update the link that's shown in the MILO console. BUG=chromium:815092 Change-Id: I6c2dde882ee01e117cfac6695ac9773092a6b09c Reviewed-on: https://chromium-review.googlesource.com/1014172Reviewed-by:
-
Allen Vicencio authored
Adds "Native Network File Share (SMB)" as the name for "@smb" provider id in metrics. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic99300e66d9e0007a8946661a4a24a4cfc9d1b4c Reviewed-on: https://chromium-review.googlesource.com/1011242Reviewed-by:
Steve McKay <smckay@chromium.org> Reviewed-by:
-
Justin Novosad authored
This fixes rendering glitches in pages with videos in them on Android WebView. I do not yet understand why the GL state is being changed without going through the gpu command buffer, but this seems to be happening with Android WebView on pages that have video elements. This is a quick fix to resolve A release-blocking regression. Further investigation will be a part of follow-up work: crbug.com/832810 BUG=826636 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id9b620ffcf74fd674d53a2eadc6efc932e9505d8 Reviewed-on: https://chromium-review.googlesource.com/1012517Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551039}
-
Joone Hur authored
This CL fixes the below build error: In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.cc:5: In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.h:15: In file included from ../../components/download/downloader/in_progress/download_entry.h:11: In file included from ../../components/download/public/common/download_url_parameters.h:25: In file included from ../../services/network/public/cpp/resource_request_body.h:18: ../../services/network/public/cpp/data_element.h:24:10: fatal error: 'services/network/public/mojom/chunked_data_pipe_getter.mojom.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: None Change-Id: I5ed108749c6d8287d91400b4324927cd58e5cd6a Reviewed-on: https://chromium-review.googlesource.com/1013230Reviewed-by:Min Qin <qinmin@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551038}
-
Leonard Grey authored
Cocoa browser's logic for deciding whether to use the light (dark mode) or regular icon requires converting the theme frame color to an NSColor in NSCalibratedWhiteColorSpace and checking against an empirical threshold. To keep things in Views-land and maintain the same interface, this change uses the light icon iff color_utils::IsDark returns false for the given text color. In practice, I will venture that anywhere this disagrees with Cocoa is a borderline case anyway. Bug: 792610 Change-Id: I57b1c0cb90cf06fce4a8a3f31806dedd86791ebc Reviewed-on: https://chromium-review.googlesource.com/1012966Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551037}
-
Sammie Quon authored
This is a reland of b9d68c49 Left the previously disabled test disabled in the reland. Will fix in a seperate cl. TBR=oshima@chromium.org Original change's description: > splitview: Grab app for splitscreen only happen on long press. > > The indicators and the item enlarging only happen after long press, or > if the item has been dragged. > > This is preparation for fling to dismiss. It also removes a flicker of > the indidcators when you tap to open a item. > > Also renables a previous flaky test. Tested locally and it is not flaky > no more. > > Test: ash_unittests SplitViewWindowSelectorTest.* > Bug: 817863 > Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 > Reviewed-on: https://chromium-review.googlesource.com/996528 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550884} Bug: 817863 Change-Id: I0d6b255a89e69443af2e6509a0769622c8f64fb3 Reviewed-on: https://chromium-review.googlesource.com/1012735Reviewed-by:
-
Ian Vollick authored
If a transition was enqueued but not serviced and, much later, another transition is enqueued, it should transition from the final value of the earlier transition. Bug: 832650,830592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2 Reviewed-on: https://chromium-review.googlesource.com/1014008 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551035}
-
crystallambert@chromium.org authored
This article serves as a central location for best practices to write a high performance extension. Bug: none Change-Id: Ie458a57b48dd0213e9effca9b69dd7a67910227e Reviewed-on: https://chromium-review.googlesource.com/821690 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551034}
-
Wez authored
- Enable CHECK against registration of new keep-alives during shutdown. - Promote some DLOG() checks to DCHECKs to make issues more visible. Bug: 720078 Change-Id: I11e24a8de0ec5ab9e0a71f776d4b7149bb847ad2 Reviewed-on: https://chromium-review.googlesource.com/1013394Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551033}
-
Avi Drissman authored
This reverts commit 4df8a2dd. Reason for revert: Tests are broken on Ozone Linux https://ci.chromium.org/buildbot/chromium.linux/Ozone%20Linux/6600 PerfettoIntegrationTest.PacketsEndToEndProducerFirst PerfettoIntegrationTest.TracingRestarted PerfettoIntegrationTest.PacketsEndToEndConsumerFirst Original change's description: > Add a Mojo-based transportation layer for Perfetto > > This adds a base layer that individual logging protocols (like tracing) > can use to send their data to Perfetto, using Mojo messaging and > shared memory. > > First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 > > A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 > > The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit > > R=primiano@chromium.org,skyostil@chromium.org > > Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 > Reviewed-on: https://chromium-review.googlesource.com/980578 > Reviewed-by: oysteine <oysteine@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: oysteine <oysteine@google.com> > Cr-Commit-Position: refs/heads/master@{#551019} TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org Change-Id: Id212b8af28bd08276b6d0ccf48e59063bd7179de No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1013343Reviewed-by:
-
Avi Drissman authored
BUG=831577 Change-Id: Iaee76e352162b0afcbe61b9ee62c5db5ef9adc7f Reviewed-on: https://chromium-review.googlesource.com/1008544Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551031}
-
Elly Fong-Jones authored
This change: 1) Uses the system focus ring color even when SecondaryUiMd is enabled 2) Moves focus ring thickness and inset out to PlatformStyle 3) Adds Mac overrides of the default values Bug: 832306 Change-Id: I6c18d9d0431dc411a5cb95f9c0639e41f4aa1127 Reviewed-on: https://chromium-review.googlesource.com/1012163 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Matt Menke authored
In particular, unescape entire unicode characters at once, and then compare against unescape blacklists, rather than the other way around, to simplify code and avoid the tree structure of the old code. This will also allow the method to use icu's code point classification logic, at some point in the future. Also separate out comparing against the character blacklist and UTF-8 character decoding into separate methods, and add a few more test cases to unittest. The method itself should behave exactly the same as before. Bug: 824715 Change-Id: I5311f25bfda4132b122ec4a079740adf093099a3 Reviewed-on: https://chromium-review.googlesource.com/998014 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551029}
-
Morten Stenshorne authored
There's no need to position pending floats at this point, since there should be none. Added a DCHECK. If a child knows its BFC offset, it has no reason to leave behind pending floats. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I288b0cbd0ce43e422eddfe331dc02a5ee3afd6a8 Reviewed-on: https://chromium-review.googlesource.com/1013486Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551028}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib455f27786c09a9439a68f6a376584efdc8c9209 Reviewed-on: https://chromium-review.googlesource.com/1014288Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#551027}
-
Lukasz Anforowicz authored
The new UMA should help evaluate how often the spare is missing (e.g. because of low process limit on low-memory devices), mismatched (e.g. when simultaneously navigating in 2 profiles) or taken. The spare can only help improve performance of cross-site navigations if it is actually taken. Bug: 808114 Change-Id: Ic37cacf014de73f9adefc0407e60b4cfa246028b Reviewed-on: https://chromium-review.googlesource.com/1012510 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#551026}
-
Tommy C. Li authored
When the URL is un-elided, and then the Omnibox is blurred: a) If the text has not been edited, re-elide the URL. b) If the text has been edited, leave the complete edited text as-is. This CL adds two tests - one for each scenario. Bug: 797354 Change-Id: Ia70cf4357218e3b8f043be73716f067d7b287fd4 Reviewed-on: https://chromium-review.googlesource.com/1012778 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551025}
-
Jérôme Lebel authored
Client secret is not use on Chrome iOS, and the API is removed from SSO. Related to crrev.com/c/975127 and crrev.com/i/480972. Bug: 516021 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If590ae3db2959b2146b6d27a606745ef749050ec Reviewed-on: https://chromium-review.googlesource.com/973229 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#551024}
-
Weidong Guo authored
Background: Long press on app icon in folder will enlarge the icon, but release will not reset it. The long press gesture event is not handled by AppListItemView, thus passed to AppsGridView which handles it. The gesture end event will thus be sent to AppsGridView directly without going through AppListItemView. This is caused by go/cgcl/987293 Change: Only handle the scroll begin event in AppsGridView if in folder instead of all gesture events. BUG=830982 Change-Id: I2ca5bddaf22cd198d6e9cca5ee5f04c9798153e8 Reviewed-on: https://chromium-review.googlesource.com/1008906Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551023}
-
Brian Salomon authored
This reverts commit 56044665. Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData. Original change's description: > Revert "Use new Skia GPU read/write pixel code paths" > > This reverts commit f17c70fe. > > Reason for revert: > > It looks like this change: > > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) > > slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) > > Bug: 825594 > Bug: 825585 > > Original change's description: > > Use new Skia GPU read/write pixel code paths > > > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > > Reviewed-on: https://chromium-review.googlesource.com/973267 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#544777} > > TBR=bsalomon@chromium.org,robertphillips@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 > Reviewed-on: https://chromium-review.googlesource.com/980292 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#545787} TBR=bsalomon@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825594, 825585 Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093 Reviewed-on: https://chromium-review.googlesource.com/1014140Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#551022}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 829039 Test: none Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007 Reviewed-on: https://chromium-review.googlesource.com/1012981 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551021}
-
Ahmed Fakhry authored
This reverts commit 94f04868. Reason for revert: This doesn't work for PWAs, I will reland with a better fix so that it can be merged as a single CL. Original change's description: > Fix extensions badges and decorations positions > > The extensions browser actions badges and decorations should > be positioned at the corners of the icon area, rather than the > corners of the full button's area (i.e. ignoring the paddings). > > Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=831946#c11 > > BUG=831946 > > Change-Id: I977883a3e6127e1f91779a7e73b4adb7fa7c6471 > Reviewed-on: https://chromium-review.googlesource.com/1013290 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550855} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831946 Change-Id: I718ab6842d4bf55f5f1cf6f833e3638974c2fea8 Reviewed-on: https://chromium-review.googlesource.com/1012734Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551020}
-
Oystein Eftevaag authored
This adds a base layer that individual logging protocols (like tracing) can use to send their data to Perfetto, using Mojo messaging and shared memory. First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit R=primiano@chromium.org,skyostil@chromium.org Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 Reviewed-on: https://chromium-review.googlesource.com/980578Reviewed-by:
oysteine <oysteine@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@google.com> Cr-Commit-Position: refs/heads/master@{#551019}
-
