- 03 Dec, 2020 40 commits
-
-
Alex Ilin authored
TBR: reillyg@chromium.org Bug: 1153716 Change-Id: Ia935c5efadae72bfd28e71da4157cdad9432b61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571099Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833357}
-
Jeroen Dhollander authored
This reverts commit 0f98cc3e. Reason for revert: Lots of assistant tests failing on this builder: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome Example builds: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10457/overview https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10451/overview https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10456/overview Original change's description: > Uprev Libassistant to 1.50 > > These are the public changes required to uprev to 1.50. > > NOTE: This includes the hash for the rolldep of src-internal, > as Libassistant 1.50 made some non-backwards compatible API changes. > > The internal changes included can be found in crrev.com/i/3414233 > > Bug: b/170170824 > Change-Id: I88f5836e896efe4005d6e9681175da36c07514b0 > Tests: Manually deployed and tested Assistant queries. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548684 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833190} TBR=xiaohuic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/170170824 Change-Id: I2f6ad96933dabb7a9b100dfe45ac28a62979ce67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572117Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833356}
-
Gauthier Ambard authored
This CL makes sure to update the zPosition of the cells in the TabGrid when they are inserted to allow the upper rows to be above the lower rows. Fixed: 1155122 Change-Id: Ib232dab6d35fa23c828fb027358cb2411e396982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571284Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833355}
-
Alexis Hetu authored
This cl is in the context of replacing SwiftShader's GL libraries with SwANGLE (ANGLE with SwiftShader Vulkan as its backend). In order to allow ANGLE to find the proper libvulkan.so when executing tests on the bots, we have to make sure the proper rpath is set. This affects all tests that depend directly or indirectly on //ui/gl:test_support. The affected tests include: app_shell_unittests aura_unittests cc_unittests compositor_unittests gpu_unittests interactive_ui_tests message_center_unittests media_unittests snapshot_unittests unit_tests views_unittests viz_unittests wm_unittests Bug: chromium:1060139 Change-Id: Ida242f511599d38ad1ec16e0f4711d80a957cc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565490Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833354}
-
cfredric authored
singleton sets. This is required since we need to be able to (quickly) distinguish sites that are members of a non-singleton set from those that are members of a singleton set (i.e. they are not a member of any set provided by Component Updater or on the command line). This, in turn, is needed because we need Chrome to ignore the SameParty attribute for cookies set by sites that are not in a First-Party Set, in order to avoid site breakage in the event of a race condition between the site registering their First-Party Set (and applying the SameParty attribute), and Chrome receiving the updated set list from Component Updater. Bug: 1143756 Change-Id: If77b60538c084a306b1c7af3d1bdabdb9fd1b0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560899 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833353}
-
Alex Turner authored
Instead of walking up the frame tree for subframes that inherit activation from their parents, we now synchronously construct a filter. This uses the functionality introduced for inheriting activation from same-origin openers, allowing synchronous construction. This should simplify the logic used, ensuring any activated frame has an associated filter. Bug: 1134288 Change-Id: Iaa624145c2f77fcce3f0e40f7248fa713ff889c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561265 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#833352}
-
Victor Hugo Vianna Silva authored
AndroidSyncSettings will soon disappear, so this CL migrates most uses of isSyncEnabled(), doesMasterSyncSettingAllowChromeSync() and isChromeSyncEnabled(). The rule determining the corresponding API in ProfileSyncService is described in crbug.com/1129426#c5. After this CL, the only remaining uses of the first two methods are in SyncController, and those must remain as long as ASS exists. Future CLs can, however, deprecate the two methods / expose them only to SyncController, in order to avoid the introduction of new calls. The third method remains used in other two questionable places, which can possibly be migrated as well % some discussion. Apart from the transient states, this CL should have no behavioral difference, *except* for a few cases where the additional case of a null ProfileSyncService must be handled, the effect being minor UI changes. This should be fine because a) the behavior would need to change anyway following crbug.com/1105795, b) the case where PSS is null is quite rare anyway (sync disabled by CLI). Bug: 1129426 Change-Id: I90282eb3674e42b270544e74356691d2ae56b91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562849 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#833351}
-
danakj authored
Fullscreen widgets no longer exist. R=sky@chromium.org Bug: 1134674 Change-Id: Ia6e5ca52332092c0804d692715a0499f1df10311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569367 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#833350}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9421b815..a6237ff2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I142a4ef9f6ba01fa66df448968bbde7e9c09b342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570442Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833349}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0cf173dfbc29..c4b9cd7d79de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sebsg@google.com,antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sebsg@google.com,antoniosartori@google.com Change-Id: I4c237b19422fb9b1615cfe88e56a9916ebb9232d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571197Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833348}
-
Azeem Arshad authored
Originally reverted here https://crrev.com/c/2570237 due to gn dependency check failures. This was caused because of known issue with gn not being able to parse conditional includes https://crbug.com/1125897. Fixed this by adding nogncheck comments for these includes. This also replaces defined(OS_CHROMEOS) macro in the original CL with BUILDFLAG(IS_ASH). This was done to align with http://go/lacros-replace-chromeos-macro-with-ash. This CL updates ShapeDetection service to be hosted in a utility process on ChromeOS. This is being done because the ShapeDetection service implementation for ChromeOS uses a third_party library and does not use any accelerated native shape detection APIs that might need to run in GPU process. Bug: 1093186 Change-Id: I583232c76fff90c3c8d323be46018f59056477c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567179Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833347}
-
Harald Alvestrand authored
Tests that when a PeerConnection closes, all open datachannels get the error and close events. (The bug was fixed earlier, but this adds a test for it) Bug: webrtc:6881 Change-Id: I4734f3d29333dcad98c34cf5dbdc8d4b04a5f986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568278 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#833346}
-
Peter Wen authored
AAR prebuilts need their resources extracted, but the resulting resource target should not need to depend on any of the aar's other deps. Bug: 1154302 Change-Id: I214fc0089a26497babb9a5f6885bf658e5ddca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570096 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833345}
-
Leonard Grey authored
Bug: 839694 Change-Id: Iccea0d36e83733d285a1222bdf1ebb669d7f3104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569969Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833344}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606964048-45fff1aeb7e9c3fd35f310aad8ee0c61f812a3a1.profdata to chrome-win64-master-1606996231-faa54c695225bf8f6afffc1841d10967281c359d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia633d08d6b3f3672b01217f3f3d7fd51f1db6583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568297Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833343}
-
Dave Tapuska authored
All usage of LayerTreeHost has been adjusted, this ptr can now be removed from the RenderWidget class. BUG=1097816 Change-Id: I77cf0adf8e34028c51100be936e9d303e4cf8012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566252 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Joe Mason authored
This class manages the memory request but does not actually do the aggregation. crrev.com/c/2557730 will add another class that does the aggregation after the response is received. The unit tests are still named WebMemoryAggregator because they will also test the new aggregator class which will be invoked by WebMemoryMeasurer. Bug: 1085129 Change-Id: I21a13a407cb96d720463e4d5b009098156324294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569675Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#833341}
-
Dave Tapuska authored
This API doesn't need to be implemented in content/renderer and moving it inside blink removes one more usage of layer_tree_host on RenderWidget. BUG=1097816 Change-Id: Ic979023db67ae93df919f93ba5d570d0865ae9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562945 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/h34dBNFluLOvrol4gz-HIJi_w1-GzSIElYTdJY6clJoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I3da1c09e561251c1d7df9da54400603e9b620567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571194Reviewed-by:
-
Jan Wilken Dörrie authored
R=kazinova@google.com Bug: 1148394 Change-Id: Iabf0963d30c293ab739a01a8a639292f89abd300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569520 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#833338}
-
Stepan Khapugin authored
Creates a new superclass for scene agents. Existing scene agents are all scene state observers, and all have a sceneState property. It also seems useful to have a way to retrieve a scene agent for a given scene. These use features are factored out in a lightweight ObservingSceneAgent class. Existing agents are made subclasses of that. Bug: none Change-Id: Ia1908e339178e52396294fa4f308d759ee32a6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568271 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#833337}
-
Elly Fong-Jones authored
These tests are being bulk-disabled as part of arm64 bot stabilization. Bug: 1154345 Change-Id: I903627c4ea56a175716a9618b73e1ed6fd330531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570195Reviewed-by:
Evan Shrubsole <eshr@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833336}
-
Clark DuVall authored
The attribution methods are only available in R, so add a ApiHelperForR class to access them. Bug: 1085041 Change-Id: Ief6957ad59cd499111c96a7a171eb2dca8e3d609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570034Reviewed-by:
-
Elly Fong-Jones authored
These tests fail consistently on the arm64 bot; disable them as part of stabilizing that bot. They will be reenabled as part of fixing the linked bug. Bug: 1154345 Change-Id: I9277a0fceeed48f434ce9643a3aa7ce4f1d20b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570105Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#833334}
-
Andrew Grieve authored
Bug: None Change-Id: Ib3b63626cdfad918518896f3dadb1a0eaf3d12dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570749 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#833333}
-
Ewann authored
This CL updates the design of TableViews. The presentation style changes depending on the device. Background colors have also been changed. Bug: 922511 Change-Id: Ifc2207146bedbc5f8332b3df7fa112a6525a279a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567928Reviewed-by:
-
Jan Wilken Dörrie authored
ReparseServerPredictionsFollowingFormChange R=kazinova@google.com Bug: 1140480 Change-Id: Ib2c5f3c9c623865beb66f39198377aadc239ab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570372 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
Bug: 1108780 Change-Id: I11765de4e2c29f8a0cc464f0af283aff36b702b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570566 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Jan Wilken Dörrie authored
TreatNewPasswordHeuristicsAsReliable R=kazinova@google.com Bug: 1140493 Change-Id: If291b2aa994ee0482775c3c5dc483ca6dc26ebb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571363 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/SDoonf2Hkjiq08J3Ms2EUYh3QtvIsKK630F0L4wd46gC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173978830,b/174603791,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: I4b2504c38e7441bd375fc733e3f4bf8c6a9980f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568299Reviewed-by:
-
Bruce Dawson authored
Windows 7 no longer works for building Chromium and nobody has volunteered to add support and Windows 7 is an unsupported OS so this change formalizes that Windows 10 is now required in order to build Chromium. This updates the documentation and modifies one of the build scripts so that a readable error message will be displayed when building on Windows 7 is attempted. Chromium and its derivatives still run on Windows 7. This only affects developers. Bug: 1150302 Change-Id: I1874c691a1405482232323bef025aba4b3ac74b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570075Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#833327}
-
Sigurdur Asgeirsson authored
TBR=sky@chromium.org Bug: 1145565 Change-Id: I1d75d411e4ba1ded30bcd20f194ad50947802858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564390 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833326}
-
Camillo Bruni authored
Add ScriptResource::ScriptType in preparation for module streaming and stop sharing ScriptResources with different ScriptTypes. Currently the ScriptResource creates the ScriptStreamer which in turn is responsible for creating the v8::ScriptCompiler::ScriptStreamingTask. To support module streaming compilation we need to pass on the script type from the fetch location to V8. Bug: 1061857 Change-Id: I6d8d032b0f42dca904493f1e80b0ff31878aa123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556942 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833325}
-
Ewann authored
This CL moves utils to /ui/table_view/*. ChromeTableViewStyle() was defined in Settings utils except this method will apply to all TableViews. Bug: 922511 Change-Id: I3f86ff0b346448ccbce134e56750b2996fc00ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567885Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#833324}
-
Scott Violet authored
BUG=none TEST=none, this is purely a documentation change. Change-Id: I4ae57d20be33b23a4d3bf3398e3bd3586621caba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567340Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833323}
-
Hiroshige Hayashizaki authored
Reflecting https://github.com/WICG/import-maps/pull/227 Bug: 848607, https://github.com/WICG/import-maps/issues/166 Change-Id: Ide80e105fc57dfa35a66051b241b699fa969fcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491594 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ee0f9db82db..c9f76ea16b75 2020-12-03 alexrudenko@chromium.org Capture page screenshot on e2e timeout errors 2020-12-03 tvanderlippe@chromium.org Add missing semicolons in TypeScript files 2020-12-03 andoli@chromium.org Add documentation to ActionRegistration interface If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9f74741076d6a35cdf69ab63edfa29df974261c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571188Reviewed-by:
-
Liquan (Max) Gu authored
PaymentUiService provides two APIs, getPaymentApps, getPaymentAppsInPaymentAppList, which returns a list of EditableOptions, PaymentApps respectively. This CL combines the two APIs for simplicity and made necessary changes to the use cases. Bug: 1025619 Change-Id: I88d5e9cf8ce881fdd87266c077482ae65c32669f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570748Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833320}
-
Ankit Kumar 🌪️ authored
Add AccessibilityTextRunInfo in pdf/ to replace usage of PrivateAccessibilityTextRunInfo. PrivateAccessibilityTextRunInfo is a Pepper struct. The new struct ensures that PrivateAccessibilityTextRunInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: Id3efb8ba95a25b3955213f9ddf2ed0f5d5d55232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560092 Auto-Submit: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833319}
-
Hans Wennborg authored
Bug: 1155145 Change-Id: I017435298a7e860f42f3d36ac27c6fc7a2e55841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571098 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
