- 31 Aug, 2019 11 commits
-
-
Jon Mann authored
Implements support for tracking the number of attempts to apply a given update as well as the ability to return a specific PendingNetworkConfigurationUpdate. Bug: 966270 Change-Id: I5b48292b51ce5cf1639af5f119b36b4e9d99e5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775670 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692299}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=mattm@chromium.org Change-Id: I8b415eafa1b618785870087c39e813d615e4e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778550 Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#692298}
-
Gary Kacmarcik authored
Change-Id: I50b6548b891a123c63b9513d469b51c0efd664b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779402 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692297}
-
Lan Wei authored
We are adding a tentative API to experiment with dynamic delegation of "autoplay" capability, and it will work with run-time flag --enable-blink-features=ExperimentalAutoplayDynamicDelegation. We have a test page with this API, which will auto-play the video after click with the flag. http://mustaqahmed.github.io/web/autoplay-dynamic-delegation-tester.html Bug: 985914 Change-Id: I7756032bd8e18f55bc77fdb1929238ee724d8958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779012Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#692296}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8b14b0dea605..ed2fc50eb12d git log 8b14b0dea605..ed2fc50eb12d --date=short --no-merges --format='%ad %ae %s' 2019-08-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 291798b8..54ad211b (692040:692182) 2019-08-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ea980c90..291798b8 (691937:692040) 2019-08-30 phoglund@webrtc.org Adding CreateTcpClientSocket without user_agent and proxy_info. Created with: gclient setdep -r src/third_party/webrtc@ed2fc50eb12d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I6c3974af983d7242de59d7ea047db572dcaff918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692295}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9e1c92c073c9..354c81aceebe git log 9e1c92c073c9..354c81aceebe --date=short --no-merges --format='%ad %ae %s' 2019-08-30 crouleau@chromium.org [Telemetry] Don't check for broken expectations during benchmark run. Created with: gclient setdep -r src/third_party/catapult@354c81aceebe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:985103,chromium:985103 Change-Id: I4f397430a3322ec2fe493dfbfcd40de684d47151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779527Reviewed-by:
-
Ahmed Fakhry authored
In multi-profile sessions, simultaneously logged-in users share the same number of desks, but switching between users should restore the user's last active desk position. BUG=995374 TEST=Manually, expanded existing tests. Change-Id: I4dcc81eb02abbc8fbd94bcce618e00fa477ccb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778594 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#692293}
-
Fritz Koenig authored
This reverts commit e78b3019. Reason for revert: Flipping the framebuffer is not correct. This flip results in the anti-aliasing being applied to the wrong locations. Original change's description: > cmaa : Flip internally allocated framebuffer > > MESA_framebuffer_flip_y needs the allocated framebuffer > to be setup to the same orientation. > > BUG=964010 > TEST=https://www.khronos.org/registry/webgl/sdk/tests/conformance/context/context-size-change.html?webglVersion=2 > > Change-Id: If7b7aaec176387e47c46c4f7337d686536375e8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641666 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Fritz Koenig <frkoenig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666113} TBR=frkoenig@chromium.org,kbr@chromium.org,mcasas@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964010, 996323 Change-Id: I3db041ea67e3dacac2bdd083c9f3fc2c15b02f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779091Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#692292}
-
Jamie Madill authored
This was fixed in ANGLE some time ago. Bug: None Change-Id: If92644285f2279cc34ce591f22e983d74f544792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779067Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#692291}
-
Hesen Zhang authored
- The input was assumed sorted, and the implementation was based on that assumption. Now it is not guaranteed, and this CL is about to fix it. Bug: 998701 Change-Id: I1162dd225e66d5724b65fc9423334e05989c50b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774826 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692290}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/adbecedad5e0..58e68e0665ba git log adbecedad5e0..58e68e0665ba --date=short --no-merges --format='%ad %ae %s' 2019-08-30 bryan.bernhart@intel.com Disable flaky BC texture tests. 2019-08-30 enga@chromium.org Add dawn_perf_tests as a data_dep of dawn_perf_tests_temp_group Created with: gclient setdep -r src/third_party/dawn@58e68e0665ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I205df7b2d12dfbaee29b9bfb3522a0dbee33ff87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779446Reviewed-by:
-
- 30 Aug, 2019 29 commits
-
-
Marijn Kruisselbrink authored
This will help us get an idea of how much usage the API gets, and how the user is interacting with the various UI surfaces exposed by the API. Tbr: jam@chromium.org Bug: 968551 Change-Id: I2c19cc8a2a411dba9f04f76da879035b66ca8071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777059 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#692288}
-
Kevin Marshall authored
Backtrace generation doesn't work for optimized official builds, so the StackTraceTest test is disabled for that case. Bug: 999737 Change-Id: If7e395d82bd77ba47cb63d33cfab1b66711f627a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779566 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692287}
-
Erik Chen authored
This CL makes WebViewImpl stop inheriting from WebWidget. The main functional change is that WebViewImpl::MainFrameWidget now returns the actual WebWidget [assuming one exists] or else nullptr. Previously it always returns `this`. All non-test callers of MainFrameWidget have previously been audited, and problematic call sites fixed. Change-Id: Ifb585add3a0e397af338022c5e30d36bdd90f83b Bug: 995981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771350 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Stephen Martinis authored
The builds are failing to find the 'utf-8' codec. This should hopefully help fixing the problem. Bug: 999461 Change-Id: I1d021974c12aab2ff365dcd95d87dc3ace5c1b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779439Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#692285}
-
Tatiana Buldina authored
Fix screenshot size on Retina screen by setting scale = 1 / device_pixel_ratio Bug: chromedriver:752, chromedriver:2683 Change-Id: I1b378e2cda6f8b52f67337c754ae18cf2cb8130f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772436Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#692284}
-
vikas soni authored
This reverts commit cc108652. Reason for revert: Shared image video overlays seems to be broken on android K,L and M. Reverting until this issue is debugged and fixed. Original change's description: > Enable shared images by default on Android > > Bug: 900973 > Change-Id: I67570ec7f0fcf7daa9bd1234d17ae5a9c9b9bf23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761634 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688744} TBR=penghuang@chromium.org,boliu@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 900973, 997574, 997579 Change-Id: I3c59ea1befcc5ea8bbff87ecdd69d56d7a85fe7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779180Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692283}
-
Joshua Bell authored
In cases where an array is being processed to generate a key (either a JS array, or an array key path), if an exception occurs the conversion needs to terminate immediately so that the exception can be delivered to script. Add early exits in a couple missing places, and add tests. Note that these cases are not reachable from script, because the conversion code is defined to run on "structured clones" of input data, so any getters that throw (for example) will have been filtered out by the previous serialize/deserialize process producing the clone. Change-Id: I53576eb1d47d23b0be4b712bc12e9de47078a419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777060 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#692282}
-
Aga Wronska authored
Bug: 935859 Test: ParentAccessViewTest Change-Id: Ie1ad5b0165e1f9c9387f0452b1b0f7cece1c5182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775555 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Anqing Zhao authored
The return value of method ReadTemperatureSensorInfo should honor the information source, rather than always set as false. Bug: None. Change-Id: If107543591c450693eef197e42c3878637ce43b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771601Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#692280}
-
Fabrice de Gans-Riberi authored
* These files were in //fuchsia/engine but are now needed for tests outside of WebEngine. * Spin-off from https://crrev.com/c/1773707 Bug: 997895 Change-Id: I8361953162f9353fba8493a08ca984de0492b7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778917 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Tricia Crichton authored
This CL enables users in headless mode to specify download.default_directory using dot notation rather than constructing a nested dictionary. Support for the nested syntax is maintained. This matches the behavior for headed mode. Bug: chromedriver:3106 Change-Id: I8b225b83272b5ab15d176603bf6df43493c64a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779427Reviewed-by:
-
Sky Malice authored
Bug: 997716 Change-Id: I1fbeeba09a9143c7e8029e5f102b6ea004947999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769515Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#692277}
-
Peter K. Lee authored
isIOS() checks value of navigator.platform. iOS 13 iPads are returning "MacIntel" for both simulator and devices. Changed regex to accept that. TESTED=Added EG test for chrome://flags Bug: 989035 Change-Id: Ibd88453c1d9e2ec425515b3c7f22229b028cace0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772119Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#692276}
-
Ben Pastene authored
Add a link to that doc in Tast test failure log snippets. Will make failure snippets look like: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904924613768986736/+/steps/chrome_all_tast_tests__with_patch__on_ChromeOS/0/logs/Deterministic_failure:_session.LogoutCleanup__status_FAILURE_/0 Bug: 923426 Change-Id: Id7d19fa94126a013763e6671cfc0cd8f6263c71b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759234 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#692275}
-
Lukasz Anforowicz authored
This CL adds a test with incorrect/undesirable expectations that will be tweaked by a (big and therefore separate) follow-up CL for https://crbug.com/998247 (see https://crrev.com/c/1633232). Bug: 998247 Change-Id: I496af280e41173a3c02908a385c544180c1a1d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773453 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692274}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fe2e9f99..a7cf9c5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d012533a21bc0ce45753c9dc9190b7a4cf2d184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778666Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692273}
-
Regan Hsu authored
Bug: 998561 Change-Id: Ia4e9ca33ee7f30eb333ff479fd7d6e9075e995bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774958 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#692272}
-
Jun Mukai authored
This CL adds the home-launcher state changes in ShellTestApi, and so LauncherDragTest can conduct within tablet mode. As far as I tested, the input latency for dragging in tablet mode is not quite bad. It is 50-60msecs in scarlet; that is comparable to the latency of clamshell mode in nocturne. Bug: 995991 Test: interactive_ui_tests Change-Id: Ifd7d2694bdcf5a60eb295d11773df1eb73ec181b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775598 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692271}
-
Xing Liu authored
This test is failing on some Android builders. TBR=ricea@chromium.org Bug: 999647 Change-Id: I37858af2761542f27510a125436f5011c90cf42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779434Reviewed-by:
-
Fergal Daly authored
This adds a failing test and fixes it by ensuring that we add an intersection observer not just to the revealed elements but go one further than that in each direction. Without that, it's possible to scroll all the way through a very large element without the ever triggering an intersection observer. More detailed explanation in bug. Bug: 983050 Change-Id: I2fa86fdb7cf58f463f716fd2f34f61b3f10bc0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772850Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#692269}
-
Donn Denman authored
Fixes some recently introduced resolve behavior problems with the Tap gesture when the CSLongpressResolve feature is enabled: 1) Tap should not be recognized (unless we're in the preserve-tap variation of the longpress experiment). 2) Tap should not resolve even when we're in the longpress variation when privacy-aggressive behavior is enabled. Adds automated tests. BUG=999448, 999663 Change-Id: I29d14c7666fdcd8ea286ae5d55c46e250e23c350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779301 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#692268}
-
Josh Nohle authored
To conform with the style of other DeviceSync v2 helper classes, send the ResultCode and the new ClientDirective (if one was sent) as individual callback arguments instead of bundling them in a CryptAuthDeviceSyncResult. We reserve the CryptAuthDeviceSyncResult to express the *final* result of the v2 DeviceSync flow. This is a stylistic clean-up; no logic is affected. Bug: 951969 Change-Id: I9cf32d1d2692c04721ccdb98da890db54b833739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778807Reviewed-by:
-
Josh Nohle authored
There is no benefit in passing the enum by reference. Furthermore, this change reduces the risk of segfaults by destroying the object that owns the ResultCode, for instance, in CryptAuthDeviceSyncerImpl::FinishAttempt. Bug: 951969 Change-Id: I8e835160865ef57182384dc2c74fa399dff406d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778405 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Ioana Pandele authored
- Add a description - Change string - Change order - Only display for signed in users Bug: 986322 Change-Id: I47e7320f66caad5587348c4e63d0e565c54bf68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776541 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#692265}
-
Becca Hughes authored
As per UI review, make the action button ink drop round. We do this by subclassing image button and returning a custom ink drop. BUG=999708 Change-Id: Ib7067cb4a27b9a01c01eb397c80e665a23027224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778652Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#692264}
-
Alex Danilo authored
This reverts commit e919a379. Reason for revert: Flag was disabled for landing on 77 branch, so reverting this to enable it again for 78. Original change's description: > Disable feedback panels by default > > Bug: 999653 > Change-Id: I3c2a65fc04817a1ced86ecbd5157877a6ac07244 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778883 > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Commit-Queue: Austin Tankiang <austinct@chromium.org> > Auto-Submit: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Austin Tankiang <austinct@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692200} TBR=adanilo@chromium.org,austinct@chromium.org Change-Id: I7860daf73b48f18f7c05fc9155f16f328c09d124 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779463Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692263}
-
Adam Langley authored
Took me too long to figure out why all the tests were dropping three bytes from the beginning of messages. Therefore it's worth a named constant. Change-Id: I3b22d9c4e654dd67b6de9ef2cb3cbe4afb358c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776795 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#692262}
-
Dominik Röttsches authored
DWriteFontLookupTableBuilder related test appear flaky. The root cause is believed to be an inconsistent state of DWriteFontLookupTableBuilder due to testing-override methods on this class. Disable the tests until the full solution is in place. Bug: 996167 Change-Id: I68eebba031b6b865c8db4d884c07641ecd1dcc4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778605 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692261}
-
Robert Ogden authored
Also will end up ignoring regexps, oh well. Bug: 999702 Change-Id: Id7e961b1ff9ac8948a2cd53f01e58164c0a79c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779178Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#692260}
-
