- 12 Aug, 2020 40 commits
-
-
Peter Beverloo authored
Bug: 1113148 Change-Id: Ie562df1e71f37bc8618d083ae68fb321a5cca1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351919 Commit-Queue: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797245}
-
Stephen McGruer authored
This reverts commit 4fb20b8a. Reason for revert: Suspect for failures on WebKit Linux ASAN; https://crbug.com/1115526 Original change's description: > [Web Payment] Very long instrumentId string test. > > This patch adds a test for JSON serialization of a very long string > being passed into PaymentRequest API. > > Bug: 1110324, 1115091 > Change-Id: I7966d71c3752d1e4378a54f534a1915fb8fade39 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348411 > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Nick Burris <nburris@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797165} TBR=rouslan@chromium.org,nburris@chromium.org Change-Id: Ieef62c51b197a87a04b4bfc4fd6c91f8bcea85a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110324 Bug: 1115091 Bug: 1115526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352549Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797244}
-
Richard Knoll authored
The final status flag is determined by the transfer status. Additionally this CL adds a Clone() method to TransferMetadataBuilder to be able to update fields from already build TransferMetadata objects. Bug: 1085067 Change-Id: Ie4a3cb335897f477329bc21189c33530ee7848ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349848Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797243}
-
Victor Hugo Vianna Silva authored
Reflecting the updated mocks. Bug: 1102294 Change-Id: If526eb2754bf4981affb0bb3a2be381f6ac5e143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352231Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#797242}
-
Sebastien Lalancette authored
Bug: 1093302 Change-Id: I8103a36420b9f99b3d8428e56f57fd244eb9f33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351953 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#797241}
-
Albert J. Wong authored
This removes the refcount thrashes in Element::setAttribute() avoiding nearly 13% of regression in blink_perf.bindings set-attribute.html story when StringImpl is made threadsafe. Bug: 1083392 Change-Id: Ia5fe7193c24ae8baa4f16a21a2a79f80e7dc0b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351950 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797240}
-
Albert J. Wong authored
This is required for removing the refcount thrashes in Element::setAttribute() and ultimately avoids nearly 13% of regression in blink_perf.bindings set-attribute.html story when StringImpl is made threadsafe. Bug: 1083392 Change-Id: I904396d7913ad18ba0f097afd087aa796dd530ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351095 Auto-Submit: Albert J. Wong <ajwong@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d7901a45. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I921cc645a5e71ef8784d9e8026cc48bd933d7cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797238}
-
Nazerke authored
Current behaviour: The animation to enter fullscreen makes the Incognito badge next to the security icon appear as if it comes from the left. The animation to enter fullscreen makes icons on the far right (Share icon/ Mic icon) and left (Message badge/ Incognito badge) move towards the center before fading out completely. Intended behaviour: There should be no x translation, when the Incognito badge appears, but instead it should start animating from a scale of 0, while maintaining the current fade behaviour. The icon should not move towards the centre, but instead combine the current fadeout with a scale translation towards 0. Bug: none. Change-Id: Ie4b4c6844aa0618366d16bacb5b29adc26e8e03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336837 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797237}
-
Danil Chapovalov authored
Bug: None Change-Id: I4b98e28ada4343a8674d4755dd9b8b224402b5b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289778 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797236}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597211695-37c2210c4f6de3e68198b41f1297acfc22a0b10f.profdata to chrome-mac-master-1597233486-9b99859a3e8f91576b2a111cc083e1a4b72a89f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic9006fb3c4fb3fe5526f76a6e8da322efd71eace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797235}
-
Stephen McGruer authored
This reverts commit f0f5ad44. Reason for revert: Tentative revert for suspect of BackForwardCachePrintBrowserTest.DisableCaching failure; see https://crbug.com/1115515 If this does not resolve the issue, I will reland the CL (with apologies! :)) Original change's description: > Narrow the scope of page pause when printing. > > In the current implementation, sometimes the scope of a page's "pause" > is too wide compared to the definition in the spec [1], and sometimes it > does not pause at all. So narrow the scope to better conform to the > spec, and apply it consistently to all possible ways users can print. > > This is based on an earlier CL [2] which only did this for printing with > the system dialog, but not for Print Preview. Some of the trickier cases > handled, which require unpausing, are: > - Navigations while previewing. > - Printing selections, which require a navigation. > > [1] https://html.spec.whatwg.org/C/#printing-steps > [2] https://crrev.com/c/1669250 > > Bug: 956832 > Change-Id: I9bf274fcfb70eefe896fbbae9ce13a88b6f4dfc0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338819 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797120} TBR=thestig@chromium.org,yukishiino@chromium.org,tkent@chromium.org Change-Id: I3518cb22f1b19fb4a2942c46fbcd9e7326d20863 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956832, 1115515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352430Reviewed-by:
-
Viktor Semeniuk authored
This change hides Password Check section during search. Bug: 1075494 Change-Id: I5f0ce561bcb5d3282c1e477298cfecbce9224580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339747Reviewed-by:
-
W. James MacLean authored
This CL switches the order of checking origin isolation so that opt-in isolation (which is the stronger of the two), is checked before command- line isolation. Bug: 1067389, 1085275 Change-Id: I82eaa73eb4be67f35e8829334cf3e7f3868f87d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346906 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#797232}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Ic966e8f21ee31af7c47dc2be9a8073cd2e6f64ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351788Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#797231}
-
Yuki Shiino authored
Annotates some of bindings::V8SetReturnValue with 'inline' so that the perf on Android improves. blink_perf.bindings/node-type improves by ~7%. Bug: 839389 Change-Id: I32162c4712d828616785747ce7f5688f5511808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348493 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#797230}
-
Avi Drissman authored
CTGetCoreTextVersion is deprecated as of macOS Big Sur. The recommended replacement is normal version checks, so migrate to the standard Chromium base::mac::IsOS() checks. Bug: none Change-Id: I782dd440d7fd04829eae4860cb57c7f7d1ffdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351161 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#797229}
-
Avi Drissman authored
On Big Sur, the system font has a full, real, 'opsz' axis rather than the 10.15 trick of gluing together two optical sizes. Adjust the test to match. Do some cleanup in the main .mm file. Switch from VLAs in VariableAxisChangeEffective() to WTF::Vector (as is used in the rest of the file) as VLAs are not allowed in Chromium nor Blink, and use #include as the style is to use #import for Objective-C headers. Bug: 1101448 Change-Id: I6043b53b9ac07cdddd082a19abf7bc8cbe3af58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351299 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Victor Hugo Vianna Silva authored
Turns out it's easier to record when the move flow is offered rather than when it's refused/ignored. For non-opted-in users these things are basically the same, since accepting the move bubble prompts an opt-in. No behavior is changed, the counter still isn't incremented. Bug: 1082152 Change-Id: I379e137d8c24e02625d569d9b65ddd715050ae58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352229Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL adds the remove button shown on the profile picker main view functionality. Bug: 1063856 Change-Id: If8733ffc50a474ccfceb5ee0a11c540752ca0676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346810 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797226}
-
Michael Ershov authored
Add separate unit tests for TpmChallengeKeySubtle and TpmChallengeKeyResult. Bug: 1090723 Test: TpmChallenge* Change-Id: I267e029410539070435cacbb98409bef1c40a8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228725 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#797225}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4451adcce85..5697d3550bc8 2020-08-12 hjd@google.com Merge "trace_processor: Fix support for displayTimeUnit" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic13a2d7b91723a663a908b519f26aec088c51daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351154Reviewed-by:
-
Matt Jones authored
This patch attaches the BottomSheet to the view hierarchy immediately upon showing a new content view. This gives the new content view the opportunity to do layout before being shown. Bug: 1113857 Change-Id: I6a329782f941c088b1dbee30c30982482e228561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343315Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797223}
-
Matt Jones authored
This patch updates the theme color when the tab's content changes as the typical onThemeColorChanged event is not sent. Bug: 1115010 Change-Id: I26bad29edff317cc71d3c67437727dc6327cbd9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346978Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797222}
-
Jérôme Lebel authored
The goal of those 5 patches is to remove const on the following methods: * IsValidIdentity() * GetIdentityWithEmail() * GetIdentityWithGaiaID() * GetCanonicalizeEmailsForAllIdentities() * HasIdentities() * GetAllIdentities() * GetAllIdentitiesSortedForDisplay() This is required for crrev.com/i/3208484, to not start async identity fetch in ChromeIdentityServiceImpl instance when the cache is not populated. * crrev.com/c/2345305 Add temporary methods * crrev.com/i/3201649 Switch to the temporary methods * crrev.com/c/2345146 Remove const in the methods * crrev.com/i/3201650 Switch back the original methods => crrev.com/c/2344467 Remove temporary methods Bug: 897470 Change-Id: If54582a6b206672cc0148433a6031182233447d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344467Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797221}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c2cfd18ab8ca..17a165467087 2020-08-12 thomasanderson@chromium.org Reland "[XProto] Add SharedXDisplay::IgnoreXServerGrabs" 2020-08-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 57dbb758..e697f4f1 (796953:797077) 2020-08-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0ac7e51..57dbb758 (796807:796953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1066670 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f225a36f64177050314c9ce12929e5c5b6a727f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351152Reviewed-by:
-
Wez authored
This reverts commit bd17f198. Reason for revert: Test is flaky, especially on Fuchsia bots. Original change's description: > appcache: delete appcache directory from profile when disabled > > Once AppCache has been removed from Chrome, sites will have no way of > cleaning up user data in local profiles. To fix this, when a storage > partition is accessed when AppCache has been disabled, we will delete > the AppCache directory from that profile directory. > > Bug: 1081897 > Change-Id: Iea404f7c83595ba1397fab4a5d3f97d1e3280916 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343588 > Commit-Queue: enne <enne@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796938} TBR=kinuko@chromium.org,mek@chromium.org,enne@chromium.org Change-Id: Ic43fce0f9ad605a7bfb3a291a320e45d8c329b9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1081897, 1115296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351834Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797219}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f28c31d179b8..3e586480ca0f 2020-08-12 nidhijaju@google.com Display link in Application Panel for pages with no Service Workers 2020-08-12 iclelland@chromium.org Don't abort copying multiple files when one matches 2020-08-12 szuend@chromium.org [ts] Type-check ui/ForwardInputEventHandler.js with TypeScript 2020-08-12 nidhijaju@google.com Remove the Service Worker from appearing if origin changes in DevTools 2020-08-12 szuend@chromium.org [ts] Remove @ts-nocheck in 'ui' files where its not needed 2020-08-12 nidhijaju@google.com Reland "Adding a link to SW internals page to view other origin SWs in DevTools" 2020-08-12 szuend@chromium.org [ts] Type-check ui/Context.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1115386,chromium:1115410,chromium:807440 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b88f0d5f01d5ccd584d6c4c2909aea821635898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352209Reviewed-by:
-
Alessio Bazzica authored
Bug: webrtc:7494 Change-Id: Ib75768a7fdc7c2c803b717f3f3c83ba8de45a74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351993Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#797217}
-
Bo Majewski authored
Exposes stretch_to_bounds parameter in the PDF to bitmap conversion, which allows thumbnails generated at low DPIs to be stretched to fill the supplied width and height. Exposes keep_aspect parameter to allow scaled up thumbnails preserve the original aspect ratio. As PDF is often in Letter or A4 format this helps with more natural looking thumbnails. Exposes dpi parameters that allow us to specify the resolution of the generated thumbnail. Bug: 903742 Change-Id: I9e526707f18c3d5fed84c32873d8c44573170e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336335Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797216}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia97e084750079d7d24ed46dd435eb1147eb3808f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351153Reviewed-by:
-
Yi Gu authored
We no longer report after crrev.com/c/2097041. This patch resumes the reporting logic. Bug: 1107590 Change-Id: I9dd8d30a91f48077694a6a3d054f36aa9b259868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350093Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797214}
-
Mason Freed authored
I have run into this twice myself, and I always end up reading the comments next to VLOG() to remind myself what I'm missing. They don't clue you in to the fact that VLOG() statements require enable-logging=stderr or they won't be seen. Change-Id: I8d00da46bf1555e0d6f5728cdc258f1ce36e3d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346927 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#797213}
-
David Bienvenu authored
Miscellaneous cleanup, no functional changes. Change-Id: I45b63c7f9a71e9166ed0178f119aeb1a9f7311e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350839 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797212}
-
Stepan Khapugin authored
Adds support for scribble in fakebox. For this, an indirect scribble interaction is added to the fakebox. This interaction delays focusing, which allows users to write without the fakebox jumping away. Then it forwards the scribble events to the omnibox. Adds a ton of plumbing to connect the fakebox and the omnibox. Bug: 1098342 Change-Id: I3a5783218b5a25dc8146f53252e50348ac1886d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340978 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Aaron Tagliaboschi authored
Bug: 955620 Change-Id: I2572a1b33f0ea6371b65f9e74fab0fe182e11244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351548Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#797210}
-
Sahel Sharify authored
This cl throws a range error when extra payment methods are specified along with "secure-payment-confirmation". Change-Id: I68b321a123fb9df8d61f733f1c6e81f024e21d61 Bug: 1110320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340670Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797209}
-
Gauthier Ambard authored
This CL removes/rename/reorder methods of the TabGridCoordinator. Bug: none Change-Id: I2358a26519604d71657f5411ea5e45ec49f43a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346272 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797208}
-
Gauthier Ambard authored
The protocol was here for compatibility reason with the old TabSwitcher. This CL removes it and moves its methods in the TabGridCoordinator and rename its methods. It also renames its delegate to TabGridCoordinatorDelegate. It removes the parameter id<TabSwitcher> when it is no longer necessary. It removes the reference to ViewControllerSwapping. Bug: none Change-Id: I4d4504d51f0c7560a13296613dfd72ba68aa116c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Harald Alvestrand authored
This adapts Chromium to the changes introduced by https://webrtc-review.googlesource.com/c/src/+/180580, and exposes the stop() method behind a flag. Intent to implement and ship thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/dAeG7K7HPG8 Bug: chromium:980879 Change-Id: Iea33c0b915b5ee6ce5cab10ce98f9b906d7d9e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344605 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
