GitLab

In our current implementation, we ask touch action filter to process
a gesture event first and then check whether the event should be queued
or not. For FlingStart and FlingCancel we never queue them even if the
touch action filter says that they are allowed. As a result, FlingStart
gesture will always sent to touch action filter and that's causing
some bugs.

This CL fixes it by re-ordering how we process a gesture event. We apply
three different filters in the following order:
1-The fling controller decides to either filter the event or forward it.
The filtering happens either when the controller processes the GSF/GFC
events or when it suppresses GSB/GSU events during fling boosting.

2- If the event is not filtered by the fling controller, the touch action
filter checks to filter the touchscreen gesture scroll events, with this
change this filter doesn't receive GFS events anymore since they are
already filtered by the fling controller.

3- If a gesture event is not filtered by any of the two filters above,
the gesture_event_queue chooses to either add the event to the event
queue to be sent to the renderer or filter the event and add it to
debouncing_deferral_queue_.

Bug: 838616
Change-Id: I0e363d2fff12fdf5f91c51d42c3752355bb7cccd
Reviewed-on: https://chromium-review.googlesource.com/1075554Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562831}

The class only needs to trigger a memory dump for light heap profiling to work.

Bug: 822843
Change-Id: I2da1cda226458f6b8b642f045f8142d561fc3ea8
Reviewed-on: https://chromium-review.googlesource.com/1076495Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562830}

This CL adds the assets for the actions of the popup menu associated
with the Search button.

Bug: 845491
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie793e1a666d72277c519b4f349f6b5416704e65b
Reviewed-on: https://chromium-review.googlesource.com/1078736
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562829}

Removes shadows around refresh artwork, and all the necessary pixel tweakage.

screenshot: https://screenshot.googleplex.com/pawpDoFFzVY

Bug: 844006
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I760902a0820b0426d75d571163cdc2ab7c7782a4
Reviewed-on: https://chromium-review.googlesource.com/1078912Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562828}

This CL adds the Request {Desktop|Mobile} Site and Find in Page actions
to the Share Menu.

Bug: 845497
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6d54ed7f723c262608c0144ec1686f317a5d376c
Reviewed-on: https://chromium-review.googlesource.com/1075090Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562827}

In QUIC, close connection if received a new ack while processing an ack frame. Protected by ENABLED quic_reloadable_flag_quic_use_incremental_ack_processing4.

Merge internal change: 198394989

R=rch@chromium.org

Bug: 844257
Change-Id: I45966ad7bf4d29b8df643409c4af3d8095554662
Reviewed-on: https://chromium-review.googlesource.com/1076591Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562826}

This CL removes the additional top/bottom separator
of the accounts submenu on Mac.

Bug: 846803
Change-Id: I7331c010a8734f62cac8bf48d19bb9854f0a0492
Reviewed-on: https://chromium-review.googlesource.com/1078752Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562825}

These tests are flaky on Mac, especially in Views mode.

Bug: 845979
Change-Id: Idb2125c8ce24595e501df8544609f0c6e6dd8957
Reviewed-on: https://chromium-review.googlesource.com/1070338Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562824}

To follow the mocks specifications, the checkmark needs to have 26px
to the trailing edge. To be able to use the UITableViewCell checkmark
with the correct margin, the cell layout margin is used to work around
this issue.

Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g34c64dbe85_0_0

Screenshot:
https://drive.google.com/open?id=1Guhu3UWjmP3h_YhHY40cUdyAeqWIkSVV

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4da23ffc5decdb5ef17b983a39723470eb9cab9e
Reviewed-on: https://chromium-review.googlesource.com/1078439
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562823}

Bug: None
Change-Id: I87e78e3ac9403f9af6a072edbbcd515a31d1b55e
Reviewed-on: https://chromium-review.googlesource.com/1079041Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562822}

These metrics were used to evaluate the LazyParseCSS experiment, which
we've launched in M67. The complexity is probably not worth the value
of the metrics for just monitoring.

Bug: None
Change-Id: I1145a1363a63fa70c6d33f5b8b8371b308defde7
Reviewed-on: https://chromium-review.googlesource.com/1077058Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562821}

Adjusts the share button size to match mocks.

Bug: 829397
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6807c123a2861522442e915b4cc687d1f98c7502
Reviewed-on: https://chromium-review.googlesource.com/1078749Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562820}

Make FilterActivityPeriodsByUsers() method use preference name that ActivityStorage was initialized with.

This is a follow up for:
https://chromium-review.googlesource.com/c/chromium/src/+/1056264.

Bug: 837001
Change-Id: Iae481736122b62216514c8bb5125273ed97e443e
Reviewed-on: https://chromium-review.googlesource.com/1077754Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562819}

crrev.com/c/1056165 moved setting |PLANE_CTM| properties trough
HardwareDisplayPlane.

Since we used to skip adding the cursor to
HardwareDisplayPlaneManager::planes_, after that CL we stopped applying
color correction to the cursor.

This CL makes sure we always add the cursor to the list of planes, so
that color correction will be applied correctly to the cursor.

It also makes sure we don't assign the cursor to an HW overlay.

Bug: 839487
Test: Ran unitests
Change-Id: If8a29e3517d5ead7b8a5edadf6446f910c26176f
Reviewed-on: https://chromium-review.googlesource.com/1077827Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562818}

ContentSettingsService handles incognito mode requests internally, so
a flag is set to redirect incognito mode requests to the original
profile.
Also, in Set Content Settings API, incorrect use of include_incognito()
function instead of IsIncognitoEnabled() is corrected.
Two tests are added to check that all settings written in incognito
are applied and do not affect regular mode, and incognito settings
cannot be modified from regular mode.

Bug: 832697
Bug: 845845
Change-Id: I6d65f824e3e3ca2fbd218ed0bf5af1ddc15c87ef
Reviewed-on: https://chromium-review.googlesource.com/1061853
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561811}
Reviewed-on: https://chromium-review.googlesource.com/1074651
Cr-Commit-Position: refs/heads/master@{#562817}

Skia's sk_sp class is moving from operator pointer to field to
explicit operator bool. As a result a few uses need to be updated.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1b120d972ea88452b36093745b897445444ab745
Reviewed-on: https://chromium-review.googlesource.com/1075609Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@google.com>
Cr-Commit-Position: refs/heads/master@{#562816}

This typo needs to be fixed, because it fails google3 presubmit
checks, when policy definitions are synced to google3.

Change-Id: I15b26347984b98417600cafd4cdd5f80044e54b5
Reviewed-on: https://chromium-review.googlesource.com/1077663Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562815}

Add ConsentSyncBridge (interface and implementation) without actually
wiring it to the ConsentAuditor. The bridge itself is heavily based on
UserEventSyncBridge, but the user event related bits were removed. Also
I've tried to make tests easier to understand.

This is the first change in a series to split user consents from user
events into a separate datatype.

Bug: 840357
Change-Id: Ief8d178d5aaf4b3bc3be68eb4580c811e8c50bb0
Reviewed-on: https://chromium-review.googlesource.com/1076248Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562814}

This is a follow-up to https://chromium-review.googlesource.com/1068528.

Change-Id: Icec51b2b2c01812385b51d688888410904c7e65b
Reviewed-on: https://chromium-review.googlesource.com/1078728Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562813}

This is removing `PlaybackStateChanged()` from WebMediaPlayerClient and
instead adds `RequestPlay()` and `RequestPause()`. HTMLMediaElement will
notify the WebMediaPlayer when it states changes and there is no need
for the WebMediaPlayer to change its internal state and then notifies
the HTMLMediaEelement that things have changed. Indeed, it breaks some
assumptions that the HTMLMediaElement has.

The change also replaces some cast-related calls that are a by-product
of this design change.

Bug: 846490
Change-Id: Ibd60f571787e5f3a0d8a5ddfdbf4a35a2e53081e
Reviewed-on: https://chromium-review.googlesource.com/1074807Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562812}

There are public platform support and invitation APIs available in Mojo
now, and they should be used exclusively in lieu of the old EDK APIs
where possible.

This converts most uses of the old APIs to the new ones.

Note that there should be no functional difference in any of these
components, and this does not change the underlying behavior of the
system, e.g. internal IPC protocol is unchanged.

Bug: 844763
Change-Id: I878f103041758d130c34bde046fa054b984feb8c
Reviewed-on: https://chromium-review.googlesource.com/1070882Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562811}

Bug: 843927
Change-Id: I7a4c7912ae535ce9afa2a2a0df433eea185a9cfd
Reviewed-on: https://chromium-review.googlesource.com/1078407Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562810}

The array represents all versions the RP supports.

Bug: 840153
Change-Id: I150e80d2e9d5149fac39400eca69d680cc86307a
Reviewed-on: https://chromium-review.googlesource.com/1060273Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562809}

Change-Id: Ie1025b480409650263c1592f28593b555e62e015
Reviewed-on: https://chromium-review.googlesource.com/1076410Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562808}

It is unused.

Change-Id: Iff3a02c0a9fb1386ea77ca9da61ffdfa8b57a297
Reviewed-on: https://chromium-review.googlesource.com/1076985Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562807}

As part of the effort to bring the new Network Service online, we are
deprecating URLFetcher in favor of SimpleURLLoader.

Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit
Previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1070110
Reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1073656

Refactoring exposed an underlying bug in the existing code (max_retries_on_5xx_ could
be used before being initialized). This CL initializes it to 0 in the constructor.

Bug: 844937
Change-Id: I419565dc899b2b48118b351206ade4f15090836a
TBR: groby@chromium.org, charleszhao@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1076407
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562806}

https://skia.googlesource.com/skia.git/+log/16f558d..21ca043


git log 16f558d..21ca043 --date=short --no-merges --format='%ad %ae %s'
2018-05-29 robertphillips@google.com Allow CCPR in DDL1 images (since DDL itself now supports CCPR)
2018-05-29 robertphillips@google.com Add DDL to SKPBench

Created with:
  gclient setdep -r src/third_party/skia@21ca043

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=rmistry@chromium.org

Change-Id: Ie2cfa85e724c3d2ac9d83384c2cc0ede2868cc6c
Reviewed-on: https://chromium-review.googlesource.com/1078630
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562805}

https://chromium.googlesource.com/angle/angle.git/+log/0ed2aa2..c518170


git log 0ed2aa2..c518170 --date=short --no-merges --format='%ad %ae %s'
2018-05-17 lucferron@chromium.org Vulkan: generateMipmaps for 2D textures

Created with:
  gclient setdep -r src/third_party/angle@c518170

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=jmadill@chromium.org

Change-Id: I1d18e49045724226eef319ff0d2eeac08150dd0b
Reviewed-on: https://chromium-review.googlesource.com/1078629
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562804}

Following bot results are included.
5964 5973 5975 5977

No deflakes detected in the last 12 try jobs.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia61d0aa4873a5bf00c97874a2cdc9a47fef94d71
Reviewed-on: https://chromium-review.googlesource.com/1078088
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562803}

The issue was fixed by VS 2017 15.7.1 with 10.0.17134.0 SDK
https://developercommunity.visualstudio.com/content/problem/131391/154-fails-to-define-deprecatedenumerator-2.html

Bug: 773476
Change-Id: Ib90e99e9b3d69907aaaa994df92f7debd65105b3
Reviewed-on: https://chromium-review.googlesource.com/1078213
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562802}

NOTRY=true  # test covered by PRESUBMIT
TBR=eyaich@chromium.org

Bug: 846710
Change-Id: I7048aa075f46755a308db36917b05d86aadcd3ab
Reviewed-on: https://chromium-review.googlesource.com/1078889Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#562801}

There are 545 tests with names matching *WebSocket* (camel case), and
only five matching *Websocket*.  This CL renames those five to match the
capitalization of the majority.

Change-Id: Id366ccdd9625e361d12b8359a48dcd7a29cf38ea
Reviewed-on: https://chromium-review.googlesource.com/1076411Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562800}

Using wpt-import in Chromium 3a3b9cc3.
With Chromium commits locally applied on WPT:
d78c1e54 "[Resource-Timing] Fix `initiatorType` values"
6534acd9 "[css-grid] Baseline alignment inside the tracks sizing algorithm"
379eafdb "[LayoutNG] Need to pre-layout legacy orthogonal writing mode roots."
69a85361 "[css-grid] Disable paint containment for ruby-text elements"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18927

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I3e3fc3d89e6733306bc9143121c8433bc705441a
Reviewed-on: https://chromium-review.googlesource.com/1078567
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562799}

In the Payment Request sheet, icons should show as square and not squashed.

Bug: 845929
Change-Id: I619f015d12e98d7cf8125a6cb8c99566e40f1d63
Reviewed-on: https://chromium-review.googlesource.com/1077450Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562798}

This fix changes NetworkQualityObserverImpl logic so it does not send
messages about network quality to renderers that are not connected -
because they crashed, were discarded or by any other reason. This is
done to lessen impact of memory leaks due to unbounded mojo message
queuing described in details in linked issue.

Bug: 813045
Change-Id: Idf5a470262e887d6559752ae1c0cfec168015f42
Reviewed-on: https://chromium-review.googlesource.com/1076148
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562797}

This CL deletes the copy constructor and the copy assignment operator from the
ppapi::proxy::SerializedHandle class replacing them with move operations. This
is preparatory step to make SerializedHandle using the new shared memory
classes that are move-only.

SerializedHandle holds a system resource that should be properly closed after
use. Move semantics allow to introduce the more clear ownership model and
prevent resource leaks.

Bug: 845985
Change-Id: Ie7202d18f4f0396133c53ee0faee111e07c58ee8
Reviewed-on: https://chromium-review.googlesource.com/1073200Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562796}

PrimaryAccountAccessTokenFetcher currently has the following flow:
- wait for user to sign in
- wait for primary account refresh token to become available
- if during that waiting refresh tokens are loaded, fail (by making an
  access token request that will be guaranteed to fail)

The third step above leads to inconsistency:

Assume that a user is signed in but their token is not available on
disk (e.g., it's been corrupted). If a PrimaryAccountAccessTokenFetcher
is created *before* the tokens are loaded from disk, that fetcher will
return an error to its client once tokens are loaded. If a
PrimaryAccountAccessTokenFetcher is created after the tokens are loaded,
that fetcher will wait until the refresh token actually becomes
available (e.g., via a reauth). It will potentially wait forever.

There seems no reason to have the distinction of whether a
PrimaryAccountAccessTokenFetcher was created before or after tokens were
loaded from disk result in behavioral differences that are visible to
clients of PrimaryAccountAccessTokenFetcher.

Note that by definition this change can result in behavioral changes for
the cases where PrimaryAccountAccessTokenFetchers are created before
tokens are loaded from disk. However, as clients of
PrimaryAccountAccessTokenFetcher do not query whether tokens have been
loaded from disk or not, any such resulting behaviors are already
possible in the existing codebase (in the case where the fetchers
happen to be created after tokens were loaded from disk, i.e., any time
after startup).

From treib@chromium.org, the original author of this code:

"I've been trying to remember if I had any particular reason for adding
this logic, but I think I just copied it from whatever I used as a model
for the very first AccessTokenFetcher implementation.

I completely agree with your reasoning that the distinction (based on
whether tokens were already loaded from disk or not) doesn't make sense."

Bug: 796544
Change-Id: I1bf855663ddee961ca68886500b92943df274f06
Reviewed-on: https://chromium-review.googlesource.com/1076289
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562795}

This CL adds UnifiedSliderBubbleController, which implements slider
bubbles e.g. volume slider and brightness slider triggered by hardware
buttons.

In old SystemTray, the impelmentation of the bubbles were tightly
coupled with SystemTrayBubble. In terms of the feature, it's not
strongly related to system tray, so in Unified, it does not use
UnifiedSystemTrayBubble and instead has its own bubble.

TEST=manual
BUG=847730

Change-Id: I5f97ebb14efead8c3613ea7c4dfe6bb9760a1079
Reviewed-on: https://chromium-review.googlesource.com/1078032
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562794}

This patch introduces |ReattachLegacyLayoutObjectList| class to patch NG layout
tree to replaces LayoutNG objects to have legacy layout objects when assocaited
elements return true for |Element::ShouldForeceLegacy()|.

|Element::RebuildLayoutTree()| does this replacment in following two DOM tree
traversals:
 1. Collection phase: collects layout objects establish block formatting context
containg elements return true for |Element::ShouldForeceLegacy()|. After
treversing DOM tree, marks descendante elements in collected block foramtting
context to |NeedsReattachLayoutTree|.
 2. Patch phase: Attaches legacy layout object for makred elements which were
LayoutNG objects.

See https://goo.gl/8s5h96 for details.

This patch also gets rid of following work arounds:
 - Change to inline-block for inline editable in |StyleAdjuster|.
 - Consider editable |LayotBlockFlow| to establish block formatting context.

New Failed tests:
* fast/block/child-not-removed-from-parent-lineboxes-crash.html
This tests hits DCHECK in IsEmpty() in NGBlockLayoutAlgorithm::HandleInflow()
for DETAIL with "position:absolute".
* virtual/layout_ng_experimental/css3/flexbox/position-absolute-child-with-contenteditable.html

# Background
we have a few cases where we want to switch to old layout; forms,
contenteditable, and a few others.

A constraint we have here is that we can't collapse margins across engine
boundary, and that all engine boundaries must create BFC. We somehow managed to
force a BFC on forms (which strictly speaking is not the right thing to do for
e.g., <legend>), but when we come to contenteditable, we can't force BFC there
because it breaks layout too much.

So the idea is, when we hit an element/box that needs to switch the layout
engine, we look for its closest ancestor that creates a BFC, and switch the
layout engine there, making sure the old layout handles all its subtree.

Following patch will use this mechanism for <ruby> too. When we find a ruby, we
can't run old layout only for ruby; needs to run old layout for its container
block. But then if the container block has margin collapsing, we need to switch
at the closest BFC boundary


Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0769eab10f0dccf8aa00fc9e02aa6358f34d6a62
Reviewed-on: https://chromium-review.googlesource.com/1063891
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562793}

- Adds chrome://flags entry
- Adds a FeatureFlag
- Make existing Blink flag dependent on the Chrome flag

Bug: chromium:757440, chromium:847735
Change-Id: Iccb63fc31b330a6bb69e95d5c0d7599cce10e2ee
Reviewed-on: https://chromium-review.googlesource.com/1077870Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562792}