GitLab

BUG=642519

Review-Url: https://codereview.chromium.org/2369013008
Cr-Commit-Position: refs/heads/master@{#422952}

This test was disabled in https://crrev.com/242483 to fix the crash
documented in https://crbug.com/342525

BUG=342525

Review-Url: https://codereview.chromium.org/2370703004
Cr-Commit-Position: refs/heads/master@{#422951}

BUG=589709

Review-Url: https://codereview.chromium.org/2389973005
Cr-Commit-Position: refs/heads/master@{#422950}

https://chromium.googlesource.com/skia.git/+log/3fdf52cf389d..511f2d79bf6e

$ git log 3fdf52cf3..511f2d79b --date=short --no-merges --format='%ad %ae %s'
2016-10-04 mtklein Make global use-analytic-AA bit threadsafe.
2016-10-04 reed Revert[4] "replace SkXfermode obj with SkBlendMode enum in paints"
2016-10-04 caryclark disallow -4 pointer
2016-10-04 mtklein Revert of skpbench: add option for gpu timing (patchset #7 id:120001 of https://codereview.chromium.org/2388433003/ )
2016-10-04 borenet Add --test to gen_tasks.go, add presubmit check
2016-10-04 csmartdalton skpbench: add option for gpu timing
2016-10-04 reed ensure we always set the pictinfo.fVersion
2016-10-04 borenet Make binary size analysis upload to skia-perf bucket
2016-10-04 caryclark run dean4 test everywhere
2016-10-04 mtklein Debug Mac test failure.
2016-10-04 benjaminwagner Remove SkFontConfigInterface_direct_google3.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/2390403002
Cr-Commit-Position: refs/heads/master@{#422949}

It contained a lot of unnecessary things.

BUG=

Review-Url: https://codereview.chromium.org/2386393002
Cr-Commit-Position: refs/heads/master@{#422948}

Commit 667f0577 created a regression
in gamepad API functionality on Android by removing the assignment
that sets the gamepad.connected value. This CL adds the missing
assignment back.

BUG=644162

Review-Url: https://codereview.chromium.org/2350573002
Cr-Commit-Position: refs/heads/master@{#422947}

BUG=643449

Review-Url: https://codereview.chromium.org/2365973003
Cr-Commit-Position: refs/heads/master@{#422946}

Rather than showing the infobar, just refresh the page. The user would usually
arrive in this situation because they've clicked a link to obtain flash, so
refreshing the page shouldn't be problematic.

BUG=641615,652479

Review-Url: https://codereview.chromium.org/2390193002
Cr-Commit-Position: refs/heads/master@{#422945}

Sometimes we get events on nodes in the internal accessibility tree that
are not exposed on that platform or under all circumstances. On Android
that led to an issue where after closing a SELECT pop-up, we got a focus
event on the OPTION and subsequent navigation was trapped inside that
control rather than outside it.

The fix is to map the focus event to the topmost leaf ancestor, which
in this case would be the SELECT element.

BUG=652805

Review-Url: https://codereview.chromium.org/2397503002
Cr-Commit-Position: refs/heads/master@{#422944}

BUG=640549

Review-Url: https://codereview.chromium.org/2389263002
Cr-Commit-Position: refs/heads/master@{#422943}

This extracts the color information from the h264 stream and attaches
it to the video frame. Currently this is only done if the result is
NV12 as we don't have the code yet to do it for RGB frames.

BUG=622133, 647725

Review-Url: https://codereview.chromium.org/2345123002
Cr-Commit-Position: refs/heads/master@{#422942}

We should remove words from index if this is the last word only.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2385273004
Cr-Commit-Position: refs/heads/master@{#422941}

Vr Shell was disabled in release build regardless if enable_vr_shell is set
or not. The reason was proguard obfuscated the name we use in VrShellDelegate
This adds rules to prevent obfuscation.

BUG=652340

Review-Url: https://codereview.chromium.org/2385113003
Cr-Commit-Position: refs/heads/master@{#422940}

BUG=650846,650848

Review-Url: https://codereview.chromium.org/2390103003
Cr-Commit-Position: refs/heads/master@{#422939}

setup.exe --delete-old-versions repetitively attempts to delete all
files that belong to old versions of Chrome. It exits when no files
that belong to an old version of Chrome remain or when another process
tries to acquire the SetupSingleton.

setup.exe --delete-old-versions is launched in two occasions:
- When the installer fails to delete old files after a not-in-use
  update.
- When executables are successfully renamed on Chrome startup or
  shutdown.

BUG=451546

Review-Url: https://codereview.chromium.org/2333853002
Cr-Commit-Position: refs/heads/master@{#422938}

BUG=563793
R=ikilpatrick@chromium.org

Review URL: https://codereview.chromium.org/2391893004 .

Cr-Commit-Position: refs/heads/master@{#422937}

BUG=none
R=einbinder, dgozman

Review-Url: https://codereview.chromium.org/2387003004
Cr-Commit-Position: refs/heads/master@{#422936}

Only used by SVGAnimateElement.

BUG=641437

Review-Url: https://codereview.chromium.org/2394583002
Cr-Commit-Position: refs/heads/master@{#422935}

BUG=

Review-Url: https://codereview.chromium.org/2389073003
Cr-Commit-Position: refs/heads/master@{#422934}

ClientOnPageFinishedTest#testCalledAfterError is flaky.

BUG=652577

Review-Url: https://codereview.chromium.org/2397533002
Cr-Commit-Position: refs/heads/master@{#422933}

Also default 'false' for shouldAggregateLogForTapSuppression and isConditionSatisfiedForAggregateLogging

BUG=642897

Review-Url: https://codereview.chromium.org/2386413002
Cr-Commit-Position: refs/heads/master@{#422932}

BUG=

Review-Url: https://codereview.chromium.org/2393533002
Cr-Commit-Position: refs/heads/master@{#422931}

Records false if we haven't received a swap ack for more
than 8 seconds. Otherwise, records true.

BUG=602486
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2258253002
Cr-Commit-Position: refs/heads/master@{#422930}

The decoder blithely passed any old 16-bit code unit through, in
violation of the Encoding standard. Surrogate pairs should go through
unscathed:

  [ ... 0xD800 0xDC00 ... ] => [ ... U+D800 U+DC00 ... ]

But cases like these should result in replacement characters:

  [ ... 0xD800 ... ] => [ ... U+FFFD ... ]
  [ ... 0xDC00 ... ] => [ ... U+FFFD ... ]
  [ ... 0xDC00 0xD800 ... ] => [ ... U+FFFD U+FFFD ... ]

This aligns Chrome's behavior with Firefox and Edge.

Note that flushing at the end of a stream remains a special case.
Streams terminating in the above sequences will not get replacements
emitted (current behavior). In addition, a lead surrogate appearing at
the end of a stream will now not be emitted, matching other browsers.

BUG=368904
R=jshin@chromium.org,foolip@chromium.org

Review-Url: https://codereview.chromium.org/2379333003
Cr-Commit-Position: refs/heads/master@{#422929}

BUG=none

Review-Url: https://codereview.chromium.org/2385793003
Cr-Commit-Position: refs/heads/master@{#422928}

This CL implements OffscreenCanvas2d's commit API in the case where the
canvas is not GPU-accelerated, but the compositor is. In this case, we
extract a StaticBitmapImage from the imageBuffer, upload the CPU memory
that the StaticBitmapImage holds to GPU texture, and prepare a
CompositorFrame from the GPU texture.

A GPU pixel test is added to test this code path.

BUG=563852
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2376743002
Cr-Commit-Position: refs/heads/master@{#422927}

This adds functionality to clear the previews black list on the IO
thread and the UI thread. Further this exposes other black list calls on
the UI thread.

BUG=639087

Review-Url: https://codereview.chromium.org/2387823002
Cr-Commit-Position: refs/heads/master@{#422926}

The traits impl was depending on the wrong generator target,
leading to potential build flag.

BUG=652779
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2392903003
Cr-Commit-Position: refs/heads/master@{#422925}

Review-Url: https://codereview.chromium.org/2391593003
Cr-Commit-Position: refs/heads/master@{#422924}

This creates a LayoutNG virtual test suite for fast/block/margin-collapse path and switches to use "Skip" instead of "Failure" to mark tests that LayoutNG doesn't support at this moment.

BUG=635619

Review-Url: https://codereview.chromium.org/2396583002
Cr-Commit-Position: refs/heads/master@{#422923}

If onAllDownloadItemsRetrieved() has already been called, return
early rather than repopulating lists.

BUG=652650

Review-Url: https://codereview.chromium.org/2391053002
Cr-Commit-Position: refs/heads/master@{#422922}

BUG=649815

Review-Url: https://codereview.chromium.org/2383243002
Cr-Commit-Position: refs/heads/master@{#422921}

BUG=563793

Review-Url: https://codereview.chromium.org/2389253002
Cr-Commit-Position: refs/heads/master@{#422920}

TESTS=chrome_elf_unittests: NtRegistryTest*
BUG=641169
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2345913003
Cr-Commit-Position: refs/heads/master@{#422919}

BUG=650710

Review-Url: https://codereview.chromium.org/2389113003
Cr-Commit-Position: refs/heads/master@{#422918}

Previously we used containingBlock() as the default flipped blocks
container in LayoutBox::topLeftLocation(). This was incorrect for
table rows and table cells whose locations and topLeftLocations
should be relative to the containing section.

This fixes layout tests about table row/cells in vertical writing
mode for slimmingPaintInvalidation.

BUG=652392

Review-Url: https://codereview.chromium.org/2392503003
Cr-Commit-Position: refs/heads/master@{#422917}

BUG=635596

Review-Url: https://codereview.chromium.org/2390863002
Cr-Commit-Position: refs/heads/master@{#422916}

Key point of the implementation:
  * We want to apply 2 commands but only push 1 undo entry.

Solution:
  1. Introduce empty wrapper command |DragAndDropCommand| and
     apply first
  2. Apply |DeleteSelectionCommand| for |deleteByDrag|
  3. Apply |ReplaceSelectionCommand| for |insertFromDrop|

The wrapper command in 1. won't create undo entry by itself, but will
act as a catcher and combine the following 2 commands into a single
undo entry.

--- After CL behavior

* Event order: (See [1])
  1. 'drop'
  2. 'beforeinput' InputType=|deleteByDrag|
  3. (DOM update for deletion)
  4. 'input' InputType=|deleteByDrag|
  5. 'beforeinput' InputType=|insertFromDrop|
  6. (DOM update for insertion)
  7. 'input' InputType=|insertFromDrop|
  8. 'dragend'

* Canceling 'beforeinput' will only prevent DOM update for current
  'beforeinput', and won't affect remaining events.
e.g. Cancelling 'deleteByDrag' won't affect 'insertFromDrop'

* |dataTransfer| field:
  1. NULL for |deleteByDrag|
  2. Readonly |dataTransfer| for |insertFromDrop|

* Undo entry:
  1. Creates a single undo entry for Drag&Drop, if no JS-triggered DOM mutation happened in between
  2. Otherwise creates 2 separate undo entries

For more detailed behavior please refer to LayoutTest.

[1] Event order for |deleteByDrag| and |insertFromDrop|:
https://github.com/w3c/input-events/issues/24#issuecomment-249153755

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

BUG=652393

Review-Url: https://codereview.chromium.org/2374743002
Cr-Commit-Position: refs/heads/master@{#422915}

There's a race between page resize and devtools emulation disabling
which can change the root layer transform scale.  If a commit occurs
after the page resize but before the scale, then layers end up picking
the wrong scale, and if they have will-change on them then they will
not change again after the root layer transform scale.

This scale isn't really part of the page or under the author's control,
and so will-change should be ignored when devtools changes the scale
and content should always be rerastered and the ideal scale.

This patch implements that behavior by plumbing a flag all the way from
the devtools scale change to LayerTreeHost which then then resets the
raster scale on all the picture layers after commit.

BUG=630979
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2390923002
Cr-Commit-Position: refs/heads/master@{#422914}

Follow-up to post-vommit comment in:
https://codereview.chromium.org/2388293002/

TBR=senorblanco@chromium.org
BUG=652126

Review-Url: https://codereview.chromium.org/2393493003
Cr-Commit-Position: refs/heads/master@{#422913}