GitLab

This CL creates a simple grid view controller.
It also adds an entry in showcase.

Partly to avoid name collision, we name the single grid
as a GridViewController. The parent tab switcher with multiple
panels and other controls is called the TabGridViewController.

Bug: 804496
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib5b06befc35408958b8613a776f2c93742137bc7
Reviewed-on: https://chromium-review.googlesource.com/920641
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537213}

Add plumbing to check if a content setting bubble is showing.
Use that to test for bubble presence, not GetAllWidgets.
See http://crrev.com/c/922268 for GetAllWidgets changes.

Bug: 811940
Change-Id: I5b8e36c5dcddb8dfd407ad0f889ad74fb9804273
Reviewed-on: https://chromium-review.googlesource.com/919922Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537212}

This upgrades --interactive to a test-launcher-scope switch (necessarily
renaming it to --test-launcher-interactive) and treats it as a timeout
specifier.  For browser UI tests on Windows, this means the parent process will
now get an (effectively) unlimited timeout and not just the child process, so
the test won't terminate early.

BUG=none
TEST=none

Change-Id: Ic94c5bff322846c2b7f69cad4b805f549dbcaa29
Reviewed-on: https://chromium-review.googlesource.com/919074
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537211}

Approved Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MAHQkH4vvUQ/i0yCobrMCQAJ

BUG=244688

Change-Id: I76f996b728bac093033f6e12d239cb3819616a91
Reviewed-on: https://chromium-review.googlesource.com/919201
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537210}

With LegacyNavigationManager, Tab calls |requirePageReconstruction|
to free the WKWebView so that it'll be recreated with the user agent of
the newest navigation item. This approach doesn't work for
WKBasedNavigationManager because deleting the WKWebView would require
reconstruction of history.

Luckily with iOS9+, WKWebView.customUserAgent can be updated on an
existing WKWebView and will cause the new header to be sent to the
server. This CL uses this mechanism to update the UA before loading
a request based on the current NavigationItem.

This alone only reloads the visible page with the new UA under
WKBasedNavigationManager because there is no URL change. So to create
a back/forward entry, the URL is reloaded using restore_session.html
with a client-side redirect.

This CL fixes RequestDesktopMobileSiteTestCase for new nav manager.

Bug: 798836
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7f23232b10a7c83db16f545cd29445a514eaa57c
Reviewed-on: https://chromium-review.googlesource.com/919175
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537209}

WebTaskRunner has became SingleThreadTaskRunner. So, the class name
WebTaskRunnerImpl does not make sense anymore.

Bug: 794845
Change-Id: Ibdb105e889febe98a1b10f96b2f4547657f3f79d
Reviewed-on: https://chromium-review.googlesource.com/920724Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537208}

Following bot results are included.
3782 3785 3787 3788 3795 3798

3 lines were removed and 9 lines were deflaked by consecutive results
since 3731.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5983d8b830015170ad8c4ee5d90be8eac0079b96
Reviewed-on: https://chromium-review.googlesource.com/920050
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537207}

Currently StylePropertyMap.set doesn't actually work with calcs.
The current way to check if something is, say, a <length> is to
check its CSSStyleValue::Type. However, this doesn't return
the right value for CSSMathValues, whose types may be quite
complicated.

The correct way is to use the CSSNumericValue matching algorthms:
CSSNumericValue::MatchesLength, which also takes into account
CSSMathValues and percent hints.

This patch changes the following to make this work:

- Removed base types from CSSStyleValue::StyleValueType. A base type
  like "length" is not really a CSSStyleValue type.
- Removed unused StyleValueTypeToString.
- Changed "Percent" to "Percentage" in CSSProperties.json5 as that's
  the correct term.
- Changed make_cssom_types to use the matching algorithms from
  CSSNumericValue.

Bug: 545318
Change-Id: I16aa71a4873e9992749f0f52ba641671d109170e
Reviewed-on: https://chromium-review.googlesource.com/901002
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537206}

This reverts commit 425707a6.

Reason for revert: ChromeDriver build bot lacks permission to
read gs://chrome-signed/ bucket.

Original change's description:
> [ChromeDriver] Automatic update Android app on waterfall
>
> On the ChromeDriver Android build bot on the waterfall, automatically
> update the Chrome app when necessary.
>
> Change-Id: I1af1bb8835c1fea63493b5f76a98923067744f13
> Reviewed-on: https://chromium-review.googlesource.com/907334
> Commit-Queue: John Chen <johnchen@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#535152}

TBR=johnchen@chromium.org,kereliuk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia2e5ff249bedb54d5356feb898c0c64495040ea1
Reviewed-on: https://chromium-review.googlesource.com/922325
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537205}

Based on initial user feedback, move the user profile name to the end,
and don't ever include it if there's only one profile.

Bug: 783479, 784676
Change-Id: I03cb9a16f5d8fd98a72afe5a4e009ef350ea3092
Reviewed-on: https://chromium-review.googlesource.com/922915
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537204}

This CL is the first step in merging the Performance and WorkerPerformance idls.
The following are the full set of steps:
1. Rename Performance.h to WindowPerformance.h.
2. Rename PerformanceBase.h to Performance.h.
3. Merge Performance.idl and WorkerPerformance.idl.

The following is roughly how it would look like after all steps are completed:
https://chromium-review.googlesource.com/c/chromium/src/+/919983

Bug: 707392
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib99ade431badca0fad9bf61dbd580f3549cbab91
Reviewed-on: https://chromium-review.googlesource.com/922927Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537203}

Bug: 812960
Change-Id: I1bb1f5db9bdc5ceb7ca73ee52ac7edc0ad5545f9
Tbr: rsleevi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/923502
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537202}

This CL extracts VaapiDecodeSurface out of VaapiVideoDecodeAccelerator
into a file on its own, because vaapi_video_decode_accelerator.cc is
quite large at 1902 lines.

It also introduces =default and adds DISALLOW_COPY_AND_ASSIGN to the
extracted class. Otherwise no new code, just moving things around.

There's also a side bonus: VaapiVideoDecodeAccelerator::VaapiDecodeSurface
uses are shortened in vaapi_video_decode_accelerator.

Test: Compile and run in simplechrome on soraka. Ran vp8, vp9
videos of crosvideo.appspot.com, verified GpuVideoDecoder engaged.

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibd7c88357b2f993a5d72e45f65dfff5d67c4194a
Reviewed-on: https://chromium-review.googlesource.com/922981
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537201}

6630558 10 bit YUV to 10 bit BGR by Frank Barchard

Bug: libyuv:777,
Change-Id: Ib8c2f19b702585785562ea8d2ed80fd497eeedb4
Reviewed-on: https://chromium-review.googlesource.com/922984Reviewed-by: Frank Barchard <fbarchard@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537200}

In patch https://chromium-review.googlesource.com/906830 we renamed cc
side animation related classes but there are some variables missing,
e.g. animation_id instead of keyframe_model_id. This should be fixed
before next patch which will rename AnimationPlayer to Animation so that
it won't conflict with the new "animation_id".

Bug: 807667
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id5a8d07a7e551fff78b746728fce3dd139bb5b21
Reviewed-on: https://chromium-review.googlesource.com/922342Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537199}

This is needed to enable the starter impl CL for decal:
https://skia-review.googlesource.com/c/skia/+/107420

Bug: skia:7638
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I00638d8f54b48e8a0b04b10c2c0a556e0c6023ae
Reviewed-on: https://chromium-review.googlesource.com/922804Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537198}

Picks up this change:

Author: James Cook <jamescook@chromium.org>
Date:   Thu Feb 15 14:30:24 2018 -0800

    checkdeps: Add "noparent" support, similar to OWNERS files

    Adding "noparent = True" to a DEPS file will cause that directory not
    to inherit rules from its parents. This is useful for a directory like
    //ash/components, where you want each component to explicitly declare
    all its dependencies and not inherit from the long list in //ash/DEPS.

    Bug: 812299
    Test: added to checkdeps_test.py

TBR=dpranke@chromium.org

Bug: 812299
Change-Id: I59d2f18780b82cc40bbba5bcfa8a623f3023bea5
Reviewed-on: https://chromium-review.googlesource.com/923389Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537197}

This was added due to TetherNotificationPresenter being a
MessageCenterObserver that modifies the message center. That was only
the case due to a misunderstanding (it should have used
NotificationDelegate) and is now fixed. No MessageCenterObserver instance
should modify the MC during iteration. The change queue made that
possible, but that just allowed abuse of MessageCenterObserver.

Bug: 795331
Change-Id: I25f94853e0c8b29f3929d7459ed3cd3bfd2ed780
Reviewed-on: https://chromium-review.googlesource.com/829983
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537196}

This CL makes CSS and structural changes to audio-track-only videos to
make the controls look like audio controls. This solves an issue where
the controls are not visible/usable on MediaDocument for audio files,
since MediaDocument uses a video tag with an audio source.

This change only applies for modern media controls.

Bug: 811377
Change-Id: Ic73f65585c19047dec1d5904b50c7c4be496c5f5
Reviewed-on: https://chromium-review.googlesource.com/917610
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537195}

Probably, this CL doesn't change behavior.
Either of the elements is <span>, another is one of an element for
which IsElementForRemoveFormatCommand() returns true. So, there should
be no differences between CloneDataFromElement() and
CloneAttributesFromElement().

Change-Id: Ia95e156411fef3decded414e1c08c5c99497a063
Reviewed-on: https://chromium-review.googlesource.com/920966Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537194}

We are down to one waterfall json generated by this file so we should
have easier to read code.

Bug: 781312
Change-Id: I9e3c770691362690c5967947001ebf219844ca8c
Reviewed-on: https://chromium-review.googlesource.com/923282
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#537193}

Bug: 812432
Change-Id: If94615836edd6413b211acc323c6d8644ffcbda3
Reviewed-on: https://chromium-review.googlesource.com/920326
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537192}

Remove existing single OS enabled_features from BUILD files.

Update existing flags to match GN-style names where needed.

Change-Id: I052c1b25d2ee79194fe82132df59fd95cce88598
Reviewed-on: https://chromium-review.googlesource.com/920561Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537191}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I1530eca57ad6000ec87eff1160d31c9e9515043b
Reviewed-on: https://chromium-review.googlesource.com/923581Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537190}

Specifically if it had a valid card number and/or expiration date.

Change-Id: I8303aaa6658ee233864ff7ec52f23538280a3beb
Reviewed-on: https://chromium-review.googlesource.com/890080
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#537189}

Bug: 812581
Change-Id: Idb9ff4831263c31b21292342804bd6633f993878
Reviewed-on: https://chromium-review.googlesource.com/923412Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537188}

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T-OkMDASYfk

Bug: 740886
Change-Id: I494bc350b5a7eaa2d3f46e4fa948ef1c3b014d37
Reviewed-on: https://chromium-review.googlesource.com/923221Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537187}

Covers widget dialog title sentence case for
bookmark_component_strings.grdp.

TBR=blundell@chromium.org

Bug: chromium:810111
Change-Id: I7e0fda476aaaf43d7906a50e302fd4ccc9227142
Reviewed-on: https://chromium-review.googlesource.com/917424Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537186}

This CL
* Adds a new flag --enable-ash-new-system-menu.
  We already have --enable-ash-sidebar flag, but we are going to do
  system menu restyling and system menu & notification center
  integration separately.

  Alternative considered: Instead of adding a new flag, we considered
  using FeatureVariation in about_flags.cc, but it seems no one in ash/
  is using this, and the primary use case of FeatureVariation looks
  different from this.

* Changes background and icon colors of system menu.
  These views are still subject to change, or will be even removed,
  as they are still largely different from the spec.

Spec: http://shortn/_1MHrIdbuHM
Design doc: go/cros-qs-restyling

TEST=manual
BUG=811641

Change-Id: I8da914e02ebfe67519f07ea3b9f3ee16c96ccbff
Reviewed-on: https://chromium-review.googlesource.com/917842
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537185}

So that we could get more consistent data across runs.

BUG=717744

Change-Id: I78eba114b1d4b603448725fefcc20ce3a3e1db71
Reviewed-on: https://chromium-review.googlesource.com/919314Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537184}

M65 is already branched, and we have to put off at least
2 milestones before the removal.

Bug: 523952

Change-Id: I1aa3950a07bbf12720e7aed8d94f3f6e3e380d2e
Reviewed-on: https://chromium-review.googlesource.com/921002
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537183}

This removes entries for a number of builders that have either
been removed or were never actually added. This will allow us
to update the buildbucket config as well.

R=bpastene@chromium.org, agable@chromium.org
BUG=732531

Change-Id: I1155f0a2eeb95de4da029ea4ff8dd8f894cb3898
Reviewed-on: https://chromium-review.googlesource.com/920602Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537182}

Allows a share-able offline page to be shared from long press or per
item 3-dot menu from the Downloads Home, but still gated by the offline
page sharing feature being enabled. Tests are also updated to check
sharing is working in this condition.

Bug: 758690
Change-Id: I6f65384b8f190cb037355edafdb9cbbdabd0769c
Reviewed-on: https://chromium-review.googlesource.com/922869
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537181}

BUG=811457
R=chrishtr@chromium.org

Change-Id: Ifc97bd14dc13ed546fa89711de531e517fa046f7
Reviewed-on: https://chromium-review.googlesource.com/923005Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537180}

CRC32 affects performance for both image decoding (PNG)
as also in general browsing while accessing websites that serve
content using compression (i.e. Content-Encoding: gzip).

This patch implements an optimized CRC32 function using the
dedicated instruction available in ARMv8a. We only support
ARM Little-Endian (LE).

This instruction is available in new Android devices featuring an
ARMv8 SoC, like Nexus 5x and Google Pixel. It should be between
3x (A72) to 7x faster (A53) than the C implementation currently used
by zlib for 8KB vectors.

This is performance critical code and can be called with both large (8KB)
or small vectors, therefore we must avoid extraneous function calls or
branching (otherwise the performance benefits are negated). So the use
of 'public' variables to read the CPU features status flags
(i.e. arm_cpu_enable_crc32 | pmull).

Finally it also introduces code to perform run-time ARM CPU feature
detection on the supported platforms: Android and Linux/CrOS. We build
and link the CRC32 instruction dependent code, but will decide to use it
at run-time if the ARM CPU supports the CRC32 instruction. Otherwise,
we fallback to using zlib's default C implementation.

This approach allows to use the instruction in both 32bits and 64bits and
works fine either in ARMv7 or ARMv8 processor. I tested the generated
Chrome apk in both a Nexus 6 (ARMv7) and a Google Pixel (ARMv8).

The crc32 function benefited from input from Yang Zang and Mike Klein,
while the arm_features benefited from input from Noel Gordon.

Bug: 709716
Change-Id: I315c1216f8b3a8d88607630a28737c41f52a2f5d
Reviewed-on: https://chromium-review.googlesource.com/801108Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537179}

IPCs communicating their Origin to the browser in requests should be updated to
remove their origin from such requests. The browser knows the Origin of the web
frame / worker making the request; it does not need the renderer to tell it the
Origin, nor should the browser believe them (renderers are untrusted, accepting
their idea of Origin is insecure). Update WebSockets, make them join the party,
remove Origin from their requests to the browser.

Bug: 779444
Change-Id: I000d23520f498f445b89f197d833fa335fa3de04
Reviewed-on: https://chromium-review.googlesource.com/788011Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537178}

Added back the canvas.clear() call that MSAN will whine without.

Original attempt: https://chromium-review.googlesource.com/c/chromium/src/+/919603

-------------------------Original description---------------------------

Changes the location of the RGB→Grayscale conversion of the
CopyFromSurface() result SkBitmap to be in
NavigationEntryScreenshotManager, as it is the only use case. This
unblocks a massive clean-up effort for bug 759310.

For reference, the following was the code that was doing the conversion
before (and is a part of a major chunk of code that we want to delete):
https://cs.chromium.org/chromium/src/content/browser/compositor/surface_utils.cc?rcl=2fe7073e23caa42cbd01575ab206ba8928ccd645&l=146

TBR=nick@chromium.org

Bug: 759310
Change-Id: Id859a8589c9866919ac77c4b7e18527526e38a8c
Reviewed-on: https://chromium-review.googlesource.com/922873
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537177}

This CL removes TrayPopupInkDropStyle from SystemMenuButton constructor,
because at all call sites TrayPopupInkDropStyle::HOST_CENTERED is given.

This CL also removes TrayPopupInkDropStyle from
TrayPopupUtils::CreateInkDrop, as it's unused.

BUG=none

Change-Id: I4168aa03ec2ee0a243eec3b8cb62f523b3d56711
Reviewed-on: https://chromium-review.googlesource.com/919924
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537176}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46541b4996f2..3ade6e121416

$ git log 46541b499..3ade6e121 --date=short --no-merges --format='%ad %ae %s'
2018-02-15 alemate Override temporary directory before spawning subprocess.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: Ic6c37717aba6df5ece34cb9983b37f21eec01144
Reviewed-on: https://chromium-review.googlesource.com/923381
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537175}

and SafeBrowsingMsg_GetThreatDOMDetails to use mojo.

- Remove SafeBrowsingHostMsg_ThreatDOMDetails,
SafeBrowsingHostMsg_ThreatDOMDetails_Node and
SafeBrowsingMsg_GetThreatDOMDetails from
//components/safe_browsing/common/safebrowsing_messages.h.

- Implement a corresponding interface and struct in
safe_browsing.mojom

- Update /safe_browsing/renderer/threat_dom_details.h/cc and
/safe_browsing/browser/threat_details.h/cc + unittests
to use mojo

- Add provides/requires as needed to
aw_renderer_manifest_overlay.json and
chrome_content_renderer_manifest_overlay.json

- Add DEPS rules to allow components/safe_browsing to include
"services/service_manager/public/cpp"

Change-Id: I27baf7c2ac5bae2afa116b4314f5db8f9eac579d
Reviewed-on: https://chromium-review.googlesource.com/899405Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537174}