- 29 Nov, 2018 40 commits
-
-
Peng Huang authored
Bug: 905337 Change-Id: I14e4188def4719f0b04151bf9d76731a46889612 Reviewed-on: https://chromium-review.googlesource.com/c/1351266Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612334}
-
Alex Leung authored
This reverts commit f1854090. Reason for revert: Causes internal b/120143260. Change-Id: I83286ee7cb9d5e96e63be66bc47efda802421232 Reviewed-on: https://chromium-review.googlesource.com/c/1354326 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612333}
-
Jonathan Backer authored
When we access RasterDecoderContextState::gr_context, the RasterDecoderImpl::context_state may become inconsistent with actual GL context state and we should set need_context_state_reset Bug: 910274 Change-Id: I834ce6e4cf9b5fe549de432b3bc6c06fa2a6ccbd Reviewed-on: https://chromium-review.googlesource.com/c/1355438 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612332}
-
Troy Hildebrandt authored
SharedProtoDatabaseClient inherited from UniqueProtoDatabase which was potentially risky since we can accidentally use some of UniqueProtoDB's functionality resulting in incorrect keys/entries from the database because we're not stripping/adding prefixes. We now inherit from ProtoDatabase to ensure that any functions added in the future must also be implemented in SharedProtoDatabase. Bug: 870813 Change-Id: I270afdb9dcffa0ba045756272a2f36af9cc93048 Reviewed-on: https://chromium-review.googlesource.com/c/1355423Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612331}
-
Dale Curtis authored
This is part 1/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. BUG=905506 TEST=updated tests, compiles. Change-Id: I9b26ed5ed8faea2f691b3a415dbdc79e18f5125a Reviewed-on: https://chromium-review.googlesource.com/c/1347588 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612330}
-
Eric Roman authored
Bug: 910212,729849 Change-Id: Iff0a02015b4b6dabfeff5b3865468df70748ddd6 Reviewed-on: https://chromium-review.googlesource.com/c/1355492Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612329}
-
Xi Han authored
Bug: 902311 Change-Id: I6f39faecc38ad002a70bfda7fd355ab83afc0889 Reviewed-on: https://chromium-review.googlesource.com/c/1337487Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612328}
-
Clark DuVall authored
ChromeMockCertVerifier was forgetting to call the parent class methods that set up the in-process NS cert verifier. Bug: 908993 Change-Id: I15251a705006c7f5dd1dc99027999e1b8739e416 Reviewed-on: https://chromium-review.googlesource.com/c/1355194Reviewed-by:
-
bsheedy authored
Adds a TL;DR to the XR instrumentation test documentation on how to locally reproduce most VR issues since many VR breakages at this point are caused by non-VR CLs, and their authors often need to ask how to reproduce the issue. Change-Id: I2a4585969a859cb9c9256c8cfa0715d9cc07b71c Reviewed-on: https://chromium-review.googlesource.com/c/1352488Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612326}
-
Mason Freed authored
This set includes a few more known issues, and changes the definition of opacity to match our more recent proposal. Under that proposal, the opacity of the backdrop-filter element applies to the filtered backdrop image as well. Bug: 497522 Change-Id: I2fa0bbb710b7a4ba5592c9a4b9ea5ecaaf5b9ddf Reviewed-on: https://chromium-review.googlesource.com/c/1354347Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#612325}
-
Donn Denman authored
Adds the ability to specify a threshold replacement to apply when predicting using an Assist-Ranker model. For Contextual Search the threshold is read from a FieldTrial variations parameter associated with the existing ContextualSearchRankerQuery Feature. For Translate, threshold setting is supported but unused. BUG=899134 Change-Id: Ia0b664ce1e0949f755e7d8898fb2769fc91ae536 Reviewed-on: https://chromium-review.googlesource.com/c/1312296 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612324}
-
Avi Drissman authored
This avoids it getting triggered by URL requests to quit/restart. BUG=909592, 142944 Change-Id: I353c1334decd556554399349bb207e63fca1352b Reviewed-on: https://chromium-review.googlesource.com/c/1354399Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612323}
-
John Delaney authored
Add a browsertest to verify that we are not counting overhead for responses with "Transfer-Encoding: chunked" towards network body bytes. Rename PageLoadMetricsTestWaiter methods to use "network bytes" instead of "resource bytes". Bug: 894168 Change-Id: Id83af484f210063761dcbf4552406f08cdd5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1351383Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612322}
-
Matthew Denton authored
Adds periodic pausing/resuming of random mojo bindings, to test whether Mojo users are relying on FIFO ordering of messages sent over different message pipes. Bug: 830815 Change-Id: Ie765813235a6ff720b2c4c3be550ad474b7be566 Reviewed-on: https://chromium-review.googlesource.com/c/1325551 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612321}
-
Jonathan Metzman authored
These are needed to stand up a builder for libFuzzer on Chrome OS Bug: 909849, 906214 Change-Id: Ifade90c138a7297a2cd5cc02e7d00628c3408d46 Reviewed-on: https://chromium-review.googlesource.com/c/1355433Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612320}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f38fffb7aa2f..9dbf638d6f75 Created with: gclient setdep -r src-internal@9dbf638d6f75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifc8506cc400887fd8ba4c5b874b50606dc88f555 Reviewed-on: https://chromium-review.googlesource.com/c/1355363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612319}
-
Pavel Shmakov authored
The following metrics were added. TWA usage: - TrustedWebActivity.TimeInVerifiedOrigin and TrustedWebActivity.TimeOutOfVerifiedOrigin - time histograms for the time spent in and out of verified origin. - Enabled Ukm recording, as implemented in org.chromium.chrome.browser.browserservices.UkmRecorder Disclosure: - TrustedWebActivity.DisclosureShown - TrustedWebActivity.DisclosureAccepted Clear Data Dialog - Boolean histograms TrustedWebActivity.ClearDataDialogOnUninstallAccepted, TrustedWebActivity.ClearDataDialogOnClearAppDataAccepted - Enum histogram SingleWebsitePreferences.NavigatedFromToReset recorded when user clicks “Clear & Reset” to tell which way did the user navigate into settings. Manage Data Activity - TrustedWebActivity.OpenedSettingsViaManageSpace - Included in enum histogram above Notification Delegation - SystemNotificationType.TRUSTED_WEB_ACTIVITY_SITES entry. - TrustedWebActivity.DelegatedNotificationSmallIconFallback which tells which fallback (if any) was used for the small icon of a delegated notification. Bug: 888961 Change-Id: If1cfe70754f474536c1d242a554a8ae517c5d15b Reviewed-on: https://chromium-review.googlesource.com/c/1353925 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612318}
-
Devlin Cronin authored
Update the underlying BaseSetOperators<T>::Map type to use std::unique_ptrs instead of linked_ptrs. Bug: 907661 Change-Id: I2161ca2acc513ee5d78cc32b14f27199f5a7d1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1351422 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612317}
-
John Abd-El-Malek authored
Revert "Alias the url for webui code with network service to get more information in debugging the crash." This reverts commit 660d336d. Got the information I needed. Original change's description: > Alias the url for webui code with network service to get more information in debugging the crash. > > Bug: 891074 > Change-Id: I8904c8d0285b8b2f245456509d88206f4789fc8d > Reviewed-on: https://chromium-review.googlesource.com/c/1330064 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606965} TBR=jam@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891074 Change-Id: Id739d25531997bcdacafa5c49a13bfd849edd32a Reviewed-on: https://chromium-review.googlesource.com/c/1355430Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/find_in_page. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I9741755b7ed101a5baf4e6bacc38abd7ad0a4029 Reviewed-on: https://chromium-review.googlesource.com/c/1351955Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612315}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ibcc14267aaa966b1833dd1537989a7bc5ae9a010 Reviewed-on: https://chromium-review.googlesource.com/c/1351952Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/sessions. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ia6e2ae8b3dc9334e9cec18328d7dda086f7ab57a Reviewed-on: https://chromium-review.googlesource.com/c/1351961Reviewed-by:
-
Clark DuVall authored
This fixes the last DRP browser test. Factors the code to a common location so it can be used in the DRP throttle. Bug: 721403 Change-Id: I47330f7e9cad75861787caa843d55147a42fb8a4 Reviewed-on: https://chromium-review.googlesource.com/c/1354653Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612312}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/tabs. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I6b33f5491423d55455e912ee01adec2c73686122 Reviewed-on: https://chromium-review.googlesource.com/c/1351079Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/web_view. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I91645c283c518b67e1a7efe866d30ba566815273 Reviewed-on: https://chromium-review.googlesource.com/c/1351965Reviewed-by:
-
Nicolas Pena authored
This CL exposes the PerformanceMark and PerformanceMeasure interfaces to Worker, thus fixing the idlharness tests in performance-timeline and user-timing. Blink-dev thread: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/Z3RKovFsA1s/DWt78xngAgAJ Bug: 898791 Change-Id: Ic4e3e8c61ac087d13ffc86e462b45ab2ddbd097f Reviewed-on: https://chromium-review.googlesource.com/c/1351562Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612309}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/infobars. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I4b9a1e4e554819b741e0901208665dc7142db08e Reviewed-on: https://chromium-review.googlesource.com/c/1351074Reviewed-by:
-
Sami Kyostila authored
This patch removes the deprecated MessageLoop{UI,IO}::{current,IsCurrent} functions and rewrites clients to MessageLoopCurrentFor{UI,IO}::{Current,IsSet}. No functional changes. # chrome/ TBR=sky@chromium.org # extensions/ TBR=finnur@chromium.org # net/ TBR=morlovich@chromium.org # remoting/ TBR=garykac@chromium.org # services/ TBR=rockot@google.com # ui/ TBR=sadrul@chromium.org Bug: 891670 Change-Id: I283cd67940e21e5b737d566a2ac351b69756e176 Reviewed-on: https://chromium-review.googlesource.com/c/1354010Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612307}
-
Gang Wu authored
User Actions: Suggestions.ScrolledAfterOpen Suggestions.Card.SwipedAway UMA: ContentSuggestions.FetchPendingSpinner.VisibleDuration Also add Guard against calls from Feed after destroy(), like https://chromium-review.googlesource.com/c/chromium/src/+/1345422 Bug: 908706 Change-Id: Ifdd9dcab594d74eb79d0161d1ee66027a7adcea0 Reviewed-on: https://chromium-review.googlesource.com/c/1351932 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612306}
-
Robert Ogden authored
Reverts all of the PLM changes in https://chromium-review.googlesource.com/c/chromium/src/+/1334944 and a partial revert of the previews code because of merge conflicts. git checkout 967d3a9b \ chrome/browser/page_load_metrics/page* \ chrome/browser/page_load_metrics/metrics* Bug: 874150 Change-Id: Ic943baa1c8945c3dd033de5890ba0d70b2efd5bc Reviewed-on: https://chromium-review.googlesource.com/c/1355331Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#612305}
-
Quan Nguyen authored
This CL includes a new Mojo service for controlling the ContainedShell, as well as a feature flag for enabling it. Bug: 902571 Change-Id: I645643270a5e595a0cadb6f781f400d700ae3bed Reviewed-on: https://chromium-review.googlesource.com/c/1323718 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#612304}
-
Garrett Beaty authored
Bug: 889992 Change-Id: I9a8d8f787507c7e461b8a02ad5b130389a9f876c Reviewed-on: https://chromium-review.googlesource.com/c/1351489Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#612303}
-
Bret Sepulveda authored
At least on Windows, the screen reader will not read non-menu-item Views in a menu. Currently, extensions hidden in the app menu and the zoom plus and minus buttons are not read. This patch tags them as kMenuItem, which fixes the bug. Bug: 835738 Change-Id: I507c9595f6aa02d8768330f18a8b725ef1b440e4 Reviewed-on: https://chromium-review.googlesource.com/c/1354482Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#612302}
-
John Rummell authored
Original change's description: > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only > External Clear Key CDM to store the license in the file system, if it is > available. > > The original CL was flaky due to Mac's only saving file timestamps to > second granularity. As a result it was possible for the newly created license > to be saved with a timestamp prior to the current actual time, and deleting > "old" licenses would include it in the deletion. Change is to wait for some > time on Macs only to ensure that the "new" license has a later timestamp. This reverts commit b6bfa2b7. BUG=808690 TEST=new browser_tests pass Change-Id: Iad919ec23bf157a9bc4af3e6d54af2b28fdc217e Reviewed-on: https://chromium-review.googlesource.com/c/1354498Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612301}
-
Adam Langley authored
(This doesn't apply to U2F register responses because there's no flags byte there.) Bug: 896980 Change-Id: I02c63d4bc63db4a8e2e7256a428d8349c34f5443 Reviewed-on: https://chromium-review.googlesource.com/c/1355242 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#612300}
-
Vladimir Levin authored
Change-Id: Icb4017f98f8edea6692d84ef82872a2182e3d29c Reviewed-on: https://chromium-review.googlesource.com/c/1355325Reviewed-by:
-
Joe Downing authored
Follow-up CL fixing a leak identified post check-in. Bug: 902041 Change-Id: I733cc6037f5c29f0decabae72d51a6470de17f91 Reviewed-on: https://chromium-review.googlesource.com/c/1355332Reviewed-by:
-
John Budorick authored
Updating android_deps is a bit more involved & will be in a separate CL. Bug: 877304 Change-Id: Ic297766125ffd638b8190033736d301ce650a86e Reviewed-on: https://chromium-review.googlesource.com/c/1350879 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612297}
-
Abhishek Arya authored
R=mmoroz@chromium.org,ochang@chromium.org Bug: 909950 Change-Id: I00c7a8dcab631a8e4f7334847733c4a10a1376f0 Reviewed-on: https://chromium-review.googlesource.com/c/1354684Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612296}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1442ecdf514..471358f39a6a git log a1442ecdf514..471358f39a6a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: fix pipeline stages of memory barriers 2018-11-29 matavenrath@nvidia.com Optimize State::syncDirtyObjects Created with: gclient setdep -r src/third_party/angle@471358f39a6a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Iad8707cc33c68cf716b17b6f184389220509bba7 Reviewed-on: https://chromium-review.googlesource.com/c/1355241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612295}
-
