- 16 Nov, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5da6b5b505..9e371caae2fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tguilbert@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047896,chromium:897470 Tbr: tguilbert@google.com,lgrey@google.com Change-Id: I348d2e942e7c3b58d32fcb1c6216cd06e8cd1c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542306Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827942}
-
Ravjit Singh Uppal authored
Since Flash is deprecated we dont need the warning prompts about Flash deprecation anymore. Bug: 1134202 Change-Id: I52ba1a8bb6c87c280ede20ad2d7178da25a755c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536643Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#827941}
-
Collin Baker authored
Uses WinRT's Windows.Devices.Input.TouchCapabilities to check if the screen has touch input. If it does, registers the client in the WebUITabStripOnTablets synthetic field trial. Bug: 1044692 Change-Id: I62ea6c627805f3ae1b18479deffef3a7c638b574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536790 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#827940}
-
James Hawkins authored
Bug: 126802 Test: OSSettingsAboutPage* Test: DeviceNameHandlerTest.* Change-Id: I4c16cb932ecbbf03f66cdec32ff72b77ff5f30e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528637 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#827939}
-
Noel Gordon authored
With CL:2536584 the SWA files app main.html is auto-generated from the files app main.html and provides its own CSS files. Thus, SWA main.css file is no longer used: remove it. Bug: 1113981 Change-Id: I88a7d0a02c10993f7c3113425466827f046939dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540146 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827938}
-
Robert Sesek authored
Bug: 1148931 Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827937}
-
Zhaoyang Li authored
The tests can pass on device now, Reenable every test under the bug number and test utility. Bug: 1067821 Change-Id: I1fdbeed8bb42eb47705f883426def8e67287d1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523306Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#827936}
-
Shakti Sahu authored
This CL adds search capability to read later bookmarks. This enables read later items to be searchable from anywhere inside bookmarks. Bug: 1139072 Change-Id: I13329f066d300be1e1a70ddd51f42908b8454749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536813 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#827935}
-
Kevin McNee authored
Per the style guide, we should use proper test assertions to report failures gracefully. Bug: None Change-Id: Ice20b1f1dae1ca46db1b6471da62ff295a6c65ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538050Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827934}
-
Alex Turner authored
Currently, it is only defined on NavigationRequests. Defining it on the handles too will allow for easy determination of when a navigation has passed through ReadyToCommitNavigation(), i.e. via HasCommitted() || IsWaitingToCommit(). Note that some navigations can pass through ReadyToCommitNavigation() without eventually committing -- e.g. due to a doc.write. Adding this call will simplify handling of these edge cases. Bug: 1101584 Change-Id: I7c272ef2768a901b8988bfe8e28ae1a0c3ef2ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536389Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#827933}
-
Haiyang Pan authored
The crrev.com/c/2534602 which adds it as 50% does not seem to affect the build duration a lot: http://shortn/_lvbjprI51m. And there are still plenty of test devices: http://shortn/_ZtBguxAg9X Bug: 1111436 Change-Id: I0126df515488a5241e0a91aac8122bf21d66391f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541222Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#827932}
-
Dave Tapuska authored
In crrev.com/6e8f1f65 a SetMouseCapture call was missed. Causing the old issue to regress. Ensure the SetMouseCapture call is there so the targeting of mouse events is correct during drag. BUG=1149432 Change-Id: Ie61c25e45ac83d295111088bd8c1e25080c84a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541202 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827931}
-
Aga Wronska authored
This cl addresses a few easy to solve problems found in the code owned by Family Experiences team. More fixes will come in a followup. Bug: 1147260 Change-Id: I6b9766b18640f626fcd6aa063d3998d5d469b95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538515Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827930}
-
Hiroshige Hayashizaki authored
Bug: 1129793, 1114601 Change-Id: Ifc26c2c9e75b25d4ff001395b4faf072c41974c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485411Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#827929}
-
Patrick Monette authored
This new member function allows the caller to modify an element in-place safely. The existing options to do this right now is either use const_cast<> then call Update() manually (was done by tests), or remove then reinsert the modified element afterwards. The issue with the later option is that you can't keep using the same HeapHandle pointer as it cleared during the removal. Bug: 971272 Change-Id: I202daa322f1160d601ffffa87ceb6a4dad0e291f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530370Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#827928}
-
Jimmy Gong authored
Previously only checked if the host phone is a PhoneHub host but did not verify whether if it was a BetterTogether host and has a valid Bluetooth address. This CL adds those checks. Bug: 1106937 Fixed: 1147290 Test: chromeos_components_unittest Change-Id: I8c2e7a596655a3a9904268873c8514f1332ae234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538694 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/54fc9abd737d..2228002b0f2d $ git log 54fc9abd7..2228002b0 --date=short --no-merges --format='%ad %ae %s' 2020-11-16 danzh Disable QuicUnackedPacketMapTest.DebugString() in chromium. 2020-11-13 nharper Remove unused QuicVersionManager::GetSupportedTransportVersions 2020-11-13 nharper Remove old TODO(nharper) that is out of date 2020-11-13 bnc Remove QUIC priority experiments. 2020-11-12 bnc Remove SpdyDeframerVisitor. 2020-11-12 dschinazi Removed unused variable 2020-11-12 danzh Pass PATH_CHALLENGE payload to QuicPacketCreator::SendPathChallenge() instead of getting it populated by this interface. 2020-11-12 wub Enhance the error message of QUIC_BUG in QUIC BandwidthSampler. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I3925f0a3efbd8c7eb30c52e878cec3e3c15572bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541807 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827926}
-
Michael Lippautz authored
These days PCScan and its bitmaps are lazily committed after startup. Since bitmaps are not committed until PCScan is enabled, there is no need for having a separate compile-time flag to avoid paying for used memory. Bug: 11297512 Change-Id: I9226a718be6309bc43de5f9f67e7c84e223eacbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539198 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827925}
-
Yue Li authored
Bug: b/173185932 Test: Run IntentGeneratorTest.* in chromeos_components_unittests Change-Id: I4f78d5713e7161b059d71cb9985461fa2f4e0155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537596Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#827924}
-
James Vecore authored
Disabled test will be address in: https://crrev.com/c/2532904 Bug: 1146293 Change-Id: I8f3a3d92a1f490fb24338a521aa832c2c31ead2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536948Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#827923}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fd5c198347e1..da73999f798a 2020-11-16 linxinan@chromium.org Make bot_update and tryserver module not crash for multiple changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0d6a685a74ae0f6a5a876114deaed472593cd08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827922}
-
Victor Fei authored
CL:2356484 fixed an issue in AXVirtualObject::AddChildren where the parent should be set. As a follow up, this change also sets |have_children_| to true when adding children for AXVirtualObject. Consider the following call stack: AXVirtualObject::AddChildren AXObject::UpdateChildrenIfNecessary AXObject::ChildrenIncludingIgnored WebAXObject::ChildAt BlinkAXTreeSource::GetChildren AXObject::UpdateChildrenIfNecessary() relies on |have_children_| to check if there are new children and should be added. If we do not set |have_children_| to true in AXVirtualObjet::AddChildren(), the above call will keep adding children and expand the heap beyond allowed capacity triggering a check. AX-Relnotes:n/a Bug: 1149437 Change-Id: I973a73994bc59e47742ddfdd8c15c90d6c664421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538354 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827921}
-
Avi Drissman authored
CFBundleDisplayName is the full name of the app (as opposed to CFBundleName which is the "short name"). It's supposed to match the file system name (before the user perhaps renames it) and several utilities display it. Make it match the full SxS app name. Fixed: 1141844 Change-Id: I7ae6fc630c49b7d96c931238d8878d43ec3ffaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542158 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827920}
-
Olivier Robin authored
Bug: 1147716 Change-Id: Ia7f8bed3568088342ebdac56fbd7b6d4b1b9db03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537638 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#827919}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfb8bc49..e05d24f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ca303d2e9ea07382b2335daadffd39e52a78cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541003Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827918}
-
Nico Weber authored
This should've been in https://chromium-review.googlesource.com/c/chromium/src/+/2540578 Bug: 1149401 Change-Id: Ia6d7edb033064a5a953625a51266fd8cb3051d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541805 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL introduces a strong alias for ISO 639-1 language coders for use within Autofill, particularly for parsing patterns to make sure that we don't mix up different kinds of strings (languages, country coders, pattern names). Change-Id: Ib14ed323987271005a582a322016afd6bc0dfd41 Bug: 1142413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493860Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827916}
-
bttk authored
This reverts commit ee00d9b5. Reason for revert: Change was reverted only due to a dependency of a breaking change. Original change's description: > Revert "[ToolbarMVC] Observe incognito state changes in location bar." > > This reverts commit 7c26f582. > > Reason for revert: this CL depends depends on https://crrev.com/c/2495969 that has to be reverted due to test > failures and crashes (https://crbug.com/1149348, https://crbug.com/1149382). Please contact bsazonov@chromium.org or > pnoland@chromium.org if you have any questions. > > Original change's description: > > [ToolbarMVC] Observe incognito state changes in location bar. > > > > This lets us remove LocationBar#updateMicButtonState() which was > > a "poke" method on the interface. > > > > Do not submit before M88 branch point (Nov 12th) > > > > Bug: 1142883 > > Change-Id: If7564ac95e6ca69e28e6de7a609f0db9fa916c9e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518202 > > Commit-Queue: bttk <bttk@chromium.org> > > Reviewed-by: Patrick Noland <pnoland@chromium.org> > > Reviewed-by: Filip Gorski <fgorski@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827544} > > TBR=fgorski@chromium.org,pnoland@chromium.org,bttk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142883, 11493484, 1149382 > Change-Id: Ia30a5089a20687be350892b75411eec2a27f7691 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540528 > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: bttk <bttk@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827847} TBR=fgorski@chromium.org,pnoland@chromium.org,bsazonov@chromium.org,bttk@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1142883 Bug: 11493484 Bug: 1149382 Change-Id: I6c1e2b617e911747d768a89db7f4208383aa2412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541573 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827915}
-
Vincent Boisselle authored
Bug: 1145201 Change-Id: Ief0a12ac8350a85b6235fe5f27df4e09d96e6b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517046 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Dale Curtis authored
This plumbs HDR support for P010 GpuMemoryBuffers on macOS. It works by setting up a side channel on the IOSurface for communicating the MDCV and CLLI SEI data to the final CVPixelBuffer. This also makes a couple of minor fixes to media/ code: - VideoDecoderConfig wasn't printing the full HDR metadata. - VpxVideoDecoder didn't always set the HDR metadata properly. Note: There are cases where we don't allow GMBs for software decoding: Full range and odd sized YUV. Possibly we want to range reduce in the copy to GpuMemoryBuffer process to eliminate the first one. Bug: 1101041 Change-Id: I3bcc390901020b20514ff18ecc6cc73b59f50525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523739Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Joey Arhar authored
AbortSignal doesn't remove the event listener if it was registered with capture: true in addEventListener. This patch fixes it by plumbing through the options to removeEventListener. Fixed: 1149047 Change-Id: Iccafee46277880088634828fc9c9310388044a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538368Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#827912}
-
Gang Wu authored
This is follow up from the comment in https://chromium-review.googlesource.com/c/chromium/src/+/2446450/comment/9408fb53_5f37aaef/ Wee should set default tint for the icon since the view may be reused previously. Bug: 1148950 Change-Id: Idfb641ff1865caea0763da613a61ec07274c8b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538350Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827911}
-
Dale Curtis authored
macOS requires a larger initial size for the encoding test to actually succeed. Linux normally doesn't have any hardware encoding support, but it may be enabled with a chrome://flag. R=eugene Fixed: 1110279 Change-Id: I05feac9fee3bb2aa76bb5e14f06b48c6b8b46a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537145Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827910}
-
Bence Béky authored
Generated by :fieldtrial_testing_config_entry --group_name=DisablePush2 --channel=stable Change-Id: Id16ca16dc9b18bef3a089771cb567fbfb70400dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535802 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#827909}
-
Lan Wei authored
We should have a WPT test to verify the text editing commands, such as "cut", "copy", "paste", and "select". When we press "ctrl/cmd" + "a", it should select all the text, "ctrl/cmd" + "x" should cut the select text, "ctrl/cmd" + "c" should copy the select text, and "ctrl/cmd" + "v" should paste the copied or cut text. Bug: chromedriver:3462 Change-Id: Id65de52c9cc444d98eca4910be77b7c3682f9404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521109 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#827908}
-
Stefan Zager authored
Change-Id: Iaed2e1af932242e08d053940bb509982c3b9af39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533318Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#827907}
-
minch authored
Bug: 1131543 Change-Id: Ib6f4f7ddf5efec27ad42bba135ee0e9478bf2147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542043Reviewed-by:
-
Mason Freed authored
See [1] for more context, but many tests are currently marked as flaky-timeout. If the only problem with those tests is that they happen to be a bit slow, and therefore sometimes don't get enough time to run, we shouldn't disable those tests. This CL moves all tests currently marked [Pass Timeout] from TestExpectations to SlowTests, and marks them [Slow]. I will attempt to run the trybots a number of times to check for remaining flakiness, but there's obviously a chance some of these will continue to flake after this CL lands. In that case, the sheriffs will need to re-mark the offending tests as flaky. However, the upside will be that likely many tests will remain enabled and our test coverage will be improved. These changes were made using roughly: $ grep -i "\[ Pass Timeout \]" TextExpectations | sed -e 's/\[ Pass Timeout \]/\[ Slow \]/g' The mechanical changes were edited to remove additional whitespace and comments, and some tests were returned to TestExpectations due to either failures on the CQ, or the fact that they were already present in SlowTests. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1095379#c20 Bug: 1095379 Change-Id: I0bf2a2879234123c5346dfeaecfca7a68e90c019 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#827905}
-
Elizabeth Popova authored
Prior to this change, it was impossible to save an Autofill profile until every required field is filled. Now it depends on the use case (purpose argument): - if opened from Autofill Settings (purpose = AUTOFILL_SETTINGS), no fields are marked as required and empty values are acceptable; - if opened from Payment Request or Autofill Assistant (purpose = PAYMENT_REQUEST), the behavior is the same as before: an error message is shown when the required field is not filled. Note, that phone number validation is still enabled for both cases. However, an empty value is allowed only for the first case. Change the test accordingly and add another test for phone number validation. Also explicilty focus the first text field in the testKeyboardShownOnDpadCenter test. Previously it was focused because it was the first required field and after the change it didn't get focused by default. Change-Id: Ib476af34b2d755236cf88a29bcf3a2ba4977ccc5 Bug: 1149568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537670 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827904}
-
Gordon Seto authored
This reverts commit 1ade577e. Reason for revert: Fix missing sim_detect_page_test.m.js error. sim_detect_page_test.m.js was not updated in chrome/test/data/webui/BUILD.gn:254 to new name setup_loading_page_test.m.js causing build to fail. Ok to reland as all instances of sim_detect_page_test have been updated to new name. Original change's description: > Revert "[CrOS Settings] Update sim-detect-page to be more generic" > > This reverts commit c0d403ae. > > Reason for revert: May be causing chromeos errors. Speculatively reverting based on error log: > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863577786188639024/+/steps/isolate_tests/0/stdout?format=raw > > > 0cf1ad3e42632633d1110de0b0a6e30ef2599740 boringssl_ssl_tests > isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/browser_tests.isolate: failed to process: stat /b/s/w/ir/cache/builder/src/out/Release/gen/chrome/test/data/webui/cr_components/chromeos/cellular_setup/sim_detect_page_test.m.js: no such file or directory > > So this error is caused by sim_detect_page_test.m.js. > > Original change's description: > > [CrOS Settings] Update sim-detect-page to be more generic > > > > Rename sim-detect-page to setup-loading-page and update UI to be used > > for both psim and esim flows. > > > > Bug: 1093185 > > Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231 > > Commit-Queue: Gordon Seto <gordonseto@google.com> > > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827473} > > TBR=khorimoto@chromium.org,azeemarshad@chromium.org,gordonseto@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1093185 > Change-Id: I48421a06df20aadd0913c1ee9bc3dc313f31097d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538858 > Reviewed-by: Minoru Chikamune <chikamune@chromium.org> > Commit-Queue: Minoru Chikamune <chikamune@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827659} TBR=khorimoto@chromium.org,azeemarshad@chromium.org,chikamune@chromium.org,gordonseto@google.com # Not skipping CQ checks because this is a reland. Bug: 1093185 Change-Id: Idf13c31d7e56b81b0e246f25d78404dfa21f16a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540923Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
