- 25 Jun, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d3a6eb96..67ad8746 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46f16f2c0e1b22a1290db550abd4957e63a493c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675585Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672017}
-
Dominic Battre authored
This CL introduces a sequence of metrics representing the autofill funnel as well as a set of key feature metrics to judge the success of autofill. These together are intended to serve as a long term set of metrics to guide our feature development. This CL has a major effect on the existing Autofill.FormEvents.Address.* metrics: In the past, everything that was not a credit card, was considered an address form (i.e. also password forms). This changes with this CL. Only forms that contain an address field are considered an address form. Bug: 966475 Change-Id: Ifb3f64a16988ed7939e76cad2dd3b58aad64d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628607 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672016}
-
Matthew Cary authored
ProcessMitigationsWin32KDispatcher uses a raw handle to open a shared memory region containing certificate data. This CL uses the new shared memory region API to open region. In keeping with current semantics, it is opened writable. This should introduce no functional change. Bug: 795291 Change-Id: I1d7bdeb0220a1deaaff8c65e9bc0e457df78057b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657897Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#672015}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b7104ada38e4..cf17e9d9c020 Created with: gclient setdep -r src-internal@cf17e9d9c020 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: Idad1fade338c41474a701f28ce6fce3adc00f320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672014}
-
Bo Liu authored
Setting scroll on UI thread apparently now requires a visual state sync. Bug: 977526 Change-Id: Ifef05e897e70885515302ee0dd68f6f9fc79ec72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672092 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672013}
-
Takashi Sakamoto authored
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909706066132280960/+/steps/compile/0/stdout In file included from ../../third_party/blink/renderer/platform/mojo/geometry_struct_traits.cc:5: ../../third_party/blink/renderer/platform/mojo/geometry_struct_traits.h:13:10: fatal error: 'ui/gfx/geometry/mojo/geometry.mojom-blink.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. FAILED: obj/third_party/blink/renderer/platform/mojo/geometry_struct_traits/geometry_struct_traits.o Change-Id: Ib22623a068225d9ebf21d44daa619a329f39a7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675668 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672012}
-
Koji Ishii authored
Change-Id: I7433114e0fa1ab597179060108e8b62cdd041c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674165Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#672011}
-
François Beaufort authored
Instead of having web developers to specify a rasterizationState frontFace value for every singleGPURenderPipelineDescriptor, a default value is now provided according to spec change. See https://github.com/gpuweb/gpuweb/pull/313 Bug: 877147 Change-Id: I05b059b9e189c996d8a087b45f4a3e82cffc7df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675764 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672010}
-
Satoshi Niwa authored
Before: ArcFileSystemBridge owns a single instance of ArcSelectFilesHandler. ARC apps can't request to open multiple dialogs at a time. After: ArcFileSystemBridge owns an instance of ArcSelectFilesHandlersManager, which manages multiple ArcSelectFilesHandler instances. ARC apps can request to open multiple dialogs at a time, with the limitation of 1 dialog per 1 task ID. Bug: 970262 Change-Id: I0227aa8ef2329699e79ba0a9d2c3f244d42e6085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669249 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672009}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id94e976ad1992da564541590c1e6c91df2b453c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672008}
-
Jack Steinberg authored
and shorten non-default timeout tests Change-Id: Ia9e6a14ff66a0f5d4b57ffb59808769bd90e578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675544 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#672007}
-
Oleh Prypin authored
Problem introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1672849 TBR: martiniss@chromium.org Bug: 976184 Change-Id: Ib09c1f8720fab8ebdb74d67d87a0fd9db2273d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675427Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672006}
-
Yutaka Hirano authored
Bug: 977015 Change-Id: Ia97e8191e1d8f0a7930baa7783575f79b5b3af7f Tbr: mjackson@microsoft.com No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675588Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#672005}
-
Quentin Fiard authored
Also remove the field trial configuration for the associated features. Bug: 973591 Change-Id: I409c71cb7bee08aaa57150df14088f49c18c92ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657920Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Quentin Fiard <qfiard@google.com> Cr-Commit-Position: refs/heads/master@{#672004}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4996d436060..2923d768f010 git log f4996d436060..2923d768f010 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c049034c..6c5bbd86 (671848:671957) 2019-06-25 mbonadei@webrtc.org Switch frame_analyzer to ABSL_FLAG. 2019-06-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6c73f30..c049034c (671737:671848) Created with: gclient setdep -r src/third_party/webrtc@2923d768f010 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I85f796f6825a53080ac3d564aa99c30d6c8161d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675389Reviewed-by:
-
Yi Su authored
This CL moves //ios/web/web_state/ui/wk_security_origin_util.* into //ios/web/web_view:util, so that they can be shared with //ios/web/js_messaging for further refactor. Bug: 956516 Change-Id: Ie507f63e5fe6655e7fba9224c7abad0a40f990df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674093 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672002}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3b2255975f37..74e98f6cb07d git log 3b2255975f37..74e98f6cb07d --date=short --no-merges --format='%ad %ae %s' 2019-06-25 jiajia.qin@intel.com Use highestUsed() instead of size() Created with: gclient setdep -r src/third_party/angle@74e98f6cb07d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I5e8aa8d24da2dd228938fa2eb789707c97280603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675388Reviewed-by:
-
Wez authored
This reverts commit e2a060b2. Reason for revert: CL changed #includes from mojom-shared.h to mojom-blink.h without migrating the corresponding |deps| in BUILD files to refer to the Blink "mojom_platform" target that generates the mojom-blink headers, leading to flaky builds. Original change's description: > Use mojom-blink.h headers in blink/renderer/ > > ... instead of the respective mojom-shared.h variant. > > Today there is a mix of *mojom-shared and *mojom-blink.h usage > within third_party/blink/renderer. > > This CL replaces all instances of the former by the later, > except for one in renderer/modules/indexeddb, which seems to > require some more work. > > Next an amend on third_party/blink/PRESUBMIT.py will be done > to avoid further occurrences. > > TBR=dcheng@chromium.org > > BUG=973028 > R=haraken@chromium.org > > Change-Id: Ifab9a832c5435e37399e8d210b5c716daeba66ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658911 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669501} TBR=haraken@chromium.org,tonikitoo@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973028 Change-Id: I2427c43ec95b27f942f1be77674069fe4fe7cc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675469Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Bug: 978265 Change-Id: Ib7347822f49f5ea8ab4b11e19d0d4db6ae218734 Tbr: caseq@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675507Reviewed-by:
-
Shuo-Peng Liao authored
In V4L2Device::V4L2FormatToVideoFrameLayout(), when converting V4L2_PIX_FMT_NV12 format, it should expect to see two planes. However, the code expects 3. It passes CQ because CQ does not cover v4l2 specific unittests. BUG=chromium:971943 TEST=pass media_unittests on an ChromeOS DUT. Change-Id: Ib5504ef36e0935235cd36a390b3905d45ba8b6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675506Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#671998}
-
Takashi Sakamoto authored
This reverts commit 87d6424d. Reason for revert: suspect causing ash_unittests failure on Linux Chromium OS ASan LSan Tests (1). https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/34147 deterministic failures: TabletModeWindowManagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest ==23210==ERROR: AddressSanitizer: container-overflow on address 0x6020000e12b8 at pc 0x55b059128cb9 bp 0x7ffdb6f1b8d0 sp 0x7ffdb6f1b8c8 READ of size 8 at 0x6020000e12b8 thread T0 #0 0x55b059128cb8 in ash::SplitViewDivider::~SplitViewDivider() ./../../ash/wm/splitview/split_view_divider.cc:253:19 #1 0x55b059128f4d in ash::SplitViewDivider::~SplitViewDivider() ./../../ash/wm/splitview/split_view_divider.cc:249:39 #2 0x55b0591499fc in ash::TabletModeController::SetTabletModeEnabledInternal(bool) ./../../ash/wm/tablet_mode/tablet_mode_controller.cc:622:16 #3 0x55b052f19119 in ash::TabletModeWindowManagerTest::DestroyTabletModeWindowManager() ./../../ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc:138:45 #4 0x55b052f8060b in ash::TabletModeWindowManagerWithClamshellSplitViewTest_ClamshellTabletTransitionTest_Test::TestBody() ./../../ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc:1974:3 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8909703871929620480/+/steps/ash_unittests/0/logs/Deterministic_failure:_TabletModeWindowManagerWithClamshellSplitViewTest.ClamshellTabletTransitionTest__status_CRASH_/0 Original change's description: > Clamshell <-> tablet mode transition > > There are 3 cases in clamshell to tablet mode transition: > 1) overview is active but splitview is not: keep overview active during > transition. > 2) overview and splitview are both active: keep them both active during > transition. > 3) overview and splitview are both inactive: keep the current behavior. > a) if the top window is a snapped window, put it in splitview > b) if the second top window is also a snapped window that snaps to the > opposite side of the screen, put it in splitview as well > c) if the top window is not a snapped window, maximize or fullscreen > all windows when entering tablet mode. > > There are 4 cases in tablet to clamshell mode transition: > 1) overview is active but splitview is not: keep overview active during > transition. > 2) overview and splitview are both active: keep them both active during > transition. > 3) overview is inactive but splitview is active (i.e., two snapped windows), > splitview will be no longer active after transition. But the two snapped > window will still keep snapped in clamshell mode. > 4) overview and splitview are both inactive: keep the current behavior, > i.e., restore all windows to its old window state before entering tablet > mode. > > > Bug: 890029 > Change-Id: I7769021f74c3e9d591b19258be2821992d780451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658955 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#670678} TBR=oshima@chromium.org,xdai@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890029 Change-Id: I518170a62a0cf82aff14748679e3a5f12f054f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675924Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#671997}
-
Yi Su authored
This CL moves the hanler method for window.error Js message from CRWWebController into WindowErrorManager. All unused and unnecessary methods in CRWWebController for Js message handling are also removed. Bug: 956516 Change-Id: If0823bc3cdab1042538ce314626681bcd28ad56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674014 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch changes the test to listen |searchParams| option so that we can test it in various size from lightweight-for-check to heavyweight-for-accuracy. Example: $ content_shell receive-arraybuffer-1MBx100.html?iteration=3&server=ws://127.0.0.1:8002/ > Connect to ws://127.0.0.1:8002/ Running 3 times Ignoring warm-up run (346.07608397871 MB/s) 349.01482119459 MB/s 332.869505903946 MB/s 286.404642021716 MB/s Description: Measure performance of receiving 1MB array 100 times. Bug: 954000 Change-Id: Idc0365c97e6a659f0d91e8e57f6c789407b06739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669149 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 972476 Change-Id: I1cca5af7809c0575f9c34a5d11068dc41aea157b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672847Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#671994}
-
Leo Zhang authored
Interfaces was used in IME service, but somehow it's not added into IME service deps. Bug: 837156 Change-Id: I8d18ad33d45f58b306e1d54f0dfe16df15cb1fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675279Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671993}
-
Rune Lillesveen authored
TBR=drott@chromium.org Bug: 977283 Change-Id: I4870a222ed6fcddfc716b6f3e43c5fcd126709e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675804Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#671992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9ca73fdc2fa..b7104ada38e4 Created with: gclient setdep -r src-internal@b7104ada38e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Id6df49dd31c020fa1ae2d28b9ac56d80009edf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675386Reviewed-by:
-
Satoshi Niwa authored
Bug: 971499 Change-Id: Ifef681fbeccc902a80df145b61830c74ae6be7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670136Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#671990}
-
Matthew Cary authored
Replace a use of the deprecated SharedMemoryHandle with the current shared memory region API. This changes PolicyTargetTest. SharedHandleTest to use anonymous shared memory rather than named shared memory. Bug: 795291 Change-Id: I5177db8e47c08259b26a3bb660da500fa0eb10b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658015Reviewed-by:
-
Jay Harris authored
The explainer is being updated to indicate that websites should use the presence of 'files' and 'request' to determine the cause of launches. Note: This API is hidden behind the NativeFileSystemAPI and FileHandling blink flags. Bug: 829689 Change-Id: Ia8a39ce36fee06281ab51e03c3ad2db401c105c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672611 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#671988}
-
Colin Blundell authored
This CL tightens the DEPS restrictions on inclusions of IdentityManager internal headers to be allowed only for the various IdentityManager factories. Even this allowance will shortly be removed when we internalize the building of IdentityManager from embedder-level dependencies. TBR=jochen@chromium.org Bug: 970268 Change-Id: Iaf0637aff5cfc3f710edcc3919645dba358bf52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674091 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#671987}
-
Colin Blundell authored
This CL updates //components/signin/core/browser/BUILD.gn to account for the evolution of the IdentityManager project and prepare for upcoming restructuring of //components/signin. Bug: 952788 Change-Id: Ie01eb5b072758d507e6ca5420030e52b433e1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674005Reviewed-by:
-
Yutaka Hirano authored
...due to flakiness. Bug: 978278 Change-Id: I227c9182e4433160a8ca8788f44f2d138ea363f3 Tbr: shik@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675904Reviewed-by:
-
Meredith Lane authored
Clusterfuzz identified a null dereference on AXLayoutObject. Bug: 970217 Change-Id: I269ba9bfce1d07e6af48a11bd9080279400ca965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666576 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#671984}
-
Lutz Justen authored
If ${PASSWORD} is present in KerberosAccounts, store the login password in the kernel keyring. The Kerberos system daemon will then grab the password to authenticate to a Kerberos account. Also moves the call to InitializePrimaryProfileServices to an earlier place. The KerberosCredentialsManager, which is created there, has to be created when the login password is still stored in the user context, so that UserSessionManager has a chance to send it to the session manager (see SaveLoginPassword). However, the call happened when the password was already cleared, see user_context_.ClearSecrets() in FinalizePrepareProfile. BUG=chromium:952240 TEST=Manually tested on device (enabled KerberosEnabled policy, set ${PASSWORD} as password for an account in KerberosAccounts, changed Gaia password to patch Kerberos password, logged in, verified in chrome:settings/kerberosAccounts that the ticket was valid. Change-Id: I3d82b293c3d236b03928cd5cd75edbea6c8999a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656570Reviewed-by:Colin Blundell <blundell@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#671983}
-
Yutaka Hirano authored
...due to flakiness. Bug: 976841 Change-Id: Ia98c267bc9d1234095196046e684372d5720a8d3 Tbr: grunell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675665Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce76d1e960eb..3df9c76a4999 git log ce76d1e960eb..3df9c76a4999 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mmortensen@google.com Build API: Refactor service/lib and commands.py to use artifacts.BundleFirmware Created with: gclient setdep -r src/third_party/chromite@3df9c76a4999 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I57657ae23cdaca4f0e5786b5f728180591682b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675385Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/afa3e0ca167b..96f6f7f65b3c git log afa3e0ca167b..96f6f7f65b3c --date=short --no-merges --format='%ad %ae %s' 2019-06-25 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dfd760055152..3b2255975f37 (3 commits) 2019-06-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 91f69e5c..aab9fad6 (366 commits) Created with: gclient setdep -r src/third_party/skia@96f6f7f65b3c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: I51ef093a250ab0699e67a771f6f1f3b3f5179beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675387Reviewed-by:
-
Colin Blundell authored
This CL eliminates the last inclusion of gaia_cookie_manager_service.h from files other than the IdentityManager internals by moving the standalone MultiloginParameters struct to its own file. Bug: 970268 Change-Id: I40d6b58065b0d3f268a775f9a0ee8ef2936a9372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674090 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements replacing the PasswordFormFieldPredictionType autofill enum with its Mojo equivalent and gets rid of now unneeded type conversions and performs minor clean-ups. Bug: 962853 Change-Id: I304443d90dc77f82283b89f283e4b1738e108472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662550 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#671978}
-
