- 15 Dec, 2016 40 commits
-
-
estevenson authored
Setting this arg allows _incremental targets and scripts to be used without explicitly building them. With this arg set to true, non-incremental targets will build their incremental counterparts if they exist (i.e. the chrome_public_apk target will actually build chrome_public_apk_incremental). This works for .apks, test runner scripts, and install scripts for instrumentation_test_apks, android_apks, and unittest_apks BUG=634430 Review-Url: https://codereview.chromium.org/2562063003 Cr-Commit-Position: refs/heads/master@{#438901}
-
mdjones authored
The control container can have different parent views depending on which flags are enabled, namely Chrome Home. This change removes the assumption that particular layout params are for a FrameLayout and instead uses the least common denominator -- MarginLayoutParams. This should be fine in this case since the margin is all that is being modified. BUG=664985 Review-Url: https://codereview.chromium.org/2579833002 Cr-Commit-Position: refs/heads/master@{#438900}
-
nparker authored
Review-Url: https://codereview.chromium.org/2585463002 Cr-Commit-Position: refs/heads/master@{#438899}
-
mattreynolds authored
The Physical Web feature will auto-enable if certain conditions are met when the browser first launches or switches modes. This CL adds a new condition: Google must be configured as the default search provider. The behavior when the auto-enable check fails is also changed. Previously, if the check failed the preference would be left in the default/onboarding state. With this CL, the preference will be explicitly disabled if the check fails. BUG=630769 Review-Url: https://codereview.chromium.org/2573923002 Cr-Commit-Position: refs/heads/master@{#438898}
-
smcgruer authored
Revert of Revert "Disable local background equivalence when we have a box shadow due to painting bug." (patchset #5 id:80001 of https://codereview.chromium.org/2561183002/ ) Reason for revert: Caused a regression in drawing backgrounds when the window was sized around 1280x1024. Regression seen in at least Windows and Linux - see http://crbug.com/674429 BUG=674429 Original issue's description: > Revert "Disable local background equivalence when we have a box shadow due to painting bug." > > This reverts commit a12e7a00. > > BUG=646464 > > TEST=Visit http://output.jsbin.com/vucefi, confirm that both boxes have > box shadows and the first box has sub-pixel AA text > > Committed: https://crrev.com/c765a85995920f79d3132e06a2c146316b823c3f > Cr-Commit-Position: refs/heads/master@{#438020} TBR=wangxianzhu@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646464 Review-Url: https://codereview.chromium.org/2576423002 Cr-Commit-Position: refs/heads/master@{#438897}
-
romax authored
Fixed the crash caused by logging to files on UI thread and violating StrictMode by changing log to AsyncTask. BUG=673450 Review-Url: https://codereview.chromium.org/2562283004 Cr-Commit-Position: refs/heads/master@{#438896}
-
sebsg authored
BUG=674571 Review-Url: https://codereview.chromium.org/2580873002 Cr-Commit-Position: refs/heads/master@{#438895}
-
robliao authored
This reverts commit ad1893a4 (https://codereview.chromium.org/2256493002). BUG=638378 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng Review-Url: https://codereview.chromium.org/2580603002 Cr-Commit-Position: refs/heads/master@{#438894}
-
xdai authored
[ChromeOS] Add device wallpaper policy handler to ensure the policy display correctly in chrome://policy. It's a following-up CL of https://codereview.chromium.org/2544693002/ and https://codereview.chromium.org/2572793003. BUG=475998 Review-Url: https://codereview.chromium.org/2572353002 Cr-Commit-Position: refs/heads/master@{#438893}
-
twellington authored
Catch the InterruptedException in CriteriaHelper#* and remove the throws declaration from methods that no longer need to declare it. BUG=673892 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2573263002 Cr-Commit-Position: refs/heads/master@{#438892}
-
sgurun authored
This was reverted due to crbug.com/673736. Fixed. Move onReceivedError and onReceivedHttpError out of AwContentsIoThreadClientImpl to AwContentsClientBridge. This is a continuation of the work started in https://codereview.chromium.org/2425423004/ and is the third patch. BUG=645983 Committed: https://crrev.com/f199141ef70d76697647830f498b25706c0b0d0a Cr-Commit-Position: refs/heads/master@{#437688} patch from issue 2558223002 at patchset 120001 (http://crrev.com/2558223002#ps120001) Review-Url: https://codereview.chromium.org/2579533003 Cr-Commit-Position: refs/heads/master@{#438891}
-
dschuyler authored
This CL performs the i18n template replacement in a source stream so that i18n replacement can be used with gzip streaming decompression. (This TBR is for adding a .cc and .h file to an existing set of files). TBR=clamy@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2544683002 Cr-Commit-Position: refs/heads/master@{#438890}
-
mdjones authored
This change passes whether or not a tab's title is needed to native code. This is necessary because the title creation logic was moved from Java in https://codereview.chromium.org/2320623003/. Previously, If a title was not created in the Java layer, querying for it would simply return null and a title would not be displayed. Since the creation logic was moved, querying for the title will create it if it doesn't already exist. BUG=673283 Review-Url: https://codereview.chromium.org/2569893002 Cr-Commit-Position: refs/heads/master@{#438889}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0aca80ba..71aad116 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2584623002 Cr-Commit-Position: refs/heads/master@{#438888}
-
jbauman authored
It's unclear what's causing this, but the current instrumentation seems to show this ExceptionCode is the last one received before a hang. BUG=636158, 613701 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2579623002 Cr-Commit-Position: refs/heads/master@{#438887}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/625cd9e0c937..344ec42f60fd $ git log 625cd9e0c..344ec42f6 --date=short --no-merges --format='%ad %ae %s' 2016-12-15 bsalomon Rename GrAtlasTextBatch->GrAtlasTextOp and sk_sp 2016-12-15 bsalomon Rename GrAtlasTextBatch files to GrAtlasTextOp 2016-12-15 reed add fatstroke sample 2016-12-15 kjlubick Fix stragling Ubuntu dimensions 2016-12-15 scroggo Another step to using gn_to_bp.py Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2576303003 Cr-Commit-Position: refs/heads/master@{#438886}
-
rohitrao authored
BUG=665969 Review-Url: https://codereview.chromium.org/2576103002 Cr-Commit-Position: refs/heads/master@{#438885}
-
sky authored
These were disabled because of issues with the allocator shim. That's been fixed, so they can be reenabled again. BUG=642879 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2584633002 Cr-Commit-Position: refs/heads/master@{#438884}
-
stkhapugin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2518583002 Cr-Commit-Position: refs/heads/master@{#438883}
-
sky authored
Close() needs to hide right away. And the delegate wasn't notified of show/hide. BUG=674003 TEST=covered by test R=erg@chromium.org Review-Url: https://codereview.chromium.org/2582523003 Cr-Commit-Position: refs/heads/master@{#438882}
-
kainino authored
Even if GL_CHROMIUM_framebuffer_multisample isn't available (such as on Qualcomm), this allows glBindFramebuffer(GL_{DRAW,READ}_FRAMEBUFFER, ...) on ES3 command buffer without throwing GL_INVALID_ENUM. BUG=674357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2576273002 Cr-Commit-Position: refs/heads/master@{#438881}
-
rohitrao authored
BUG=665969 Review-Url: https://codereview.chromium.org/2571383002 Cr-Commit-Position: refs/heads/master@{#438880}
-
corona10 authored
Replace it by GetValueFontColorForRow() BUG=666189 TEST=existing Review-Url: https://codereview.chromium.org/2563863003 Cr-Commit-Position: refs/heads/master@{#438879}
-
lushnikov authored
Thie crrev.com/2570783006 introduced a non-icon-mask class for toolbarButtonGlyphs, which clashed with masked images. This patch eliminates the clash. BUG=674418, 674425 TBR=dgozman NOTRY=true Review-Url: https://codereview.chromium.org/2581753002 Cr-Commit-Position: refs/heads/master@{#438878}
-
jbudorick authored
They should be strings. They were not strings. This fixes https://codereview.chromium.org/2572233003/ BUG=668202 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2579103002 Cr-Commit-Position: refs/heads/master@{#438877}
-
bpastene authored
All incidence of flake that dropped it out of the CQ has been absent for a good few days now. I think it's time to add it back. TBR=tandrii@chromium.org BUG=672382 Review-Url: https://codereview.chromium.org/2583553002 Cr-Commit-Position: refs/heads/master@{#438876}
-
sunyunjia authored
ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() currently doesn't update the touch rects when TouchEvent feature detection is disabled. This could be bad when scrolling with a touch-action:none region. Since we are always firing touch events, we can remove all refs to touchEventFeatureDetection in ScrollingCoordinator. BUG=671232 Review-Url: https://codereview.chromium.org/2582473003 Cr-Commit-Position: refs/heads/master@{#438875}
-
nhiroki authored
API use on the ThreadedWorkletGlobalScope is recorded in parent Document's UseCounter. Note that ThreadedWorkletGlobalScope hasn't been shipped yet and this should not affect use counts in the real world. BUG=667357 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2582483002 Cr-Commit-Position: refs/heads/master@{#438874}
-
qyearsley authored
This path has been removed, so there's no need for the exception now. Related CL: http://crrev.com/606563004 Review-Url: https://codereview.chromium.org/2577553004 Cr-Commit-Position: refs/heads/master@{#438873}
-
wnwen authored
Startup.FirstCommitNavigationTime2 BUG=668726 Review-Url: https://codereview.chromium.org/2559823004 Cr-Commit-Position: refs/heads/master@{#438872}
-
wnwen authored
Caused by caller switching to anonymous functions for deferred startup. BUG=672201 Review-Url: https://codereview.chromium.org/2576213005 Cr-Commit-Position: refs/heads/master@{#438871}
-
mthiesse authored
I originally added the WeakPtrs all over the place so that we could post to the device provider from the GL thread. This CL moves the calls to the UI thread, and removes the WeakPtrs with it. BUG=671302 Review-Url: https://codereview.chromium.org/2570553004 Cr-Commit-Position: refs/heads/master@{#438870}
-
lunalu authored
BUG=662005 Review-Url: https://codereview.chromium.org/2574303002 Cr-Commit-Position: refs/heads/master@{#438869}
-
dvadym authored
BUG=619345 Review-Url: https://codereview.chromium.org/2583493003 Cr-Commit-Position: refs/heads/master@{#438868}
-
pmonette authored
As per Microsoft's recommendation for LoadLibraryEx on MSDN. https://msdn.microsoft.com/en-us/library/windows/desktop/ms684179(v=vs.85).aspx "Use this flag when you want to load a DLL only to extract messages or resources from it." Review-Url: https://codereview.chromium.org/2570563002 Cr-Commit-Position: refs/heads/master@{#438867}
-
kmackay authored
BUG= internal b/27450476 TEST= cast_multizone_backend_unittests Review-Url: https://codereview.chromium.org/2557513002 Cr-Commit-Position: refs/heads/master@{#438866}
-
hs1217.lee authored
remove already fixed items. and change the order as same as specification. spec list: https://drafts.fxtf.org/geometry/#DOMMatrix BUG=388780 Review-Url: https://codereview.chromium.org/2530273003 Cr-Commit-Position: refs/heads/master@{#438865}
-
pmonette authored
Fixes a crash that could happens when closing the Win10 welcome page while the utility process is running. BUG= Review-Url: https://codereview.chromium.org/2581473002 Cr-Commit-Position: refs/heads/master@{#438864}
-
rogerm authored
This CL fixes a number of race conditions on request cancellation and completion. In particular: - Multiple cancellation calls on a request would DCHECK/crash. - A request could be cancelled concurrent to completion, resulting in a DCHECK/crash. - There was an ineffective lock internal to each request. Most of the critical code was already protected (though sometimes not properly) by the managers internal lock and the request lock wasn't adding any value. BUG=672823 Review-Url: https://codereview.chromium.org/2571923002 Cr-Commit-Position: refs/heads/master@{#438863}
-
thomasanderson authored
This CL adds a new script that automates building and uploading new sysroot images. Previously, you had to run UpdatePackageListsAll, BuildSysrootAll, and UploadSysrootAll for each of the 4 sysroot-creators. Then, you had to manually update the revision and sha1sum in install_sysroot.py. Now, simply run build_and_upload.py and your CL should be ready to go. In addition, the script concurrently updates each sysroot image (there are currently 11 of them), greatly reducing the time it took to update the sysroots. In addition to adding the script, this CL also rolls all sysroots. R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2567123002 Cr-Commit-Position: refs/heads/master@{#438862}
-