- 15 Sep, 2020 40 commits
-
-
Yue Li authored
Replace the current language detect API with the FindLanguage API from text classifier. This is the first change of the Translation backend for the Quick Answers. Bug: b/150034512 Test: Manual Test Change-Id: Ie0a53e473b8a378c2692952f350f37b3b2534894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377582 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806902}
-
Peter Kasting authored
While such views are still sized based on their preferred size, this allows marking them as "can flex" or "should be visible" in more cases. In turn this allows FlexLayout to realize that e.g. zero min/unlimited max width Views should have their heights included in parent preferred size calculations. Bug: 1012136 Change-Id: Icd13e1d672701c962e88d9ce55a26a34547fa02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021463 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#806901}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2296e7afd748..06b4fb92c569 2020-09-15 cclao@google.com Vulkan: Fool proof packed attachment index to vulkan and from OpenGL 2020-09-15 jmadill@chromium.org Test Runner: Re-use displays when using "bot mode". 2020-09-14 cclao@google.com Vulkan: Defer glFlush issued in middle of renderpass to endRenderpass 2020-09-14 jmadill@chromium.org Test Runner: Print total test execution time. 2020-09-14 jmadill@chromium.org GN: Componentize "Null" back-end. 2020-09-14 jmadill@chromium.org Add luci-go and mb to DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I59f4b4e46c04db4f4d56dce616509dec76189271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411356Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806900}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d1b7c5ca690c..ac8edb313ce2 2020-09-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea61601349aca2078aec981da9fe72e818ab9d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411365Reviewed-by:
-
Peter Kasting authored
This makes functioning of FlexLayout a bit more uniform by removing a conditional of whether the main axis is bounded. With the addition of SizeBounds and its various methods, very little syntactic change is needed. This will also help when fixing bug 1012136. Bug: 1012136 Change-Id: I0d768bed020c5039ddc326de86aa5b490780c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036638 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Peter Kasting authored
Using a dedicated class for this has the benefits of a type alias along with allowing overloaded math and comparison operators, as well as ToString(). All these together make code using this concept more streamlined and obvious. This will become even more useful when actually fixing bug 1012136. Bug: 1012136 Change-Id: I962edf36e16f5e2ca4e631b64cdd9c4aab2e3395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021295 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Johann authored
If mojo interfaces are bound to a RenderProcessHost then the interface cannot be frozen for a specific Frame. This is problematic for prerendering. Bind them to a RenderFrameHost (via PopulateFrameBinders) instead. BUG=chromium:1126758 Change-Id: I8c6683b45737a8276cb28391532b0e6a036386d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400554 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806896}
-
Yuheng Huang authored
Currently Tab.fav_icon_url conveys a base64 stream of favicon image, which is slow, heavy and not reusable. This CL removes it and the js side can get the favicon from chrome://favicon2. Removing fav_icon_url makes GetProfileTabs() and TabUpdated() API ~6x faster. Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3265887 Bug: 1099917 Change-Id: I4d1361b96a3f5a5b8ee43f77fb50e04b6f958607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406932Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806895}
-
Vladimir Levin authored
Original change's description: > viz: Remove two fields from CompositorRenderPass. > > This patch moves two fields from RenderPassInternal into > AggregatedRenderPass, effectively removing them from CompositorRenderPass > since they are not used there. The fix to the test is to use the aggregated render pass for size comparison, since that's what the test is constructing / testing. R=weiliangc@chromium.org Fixed: 1124768 Change-Id: I414e802629395f739cb9d9f72b706935cf5d0096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392704 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#806894}
-
Hiroshige Hayashizaki authored
Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 https://github.com/web-platform-tests/wpt/pull/24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893}
-
Prashant Nevase authored
Before organizing the dark mode test, we had same tests with different names different in folders like filter-all, filter-none and grayscale. This patch removes duplicate web tests for gradient and image. Bug: 1116914 Change-Id: If36468417c84ed122e0ce612569f7b2f8e8c30e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409879Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#806892}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41974f57973e..0f14b7ab7a55 2020-09-14 amaiorano@google.com CMake: normalize FOLDER property for third_party targets 2020-09-14 bclayton@google.com SpirvShaderDebugger: Add PRINT_EACH_DEFINED_DBG_INSTRUCTION 2020-09-14 bclayton@google.com SpirvShaderDebugger: Implement DebugValue 2020-09-14 bclayton@google.com SpirvShaderDebugger: Reduce lock contention 2020-09-11 capn@google.com Drop the float literal suffix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9f8edc59b88cb30c70fa71e7f444d2827125dc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410883Reviewed-by:
-
Mark Mentovai authored
content_nocompile_tests only works in non-cross builds. See build/nocompile.gni enable_nocompile_tests. For now, all mac-arm64 builds are cross builds where the build host is x86_64 targeting arm64. Removing this test should fix “analyze” step errors such as https://ci.chromium.org/p/chromium/builders/try/mac-arm64-rel/413. Native Client is not a thing on mac-arm64, and will never be a thing. Removing nacl_loader_unittests should fix generate_build_files errors such as https://ci.chromium.org/p/chromium/builders/try/mac-arm64-rel/414. These changes should bring mac-arm64-rel [closer] to a good state. This change was made by editing test_suites.pyl and waterfalls.pyl. chromium.*.json were generated by running testing/buildbot/generate_buildbot_json.py. Change-Id: I8be7c02793262d4e8dcd5f780f6f70fe21c14463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410764 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#806890}
-
Hiroshige Hayashizaki authored
Change-Id: I4044fbf55b82e998433c118fe0b6130ae3842966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409253Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#806889}
-
Alan Cutter authored
This is a follow up CL to https://chromium-review.googlesource.com/c/chromium/src/+/2392168. Background: The above CL fixes a bug that caused bookmark app -> BMO migration to set the user_display_mode to kBrowser for non locally installed apps. The bug fix unfortunately doesn't fix the effects of that bug for users that ran the migration code bug. Change: This CL specifically looks for users affected by the bug (where their bookmark app is set to open in a window while the BMO app is set to open in a tab) and re-migrates their bookmark app user_display_mode. Known issues: - If the user sets their user_display_mode to open in browser tab after migration and before the clean up runs it will be reverted back to window (this is indistinguishable from the migration bug but should be rare). - This won't run for users with sync disabled (though they are unlikely to have this bug as sync is required to have non-locally installed bookmark apps). Bug: 1127128 Change-Id: I4268fbf450760b0ef1403be209d1983fd83a8b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391704 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#806888}
-
Felipe Erias authored
Implementation of "force" for the scrollbar-gutter CSS property. This keyword forces a gutter on a non-scrollable element, so it can be accurately aligned with nearby scrollable areas (e.g. when implementing a header). css_properties.json5: scrollbar-gutter becomes non-inheritable, as otherwise the children inside a "force" element would also get gutters of their own, messing up the layout. This matches the current editor's draft: https://drafts.csswg.org/css-overflow-4/#scrollbar-gutter-property paint_layer: Assign a scrollable area to "force" elements, in order to calculate the size of scrollbar gutters. layout_box: Assign a layer to "force" elements. Take "force" into account when checking for scrollbar gutters. ScrollWidth and ScrollHeight defer to the scrollable area for "force" elements. Updated and expanded the scrollbar-gutter tests. Bug: 710214 Change-Id: Iea25ded4b7b635edeb513a93e30645326eb051e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404233Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Cr-Commit-Position: refs/heads/master@{#806887}
-
Gavin Williams authored
Add the printer status icon to the destination dialog to show the status of local CrOS printers. Bug: 1123754 Change-Id: Ie4012183b9815a5eac906b5379e30e17a78fc071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406381 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806886}
-
Ian Clelland authored
The use of commas as separators in the iframe allow attribute is not allowed, according to the specification, but it was previously parsed, as it can appear in HTTP headers. This CL adds a deprecation message, and is the first step towards removing this. Blink intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/43EhaSQWm6M/iqvQ3hY0AwAJ Bug: 1062400 Change-Id: I2efff7c9610ca7b85145a7600d1c0074ad2e30be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313298Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#806885}
-
Xiaohui Chen authored
* Moved `GlanceableInfoView` to `AmbientBackgroundImageView` together with the photo attribution so they can be moved together. * Move glanceable info views in small steps on each refresh with in a fixed bounds. * Fixed the spaceing to account for shadows. * Fixed typo in metadata setup. * Fixed dismiss event handling to include touch events. Bug: b:162596816 Test: run existing unit tests and manual test. Change-Id: If96d83b1541cc301c881e07ce987ef7eb78794ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410532Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806884}
-
manukh authored
Search suggestions are grouped above URL suggestions regardless of relevance scores. There are a some exceptions e.g. default match. After grouping, this CL, bubbles URLs back above search suggestions if 2 conditions are met: 1) There must be a sufficient score gap between the adjacent searches. E.g. for (S1, U1, S2), the difference in scores of S1 and S2 must be larger than some threshold. 2) There must be a sufficient buffer between the URL and search scores. This only applies to the first URL suggestion in a series. E.g. for (S1, U1, U2, S2, U3, S3), U1 & U3 must score higher than S2 + threshold & S3 + threshold respectively, but U2 need only score higher than S2. The intention is to allow good URLs to rank above relatively bad searches while maintaining some propensity to group URLs and searches into clusters. These changes are behind a 'OmniboxBubbleUrlSuggestions' feature with 4 params: - OmniboxBubbleUrlSuggestionsAbsoluteGap - OmniboxBubbleUrlSuggestionsRelativeGap - OmniboxBubbleUrlSuggestionsAbsoluteBuffer - OmniboxBubbleUrlSuggestionsRelativeBuffer And chrome://flags flag 'omnibox-bubble-url-suggestions'. Bug: 1127125 Change-Id: I43662284537e9a89ab19b7bab040f8a6ad996e2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404753Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806883}
-
rbpotter authored
- Hide and disable the sidenav in annotation mode. - Fix a timing issue, where the annotations bar would briefly appear when the annotation mode was toggled before disappearing and then re-appearing when the ink controller finished loading. - Fix a positioning issue in which the document scrolled slightly when changing between annotation mode and the plugin. - With the third fix above, positioning is much closer to expectations in the annotations feature enabled test. Verified that scrolling/zoom seems correct now, and updated the mismatched expectation for the case of the update being enabled as recommended by the test's original author. Bug: 1124183 Change-Id: I8f9357d883088e31fc8882f3359e662685978de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405539 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#806882}
-
Kyle Horimoto authored
Bug: 1045266 Change-Id: I2826792dc171aeeb8cfb338b384ccf1c8e0d8785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411469 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#806881}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/295570eb332d..7703f23b60c4 2020-09-14 sprang@webrtc.org Adds ability to delay pacer start until media is added. 2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e645bb4c..b0398ace (806687:806731) 2020-09-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ff96bd07..e645bb4c (806570:806687) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6428a490939359802e029f051dc38915650441c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411352Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b71187bf99c5..0547fb291708 2020-09-15 vadimsh@chromium.org [lucicfg] Update to v1.18.7. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Iae1210e1783ed308ec024d850bb5621958e678a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410286Reviewed-by:
-
kylechar authored
The GPU process mojo error handler would cache the error string for 5 seconds and if a specific crash was triggered the error string would be put in a crash key. This produced some unexpected error strings, see https://crbug.com/1075495#c32, for deserialization errors on viz.mojom.CompositorFrameSink interface between browser and GPU. Change the error handler to immediately DumpWithoutCrashing() so we get a stack trace during deserialization. Hopefully the stack trace will provide some better clues as to what went wrong. Bug: 1075495 Change-Id: Iaa9d6c0cddb43132603c5c0fffc1e9a76c745631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405413Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806878}
-
Clark DuVall authored
Unfortunately, there are bugs with resources in splits when the base module has shared_resources=true. To get around this for now, all WebLayer resources are moved to the base module. A new option was added to the android_resources() template which allows pulling all resource deps from java targets, which allows easily pulling out all resources that would be used in the WebLayer split. Bug: 1105096 Change-Id: I65f58d68014e44f26081da134d54d7425b42970b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404392 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#806877}
-
Adam Rice authored
This reverts commit b0398ace. Reason for revert: Suspected of causing MSAN test failures: https://crbug.com/1128203 Original change's description: > [Autofill] Update Sync Bridge to save instrument_id > > Please see bug for design doc. > > Bug: 1121806 > Change-Id: I9c67bc3487a64eb1b07b4d0334a63081f85c66fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404947 > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Anne Lim <annelim@google.com> > Cr-Commit-Position: refs/heads/master@{#806731} TBR=battre@chromium.org,treib@chromium.org,jsaul@google.com,annelim@google.com Change-Id: I9bcb174ab83c92b9eeb242670afa4c085b827cb7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121806, 1128203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409737Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#806876}
-
Gayane Petrosyan authored
Connect selector generation in renderer to Android frontend using mojom interfaces. This CL add producer interface implemented in the renderer. When user selects a text, in the renderer side along with saving the selection frame and range, TextFragmentSelectorGenerator is registered for the producer interface and bound when user chooses 'Link to Text'. See https://screenshot.googleplex.com/0kb39qFn6JP.png for user flow. Bug: 1102382 Change-Id: I4152b07d3058d4109f3919f285b46b9b2dd82f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341662Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/02fad13e1950..d1b7c5ca690c 2020-09-14 tmathmeyer@chromium.org Fix accessibility issue with Media timeline view dark mode font color 2020-09-14 patrick.brosset@microsoft.com Grid: Avoid protocol errors when scrolling to grid containers 2020-09-14 tvanderlippe@chromium.org Load sources_test_runner as module 2020-09-14 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewCompletedView.js with TypeScript 2020-09-14 tvanderlippe@chromium.org Load security_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load sdk_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load performance_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load network_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load lighthouse_test_runner as module 2020-09-14 jacktfranklin@chromium.org Make it.repeat also do it.only 2020-09-14 tvanderlippe@chromium.org Load layers_test_runner as module 2020-09-14 tvanderlippe@chromium.org Remove unused fetches for module.json files 2020-09-14 tvanderlippe@chromium.org Load i18n as module 2020-09-14 tvanderlippe@chromium.org Add unittests for Root.Runtime.Module.substituteURL 2020-09-14 tvanderlippe@chromium.org Load heap_profiler_test_runner as module 2020-09-14 patrick.brosset@microsoft.com Grid: Use better colors for the grid overlays 2020-09-14 tvanderlippe@chromium.org Load extensions_test_runner as module 2020-09-14 jacktfranklin@chromium.org Add timeout to Heap snapshot tests 2020-09-14 tvanderlippe@chromium.org Load elements_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load device_mode_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load data_grid_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load cpu_profiler_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load coverage_test_runner as module 2020-09-14 tvanderlippe@chromium.org Load console_test_runner as module 2020-09-14 tvanderlippe@chromium.org Run `depot_tools` canned checks after Devtools checks in PRESUBMIT 2020-09-14 tvanderlippe@chromium.org Load bindings_test_runner as module 2020-09-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-14 tvanderlippe@chromium.org Load axe_core_test_runner as module 2020-09-14 changhaohan@chromium.org Commonize debouncer and debounce updateStyleAdorners 2020-09-14 patrick.brosset@microsoft.com Fix unreachable nodes in Elements pane when scrolled horizontally If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1105476,chromium:1109177,chromium:1110817,chromium:1123052,chromium:1126334,chromium:1126388,chromium:880265 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I71c7b4f942bce64de934fde0928a766af0d910b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410452Reviewed-by:
-
Ryan Hansberry authored
Implement BleMedium::StartAdvertising() and BleMedium::StopAdvertising(). This requires adding a bluetooth::mojom::Adapter::RegisterAdvertisement() method and a new bluetooth::mojom::Advertisement interface. See go/nearby-chrome-bt for more details. Bug: 154845685 Change-Id: Ie5b65fe11702676e29558faf7d021daefc03b15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378765 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#806873}
-
Jose Magana authored
For review with: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/3268904 Bug: b:156979639, chromium:1094203 Change-Id: I569ea223107ac93a235fa7fe9fa25adb6656a444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407999Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Jose Magana <jomag@chromium.org> Commit-Queue: Jose Magana <jomag@chromium.org> Cr-Commit-Position: refs/heads/master@{#806872}
-
Maggie Cai authored
This CL adds the drive action vector icon. This icon is created from material design icon person_add.svg, this is the same icon used in files app for the drive share. BUG=1097623 Change-Id: Ic92d505befcbae3d77869e34c78c53c3da956021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404232Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806871}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44c9ca6a2c0e..a0ee89a93f64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1039881,chromium:1040645,chromium:1045256,chromium:1085419,chromium:1099917,chromium:1103401,chromium:1109276,chromium:1113470,chromium:1122784,chromium:1124063,chromium:1124803,chromium:1124873,chromium:1126022,chromium:1127172,chromium:1127514,chromium:1127557,chromium:1128141,chromium:903249,chromium:912681 Tbr: ricea@google.com Change-Id: I36a95737a3576d7ef47d19ed5774b524ec1f0a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806870}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b0245494c615..2bc4077c9e42 2020-09-14 mtklein@google.com notes on bazel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I6313994ce8274a07e12691b0cf7529b4a0fe6c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411355Reviewed-by:
-
Peter Beverloo authored
Bug: 1127634 Change-Id: Ia89c7e2a94d7cdae623d538505180f0883137908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410065 Auto-Submit: Peter Beverloo <peter@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I89d228905dd8f307bd9452d2c06cd78f7aaab34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411569Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806867}
-
nancylingwang authored
This CL adds 2 test cases for loading extension app icon and loading web app generated icon. BUG=1083331 Change-Id: I631156c81ba58e3d60a0e9004af23e78d53e218f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407415Reviewed-by:
-
Bo Majewski authored
This is a reland of 4ccb6508 http://crrev.com/c/2367397 and this CL were prepared without the authors being aware of each other's efforts. Timeline for 2367397: Sep 10, 2020, 6:06:39AM UTC+10 it is submitted to CQ Sep 10, 2020, 9:01:21AM UTC+10 it is successfully submitted Timeline for 2402560 Sep 10, 2020, 10:46:31AM UTC+10 dry run is successfully completed Sep 10, 2020, 12:19:23PM UTC+10 it is submitted to CQ Sep 10, 2020, 12:23:56PM UTC+10 it is successfully submitted Original change's description: > Files SWA: Moving to a new directory. > > Bug: 1111229 > Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Bo Majewski <majewski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805598} Bug: 1111229 Change-Id: I8894da793702136d5e394b9854993026603c311d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402560 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
David Tseng authored
R=anastasi@google.com, dmazzoni@chromium.org AX-Relnotes: n/a Fixed: 1126707 Change-Id: I812918d101fba188b7c6f488bb9658b571fe612b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410347 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#806864}
-
Andrew Grieve authored
This reverts commit edc1346f. Reason for reland: Created dummy target for downstream. Original change's description: > Revert "Remove unused androidx-legacy libraries" > > This reverts commit 9d53cbf3. > > Reason for revert: https://crbug.com/1122225 (build errors for downstream checkouts) > > Original change's description: > > Remove unused androidx-legacy libraries > > > > As far as I can tell these were never used... > > > > Bug: 1121713 > > Change-Id: Ie81d7bfa72e40b48a775442684aae025a55259f4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376125 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: benjamin joyce <bjoyce@chromium.org> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: benjamin joyce <bjoyce@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801973} > > TBR=agrieve@chromium.org,bjoyce@chromium.org > > Change-Id: I745e025f674b51f012fa138d5abd760444ded1c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1121713 > Fixed: 1122225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378736 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802001} Bug: 1121713 Change-Id: Ie87069f2d913beb056c203bd0e38d358772a37fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405998 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#806863}
-
