- 05 Oct, 2020 40 commits
-
-
Morten Stenshorne authored
We got it wrong when there was overflow. Use WritingModeConverter. Bug: 829028 Change-Id: Idf060c3417f254f414251a9e3287a3c8f5c6cd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450315Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813898}
-
Adam Langley authored
In order to make things more easily extendable in the future, make the contents of the caBLEv2 QR codes be a CBOR map. This should eliminate the need to version-switch based on a URL prefix, so drop the "/c1/" from the URL. BUG=1002262 Change-Id: Id05a38c8ba510f673594774e57d418f8259779f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444174 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#813897}
-
Eric Orth authored
These were never true timeouts but merely the period of time after querying a resolver before we would try another server or retry. The original query would keep going. Renaming these to avoid confusing myself as I add more logic for transaction timeouts (that actually will be timeouts for the overall transaction). Bug: 1109792 Change-Id: Icafcce30c5250a9164cd8b779a8ddf1b9fdbfbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446526Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813896}
-
Becca Hughes authored
This reverts commit 55c1d6cd. Reason for revert: Broke official builds https://crbug.com/1135285 Original change's description: > WebUI: Replace uglify-es with terser. > > The former is deprecated and no longer receives any updates. > > Bug: 1087970 > Change-Id: I15cb6beb49eb55fb7fa7489459d7072ba8e2f66c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444486 > Reviewed-by: John Lee <johntlee@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813856} TBR=thestig@chromium.org,dpapad@chromium.org,johntlee@chromium.org Change-Id: Ifd82789f8e17dd5c19ee894fa99f08278ed5be29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450840Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813895}
-
Mason Freed authored
This CL removes the Web Components V0 APIs (Shadow DOM v0, Custom Elements v0, and HTML Imports) from the web platform. The features are still available for use by limited internal code directly, for a limited additional period. See crbug.com/1111843 for reference. These features were deprecated in August, 2018, in [1], and removed by default in Chromium M80, in [2] and [3]. For those sites that needed additional time, there was then a "deprecation extension" [4] (sometimes called a "reverse origin trial") that allowed sites to continue using these APIs through M87. Now that M87 has branched to Beta, the origin trial has now ended. These public APIs are now disabled for all sites. With this CL, several test suites are being skipped in TestExpectations, including several folders that have been prepared in advance: crbug.com/1081941 web-components-v0-only/* [ Skip ] crbug.com/1081941 virtual/web-components-v0-disabled/* [ Skip ] crbug.com/1081941 http/tests/htmlimports/* [ Skip ] Once this CL has landed and stabilized, these folders/tests will be deleted entirely. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1850795 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1869562 [4] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 Bug: 911943, 1111843 Change-Id: Ia7bde5af655eba43538d18ce1335ed3e72846503 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195005Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#813894}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601877511-e7db431e3df4886bdee72d3fd137fde2437674f5.profdata to chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id226d83f51577d75a58974891e99401acd083b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813893}
-
Morten Stenshorne authored
A column spanner forcefully breaks a column, so any leading margins on content right after the spanner shouldn't be discarded. Bug: 829028 Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I178fab3f54a6fcf52ac41f6642c5d6b02f1408de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442889Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813891}
-
Anupam Snigdha authored
Clamped the values in |ConvertRectToScreen| to avoid integer overflow while calculating the width/height of the rectangle. Bug: 1134463 Change-Id: Ic53a8513be7393b0e58ee9d3b2019a0b71c9d703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450920Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#813890}
-
Darwin Huang authored
The proportion of content script reads without user activation will inform potential deprecation plan and messaging. Bug: 1051198 Change-Id: Ie9c76a6d26ee78219729ef54da7237eb061c98f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440116Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813889}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_koR1dg8Vvu Also the host pool also has plenty of rooms: http://shortn/_xqhW5Z67ft Bug: 997376, 1127110 Change-Id: I56b432d960c2f1821934667ac2f38d3fcb4705bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450331Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813888}
-
Jeffrey Young authored
BUG=1103703 Change-Id: I1505384aadc98eea6e0dab4ecf51b2cd0a045e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440292Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813887}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/256b2c258767..c9e3d3e3a7e0 2020-10-05 pfaffe@chromium.org Implement support for the JavaScript formatter API 2020-10-05 sigurds@chromium.org Prepare for removal of isScrolledToBottom from Element's prototype 2020-10-05 tvanderlippe@chromium.org Typecheck sources/SourcesView.js with TypeScript 2020-10-05 bmeurer@chromium.org Fix accidentally inversed experiment. 2020-10-05 yangguo@chromium.org [ts] Type-check har_importer/HARFormat.js with TypeScript 2020-10-05 bmeurer@chromium.org [ts] Type-check worker_main/WorkerMain.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1128416,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b23e31a76d9a4b3034134e9c0af2c18392668a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450869Reviewed-by:
-
Yu Han authored
Updates eye dropper icon for dark mode based on spec. Bug: 1125025 Change-Id: I13f8be7d4195b5ed24f781376b666668aca87c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445050Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813885}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6413f6158daede8769353c367510f44be07f7645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450725Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813884}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ef897a9c3ec2..34445b29ae40 2020-10-05 cnorthrop@google.com FrameCapture: More fixes for app updates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Temple Run on multiple systems Change-Id: Id6000228a4b1d7c92858f5ddda0c6d6f67d1240b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448686 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Daniel Rubery authored
This metric is useful for monitoring as we work on visual features for detecting phishing. Fixed: 1089244 Change-Id: I52dc7744f3b4df1e5755f5166f2d9eac06e87b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450696 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#813882}
-
Jeff Yoon authored
These bots are specified to run on os Mac 10.14. This change adds |Mac-10.15 such that when these bots are upgraded, the bots don't fail. Bug: 1135264 Change-Id: If5e64412821f2e87815cb15d0364e5e640d6dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450741Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813881}
-
Xianzhu Wang authored
Previously we always baked transform origin into transform for SVG transforms in paint properties. However, when there is composited SVG transform animation, the compositor animates the transform part only, so we need to store transform origin separately in paint properties. Also disable SVG compositing when there is SMIL animation which is not supported by the compositor. Bug: 1133718 Change-Id: Icd2cf67e3952a9006ff2d74fb798a058db96a433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441386 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#813880}
-
Xinghui Lu authored
Implement OpenEnhancedProtectionSettings() in controller_client. Create an interface named settings_page_helper at component/ level and an implementation class named chrome_settings_page_helper at chrome/ level. The interface is injected to controller_client. Add Safe Browsing enhanced protection page in chrome_pages. The URL path is "security?q=enhanced". During navigation, it opens "chrome://settings/security" and expands the enhanced protection section. Bug: 1130721 Change-Id: I27b9b938d47c8ea4caed2b4da6e9b374086366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429440 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813879}
-
George Burgess IV authored
CrOS builders are complaining about broken flags like: `-mllvm ,-enable-dse-memoryssa=false` We should probably be dropping that `,`. This CL makes us do that. Bug: 1135234 Change-Id: I3f99498003282d8e737d3d066bc7e2e257f65dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450743Reviewed-by:
Bob Haarman <inglorion@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#813878}
-
Moe Ahmadi authored
Fixed: 1134606 Change-Id: I6e640d0680a0e737dfabcdae6b9c3e96acaa58a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446014 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813877}
-
Kartik Hegde authored
Swap the args in the function. TEST=unit_tests --gtest_filter=HttpFirewallRoutineTest* BUG=chromium:956783 Change-Id: Iffebb35c0e2971bb64d27e694e1d4412a6125268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450575Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#813876}
-
Chong Gu authored
Move hash file related functions to generic_x64_target.py. Fix wrong references to changed variable names. Ensure that exceptions don't get suppressed when target exits. Change-Id: Iba4acecd3681e1b200c5a70e501f8cf00a1b1db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416838 Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#813875}
-
Alexander Surkov authored
Create new location for accessibility tree formatters and event recorders in ui/accessibility/platform/inspect, which is appropriate place for code used project wide. Bug: 1133330 Change-Id: Iaa6918e9af1041044ae7e9c21be19e9529d09b7e AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438591Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#813874}
-
David Black authored
Previously we only handled opening files. Now, we'll check metadata and if the holding space item is backed by a directory, open it as a folder. Otherwise we'll continue opening as a file. Bug: 1134400 Change-Id: I122f52df2f39e705abcb44af1bd8e4230b8f4626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447034Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#813873}
-
Joe Mason authored
This object will create a memory request for a single renderer process and send it immediately. The renderer will perform the request at the next GC as specified by the measurement mode. This implementation actually sends memory requests to all renderers and ignores responses from the unininteresting ones. A followup will only send the request to the given renderer process. Also updates ExpectBindAndRespondToQuery to test the process ID with gmock matchers instead of DCHECK, so that it can be called multiple times with different process ID's in the same test. R=chrisha, ulan Bug: 1080672 Change-Id: Icba4b66f60bd32b86ea7786441aa84559395b570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430063 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813872}
-
Albert Chaulk authored
Test: loaded webview on device in incognito context Bug: b/167428704 Change-Id: If327a22657fe0e9b989df7cd3bdb8fe8e97a0143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388886Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#813871}
-
Austin Eng authored
This makes previously broken ref tests on Win crash the GPU process instead, though the tests still render to the canvas correctly when run. This same crash already exists on Linux before this patch, but the crash isn't reported by the harness. This is likely a pre-existing issue in Chrome where Dawn SharedImages don't work with the screenshots. In general, canvas readback for WebGPU is currently unimplemented. Bug: 976495, 1083478 Change-Id: I345151bd6ce38fc00e52c1efd12bddb8a425e283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438893 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813870}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04482985b204..9f0c89bd5660 2020-10-05 terelius@webrtc.org Allow RTCP packets longer than 1500 bytes in RTC event log. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134107 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0931871d91b0e306e3f63bd910d2f30c60171f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450851Reviewed-by:
-
Hidehiko Abe authored
Currently OS_LINUX is defined in Chrome OS build, but it will be unset. This CL is the preparation to keep the current behavior. Bug: 1110266 Test: Built locally. Change-Id: I4dd508f10e28438632c98a5b8692d5fbdc04b388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449870Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#813868}
-
Rouslan Solomakhin authored
Before this patch, macOS browser test for loading and removing iframe with many payment requests sometimes timed out because the test created 4096 instances of PaymentRequest. This patch reduces the number of PaymentRequest objects by 75% to 1024. After this patch, macOS browser test for loading and removing iframe with many payment requests should not timeout. Bug: 1129573 Change-Id: Ibca3c55d68285edc85fb712337847951bba71aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443937Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813867}
-
David Bienvenu authored
Change-Id: I18d23eb64d576ea1e9ff443f2de7b9c0c03da81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448664 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#813866}
-
Bo Liu authored
Hopefully getting the stack and some info of of when a !normal_termination and kInvalidSigno happens will be helpful to pin down the cause. Bug: 1115216 Change-Id: I4bda59c1e27782e7688d1594c8af6efba6c1c9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448058Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813865}
-
Tom Anderson authored
base::FileDescriptorWatcher is not usable on the main thread because it is initialized as a UI thread, when an IO thread is required. Since it's a UI thread, it's able to dispatch events already without special FD watching. All that's required is creating an X11EventSource. This CL creates the event source where necessary so that KeyboardLayoutMonitorLinux can dispatch events. R=lambroslambrou CC=rkjnsn@chromium.org Fixes: 1133481 Change-Id: I6e0a380c7c1168c4b1515be10ec34e67d0ae0d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444530 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#813864}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/88d84cce..8c063270 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfa04c4a4b77cccab7f25faaf89e2b5957c7c994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449933Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813863}
-
Brandon Wylie authored
Better alignment with the requirements (delete everything when a user deletes history in a time range) could eliminate the crashes seen in the linked bug. Bug: 1133268 Change-Id: I35690a4c70a9447949467731e67f163fa6acbae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439636 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813862}
-
Nick Harper authored
Bug: 1131222 Change-Id: I874d4b99c888c7ebbf7a7830836ee02441962f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446019Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#813861}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I50663e97b9957e7dfcf326563810fd92cc9e4ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450853Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1134761 Change-Id: Ie2252ac8e57ef0dd2c71d1de523e2f67c58e9a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446527Reviewed-by:
-
