- 12 Mar, 2020 40 commits
-
-
Evan Stade authored
Bug: 1007826 Change-Id: I02f9967855e44023c98ad38db5206431d26348c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098846Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#749462}
-
Evan Stade authored
Bug: 1007803 Change-Id: I4a806da7af7db8d13b91b1700882cc751130b24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098497 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#749461}
-
dalyk authored
This cl adds Net.DNS.DnsConfig.SecureDnsMode and Net.DNS.DnsTransaction.Secure.[FailureError,FailureTime,SuccessTime]. Bug: 1037944 Change-Id: Id76c1040e6fade6f53adaeab990f97ef4332d737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094456Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#749460}
-
Peter Wen authored
Bug: None Change-Id: If581f3d86f151d3ab4004b736a7c9092375a23d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098587 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749459}
-
Klaus Weidner authored
As suggested in https://github.com/immersive-web/dom-overlays/issues/20#issuecomment-596816355 This ensures that top layer elements act as a containing block for "position: fixed" descendants. Bug: 1060731 Change-Id: Id5bedac6ecde75a11d83442c025c0bd1da4e1cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098178Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#749458}
-
Kent Tamura authored
Also, this CL makes SelectType::UpdateMultiSelectFocus() a private function of ListBoxSelectType. Only ListBoxSelectType needs it. This CL has no behavior changes. Bug: 1052232 Change-Id: Idc6a86adc0ad9cd4c8d51caa51a2d58251f9e254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098138 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749457}
-
Orin Jaworski authored
This adds a test in components_unittests for OmniboxPopupModel::StepSelection, testing the various step directions and step behaviors. Bug: 1046523 Change-Id: I9d5bd89017e3f7ff5c7f5efa10e19e6e3ab72dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096019 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#749456}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fa0f8538. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I32b578367cda17aff4751c688b0070187b6e5cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098405Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749455}
-
Esmael El-Moslimany authored
Screenshots https://crbug.com/1054808#c6. Bug: 1054808 Change-Id: Ib7888e7356fd47d3814302aa48658376e2b2a559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095931 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749454}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79bf811d23f5..de29e8343a24 git log 79bf811d23f5..de29e8343a24 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 primiano@google.com Docs: fix long-traces.md Created with: gclient setdep -r src/third_party/perfetto@de29e8343a24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0ca04c949840502aab14cc49563838f22d40b58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099184Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749453}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94a9b0c7684f..21996bda4c52 git log 94a9b0c7684f..21996bda4c52 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 michael.liao@microsoft.com [Coverage]: fix for focus bug when clicking the reload/start recording button Created with: gclient setdep -r src/third_party/devtools-frontend/src@21996bda4c52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c5143141a1456bc1ab67ee8618e3aa5593db597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099517Reviewed-by:
-
Joshua Peraza authored
7500e2ef452a linux: add fallback-modes for memfd_create e1b3bd11cd08 Add support for Hygon Dhyana CPU 42da41d24a21 Targets iPhone 8 when running tests 209124197145 Roll crashpad/third_party/mini_chromium/mini_chromium/ f8f1182ad..c426ff98e (3 commits) b109e4ce3897 [ios] Bring up first draft process and module snapshot 1d75af9bf591 Fix bad iOS module casting Change-Id: I1f447aeefeb1769bb9d56bcc7339b3e5794544af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099300 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#749451}
-
Matthew Mourgos authored
Change-Id: I1c33a6161b91f17a924efd92e5efceb034cbceb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092907Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#749450}
-
Adam Langley authored
Logging tags should be, at most, 20 characters. BUG=1002262 Change-Id: I9f73e2656df2374c5fe70e1fe442291d5b64f7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099235 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#749449}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/dad31a0aa440..84bd9713ed32 git log dad31a0aa440..84bd9713ed32 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Discovery: Fuzz Tests 2020-03-11 rwkeane@google.com mDNS: Fix MdnsSender UTs 2020-03-11 miu@chromium.org Cast Streaming Standalone Sender (2 of 3): StreamingOpusEncoder Created with: gclient setdep -r src/third_party/openscreen/src@84bd9713ed32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: If04320dca87aa85ec1403e0267f58da894a266e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099515Reviewed-by:
-
Nathan Zabriskie authored
In order to transition Canvas2D to OOP-Rasterization (crbug.com/1018894) we need to remove references to ContextGL on the SharedMainThreadContext. This CL begins that transition by replacing viz::ContextProvider with viz::RasterContextProvider throughout the class and calling the appropriate functions on RasterInterface. A follow up CL will be required to fully remove references to ContextGL once Skia is no longer used in the client process to copy/translate video frames. Bug: 1023270 Change-Id: I7a37aa18d75119a46b1f2c804b7d65ecf08bc98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083746Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#749447}
-
rbpotter authored
Bug: 1026426 Change-Id: Id2e3fd7330fe5c4651fc1853261217e56f61df05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099026Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#749446}
-
John Lee authored
https://imgur.com/a/KpWnPGN Change-Id: I9783df88d5270d7fbe6d4913573834ff52c55439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098983Reviewed-by:
-
Ben Pastene authored
The amd64-generic CQ and CI bot looks good after crrev.com/c/2088508. Should be safe to roll out to the remaining builders. Bug: 937821 Change-Id: Ic1ba5f2afbbcb341c8c21172332df79025e3d8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097516 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#749444}
-
Sadrul Habib Chowdhury authored
Report throughput metrics for scrolls initiated by the scrollbar. BUG=1060717 Change-Id: I2cbb002c60317f07de2858f937ec222ec0290712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097528 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#749443}
-
Caleb Rouleau authored
Add new Chromium committers who understand perf waterfall to own perf waterfall buildbot configuration file. Nominate Brian Sheedy as an overall OWNER. Remove ex-team member from OWNERS. R=bsheedy@chromium.org, hypan@google.com, wenbinzhang@google.com Change-Id: I0bfb3c3a86a22f1beeed5eddb561ef37c69c0d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099286Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I56abba32a3261769a089304340a3773bef24c551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099465Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749441}
-
Xi Han authored
Bug: 1041865 Change-Id: I7c91404d922f12dae22f42fbc71be31b2949f307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098765 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749440}
-
sreejakshetty@chromium.org authored
Update the implementation of RenderFrameHost::IsCurrent() to also check recursively for current RenderFrameHost and all parents if it is the current RenderFrameHost in its FrameTreeNode. More specifically, changing the meaning of IsCurrent from "current in the FrameTreeNode" to "current in their FrameTreeNodes for its RFH and its parents". The major problem with the current implementation is that during a navigation, new RenderFrameHost replaces the old one in its FrameTreeNode but the children are still the current ones within their FrameTreeNode as we keep the RFH alive for sometime after commit. In particular, after a navigation from A(B) to C, only A.IsCurrent() becomes false. B.IsCurrent() still remains true. With the current update now both A.IsCurrent() and B.IsCurrent() would return false which is the expected behaviour. BUG=1058984 Change-Id: I3c22e3e512021c8ca2e8ccc7eed66075700bb632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060374 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749439}
-
Malay Keshav authored
This patch clips the accumulated damage from a render surface to its bounds. This is needed for scrollable layers within the render surface that can have bounds much larger than their render target thus indirectly contributing to the damage rect of their render target's render target. It also removes the expansion of the damage rect based on background blur filter. This is okay because the background blur is computed within the bounds of the render surface. Test=Manually ran chrome os to check for ui glitches. Bug: 1056014 Change-Id: I942aae3452250540fa283403894078f68630dff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075962Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#749438}
-
Hiroshi Ichikawa authored
I have sent a heads up to the team about this change. Change-Id: If1dca2ebd3e5289edb969eb03394a44ca7eb0776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094387Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#749437}
-
Danan S authored
These changes are required in order to prompt a child user to get parent permission when they attempt to install an extension in the Chrome Webstore. This CL also enables the feature by default. Bug: 957832 Change-Id: I3a2011b418e31dd491fd35e37d976b492eef197b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079620 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749436}
-
shrekshao authored
* Fix 3D texture validation for ASTC with HDR * Fix unexpected INVALID_ENUM after allocating immutable 2D compressed texture array by * Return GL_UNSIGNED_BYTE instead of GL_NONE for compressed formats * Add missing ASTC cases in ExtractFormatFromStorageFormat * Add a separate ClearCompressedTextureLevel3D (equivalent of ClearCompressedTextureLevel for 2D cases) path * Immutable texStorage3D for ASTC (https://github.com/KhronosGroup/WebGL/commit/400f9eec05af2220191e00fc80b5e38bb6fad0df#diff-d6f2beefa62a7933bb6f5bef338681eaR2318) is still failing at driver level on test device (Pixel 3 XL) This will be handled in a new bug ticket, more details are listed there: (http://crbug.com/1060012) Bug: 1051217, 1049880 Change-Id: I0dab58b1abd8173077f31447125b499ddf2935fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086318Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#749435}
-
Michael Cui authored
This CL adds all the OOBE screens to OOBE.StepCompletionTime since the last update (https://crrev.com/c/1707491). Change-Id: Idafac4e9e836c0071524fecb8cbe8bdb54137bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094074Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#749434}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/71d8ec363794..2990167ccdca git log 71d8ec363794..2990167ccdca --date=short --first-parent --format='%ad %ae %s' 2020-03-11 bsheedy@chromium.org [Telemetry] Don't hard-code temporary CrOS env file 2020-03-11 bsheedy@chromium.org [Telemetry] Fix minidump pulling on L- Created with: gclient setdep -r src/third_party/catapult@2990167ccdca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056235,chromium:1059426 Tbr: eseckler@google.com Change-Id: I1b60716a4860e1c5f6ffcc273cdda8c855b684ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099308Reviewed-by:
-
Sorin Jianu authored
This allows debugging the updater engine without the hassles of dealing with the client-server(service) RPC multiprocess model. Consider implementing the mode for macOS too, if it is valuable. Run updater --single-process to enter this mode. Bug: 1060800 Change-Id: I63c198e1af454ec885b7248ec86d935351e79bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099603Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749432}
-
Adam Langley authored
This change causes the camera preview in the QR-scanning dialog to be rotated correctly. It also moves opening the camera (which is a slow operation) off the UI thread, thus keeping StrictMode happy. BUG=1002262 Change-Id: I9a7ae2ead10703fee38764a0c8f76597ef6212cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097302 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d52eddaad2fb..4c7c4b4bc6e8 git log d52eddaad2fb..4c7c4b4bc6e8 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-03-11 ehmaldonado@google.com gclient: Fix auto-fetching refs. Created with: gclient setdep -r src/third_party/depot_tools@4c7c4b4bc6e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6ca6180048982ba64af759d8d5f5abac55356b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099309Reviewed-by:
-
John Chen authored
When a WebView is in use, lock all its parents, to avoid dangling WebView. Bug: chromedriver:3383 Change-Id: I3503e35922c45d7d9b1b244877486512d16124bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099583Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749429}
-
Sergey Ulanov authored
Now WebEngine implements SetPermissionState() which allows to grant permissions for web features. Bug: 922833 Change-Id: I356e54646ad870bb7882a5b9a95bc87deccba453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058086 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#749428}
-
Tsuyoshi Horo authored
This CL introduces WebContents::GenerateWebBundle() method. This method does the following: - Call GetResourceSnapshotForWebBundle() for each frame (the main frame and sub frames) to get an array of mojo::PendingRemote<ResourceSnapshotForWebBundle>. - Open a file to write to. - Call DataDecoderService::BindWebBundler() to get a mojo::Remote<WebBundler>. A WebBundler object is instantiated in the data decoder process. - Call WebBundler::Generate() with the opened file and the array of mojo::PendingRemote<ResourceSnapshotForWebBundle>. This CL doesn’t implement the logic of WebBundler::Generate(). This method just returns an error (kNotImplemented). Bug: 1040752 Change-Id: Ia0a8ba0362cea181dcfd67bda9d42ebc00f9a4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084042Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749427}
-
Kenichi Ishibashi authored
This CL replaces |main_script_http_info_| of which type is HttpResponseInfo with |main_script_response_| of which type is a new struct called ServiceWorkerVersion::MainScriptResponse. MainScriptResponse is a subset of HttpResponseInfo and only contains information needed by ServiceWorkerVersion. The motivation of this change is to remove HttpResponseInfo dependency from ServiceWorkerVersion so that we can eliminate URLResponseHead -> HttpResponseInfo conversion in service worker code. This CL also removes OnMainScriptHttpResponseInfoSet() from ServiceWorkerVersion::Observer. ServiceWorkerContextCore is the only class that implements the method and ServiceWorkerVersion has a reference to the instance so this indirection isn't needed. This CL doesn't modify SetMainScriptHttpResponseInfo(). A subsequent CL will change it to remove HttpResponseInfo use in ServiceWorkerVersion. Bug: 1060076 Change-Id: I5c632fb7e9b88ce826018c2175506a8602d3b9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093971 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#749426}
-
Michael Montvelishsky authored
By default output is not saturated to [-1, 1] range. Use option -s to saturate the output. Bug: None Change-Id: Idd6fa198b2693543be988938c25b8a387e5ba2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097530 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#749425}
-
bttk authored
In the future it will be used for non-histogram data, namely backing RecordUserActions. Bug: 658300 Change-Id: I0a872878466f8cf62847ed10da2011fcdbfb07b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079841 Auto-Submit: bttk <bttk@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#749424}
-
Victor Hsieh authored
Although /chromebook/?p=develop_android_apps seems to be preferred, for the OOBE/opt-in UI, we need to refer by the help center ID, which gives us the offline content (see crrev.com/i/2740252). TEST=see the correct content in both settings and opt-in flow BUG=chromium:1059930 Change-Id: I5dc4e83bec10928243d042b53b1426462ca40756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094910 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#749423}
-
