GitLab

BUG=571155

Review-Url: https://codereview.chromium.org/2348603002
Cr-Commit-Position: refs/heads/master@{#418993}

Revert of Enable whitelisting for targets other than libchrome. (patchset #8 id:40002 of https://codereview.chromium.org/2336033002/ )

Reason for revert:
Broke ninja on Linux x64:

ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
FAILED: build.ninja
/mnt/ssd/miu/chromium/src/buildtools/linux64/gn --root=/mnt/ssd/miu/chromium/src -q gen //out/Release/
ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier.
    public_deps += [ ":default_apps" ]
    ^----------
See //BUILD.gn:211:7: which caused the file to be included.
      "//chrome",
      ^---------
ninja: error: rebuilding 'build.ninja': subcommand failed

Original issue's description:
> Refactor chrome resource targets into chrome_paks.gni
>
> This will allow monochrome to easily define its own set of the same
> targets with a different resource whitelist
>
> BUG=641032
>
> Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e
> Cr-Commit-Position: refs/heads/master@{#418966}

TBR=brettw@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641032

Review-Url: https://codereview.chromium.org/2348643002
Cr-Commit-Position: refs/heads/master@{#418992}

BUG=646037

Review-Url: https://codereview.chromium.org/2343973002
Cr-Commit-Position: refs/heads/master@{#418991}

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116

R=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2323153003
Cr-Commit-Position: refs/heads/master@{#418990}

We need to configure code to use built-in data from system library,
not a separate file shipped with Chrome.

BUG=551343
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/2339173005 .

Cr-Commit-Position: refs/heads/master@{#418989}

This implements:

- allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Review-Url: https://codereview.chromium.org/2259903002
Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}

BUG=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/2343883002 .

Cr-Commit-Position: refs/heads/master@{#418987}

chrome.exe appears to have grown by 150% when skia rolled in r411308.
chrome.exe shouldn't need skia or gfx, so let's try not depending on
them!

BUG=647223
R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2345503006
Cr-Commit-Position: refs/heads/master@{#418986}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8091fad9d075ecec116e1740360ff955a7654c4a Remove use_isolate from Marshmallow 64 bit Tester (bpastene@chromium.org)
  https://crrev.com/2f0a7c064259dc0e0bf375c2d1771544f5647a1c Changed sequence of package_build step to be before package_build_for_bisect (miimnk@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645662

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2342153002
Cr-Commit-Position: refs/heads/master@{#418985}

This method is not used outside of SequencedWorkerPool itself. Making it private
will prevent external users from using it directly, which will help the deprecation
of SequencedWorkerPool.

SequencedWorkerPool::IsRunningSequenceOnCurrentThread() is still used
by the RunsTasksOnCurrentThread() method of SequencedTaskRunners
returned by a SequencedWokrerPool.

BUG=622400

Review-Url: https://codereview.chromium.org/2341063002
Cr-Commit-Position: refs/heads/master@{#418984}

BUG=384330

Review-Url: https://codereview.chromium.org/2343923002
Cr-Commit-Position: refs/heads/master@{#418983}

Bring the code to C++11 standard and streamline the execution path inside the function.

BUG=646904

Review-Url: https://codereview.chromium.org/2340003002
Cr-Commit-Position: refs/heads/master@{#418982}

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
    https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion)

BUG=646443
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2335193007
Cr-Commit-Position: refs/heads/master@{#418981}

BUG=620813

Review-Url: https://codereview.chromium.org/2339873003
Cr-Commit-Position: refs/heads/master@{#418980}

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275

Review-Url: https://codereview.chromium.org/2338273005
Cr-Commit-Position: refs/heads/master@{#418979}

https://chromium.googlesource.com/chromium/src/+/7c023bffa

BUG=641261
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2342143002 .

Cr-Commit-Position: refs/heads/master@{#418978}

This change populates the feedback dialog with some initial info, including profile email and current URL, by adding a new WebUI Message Handler for C++ <-> JS messaging. The handler will be build out to support more messaging in the future, e.g. system info, screenshots, and feedback submission.

BUG=632112

Review-Url: https://codereview.chromium.org/2190653003
Cr-Commit-Position: refs/heads/master@{#418977}

This simplifies the code a little bit + avoids consuming memory for what
is ultimately an unused value.

BUG=647392
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2329523003
Cr-Commit-Position: refs/heads/master@{#418976}

https://chromium.googlesource.com/webm/libvpx.git/+log/e66cd132f09e..4282d29355df

$ git log e66cd132f..4282d2935 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 johannkoenig vp8 decoder: cast decoding_thread_count to int
2016-09-13 johannkoenig vp9 frame parallel test: Initialize cfg to 0
2016-09-13 johannkoenig vp9cx_set_ref.c: remove unused 'cfg' parameter
2016-09-13 johannkoenig webmenc: remove unused 'fps' parameter
2016-09-09 jzern cosmetics,vp8: join some lines, fix table format
2016-09-09 marpan vp8: Set the skin model to mode 1.
2016-09-06 glider vp8: Remove TSAN warning around end of encode.
2016-09-07 jzern vpx_mem.c: remove unnecessary inline
2016-09-07 slavarnway vpx_dsp: added vpx_highbd_idct32x32_1_add_sse2()
2016-09-03 sarahparker Fix missing write to opsnr in internal stats
2016-09-01 jzern invalid_file_test: quiet -Wunused-const-variable warnings
2016-09-01 jzern vp8_cx_iface: quiet -Wshorten-64-to-32 warning
2016-09-01 jzern get_cpu_count: quiet -Wshorten-64-to-32 warnings
2016-09-01 paulwilkins Casts to remove some warnings.
2016-08-31 johannkoenig Enable -Wundef by default
2016-08-31 johannkoenig Define VP8_TEMPORAL_ALT_REF to !CONFIG_REALTIME_ONLY
2016-08-26 johannkoenig Remove CONFIG_DEBUG guards from assert()
2016-08-26 johannkoenig Remove unused function vpx_de_mblock
2016-08-26 johannkoenig Fix -Wundef warning for OUTPUT_FPF
2016-08-26 johannkoenig Fix -Wundef warning for __SANITIZE_ADDRESS__
(...)

R=johannkoenig@google.com

Review-Url: https://codereview.chromium.org/2346903003
Cr-Commit-Position: refs/heads/master@{#418975}

BUG=None

Review-Url: https://codereview.chromium.org/2233963002
Cr-Commit-Position: refs/heads/master@{#418974}

BUG=647016
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2340923002
Cr-Commit-Position: refs/heads/master@{#418973}

https://chromium.googlesource.com/skia.git/+log/ab00f4222c9f..615af784ab6e

$ git log ab00f4222..615af784a --date=short --no-merges --format='%ad %ae %s'
2016-09-15 djsollen Revert of Update version of SVG asset (patchset #1 id:1 of https://codereview.chromium.org/2341043003/ )
2016-09-15 mtklein GN: support 32-bit x86 builds

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2344893004
Cr-Commit-Position: refs/heads/master@{#418972}

*PERF SHERRIF: this CL intentionally breaks dummy_benchmark.noisy_benchmark_1
for intergration testing purpose.

BUG=646628
NOTRY=true

Review-Url: https://codereview.chromium.org/2334323003
Cr-Commit-Position: refs/heads/master@{#418971}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e1d15cd7795cc1c5465983af8a49669242857107 Add rtc_stats_unittests to the test suite (ehmaldonado@chromium.org)
  https://crrev.com/37294244d9d54d639a083d382da68c50f8fe14e5 Add linux_chromium_headless_dbg trybot (perezju@chromium.org)
  https://crrev.com/f0f4c4a27746dee8a53234f03e452dba556deb55 Reland of Enable the ninja up-to-date check for Android builders (agrieve@chromium.org)
  https://crrev.com/2744734cf3aa1d8a02d0f0b7abf99635e9f2aa48 Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2343563003/ ) (agrieve@chromium.org)
  https://crrev.com/1575589a1d8f61fee45ec53ccbf77f073fd38847 recipe_modules/chromite: Use "build_type". (dnj@chromium.org)
  https://crrev.com/5799bab975aa3eda6785f36d9f7879549074b28b Reland of Enable the ninja up-to-date check for Android builders (agrieve@chromium.org)
  https://crrev.com/ecdf065c9d2a6e28d86c8ad333432b497158ee7a chromium.android: Enable swarming on Android arm64 builder (bpastene@chromium.org)
  https://crrev.com/7a71133c89aa2a770fc2326188306cf6a3a6f1e1 Revert of Enable the ninja up-to-date check for Android builders (patchset #1 id:1 of https://codereview.chromium.org/2343953002/ ) (agrieve@chromium.org)
  https://crrev.com/c65424c419105e0720cc0de09fb9e7a36c3d4601 Pass ninja -n in the ninja -d explain step to avoid more work (agrieve@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=646165,chromium:627996,646838,632008

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2346723003
Cr-Commit-Position: refs/heads/master@{#418970}

BUG=637460
TBR=drott

Review-Url: https://codereview.chromium.org/2339863003
Cr-Commit-Position: refs/heads/master@{#418969}

-- The DeleteAllPages method is only used by the offline internals page.
-- The Javascript can send all the request ids for DeleteAllRequests to eliminate additional async callback complexity.
-- Update IDs to be less confusing.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2342603004
Cr-Commit-Position: refs/heads/master@{#418968}

https://pdfium.googlesource.com/pdfium.git/+log/38fd84428a1e..8f53f54a9cca

$ git log 38fd84428..8f53f54a9 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 tsepez Add short-cut in CFX_{Byte,Wide}String::Operator<()

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2345713003
Cr-Commit-Position: refs/heads/master@{#418967}

This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist

BUG=641032

Review-Url: https://codereview.chromium.org/2336033002
Cr-Commit-Position: refs/heads/master@{#418966}

BUG=646363
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2343963002
Cr-Commit-Position: refs/heads/master@{#418965}

Power measurements on a nexus 5 show that there's very little
difference below 360p between hardware and libvpx decoding.  This CL
switches to libvpx decoding for <360p, even if it could be hardware
accelerated by AVDA.

This saves a hardware codec instance, and avoids potential stability
issues with lots of MediaCodecs in use at once.

BUG=647259, 642948
TEST=manually checked 240p and 360p.

Review-Url: https://codereview.chromium.org/2334223009
Cr-Commit-Position: refs/heads/master@{#418964}

This patch refactors some tile manager code into ImageManager with
an intent of moving all image related stuff (pre-decode images /
checker images) into that class.

R=enne
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2339703005
Cr-Commit-Position: refs/heads/master@{#418963}

Direct access to LayoutPart is deprecated and being removed soon. The
replacement is LayoutPartItem, which routes methods through the new
block layout API. (See linked crbug for details.) This means the
ownerLayoutObject() method is also deprecated, to be replaced with
ownerLayoutItem().

There are no functional changes.

BUG=499321
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2334313002
Cr-Commit-Position: refs/heads/master@{#418962}

BUG=646631

Review-Url: https://codereview.chromium.org/2338063004
Cr-Commit-Position: refs/heads/master@{#418961}

It is both clearer this way, and it avoids shadowing by the identically-named
m_frame in FrameView.

TBR=drott

Review-Url: https://codereview.chromium.org/2343553002
Cr-Commit-Position: refs/heads/master@{#418960}

The call sites where the time is used to compute time deltas within the
lifetime of the Chrome browser process are affected.

BUG=646619

Review-Url: https://codereview.chromium.org/2336913003
Cr-Commit-Position: refs/heads/master@{#418959}

If it's an exclusive end offset, we need to know this, so that we map to the
former fragmentainer group, rather than the latter, if the offset is at a
column row boundary.

Review-Url: https://codereview.chromium.org/2345583004
Cr-Commit-Position: refs/heads/master@{#418958}

This CL adds support for BACKGROUND mode in MemoryCache dump provider,
where it just adds the total sizes of resources (given by encodedSize
of each resource).
This CL also fixes the image resources reporting which had a shared
buffer that was not reported in the ImageResource subclass.
It also fixes the SharedBuffer::onMemoryDump to dump when both shared
buffer and segments are used together.

BUG=629925

Review-Url: https://codereview.chromium.org/2337733002
Cr-Commit-Position: refs/heads/master@{#418957}

This fixes an MSan error introduced by
https://codereview.chromium.org/2294373002/

==31610==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xa7ce15a in WriteBytesCommon base/pickle.cc:478:3
    #1 0xa7ce15a in WriteBytesStatic<4> base/pickle.cc:443:0
    #2 0x98c5407 in WritePOD<int> base/pickle.h:367:5
    #3 0x98c5407 in WriteInt base/pickle.h:229:0
    #4 0x98c5407 in Persist net/cert/signed_certificate_timestamp.cc:43:0
    #5 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #6 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18

  Uninitialized value was stored to memory at
    #0 0x98c57fd in Persist net/cert/signed_certificate_timestamp.cc:43:3
    #1 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #2 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18

  Uninitialized value was created by a heap allocation
    #0 0x8da8c2 in operator new(unsigned long) ??:0
    #1 0xa68c2f8 in GetX509CertSCT net/test/ct_test_util.cc:220:14
    #2 0x2cb7451 in TestBody net/http/http_response_info_unittest.cc:104:3

Review-Url: https://codereview.chromium.org/2337983006
Cr-Commit-Position: refs/heads/master@{#418956}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8a8133bd..48c952ad

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2340393002
Cr-Commit-Position: refs/heads/master@{#418955}

BUG=646146

Review-Url: https://codereview.chromium.org/2337143004
Cr-Commit-Position: refs/heads/master@{#418954}