- 05 Oct, 2018 40 commits
-
-
Mikel Astiz authored
If a model (or SyncableService) reports an error, let's plumb it through to base::debug::DumpWithoutCrashing() via ReportUnrecoverableError(), which does it only for canary&dev channels, with random sampling. This achieves feature parity with the directory-based setup and may allow future investigations if we see datatypes with high error rates. Bug: 870624 Change-Id: Idb3d00b178167a8b7b9eabb560858197e03aecb2 Reviewed-on: https://chromium-review.googlesource.com/c/1264198Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597035}
-
Yoichi Osato authored
This patch just removes the functions. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie0bcda4080ff4390cf29cad4661dca67ead9ad44 Reviewed-on: https://chromium-review.googlesource.com/c/1264156Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597034}
-
Findit authored
This reverts commit d270ec39. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596972 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDI3MGVjMzkwMmFmZTU4OTg4MjM0ODMyYjdjMzNmN2U1Y2U5MmFhNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8178 Sample Failed Step: viz_browser_tests Sample Flaky Test: GalleryBrowserTest.DeleteSingleOpenPhotoOnDownloads Original change's description: > Hide filename edit field when there is no image > > Hide |filenameEdit_| line edit box when there is no image to be displayed. > This fixes an undesired grey line appearing as the bottom of this edit box. > Changing the "disabled" state doesn't change the style of this box, > "disabled" state is only used for read-only behaviour not style. > > R=fukino@chromium.org > > Bug: 796503 > Change-Id: I6fc9a4eb218231781325ba7a5af992b12610b929 > Reviewed-on: https://chromium-review.googlesource.com/c/1212263 > Reviewed-by: Noel Gordon <noel@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Alexander Nohe <nohe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596972} Change-Id: I5a64c57351cc39d641af6052567c8f8d150542cc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796503, 892543 Reviewed-on: https://chromium-review.googlesource.com/c/1263887 Cr-Commit-Position: refs/heads/master@{#597033}
-
Mathias Carlen authored
This change adds a highlight element action which updates the css shadow of a given element. R=gogerald@chromium.org Bug: 806868 Change-Id: Ife28259e4020721fd87487770b154c452425a48c Reviewed-on: https://chromium-review.googlesource.com/c/1262555 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#597032}
-
Peter E Conn authored
This change adds code to react when a Trusted Web Activity client is uninstalled or has its data wiped. Currently it does nothing on this trigger, that will come in a later CL. Bug: 888447 Change-Id: I354e5d0ade9327659f198e9ba099875daf89f378 Reviewed-on: https://chromium-review.googlesource.com/c/1243485 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597031}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I2a8532f6292c4d8f79a3d153bd66c3058409f994 Reviewed-on: https://chromium-review.googlesource.com/c/1263868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597030}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/sync_file_system. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 890902 Change-Id: I787a26b538cb11b45a42dbf4573fcf7adef06e75 Reviewed-on: https://chromium-review.googlesource.com/c/1257907Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597029}
-
Noel Gordon authored
Now we have the QuickView <webview> infra to detect the 'loaded' state of thew <webview> content, add a <file-safe-media> video test and also check the <webview> renders its content on a transparent black body. Bug: 891150 Change-Id: I634a60ba733bfff79ed72b0e75d7024da4c8182c Reviewed-on: https://chromium-review.googlesource.com/c/1264097 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#597028}
-
Morten Stenshorne authored
Added a comment to LayoutInline, pointing out that LayoutNG is doing the right thing already, while legacy is wrong. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I026404af70c33b0a94900773636d5e138a725976 Reviewed-on: https://chromium-review.googlesource.com/c/1261436Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#597027}
-
Mikel Astiz authored
Feature toggles cannot change during runtime, so let's make sure the final values are fixed before a profile is created for tests. This fixes flakiness in TSAN bots due to recent unrelated changes, where a KeyedService's backend thread reads a feature toggle (although the feature is unrelated to this test suite). TBR=rockot@chromium.org Bug: 891906 Change-Id: I385c8d5ff38c660d84465cbaaa1bcbeca6b9482a Reviewed-on: https://chromium-review.googlesource.com/c/1264161Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597026}
-
Amos Lim authored
external/wpt/interfaces.html was removed in http://crrev.com/c/1154644. Remove dangling interfaces-expected. Bug: N/A Change-Id: Ibff4c1f20dee384c4d4df2c45f4a140623003527 Reviewed-on: https://chromium-review.googlesource.com/c/1263637Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#597025}
-
Noel Gordon authored
Bug: 891150 Change-Id: I571b3ec2d402d9eee7bf49eae65d3bec8f6c2132 Reviewed-on: https://chromium-review.googlesource.com/c/1264096 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL introduces two counters. - kFormDisabledAttributePresent 'disabled' attribute is updated on <form> elements. - kFormDisabledAttributePresentAndSubmit A <form> element is submitted while it has 'disabled' attribute. Background: In WHATWG HTML, we're discussing on adding 'disabled' content attribute to <form>. It will prevent form submission though no browsers implement it now. We're afraid there are web sites using 'disabled' attribute on <form>, and they will stop working if browsers implement 'disabled' attribute. This CL add counters to know how many such sites and how many sites will be broken. If the numbers are high, we may change the attribute name, or we won't standardize it. Bug: https://github.com/whatwg/html/issues/3682 Change-Id: Id4daa27ebdb3600b00b47c0e82814673243c37aa Reviewed-on: https://chromium-review.googlesource.com/c/1263679 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f87e2255b8a..787bb77798ed git log 4f87e2255b8a..787bb77798ed --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@787bb77798ed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I15ba57e68fc6a771eda3819f7f7eeb6bf1f3891e Reviewed-on: https://chromium-review.googlesource.com/c/1263865Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7659b7123080..30f82e022cc4 Created with: gclient setdep -r src-internal@30f82e022cc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib9b4a4c7b952f1261802cf74ed0f19ea4f116d92 Reviewed-on: https://chromium-review.googlesource.com/c/1263866Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597021}
-
Findit authored
This reverts commit 24c77b16. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596999 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjRjNzdiMTZlYTg2ZmEwMmRmOGI4YjBlYjQ1YTEyMGNmMDJkYzg3OQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14262 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: NetworkServiceRestartBrowserTest.SharedWorker Original change's description: > shared worker: Self-terminate when network service crashes. > > This treats the network service crashing like the worker's process > crashing, and prevents clients getting stuck with a broken worker. > > Bug: 848256 > Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da > Reviewed-on: https://chromium-review.googlesource.com/c/1260903 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596999} Change-Id: I2bf5229056da67f539f4f89ed7fc92578edac567 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848256, 892535 Reviewed-on: https://chromium-review.googlesource.com/c/1263885 Cr-Commit-Position: refs/heads/master@{#597020}
-
Renee Wright authored
This change fixes a bug where the value for Settings > Device > Storage Management > Linux (Beta) storage shows as 0 when the Termina container is not running. Bug: 888795 Change-Id: I6ab468bc6cca5cdf786e226517ecc25c971061ec Reviewed-on: https://chromium-review.googlesource.com/c/1260608 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597019}
-
Kunihiko Sakamoto authored
Bug: 849935 Change-Id: Ifc480bba69fa9b15aa0b0adb9b0c6a6cb28441b0 Reviewed-on: https://chromium-review.googlesource.com/c/1264136Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597018}
-
Trent Apted authored
Adds - FileManagerJsTest.ImporterCommonTest - FileManagerJsTest.LRUCacheTest - FileManagerJsTest.AsyncUtilTest - FileManagerJsTest.FilesAppEntryTypes - FileManagerJsTest.UtilTest Also adds test_importer_common.js to be typechecked, which isn't itself a unit test. This exposed a weird dependency group on ui/file_manager/exerns/volume_info.js - encapsulate those dependencies as well as we can. Remove the dependency on cr.EventListenerType: it's a @typedef {...|*} so adds no type safety and requires a dependency on "//ui/webui/resources/js/cr:event_target" which is not an extern. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I479f8e7b22b56ea315c27fabc5e7ccdeb6277728 Reviewed-on: https://chromium-review.googlesource.com/c/1250762 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597017}
-
Trent Apted authored
This allows the html files generated under out/foo/gen/.... to be opened in Chrome as a file:/// URL. It doesn't affect how the files are served by the embedded test server (leading ../..'s are ignored). Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6a7a8838c6158f9f5cdeb9fa8e0745c23d88f602 Reviewed-on: https://chromium-review.googlesource.com/c/1264095Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#597016}
-
Asami Doi authored
to record a script type 'classic' or 'module'. The goal is to import and evaluate as a module script at ServiceWorker. Users can use it by adding type 'module' when register a service worker script. This CL allows to store script type into ServiceWorkerDatabase and use it when starting an installed service worker. Bug: 824647 Change-Id: I4d26b774fa662a6e6587bf10137fd8b1dae2e42a Reviewed-on: https://chromium-review.googlesource.com/c/1226488Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Lei Zhang authored
IWYU for GN. Change-Id: I88f2a9c1b7c115aefeca36208d21ea4b1db89687 Reviewed-on: https://chromium-review.googlesource.com/c/1263570Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#597014}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1d4dc8eb878..f98905e8f03c git log d1d4dc8eb878..f98905e8f03c --date=short --no-merges --format='%ad %ae %s' 2018-10-05 hinoka@google.com [led] Roll led to fix broken Milo annotation stream. Created with: gclient setdep -r src/third_party/depot_tools@f98905e8f03c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891925 TBR=agable@chromium.org Change-Id: Ic4783663bfe1bf6803e828cfc68c734f11956d46 Reviewed-on: https://chromium-review.googlesource.com/c/1263864Reviewed-by:
-
Noel Gordon authored
Add a tall PDF file (derived from tall.txt). No change in behavior, so no new tests, just adding a resource. Bug: 891150 Change-Id: Ib5b7f2faec713c8cae23183cc3c55a3f77188a4b Reviewed-on: https://chromium-review.googlesource.com/c/1263680 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
This reverts commit e275f44c. Reason for revert: network_service_browser_tests and browser_tests failures on Mac10.* An example of failed builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15650 An example of failures: [ RUN ] PPAPINaClNewlibTest.MessageHandler [20331:4611:1004/172559.081686:WARNING:notification_platform_bridge_mac.mm(512)] AlertNotificationService: XPC connection invalidated. [20331:775:1004/172559.238456:ERROR:delegated_frame_host.cc(174)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20331:775:1004/172559.246528:ERROR:web_contents_view_mac.mm(487)] Failed to look up NSViewBridgeFactoryHost! [20331:87555:1004/172600.232802:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico [20331:41475:1004/172600.253102:FATAL:child_process_launcher_helper_mac.cc(111)] Check failed: false. 0 browser_tests 0x000000010880e56f base::debug::StackTrace::StackTrace(unsigned long) + 31 1 browser_tests 0x0000000108749e0f logging::LogMessage::~LogMessage() + 223 2 browser_tests 0x0000000106daeea8 content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread(content::PosixFileDescriptorInfo const&, base::LaunchOptions*) + 584 3 browser_tests 0x0000000106dae42a content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() + 90 4 browser_tests 0x0000000108737492 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 242 5 browser_tests 0x00000001087cc726 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 918 6 browser_tests 0x0000000108819974 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 100 7 browser_tests 0x00000001087cbd81 base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) + 305 8 browser_tests 0x00000001087c2b57 base::internal::SchedulerWorker::RunWorker() + 391 9 browser_tests 0x00000001087c29b4 base::internal::SchedulerWorker::RunDedicatedWorker() + 20 10 browser_tests 0x0000000108819e47 base::(anonymous namespace)::ThreadFunc(void*) + 87 11 libsystem_pthread.dylib 0x00007fffbcc2f93b _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffbcc2f887 _pthread_body + 0 13 libsystem_pthread.dylib 0x00007fffbcc2f08d thread_start + 13 Original change's description: > macOS V2 Sandbox: Remove the feature flags. > > The V2 sandbox is now default for all but the network and GPU processes > on macOS. This CL deletes the feature flag. A new experiment will be > introduced for the GPU process. > > Bug: 749839 > Change-Id: Idb65a83f25f48db5aaf8d8d2400992640673d0e8 > Reviewed-on: https://chromium-review.googlesource.com/c/1258214 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596910} TBR=avi@chromium.org,asvitkine@chromium.org,kerrnel@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I318db92c92f7d03b1a67fd2734e27b50169bd4e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/c/1263737Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#597011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b0f761dc3cd..7659b7123080 Created with: gclient setdep -r src-internal@7659b7123080 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6f5b6c87a3e36c36006203858befe06cf1d1f8df Reviewed-on: https://chromium-review.googlesource.com/c/1263863Reviewed-by:
-
Andrew Luo authored
Uninstall webview before running cts test and don't run shell instrumentation test on swarming for now. Bug: 814405 Change-Id: Icdd9f5f68679d3483d2b329f18a7b820ae500d0e Reviewed-on: https://chromium-review.googlesource.com/c/1264155Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#597009}
-
Kouhei Ueno authored
Bug: None Change-Id: Ifea1dad183590cdb258264f4158473fbcebea35d Reviewed-on: https://chromium-review.googlesource.com/c/1263683 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Jun Choi authored
Currently relying party ID is injected to the title of AuthenticatorBlePinEntrySheetModel. This should be fixed to device display name. Bug: 877344 Change-Id: Ia2126c401881df9b70a4867711886f50ae53fdf6 Reviewed-on: https://chromium-review.googlesource.com/c/1260013 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597007}
-
Giovanni Ortuño Urquidi authored
This is a reland of 837b3c20 The original patch attempted to init the alternate dbus client on Linux where there is no alternate bus connection. The latest patchset fixes this by returning early if there is no alternate bus connection. Additionally, BluetoothAdapterClientImpl assumed it was always initialized. This caused a crash on Linux during shutdown. This latest patchset fixes this by only cleaning up if the client has been initialized. TBR'ing since it's a small change from the original CL. Original change's description: > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > There are two parts to this change: > > 1. Create a new BluetoothAdapterClient instance. For this we add > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > This new instance uses a separate DBus Connection through > BluezDBusThreadManager. This ensures actions on one client won't > affect the other client. > > 2. Implement BluetoothSystem::GetState using the new client. > > Bug: 870192, 882771 > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596520} TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org Bug: 870192, 882771 Change-Id: Ie089e30d297e8afd9ceb70c0e9a4af7600e633de Reviewed-on: https://chromium-review.googlesource.com/c/1263640Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#597006}
-
Tetsui Ohkubo authored
This CL adds Clear All button to NewUnifiedMessageCenterView. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: Ibadc6e5a3d799fcbeb6c94199d68656d169295d4 Reviewed-on: https://chromium-review.googlesource.com/c/1260530Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#597005}
-
Yoshifumi Inoue authored
This patch makes Element#innerText to collapse white space after <br> to avoid emitting extra space for improving interop. Bug: 892491 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8dd429a8af6ecd2e6d5195d6a6ec7b0214c6345c Reviewed-on: https://chromium-review.googlesource.com/c/1263638Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597004}
-
Ryan Sturm authored
This allows a future CL to add PreviewsState to this object without violating DEPS. Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca TBR=mmenke,jianli Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca Reviewed-on: https://chromium-review.googlesource.com/c/1263395 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597003}
-
Xiaoqian Dai authored
After the drag ends, the dragged tab window might need to merge back into the source window if 1) the dragged window or the source window is not added to overview and 2) the dragged window has dragged farther than half of the screen height and 3) the dragged window is not in snap preview area and 4) the dragged window is not dragged to other side of the splitscreen if source window is showing in splitscreen. Bug: 887739 Change-Id: I21bab4ef5fbfc4c9c4294a6028798be3793b8b5c Reviewed-on: https://chromium-review.googlesource.com/c/1259468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597002}
-
Yuta Kitamura authored
This CL moves web_thread.h to blink/renderer/platform/scheduler/public and renames WebThread to Thread, so this class can only be referred from Blink. All the existing #include lines are rewritten, but references to WebThread in Blink are not renamed yet. The rename will happen in later CLs. To make the migration easier, temporary aliases of old names are added. Bug: 826203 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3cc9d209fd0c53c8a6362321661a361602f12dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1257473 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597001}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7a24422d086..56216d7832a4 git log a7a24422d086..56216d7832a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: pixel approximated/checkerboarded Created with: gclient setdep -r src/third_party/catapult@56216d7832a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757 TBR=sullivan@chromium.org Change-Id: I00fdd306c02a5ff45b9706d9664e45bed98bec4f Reviewed-on: https://chromium-review.googlesource.com/c/1263862Reviewed-by:
-
Matt Falkenhagen authored
This treats the network service crashing like the worker's process crashing, and prevents clients getting stuck with a broken worker. Bug: 848256 Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da Reviewed-on: https://chromium-review.googlesource.com/c/1260903Reviewed-by:
-
Darren Shen authored
For the inline handwriting feature, we introduced a private onFocus event to pass along stylus information. However, third party IMEs cannot listen to this, so we have to dispatch the public onFocus events to them. In our original patch, we did consider this issue and made sure that we only dispatch the private onFocus if "HasListener" is true. However, it turns out that "HasListener" returns true if *any* extension is listening to the event, so as long as the XKB extension is active, no third party IMEs will receive the public onFocus event. We change it so that we check whether each particular extension is listening to the private onFocus event before dispatching, so that the XKB extension receives the private onFocus event and third party IMEs receive the public one. We think that the other usages of HasListener are technicaly incorrect as well, but we will fix them in a follow up patch to limit the scope of this one. TBR=shuchen@chromium.org Bug: 835699 Change-Id: I7895d8503eb3677de8d248475f2856d1dfd397ca Reviewed-on: https://chromium-review.googlesource.com/c/1258702 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596998}
-
Ilya Sherman authored
* Hide more internal logic within PendingProfiles * Ensure that the functions that collect profiles cannot be called without verifying that collection is enabled. * Move profile serialization out from being under a lock. There's an important implementation detail: Profiles stored in the two vectors might end up interleaved, in terms of timestamps. However, it is still guaranteed that profiles from a single process are ordered consistently in the uploaded data, which is sufficient for later efficient processing. BUG=888716,851163 R=chengx@chromium.org Change-Id: I94c4ab165753e8a09a53490494f8161b197f1428 Reviewed-on: https://chromium-review.googlesource.com/c/1258514Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596997}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/84583f618399..0a74e09b39c1 git log 84583f618399..0a74e09b39c1 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0af97cea..618ddbcb (596847:596951) Created with: gclient setdep -r src/third_party/webrtc@0a74e09b39c1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie39b01f2cdf1f4e3cb6506f6227ea9c6162e7da7 Reviewed-on: https://chromium-review.googlesource.com/c/1263860Reviewed-by:
-
