- 15 Oct, 2020 40 commits
-
-
Owen Min authored
Update the owner and expire date for the following metrics: EnterpriseCheck.IsDomainJoined EnterpriseCheck.IsEnterpriseUser EnterpriseCheck.IsLocalMachine EnterpriseCheck.IsLocalUser EnterpriseCheck.IsManaged2 Bug: 1138385 Change-Id: I33c3e6c515680e017e3ba4dcd04010909ba2f576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476833Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817678}
-
Peter Kasting authored
This matches how secondary buttons are created and will facilitate converting buttons from listeners to callbacks. Bug: none Change-Id: I73d2cd81f136bdbc6827528ac4fe423782211250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468939 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#817677}
-
Brian Ho authored
Currently, P010 (both HDR and SDR) videos don't render on SkiaRenderer on Chrome OS. One issue is that creating the SkImage fails due to a color type/color format check [1]. The GrBackendFormat is created from a P010 format as GL_RGBA8_OES when hitting a NOTREACHED code block [2]. Similarly, the SkColorType is converted from P010 as kN32_SkColorType [3] which is a platform-dependent alias of either kRGBA_ or kBGRA_ [4]. If the platform supports a BGRA byte order, SkImage_Gpu::MakePromiseTexture fails because RGBA != BGRA. This CL handles P010 in some resource format conversion functions by converting to its closest neighbor- RGBA1010102. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/src/image/SkImage_Gpu.cpp;l=548;drc=1fc76ce6ff5553c3c1b98f34350c14887b6d4be7 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/common/resources/resource_format_utils.cc;l=337;drc=3e072dfcd46e4d23e7b985ffe97f784ec2731b86 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/common/resources/resource_format_utils.cc;l=66;drc=3e072dfcd46e4d23e7b985ffe97f784ec2731b86 [4] https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/include/core/SkImageInfo.h;l=96;drc=e3dc752d1c137b90e708d70e415d7cb1fd85326f Bug: 1138518 Change-Id: Ib7788c73919222dff1c09e315317e623e28481e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468443Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#817676}
-
Dave Tapuska authored
It has been used in 4 years since https://crrev.com/cb959ce66a so I don't think anyone is going to use it now. BUG=1097816 Change-Id: I492413144ca1d7905657fe3717ff8cd9c7a5f37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476755Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#817675}
-
Robert Ogden authored
This new class will be shared between the TabHelper and all Subresource Managers and have all prefetches reported to it. On destruction, it logs all the prefetches to UKM. The UKM source page will be the Google SRP, which is where all the prefetches occur, but the UKM may not be recorded until the next page load when we know what prefetches will be reused from the cache. This class is a scoped refptr so that its ownership can be effectively transferred to the navigated prefetch's SubresourceManager, if applicable, instead of complex handling of the class in the TabHelper. See https://chromium-review.googlesource.com/c/chromium/src/+/2463544 for the full impl. Privacy doc: http://shortn/_jDobercSsm Bug: 1136174 Change-Id: I358bdd1daf2e4564732fc72ca3b0a4ca9cabe63b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465216 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#817674}
-
Peter Kasting authored
Bug: 772945 Change-Id: I3b5131b40eabe286131692bc9891ee1d94afbd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476604 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#817673}
-
Mario Bianucci authored
Because RenderWidgets exist 1:1 with tabs, if delegated ink trails are being used in one tab, and then another tab starts using them, a second mojo pipeline between browser proc and viz will try to be created. However, since there is only one receiver in viz and it is already bound, we hit a DCHECK() and crash. The fix is to just add an if check in viz, and if the receiver is already bound, then reset it and bind the new PendingReceiver. This makes sure that the feature is available on the most recent tab to use it. Moving the Remote from RenderWidgetHostViewEventHandler to somewhere that it can exist 1:many with tabs is another possible solution. This would also have the benefit of exactly one IPC to make the connection for all tabs in a window. However, that would require the Remote to move to a much less obvious place for it to live, and since the trade off is only one extra IPC call per tab switch (when the new tab starts using the API - if it never uses it, no IPC call), it is unlikely to cause any noticeable performance regression. Bug: 1138602 Change-Id: I2ea9bb0962ac6e67b21276d0b75d9c455e7ede76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472901Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#817672}
-
Yuke Liao authored
This CL adds an example to show how to use tests against a locally built ash-chrome. Change-Id: I7f7cc04a3ae594fb388c9b81a13ac5375d72db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476902Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#817671}
-
dpapad authored
Bug: 1132403 Change-Id: I7fb7561cf7a808fe26420dae42814e5f41072b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470305 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#817670}
-
Jesse Schettler authored
Replace the colons in the scanner's instance name to prevent them from breaking sane-airscan's device name parsing logic. Bug: b:170976627 Change-Id: Ia62b200a6699f59b9fc55935c2ab9956279869ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476517Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#817669}
-
Kyle Horimoto authored
This CL adds policies for Phone Hub as well as its two sub-features (notifications and task continuation). The top-level feature is disallowed by default for managed users, and its subfeatures are allowed by default but only usable if the top-level feature is also allowed. The preferences for these policies are already implemented, so this CL simply hooks up the new policies to them. Bug: 1106937 Change-Id: I11d08a67af01daab95f20abebf031c67eb848d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473337 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#817668}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 86.0.4240.99 TBR=estaab@chromium.org Bug: 1041619 Change-Id: Ib3f1818b30bada61f7a1c361b373881edc61b920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476580 Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#817667}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9dfc25eb5de2..63fa6951fb7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com,jbroman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: pkasting@google.com,jbroman@google.com Change-Id: Ifad4cae80bee6247479f0942b7b84cc091b76157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477225Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817666}
-
Matt Jones authored
Bug: 1135465 Change-Id: I3202884bcaaa9c80c6d6b3940da77c717f54b357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459108Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817665}
-
Austin Eng authored
This is a reland of 290037a8 It's been preceded by a fix to set dawn_use_x11=false to fix compilation on lacros. Original change's description: > Set use_dawn=true on Linux > > This enables WebGPU on Linux behind --enable-unsafe-webgpu > and --enable-features=Vulkan. Shared image support requires > SkiaRenderer (default on Linux) and Vulkan to be enabled. > > Bug: 976495 > Change-Id: I97065f2ac6aadd110971254bfe3526d366318b83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368534 > Commit-Queue: Austin Eng <enga@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817266} Bug: 976495 Tbr: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux-lacros-rel Change-Id: I6bcf6daa48e838bc8e721126f353c97a5eb752e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476774 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#817664}
-
Richard Knoll authored
This adds a UMA metric that records the result of the promise returned by a call to showNotification. This allows us to spot and pinpoint common errors earlier. TBR=peter@chromium.org Bug: None Change-Id: If6505a86acbfc20f101a421b6a187c08f32c4af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475882 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#817663}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602709027-5dd91a5323ea4bffe2a30c2aaff27b21af6d45ea.profdata to chrome-win32-master-1602730724-a2f2ccfa1a9355c75a0cf65d2477506fef2f19f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib971cbbf8cf9ce06afa307524496e6b09eacca97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474004Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817662}
-
Benoit Lize authored
ThreadCacheRegistry is a singleton, using the common static local pattern. However this doesn't work for PartitionAlloc-Everywhere builds on Windows, as static locals are not safe very early on, and this one is called during CRT initialization. To avoid using a static local here, use a regular global variable in the .cc. This means that the object must be constexpr-constructible, so this CL: - Moves to PartitionLock vs base::Lock - Makes PartitionLock's constructor constexpr Bug: 998048 Change-Id: Ie16c642122696d34d9f07813a763ca986b25895c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474857 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817661}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602762990-5610fc4d08ce928742199548ea998fa82cc20428.profdata to chrome-linux-master-1602784677-a93fbaee821e881bb685f33a6370b1d8843d7235.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic965a389f3d69598d73d67d60105595ccdfe2db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477274Reviewed-by:
-
Steven Bennetts authored
This CL: * Removes the no longer accurate typedef * Eliminates DictionaryValue from ShillClientHelper BUG=1109627,1137487 Change-Id: I1ae00753e7a8d77c2c7948c78c7ad31c1bcabb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466382 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#817659}
-
Gavin Williams authored
In Wallpaper app add a blue border around the category to show when focused. Screenshot: https://screenshot.googleplex.com/C6LMc4tGitLTkdA Bug: 1045359 Change-Id: Icd3e36343451e517b1f10a1de303a5df827fec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476557Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#817658}
-
minch authored
Bug: 1131543 Change-Id: I358c1bac6cdb59302c15144340f64e43cead1258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472597 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#817657}
-
Ryan Heise authored
Bug: 1138953 Change-Id: Ie8475db0b7991c867564894cccd775c0cbf19dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476674Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817656}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/a3f46f23c526..bd45d582f51e 2020-10-15 jophba@chromium.org Allow loopback for discovery If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2ccd0ed0216ae007259015a7b2ec0b80748abeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477217Reviewed-by:
-
Dave Tapuska authored
No one listens or sends messages via RenderViewObserver anymore. BUG=1097816 Change-Id: I760e8f97992a23f6aaec51cb187405881f494471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476754Reviewed-by:
-
Devlin Cronin authored
browser_action and page_action are being replaced by simply "action" in manifest v3. Limit browser_action and page_action to manifest v2. Bug: 987838 Change-Id: Ib007f607e8879b6a2667093ee223a03572fb616c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473142Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817653}
-
Matt Jones authored
Recent changes to the SceneOverlay system have allowed it to be used more dynamically; features don't need such a close relationship the the LayoutManager. This patch moves the contextual search feature code out of LayoutManager and into ContextualSearchManager since LayoutManager shouldn't and no longer needs to be responsible for it. Bug: 1100332 Change-Id: I133f4104de0d1dbeff8f6c355d66a2d7955db42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456634Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#817652}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602762990-5c0ecdd782b8586c3ade2c97da0a453329c89923.profdata to chrome-mac-master-1602784677-cb2da9a5056db49e979dc05760b0abb885837837.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib7569241d98126435730ddd0b7708285e2344f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477229Reviewed-by:
-
Andrew Grieve authored
* source_path, object_path, template_name, and "name" all now use the class name that a symbol was merged from rather than the one it was merged into. * Made lambda name normalization work for class merging * Changed object_path to be the same whether or not source_path exists (because why would it differ!?) * Added more tests :). Bug: 1121569 Change-Id: I7d52b75f6887df529ce2178ad5430d49107ec864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473368 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#817650}
-
Leonid Baraz authored
Bug: b:169248924 Change-Id: Icd034dbfc84b33a9fc8325043d85391bce185480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458288Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#817649}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/029d567d..aedca41e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebf1e2fed409e4a39003e0c3f2e6fc787ef70088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476575Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817648}
-
Victor Hugo Vianna Silva authored
EnableEncryptEverything() and IsEncryptEverythingEnabled() were only relevant for the Directory implementation of Nigori, so they can be removed now, together with the associated plumbing. Bug: 1033040 Change-Id: Iccad5b4bcbbedd2167df258f1f370adf8ca7db2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465856 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#817647}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5d099fcb489d..39d870e1f07f 2020-10-15 sdefresne@chromium.org Fix `git map-branches` when branch is named after a file/directory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I2308c806d57e6d7af9c3a6faa5af5e3d2dd262db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477216Reviewed-by:
-
Ella Ge authored
This reverts commit af52bf4c. Reason for revert: Reland with fix Original change's description: > Revert "Merge Webapk/TWA disclosure controller 1" > > This reverts commit 6460aa02. > > Reason for revert: Looks to have broken Android compile: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/15768 > > Original change's description: > > Merge Webapk/TWA disclosure controller 1 > > > > This CL moves WebappDisclosureSnackbarController to browserservices > > folder, makes it use TrustedWebActivityModel and the > > DisclosureInfobar as TrustedWebActivityDisclosureController. > > > > This will change the text in unbound webapk's disclosure snackbar text > > to be the same as TWA one. > > > > Bug: 1128675 > > Change-Id: I900c41c04a6f36489bed1e08cf81c74f89e2801e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453896 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Conn <peconn@chromium.org> > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#817516} > > TBR=agrieve@chromium.org,peconn@chromium.org,eirage@chromium.org > > Change-Id: I97a14528dbe701a19753b87b3a9a13963716099f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1128675 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476775 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817533} TBR=pkasting@chromium.org,agrieve@chromium.org,peconn@chromium.org,eirage@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1128675 Change-Id: I8575237c9c14f1edf53be3605fba962c0b7de3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476915Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#817645}
-
harrisonsean authored
If a user accesses the Google Services settings page through the Safe Browsing Check row of the safety check and clicks done, then the Google Services Coordinator is not properly stopping and crashing the browser. This makes sure that the Google Services coordinator is stopped when done is clicked. Bug: 1078782 Change-Id: I3f0679b9d501095aabb8560b27c22993e4d99607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474915 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#817644}
-
Idries Hamadi authored
AwContents currently attaches the PreDraw listener all the time, but it does nothing unless WEBVIEW_MEASURE_SCREEN_COVERAGE is enabled. This may be the cause of a perf regression. This CL changes the behaviour of WEBVIEW_MEASURE_SCREEN_COVERAGE so that the listener will not even be attached unless the flag is enabled. Bug: 1138032 Change-Id: I3e2f792c16bdccc0cc9f8f57e1490f70414b4bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475853Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Idries Hamadi <idries@google.com> Auto-Submit: Idries Hamadi <idries@google.com> Cr-Commit-Position: refs/heads/master@{#817643}
-
Andrew Grieve authored
Requires adding expectations in //clank as well in a separate commit. Bug: 1117577 Change-Id: I149718ae175c3709d657bc7822b18236fd6690d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475974Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#817642}
-
kylechar authored
This is a reland of 0be396a2. Using SharedImageRepresentationFactory if Mailbox::IsSharedImage() returns true caused failures on AMD GPU FYI bot. Remove that change from the CL to land. Original change's description: > Fix Windows overlay texture lifetime > > With SkiaRenderer on Windows overlay textures weren't kept alive after > the client destroys them if still in use. Implement something in > SkiaOutputDeviceGL that is similar SkiaOutputDeviceBufferQueue where we > keep a map of mailboxes to textures to keep alive. Instead of using > SharedImageRepresentationOverlay we have to use GLImage still as not all > Windows video paths are using shared image. > > Bug: 1136194 > Change-Id: Ibeb5726b914058c0868a90dcc9bca74a8499c660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462038 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817164} Bug: 1136194 Change-Id: I601814a082a26d6025c376b984d3a9005c8c94be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475978 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#817641}
-
Stephanie Kim authored
Bug: 1136565 Change-Id: I38d3499f359cfca44b5c7d88dc4907edde6aa9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473038 Commit-Queue: Stephanie Kim <kimstephanie@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#817640}
-
Joon Ahn authored
With data initialized to 0, you can somewhat see the plot line at y=0. This has the potential to be misinterpreted. Bug: 1125150 Change-Id: I3422359f1ef5d21c5376a633af9c16cb0d803ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476518 Commit-Queue: Joon Ahn <joonbug@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Joon Ahn <joonbug@chromium.org> Reviewed-by:
-
