GitLab

Allow a bit of wiggle room in highlight's bounding box. This should help reduce the noise on speed index. Previously, we were searching through the frames for when the orange highlight disappears, but with compression artifacts we might see a slight variations in each frame's highlight bounding box.


BUG=

Review URL: https://codereview.chromium.org/152643010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251010 0039d316-1c4b-4281-b951-d872f2087c98

Adds InstantExtendedEnabledParam('&espv') to the search request URL iff the query extraction flag is enabled in field trials.
- When the query extraction is turned off, InstantExtended UI is not enabled in search results page. Therefore, InstantExtendedEnabledParam is unused.
- InstantExtendedEnabledParam() need not be a part of SearchTermsData. Therefore, moved InstantExtendedEnabledParam() from SearchTermsData to search.cc.
- Added unit tests.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/151813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251009 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by my recent forwarder refactor.

BUG=
Notry=true

Review URL: https://codereview.chromium.org/162433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251008 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251007 0039d316-1c4b-4281-b951-d872f2087c98

Add mvrable to activity_log OWNERS files, and add a note saying to only ask mpcomplete for review if felt and mvrable can't be reached.

BUG=none

Review URL: https://codereview.chromium.org/148003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251006 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/162703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251005 0039d316-1c4b-4281-b951-d872f2087c98

Add the following new histograms:

  Power.ShutdownReason
  Power.SuspendAttemptsBeforeCancel
  Power.SuspendAttemptsBeforeSuccess

Also deprecate Power.RetrySuspendCount, which was both
poorly-defined and broken.

BUG=337508

Review URL: https://codereview.chromium.org/161103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251004 0039d316-1c4b-4281-b951-d872f2087c98

> Exclude notification strings for builds that dont use it.
> 
> BUG=326023
> 
> Review URL: https://codereview.chromium.org/160113002

Broke win64 sync tests, e.g. output:

c:\b\build\slave\cr-win-rel-x64\build\src\chrome\browser\sync\test\integration\sync_test.cc(707): error: Value of: UTF16ToASCII(browser()->tab_strip_model()->GetActiveWebContents()-> GetTitle())
  Actual: ""
Expected: "Notifications enabled"

TBR=aurimas@chromium.org

Review URL: https://codereview.chromium.org/163713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/157383010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251002 0039d316-1c4b-4281-b951-d872f2087c98

UdpTransport is used by cast sender and receiver. When used in the cast
sender a bind cannot be done. So UdpTransport should use UdpSocket
and perform bind or connect based on the value of remote and local
address.

Tested this with cast_sender_app and cast_receiver_app.

Review URL: https://codereview.chromium.org/161913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251001 0039d316-1c4b-4281-b951-d872f2087c98

This API allows pp::Resource objects to be read and written to pp::Vars.

Moved the methods of PPB_VarResource_Dev (C API) to PPB_Var version 1.2.
Moved the methods of pp::VarResource_Dev (C++ API) to pp::Var.

Code written against the dev API will no longer compile, as references
to the API need to be updated to use Var instead of VarResource_Dev.
Binaries compiled against the dev API will now experience run-time
errors loading the old interface.

BUG=177017

Review URL: https://codereview.chromium.org/148213016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251000 0039d316-1c4b-4281-b951-d872f2087c98

Access now happens through the PasswordManagerDriver or PasswordManagerDelegate.

BUG=334670,335107

Review URL: https://codereview.chromium.org/152133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250999 0039d316-1c4b-4281-b951-d872f2087c98

BUG=340957
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/163703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250998 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250997 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/160933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250996 0039d316-1c4b-4281-b951-d872f2087c98

The "Use system title bar and borders" preference can now be set on
Linux Aura, through the settings page or tabstrip menu, and is used to
determine whether the system title bar or custom Chrome title bar style
is used. Changing the preference dynamically updates the browser style.

Removed the --use-system-title-bar flag.

BUG=317859

Review URL: https://codereview.chromium.org/146363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=218627

Review URL: https://codereview.chromium.org/150203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342325

Review URL: https://codereview.chromium.org/139983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250993 0039d316-1c4b-4281-b951-d872f2087c98

Now that Promises have arrived in stable, we can start using them.
This change converts onStateChange to use promises and adds rudimentary
unit test support to handle this new feature.

V8's Promises are not used because the Javascript test harness expects
tests to complete synchronously. Promises, which run asynchronously, may
still be pending at the completion of a test, causing the test case to fail.

BUG=164227

Review URL: https://codereview.chromium.org/158003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250992 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250991 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=gcasto@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/153243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250990 0039d316-1c4b-4281-b951-d872f2087c98

r1852: (sdefresne) Fix generation for ninja of multiarch executable targets
r1851: (sdefresne) Use "formats" parameter to TestGyp to filter the format
r1850: (sdefresne) Improve ninja's Xcode emulation
r1849: (sdefresne) Extract XcodeVersion to be a standalone module function
r1848: (sdefresne) Fix comparison of Xcode version
r1847: (scottmg) Ninja generator: check if meminfo exists before reading it.

BUG=314720
R=blundell

Review URL: https://codereview.chromium.org/148903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342585
TEST=Remove the OFFICIAL_BUILD ifdefs and:
1) Confirm that running with --force-fieldtrials with an unforceable experiment and a forceable one only forces the forceable one.
2) Confirm that the value which couldn't be forced in the browser also makes it unforced in the renderer.

Put the OFFICIAL_BUILD ifdefs back and confirm that unforceable experiments are still forceable in non-official builds.

Review URL: https://codereview.chromium.org/153913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250988 0039d316-1c4b-4281-b951-d872f2087c98

    
    The program reads an H.264 bitstream file and writes a file containing
    the decoded frames in I420 format. Alternatively it verifies MD5 sum
    of the decoded frames. It can be used for development verification and
    regression testing.
    
    BUG=none
    TEST=run through H.264.1 Base/Ext/Main profile test streams on link.

Review URL: https://codereview.chromium.org/27498002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250987 0039d316-1c4b-4281-b951-d872f2087c98

The plan to use <dialog> in WebUI didn't work out. It was risky to use
an experimental feature in Settings, especially as Chrome for iOS won't
be able to use it.

BUG=276825

Review URL: https://codereview.chromium.org/156853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250986 0039d316-1c4b-4281-b951-d872f2087c98

We should update the manifest file as well as the contents of the extension in
the chromeos image.

BUG=342308
TEST=none

Review URL: https://codereview.chromium.org/162593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250985 0039d316-1c4b-4281-b951-d872f2087c98

For example, it supports running two GPU threads.

This simplifies the scheduling/queuing logic in InProcessCommandBuffer
a bit and moves the non-thread/queue implementation out to WebView by
allowing for passing in a InProcessCommandBuffer::Service instance
when creating a context.

BUG=332146

Review URL: https://codereview.chromium.org/143023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250984 0039d316-1c4b-4281-b951-d872f2087c98

- Variable renaming: they should be prefixed with received_ so that
  reviewer can understand that they store values received from the
  server
- HandleFrame() is just a part of ProcessFrame(). I want them to have
  names from which we can see that
- Factor out the switch-clause in HandleFrame building a frame type
  string as the method is very long

BUG=none

Review URL: https://codereview.chromium.org/131333010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250983 0039d316-1c4b-4281-b951-d872f2087c98

A UserStyleLevel parameter is no longer used in insertUserStyleSheet()
and insertUserStyleSheet() calls just insertStyleSheet() again.

blink side: https://codereview.chromium.org/143203006

Review URL: https://codereview.chromium.org/154113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250982 0039d316-1c4b-4281-b951-d872f2087c98

Like linux, on android we can get the thread names to show up in the
debugger by setting the process name for the LWP.

This change sets the name of the calling thread using prctl.

BUG=332881

R=jam@chromium.org
R=torne@chromium.org

Review URL: https://codereview.chromium.org/144943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332032
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/132803012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250980 0039d316-1c4b-4281-b951-d872f2087c98

Update deps whitelist to match current downstream merge list.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/163323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250979 0039d316-1c4b-4281-b951-d872f2087c98

> suppress data race on media::CoreAudioUtil
> BUG=314654
> TBR=ygorshenin@chromium.org
> TEST=waterfall
> 
> Review URL: https://codereview.chromium.org/57643003

TBR=zhaoqin@google.com
BUG=314654

Review URL: https://codereview.chromium.org/163253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250977 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService (https://codereview.chromium.org/137753012/)

Reason for revert:
Possible build bustage on Win64.

Original issue's description:
> [sync]: add ManagedUserSigninManagerWrapper and pass to ProfileSyncService
> 
> BUG=80194
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250814

TBR=bauerb@chromium.org,rogerta@chromium.org,pavely@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=80194

Review URL: https://codereview.chromium.org/162943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250967 0039d316-1c4b-4281-b951-d872f2087c98

If a channel closes right before a send call, listeners might not be notified of
the problem, which can cause hangs. This CL fixes that and adds a test that makes
sure that this does not happen in the future.

This is cl/30133002 + a memory leak fix.

BUG=338709

Review URL: https://codereview.chromium.org/150893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250964 0039d316-1c4b-4281-b951-d872f2087c98

Add GCM check in status code metric collection. We also decided to collect registration success signal now.

BUG=284553

Review URL: https://codereview.chromium.org/158023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250963 0039d316-1c4b-4281-b951-d872f2087c98

We should use LF-only unless it is really necessary (e.g. .BAT files).
Probably this was introduced by crrev.com/250068.

BUG=none
TBR=mnaganov@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/162763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250962 0039d316-1c4b-4281-b951-d872f2087c98

Move the sources! section out of link_settings, where it was
being ignored.

BUG=330074

Review URL: https://codereview.chromium.org/150973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250961 0039d316-1c4b-4281-b951-d872f2087c98

When a profile is being signed out, we need to:
1) Close all the requests and connections.
2) Delete the GCM store.
3) Delete the persisted registration info (sender IDs and
   registration ID) from the app's state store.
4) Delete the persisted data from prefs store

To support 3, we need to remember the IDs of all registered
apps. As the result, I added the code to write the IDs of
all registered apps to the prefs store.

Also due to this change, we do not need to listen to 
NOTIFICATION_EXTENSION_LOADED and load the registration info
when the app is loaded because we will restore all the app
IDs and then read all the registration info when GCMProfileService
starts. This also makes us support other types of apps.

BUG=284553
TEST=new tests added

Review URL: https://codereview.chromium.org/162233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250958 0039d316-1c4b-4281-b951-d872f2087c98

The idea came first while I found this code was using google_breakpad's
scoped_ptr version rather than base's version.

Then I saw in win8/ that this function could return a scoped_ptr to make
it clear the ownership to caller, i.e., this function passes the
ownership of ExceptionHandler to the caller, so it should own the
pointer to release it when it is done.

BUG=None
TEST=None
R=grt@chromium.org

Review URL: https://codereview.chromium.org/160283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250957 0039d316-1c4b-4281-b951-d872f2087c98