GitLab

0 is not a valid close code, but we're passing through the other invalid
codes. Let's apply the rule also to 0 for consistency.

R=ricea
BUG=428794

Review URL: https://codereview.chromium.org/690753009

Cr-Commit-Position: refs/heads/master@{#302233}

The app will be installed as an external component, as we don't want it to be
uninstalled by users.

TEST=Tested manually that the extension gets downloaded on startup.
BUG=427775

Review URL: https://codereview.chromium.org/686993003

Cr-Commit-Position: refs/heads/master@{#302232}

Related CLs:
http://crrev.com/658013002
http://crrev.com/679383002

BUG=423257
TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged

Review URL: https://codereview.chromium.org/693123002

Cr-Commit-Position: refs/heads/master@{#302231}

BUG=315436
TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.*

Review URL: https://codereview.chromium.org/663513003

Cr-Commit-Position: refs/heads/master@{#302230}

This patch implements the storage::WatcherManager interface, which simply calls
the Add/RemoveWatcher methods on ProvidedFileSystemInterface implementations.

An additional callback has been added to AddWatcher, so it's easy to notify
WatcherManager about changes. Without that, we would have to observe provided
file system objects and store callbacks passed to WatcherManager::AddWatcher,
which would make the code complex.

Along the way the storage::WatcherManager interface has been refactored to have
consistent naming with FSP watching methods.

TEST=unit_tests: *ProvidedFileSystem*
BUG=248427

Review URL: https://codereview.chromium.org/689603002

Cr-Commit-Position: refs/heads/master@{#302229}

Tests for some of the ChromeOS UI elements, including:
- shelf and app launcher
- system tray
- volume/brightness sliders
- notifications
- overlay mode

BUG=None
TEST=this

Review URL: https://codereview.chromium.org/687353004

Cr-Commit-Position: refs/heads/master@{#302228}

BUG=427334

Review URL: https://codereview.chromium.org/689473002

Cr-Commit-Position: refs/heads/master@{#302227}

* Removes an image without [alt] from being spoken
* Adds a label to summary (e.g. Printing: 1 sheet of paper.)
* Removes "Loading preview..." from screen readers (hidden with opacity: 0 only)
* Adds more info to the custom pages input ("e.g. 1-3, 5, 8-11")

R=dmazzoni@chromium.org
BUG=383955

Review URL: https://codereview.chromium.org/697463002

Cr-Commit-Position: refs/heads/master@{#302226}

For such a small change, I don't think we need to run an experiment.

BUG=416148

Review URL: https://codereview.chromium.org/695693002

Cr-Commit-Position: refs/heads/master@{#302225}

This patch makes the icons smaller plus fixes the mask, so they are always
white (except transparent pixels) when selected.

TBR=fukino@chromium.org
TEST=Tested manually with 3 different icons.
BUG=412602

Review URL: https://codereview.chromium.org/693073002

Cr-Commit-Position: refs/heads/master@{#302224}

/** @type {number} */ cr.defineProperty(a, 'c'); doesn't compile because of the warning misplacedTypeAnnotation.
As the warning is from parser, it can not be suppressed by @suppress tag.
So this CL suppress the warning by compile option.

BUG=421562

Review URL: https://codereview.chromium.org/687453007

Cr-Commit-Position: refs/heads/master@{#302223}

Currently when tab manager is shown and user presses back key
then instead of hiding tab manager page is navigated to previous
entry. If there is nothing to navigate then application is exited.
Added code to hide tab manager view if back key is pressed and tab
manager view is on.

BUG=

Review URL: https://codereview.chromium.org/689583002

Cr-Commit-Position: refs/heads/master@{#302222}

When opening an archive with the new ZIP unpacker based on the File System
Provider API, we need to open on once it's mounted in the left nav.

However, in the current design, we can't say if a newly mounted volume is
a result of opening an archive.

As a temporary workaround, this CL makes Files app open all FSP based volumes
once they are mounted, but only in the focused window.

TEST=Tested manually with the new ZIP unpacker.
BUG=427776

Review URL: https://codereview.chromium.org/695713002

Cr-Commit-Position: refs/heads/master@{#302221}

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/693503002

Cr-Commit-Position: refs/heads/master@{#302220}

We'll soon remove AthenaStartPageView, so AppList independent
components like background should belong to HomeCardView.

This CL also fixes the bug of the visual effect; the spec is
saying that the gradient end should be white even in
the BOTTOM state.

BUG=425717
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/692643003

Cr-Commit-Position: refs/heads/master@{#302219}

This CL:
- Moves the constants in magnifier_constants.h and accessibility_delegate.h
  to ui/chromeos/accessibility_types.
- Stops compiling MagnificationManager on Athena

BUG=426561, 408733
TEST=None

Review URL: https://codereview.chromium.org/682943002

Cr-Commit-Position: refs/heads/master@{#302218}

This CL introduces a flag to switch nacl_helper binary for NaCl in Non-SFI
mode. When the flag, nacl_helper_nonsfi binary is used, otherwise nacl_helper
binary in Non-SFI mode is used.
nacl_helper_nonsfi binary is under development, and this flag is for
its experiment. Also, the flag will be used to run browser_tests with
nacl_helper_nonsfi binary (similar to NaClBrowserTestNonSfiMode test suites).

BUG=358465
TEST=Ran trybot. Ran browser tests locally with local modification on
NaClBrowserTestNonSfiMode and made sure the binary is actually switched.

Review URL: https://codereview.chromium.org/676323002

Cr-Commit-Position: refs/heads/master@{#302217}

BUG=424679
TEST=covered by existing tests

Review URL: https://codereview.chromium.org/685133004

Cr-Commit-Position: refs/heads/master@{#302216}

Added GetAccessibleState to DialogDelegateView to return the proper
accessibility state, and added a call to NotifyAccessibilityEvent which
fires when the dialog opens.
Implementation details on comment #6 on bug.

BUG=425311

Review URL: https://codereview.chromium.org/691703002

Cr-Commit-Position: refs/heads/master@{#302215}

BUG=427114
TEST=None

Review URL: https://codereview.chromium.org/687903004

Cr-Commit-Position: refs/heads/master@{#302214}

This changes licenses.py to collect the license version information
during ParseDir, as an optional field.  This is for scripts that
import this script as a module, that may need this information.

Additionally, this removes the "Required Text" support from
licenses.py, because it was only used by SwiftShader, which no
longer needs this functionality.

BUG=424424

Review URL: https://codereview.chromium.org/660163002

Cr-Commit-Position: refs/heads/master@{#302213}

This function (documented as SetProcessDpiAwareness but exported as
SetProcessDpiAwarenessInternal) has a return type of HRESULT but we
declared it as returning BOOL. This triggered the following /analyze
warning:

src\chrome\app\chrome_exe_main_win.cc(104) : warning C6216:
   Compiler-inserted cast between semantically different integral
   types:  a Boolean type to HRESULT.

BUG=427616

Review URL: https://codereview.chromium.org/691903002

Cr-Commit-Position: refs/heads/master@{#302212}

This CL adds permissions block list for extensions. Currently only simple API permissions are supported, and the block list applies to both required and optional permissions of extensions.

BUG=177351

Review URL: https://codereview.chromium.org/595363002

Cr-Commit-Position: refs/heads/master@{#302211}

In subsequent changes, this will be used across platforms to replace all answer json parsing.

BUG=427107

Review URL: https://codereview.chromium.org/669573005

Cr-Commit-Position: refs/heads/master@{#302210}

Fix the width of location bar will be less than the minimum width, when
dragging the browserActionsContainer to the left.

Before the browserActionsContainer will translate on x-axis, sending a
notification to see whether it will be allowed. This will give the
toolbar controller a chance to check if the width of location bar will
reach the minimum by dragging the browserActionsContainer.

BUG=329842
TEST=manually tested.

Review URL: https://codereview.chromium.org/636283004

Cr-Commit-Position: refs/heads/master@{#302209}

WaitForExitCode already handles closing the processes handle, so we
shouldn't be double closing it.

TBR=waffles
BUG=428957

Review URL: https://codereview.chromium.org/689993003

Cr-Commit-Position: refs/heads/master@{#302208}

This reverts commit ac77ecc7.

Speculative revert.
ResourceDispatcherHostBrowserTest.CrossSiteNavigationErrorPage started
flaking on Mac ASan and Mac ASan 64 following this change.

BUG=374264

Review URL: https://codereview.chromium.org/691323002

Cr-Commit-Position: refs/heads/master@{#302207}

Review URL: https://codereview.chromium.org/691223002

Cr-Commit-Position: refs/heads/master@{#302206}

TBR=vsevik
BUG=

Review URL: https://codereview.chromium.org/696553002

Cr-Commit-Position: refs/heads/master@{#302205}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9bde31e..d8aa7b7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/688953002

Cr-Commit-Position: refs/heads/master@{#302204}

This relands https://codereview.chromium.org/683583002/

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/695583002

Cr-Commit-Position: refs/heads/master@{#302203}

When no browsers are open and About Chrome, Preferences or
the Task Manager are selected from the menu, the guest profile is by
default used. If the guest profile preference is disabled, then first
show the user manager, then direct to the selected page.

This is somewhat of a follow up to: https://codereview.chromium.org/564453003

BUG=412862

Review URL: https://codereview.chromium.org/631163004

Cr-Commit-Position: refs/heads/master@{#302202}

This update includes the ones used in CL 576313002 (https://codereview.chromium.org/576313002/).

BUG=405690, 406200

Review URL: https://codereview.chromium.org/686223002

Cr-Commit-Position: refs/heads/master@{#302201}

Previously it was true to maintain consistency with the options_page key, but
this introduces more complexity than it avoids for extension developers.

BUG=414920
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/670623004

Cr-Commit-Position: refs/heads/master@{#302200}

This is a spinoff from: https://codereview.chromium.org/680193002/

BUG=NONE

Review URL: https://codereview.chromium.org/688343003

Cr-Commit-Position: refs/heads/master@{#302199}

This CL adds the following tests to app_shell_browsertests:
AppViewTest.TestAppViewGoodDataShouldSucceed
AppViewTest.TestAppViewRefusedDataShouldFail
AppViewTest.TestAppViewWithUndefinedDataShouldSucceed

BUG=352293

Review URL: https://codereview.chromium.org/643703007

Cr-Commit-Position: refs/heads/master@{#302198}

After landing of https://codereview.chromium.org/651593002,
the inheritance relationship between RendererAccessibility and
RendererAccessibiltiyComplete is not necessary anymore.
So we can make them one class.

BUG=417758

Review URL: https://codereview.chromium.org/688173002

Cr-Commit-Position: refs/heads/master@{#302197}

BUG=408328

Review URL: https://codereview.chromium.org/696453002

Cr-Commit-Position: refs/heads/master@{#302196}

BUG=428538

Review URL: https://codereview.chromium.org/690083005

Cr-Commit-Position: refs/heads/master@{#302195}

Since we deleted the gfx::screen each time we closed an app,
A query to the screen size during metrics gathering was causing
a check failure.

BUG=

Review URL: https://codereview.chromium.org/691023003

Cr-Commit-Position: refs/heads/master@{#302194}