- 23 May, 2019 40 commits
-
-
Krishna Govind authored
This reverts commit 2f05fdbf. Reason for revert: Breaks chrome translation, crbug 966547 Original change's description: > DevTools: Added GRD/GRDP files for all localizable strings in the DevTools. > > This change includes... > * A main GRD file for the DevTools (front_end/langpacks/devtools_ui_strings.grd) > * GRDP files organized by subfolder > * A node script that keeps the GRD/GRDP files in sync with the keys in the DevTools frontend > * A git cl presubmit --upload check that runs the node script > > Note: Subsequent changes will add a build step to generate a .pak file that contains these DevTools strings. You can read about the overall approach here (https://bugs.chromium.org/p/chromium/issues/detail?id=941561). > > > Details of this design: > ====================== > We followed a similar pattern used by WebUI where strings are encoded in GRIT GRD/P files, which are used by a localization service to perform translations. They are also consumed in the build step to generate a .pak file, which is loaded by the browser's resource system. > > Chromium documentation: > * https://www.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-guide > * https://www.chromium.org/developers/design-documents/ui-localization > > Frontend strings: > ----------------- > These are the localizable strings that are displayed to the user. > > GRDP <message> strings: > ----------------------- > Each frontend string has a corresponding <message> entry in a GRDP file. These entries are what the localization service will use to perform localizations. It's also the input to the GRIT compiler, which generates a .pak file, which is loaded by the browser's resource_bundle system. > > GRDP <messsage> placeholders: > ---------------------------- > Frontend strings use placeholders, which are used to substitute in values at runtime. > For example, > 'This string has %s two placeholder %.2f.' > > Since the order of the string may change in a different language, we need to encode the order of the placeholders. As such, in the GRDP file you'll find %s replaced with $[1-9]. > > For example, > 'This string has <ph name="ph1">$1s</ph> two placeholder <ph name="ph2">$2.2f</ph>.' > > Also, note that the precision and type of the placeholder is maintained (i.e. .2f). > > Detecting changes: > ----------------- > The check_localizable_resources.js script performs the following check and generates an error if there are any changes that need to be made to a GRDP file. > > 1. Parses the frontend strings and hashes them. > 2. Reads the messages from the GRDP files and hashes them. > 3. Uses a difference between these two sets to report which strings need to be added and/or removed from GRDP files. > > Optionally, the user can specify --autofix and it will automatically update the appropriate GRDP files. > > Presubmit check: > --------------- > Running git cl presubmit --upload will run the check_localizable_resources.js script with the --autofix argument. > > If there are any changes, they reported to the user like this. > > ** Presubmit ERRORS ** > Error: Found changes to localizable DevTools strings. > DevTools localizable resources checker has updated the appropriate grdp file(s). > Manually write a description for any new <message> entries. > Use git status to see what has changed. > > BUG=941561 > > Change-Id: I5ac1656a037a6aaffeb4f64b103c4daec28be39a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613921 > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#662371} TBR=alph@chromium.org,einbinder@chromium.org,exterkamp@chromium.org,jeffish@microsoft.com,lomitch@microsoft.com Change-Id: Ic4ca7d000d10b2bc61b585198469ca30f051dc62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627943Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#662798}
-
Majid Valipour authored
Bug: 930196 Change-Id: I670db243b71c4a99aaa31a942de3ed6cb06ebe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614966 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#662797}
-
John Rummell authored
Add the UMA "Media.EME.MediaDrm.GetOriginIdResult" to record how the pre-provisioned origin ID was obtained (or if it failed). Tested manually by going to the Shaka demo site, playing some Widevine encrypted content, and then checking the UMA locally by viewing chrome://histograms. Bug: 963629 Test: tested manually and MediaDrmOriginIdManagerTest unit_tests pass Change-Id: Ia9df557283df72e7b90eaf004f839a127c15a2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614681Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#662796}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/58c71db1b344..c1b36669db55 git log 58c71db1b344..c1b36669db55 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 hbos@webrtc.org Revert "Delete STACK_ARRAY macro, and use of alloca" 2019-05-23 titovartem@webrtc.org Fix chromium autoroller to parse new clang revision format 2019-05-23 eladalon@webrtc.org RtpVideoSender nits 2019-05-23 srte@webrtc.org Cleanup of video packet overhead calculation. 2019-05-23 jakobi@webrtc.org Improve NetEq network adaptation in the beginning of the call. 2019-05-23 nisse@webrtc.org Delete STACK_ARRAY macro, and use of alloca 2019-05-23 sprang@webrtc.org Fix incorrect libvpx vp9 dynamic rate control settings 2019-05-23 mirtad@webrtc.org Add option to configure raw RTP packetization per payload type. 2019-05-23 crodbro@webrtc.org Add a config flag to disable the audio ALR probing request. 2019-05-23 nisse@webrtc.org Remove hex_encode functions with raw buffer output from the header file 2019-05-23 nisse@webrtc.org Delete unused method ModuleRtpRtcpImpl::SendCompoundRTCP 2019-05-23 ssilkin@webrtc.org Add sizes of spatial layer frames to EncodedImage 2019-05-23 noahric@chromium.org Lowercase windows includes in desktop_capture/. 2019-05-22 qingsi@webrtc.org Replace a broken assumption in candidate gathering for mDNS candidates. 2019-05-22 kwiberg@webrtc.org WebRTC Opus C interface: Add support for non-48 kHz encode sample rate 2019-05-22 hbos@webrtc.org Implement RTCMediaSourceStats and friends in standard getStats(). Created with: gclient setdep -r src/third_party/webrtc@c1b36669db55 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:944577 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieeb598b75d2baad4a0676b3fd6fffd3d69d59b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662795}
-
Austin Eng authored
https://dawn.googlesource.com/dawn.git/+log/1c85976abe4e..820a04b9ce6b git log 1c85976abe4e..820a04b9ce6b --date=short --no-merges --format='%ad %ae %s' 2019-05-22 brandon1.jones@intel.com Add Debug Marker Functionality for D3D12 2019-05-22 enga@chromium.org Implement CreateBufferMapped in dawn_wire CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Iacf4cf59abf99912a270f57d7dcf54540fa6a1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627576Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#662794}
-
David Trainor authored
This reverts commit b43c535e. The original patch had a StrictMode violation while accessing preferences. Original description: - Add a persistence layer to save a proto when we attempt to start an update. - Add a startup analyze step that compares the proto with the current app state to figure out if a startup was successful. - Add two types of success attribution metrics: session and time window. - Session tracks the first session where we see no active update. - Time window tracks that an update occurs within a current window of time (regardless of session). BUG=953112 TBR=isherman@chromium.org Change-Id: I0284a5c7609647212dc013982af1a77334f278db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626529 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#662793}
-
Caroline Rising authored
Bug: 910739 Change-Id: Id585045006d8548dfefeb0742157d356e2ac5dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626132 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#662792}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6779e5e01b13..e2cb4e0573e3 git log 6779e5e01b13..e2cb4e0573e3 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 samans@chromium.org Fix build file 2019-05-23 sugoi@google.com Fix sRGB -> sRGB multisample resolves 2019-05-23 bclayton@google.com VkQueryPool: Add missing lock on the Query. 2019-05-23 bclayton@google.com Vulkan: Always call the object's destructor before deallocation. 2019-05-23 bclayton@google.com Reimplement sw::Resource with modern C++ primitives 2019-05-23 bclayton@google.com System: Replace concurrent types with std versions where possible 2019-05-23 bclayton@google.com SpirvShader: Restore the current block ID after emitting loop blocks 2019-05-23 bclayton@google.com System/Synchronization.hpp: Remove unlock() call before notify_one() 2019-05-23 bclayton@google.com System/Synchronization.hpp: Add file documentation and warning. 2019-05-23 bclayton@google.com VkQueue: Embed the sw::Renderer into the vk::Queue. 2019-05-23 bclayton@google.com VkQueue: Destruct the object. 2019-05-23 bclayton@google.com VkQueue: Use a sw::WaitGroup for waitIdle() 2019-05-23 bclayton@google.com Pass around sw::TaskEvents* instead of vk::Fence*. 2019-05-23 bclayton@google.com System/Synchronization.hpp: Add the sw::TaskEvents interface Created with: gclient setdep -r src/third_party/swiftshader@e2cb4e0573e3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/133127573,chromium:b/133127573,chromium:b/133127573,chromium:b/133212545,chromium:b/133135427,chromium:b/133135427,chromium:b/133127573,chromium:b/133127573,chromium:b/133127573,chromium:b/133127573,chromium:b/133127573 TBR=swiftshader-team+autoroll@google.com Change-Id: I2b0a4ba4f28d1ac711ae8c3135cd2656535fae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662791}
-
Jan Wilken Dörrie authored
This change modifies browser code to use the newly introduced FocusedFieldType enum instead of multiple bool parameters. Bug: 957532 Change-Id: Ia25197b3c1dfdd2915a0eb9b35921c2c72bed3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615028Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#662790}
-
Edin Kadric authored
We would set this variable to false to prevent the menu from coming down if the EditableCombobox gets focus automatically (as soon as the password bubble is shown for example). We now remove it, so focusing on the EditableCombobox always brings down the menu, and instead we make sure that the username EditableCombobox doesn't get focus automatically when the password bubble is shown. When the bubble shows up automatically the new Widget wouldn't get focus anyway so there is no issue there. When the bubble shows up due to the user clicking the key icon in the URL bar, the Widget would become active, and in turn the username EditableCombobox would get focus. This CL changes this behavior: The Widget still becomes active, but the username doesn't get focus. The only scenario in which the username also gets focus is when there are no suggested usernames, so the user can start filling it out right away. This was intended by the current code, but there was a mistake, where it was checking for |model()->pending_password().username_value.empty()| instead of |username_dropdown_->GetText().empty()|. The |username_value| variable could in fact be empty even when the control shows text in cases where there are more than one possible username. Bug: 965426 Change-Id: I5b843670beca6022f819336d9c9611940eb1e05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621395 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#662789}
-
Caroline Rising authored
This was causing focus to not properly leave the previous location when changed using F6. Bug: 910739, 966312 Change-Id: Iea9ffc70c7455665091e260586d1ba8fb96225bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625856Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#662788}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2491ddef9616..37e000347c2f git log 2491ddef9616..37e000347c2f --date=short --no-merges --format='%ad %ae %s' 2019-05-23 rmhasan@google.com [Typ] Use a file to store sub process output Created with: gclient setdep -r src/third_party/catapult@37e000347c2f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960833,chromium:960606,chromium:952105 TBR=eyaich@google.com Change-Id: Ib4750f4e135810b7631d543699d7bd999769e330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662787}
-
Caroline Rising authored
Bug: 910739 Change-Id: I33d827132f8be6363612c4f6ad0244702f40c57b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627892 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#662786}
-
Rouslan Solomakhin authored
Bug: 884680 Change-Id: Ibfb6b5c5a9a6460077b141523b412360a6a0a613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626543 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#662785}
-
Nicolás Peña Moreno authored
GetFrame() can be nullptr, so we should call GetExecutionContext() so we do the null check before calling GetDocument(). Bug: 966314 Change-Id: I09adb1fce626a5211ba23cf96d4cec9dd7b99fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627634 Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#662784}
-
Klaus Weidner authored
This helps ensure that the links work even on webservers that don't auto-redirect directories to "index.html". Automatically changed via: $ perl -pi -e \ 's{href=(['\''"])([^:]*?)/(['\''"])}{href=$1$2/index.html$3}' \ *.html */*.html Change-Id: Idc6b73e8917a7b98887978d684481888d8e8b95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627750Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#662783}
-
Caitlin Fischer authored
The call to BindRepeating that takes advantage of this change is made in a later CL. This has been separated in the interest of having smaller CLs. This will be tested through the MobileLabelFormatter work. Bug: 958333 Change-Id: I10fd35dc66c0ab7fcbb8bd29fc2ec9972de74b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626392 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#662782}
-
Ben Pastene authored
This var is overwriting the one in src-internal, so I need to whitelist the internal VM board here as well. Gonna replace this with crrev.com/c/1625812 if/when crrev.com/c/1626479 lands Bug: 947531 Change-Id: I01568d9e2cf3b7d1d195e1f8685a6d9c5d709ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625813 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662781}
-
Vincent Boisselle authored
This is a reland of 4149e2e9 Original change's description: > Reland "Added handling of large requests to Autofill API." > > This is a reland of c6677df1 > > Original change's description: > > Added handling of large requests to Autofill API. > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > added UMA metrics to keep track of URL length and associated events. > > > > This change might be needed when metadata is enabled. > > > > Bug: 948862 > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656080} > > Bug: 948862 > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#656452} Bug: 948862 Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#662780}
-
Joe Laughlin authored
Prefetching just half of the DLLs led to startup regressions so this changes it so that we prefetch the entire DLL. We now use the image size rather than the size on disk in our prefetching calculations, in order to make them more accurate. We also prefetch the DLL as non-execute to avoid callbacks that can also cause hard faults. To measure Reference Set, which is the set of pages touched between two timestamps use the following link. Reference Set enables the visualization of the impact of the switch to PrefetchVirtualMemory. https://docs.microsoft.com/en-us/windows-hardware/test/wpt/wpa-reference-set Bug: 962499 Change-Id: I32c6d7e388ce9c6a53418885aad5b3a4ba646758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611098 Commit-Queue: Joe Laughlin <joel@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#662779}
-
Bill Orr authored
This reverts commit 217bbfe0. Reason for revert: Turning WPT-Notify back on. Original change's description: > Temporarily disable WPT-NOTIFY for WebXR tests > > Bug: 923060 > > Change-Id: Ia8fb926fd2f8e2366b8d8179154f080f95e40e1f > Reviewed-on: https://chromium-review.googlesource.com/c/1418113 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#623825} TBR=ddorwin@chromium.org,bajones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 923060 Change-Id: If5d316d6cacbe785a68d7a2d8371b072485db634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626546Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662778}
-
Ben Kelly authored
In order to support moving CacheStorage off of the IO thread this CL does the following: * Makes CacheStorageDispatcherHost an internal detail of the CacheStorageContextImpl. The RenderProcessHostImpl now sends binding requests through the context. * The CacheStorageDispatcherHost becomes a SequencedBound<> object on the target SequencedTaskRunner. * As a consequence all the mojo interfaces are also bound on the target SequencedTaskRunner. * Some of the CacheStorageContextImpl initialization is also updated to respect the target SequencedTaskRunner. This CL does not update other context APIs (observers, cache_manager(), etc) to use the new TaskRunner yet. Those will come in later CLs. Bug: 960012 Change-Id: Iada6132a79952dd11b0a0ba8bfec3300d03327ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610679 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#662777}
-
Sophie Chang authored
Bug: 964385 Change-Id: I1a294e74ad561cd1fcb6a5b2a08f707c4cc0caa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618058 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#662776}
-
Daniel Rubery authored
Based on feedback from the Chrome UX team, we no longer indicate Advanced Protection's involvement on DANGEROUS downloads, and we have changed the icon for UNCOMMON downloads to prevent users habituating to the red triangle icon. We expect a sharp increase in false positives for Advanced Protection users, so this should help a little with warning fatigue. Renders: https://screenshot.googleplex.com/eei9zcKgrnv https://screenshot.googleplex.com/cgxs53j2J0t Bug: 917190 Change-Id: I7a4b3f22b66cdaf9eab5fa2236ec6cd90b1d7f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603766 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662775}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/181e44c23185..6768b27cc897 git log 181e44c23185..6768b27cc897 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6768b27cc897 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1e95c6ef9c4c043bdbf40afc1f943a7149f2e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662774}
-
Daniel Cheng authored
Change-Id: Idb25eed43a7f6f2d024e3266614fe6242cf6f1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625740Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662773}
-
Jacob DeWitt authored
According to the Gamepad spec, y axis values should have -1.0 be up and 1.0 be down. WMR, OpenVR, and Oculus device APIs have 1.0 correspond to up, so we have to flip the signs for the y axis values that come from those platforms. The Oculus gamepad builder code already flips the sign for the y axis, which is why it's not included in this CL. Note that this will also affect the WebVR gamepads in the same way. Changes to input-selection.html are to help testing and debugging WebXR gamepads. Now the page shows tables for button and axis values which are updated in real-time. Bug: 965522, 965527 Change-Id: I08a1ecf4d5f90f41edcf5574fc9fd96e043482a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626393Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#662772}
-
Eric Stevenson authored
Some debug builds of Webview have 3 dex files now. Bug: 966542 Change-Id: Ib636f086042d2eb02f08f3390993594650f501b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627662Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662771}
-
Dave Tapuska authored
Apparently some clang plugin requires the value to be specified as kMaxValue as per comment https://chromium-review.googlesource.com/c/chromium/src/+/1221696/9/ui/base/ime/text_input_action.h#24 BUG=634330 TBR=shuchen@chromium.org Change-Id: I14cce2759494c2c7df303478168ebae2135e2b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625808 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#662770}
-
Henrik Grunell authored
Feature was added in https://chromium-review.googlesource.com/c/chromium/src/+/1615018. Bug: 963810 Change-Id: I33b73b5b1527e40bd743c40f65821159b59ee818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626418Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#662769}
-
Siye Liu authored
We need to add one histogram to track number of active IMM32-based input method processor usage when TSF is disabled on Windows. Bug: 963686 Change-Id: I73433f2a3f6abb35b5e755f2f010e813718005cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617916Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#662768}
-
Esmael El-Moslimany authored
Change-Id: I87f1ec11f4fd70298f472cddeda669ceee58bee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626459Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662767}
-
Andrew Grieve authored
This reverts commit 055dc2c6. Reason for revert: Fixed webview tests (see patchset 2) Android: Never persist SharedPreferences in instrumentation tests. I'm hoping that this will reduce test flakes by removing a source of tests being able to change the behavior of other tests. * Uses InMemorySharedPreferences instead. * Asserts after each test that no SharedPreferences circumvented the fakes (which is possible by using non-application Context objects * Combines LifetimeAssertRule and CommitSharedPreferencesTestRule into a single BaseJUnit4TestRule. TBR=hanxi@chromium.org,agrieve@chromium.org,jbudorick@chromium.org,yliuyliu@google.com Change-Id: I9f15c5cdbd5a4d0fb97ccf83f2cce7293d18ca47 Bug: 441859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626963 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#662766}
-
Laís Minchillo authored
Record distribution of sslError from onReceivedSslError. Note regarding the placement of the UMA recording, onReceivedSslError is only called from AwContentsClientBridge.allowCertificateError so it should be the correct place to log this information. Bug: 948786 Change-Id: I9cb3c083534a094273221255efaaa2509144b7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601514 Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662765}
-
Kyle Horimoto authored
A refactor [1] introduced use of the <cr-link-row> element, which exposed a layout bug caused by a stray </div> tag. This CL removes that tag to fix the layout problem. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1577594 Bug: 959328 Change-Id: I307308283dead18c0e17f51e059abbeaed2afe31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627655 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662764}
-
Ian Kilpatrick authored
When positioning a new formatting-context in the presence of adjoining floats sometimes a "forced" BFC block-offset will be set twice. When this new formatting-context was wrapped in a <div> (a parent which hadn't had its BFC block-offset resolved yet) we ran into a bug with our state machine. Upon the second time resolving the BFC block-offset the parent would resolve *its* BFC block-offset to the previous "forced" BFC block-offset. Upon the final relayout the parent would set the first "forced" BFC block-offset to its children causing an "infinite" loop (if we had a loop driving this machinery. This ensures we use the child's new BFC block-offset in this case. Bug: 966278, 966214 Change-Id: I5da2f3e90b9d2ff78f124247f6f68cd3a289ae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627692 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#662763}
-
Nathaniel Steinbock authored
See change 1554130. Bug: b/132997084 Test: base_unittests Change-Id: I51769adf4402c5c78b387ff50f3b669056b4b4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622735Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Steinbock <steinbock@google.com> Cr-Commit-Position: refs/heads/master@{#662762}
-
Esmael El-Moslimany authored
Bug: 966353 Change-Id: Id66b5bb439dea81d6ab56db8763681d6510932e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627695Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#662761}
-
Eric Stevenson authored
This reverts commit 2385ddd3. Reason for revert: Broke chromium.android/android-jumbo-rel (crbug.com/966545) Original change's description: > [MFill Android] Retrieve addresses for sheet on native side > > This class adds the Address controller that collects data for the manual > fallback sheet on Android. > It does work similar to https://crrev.com/c/1599927, and the existing > PasswordAccessoryController. All three classes should be fairly similar > in behavior. > > The interface leans on the draft implementation of the bridge which > currently pulls data and might need changing to pushing data - I am open > for suggestions. > > Bug: 962548 > Change-Id: Id4c593a7af9eda815be16a85354bcfe241bc731f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614200 > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662658} TBR=tmartino@chromium.org,fhorschig@chromium.org Change-Id: I35ff714d0d57c73268da8f3ade4bb68515b861cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 962548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627457Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662760}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/459b295bedce..0dee19bacc00 git log 459b295bedce..0dee19bacc00 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 robertphillips@google.com Revert "Track quad type on GrQuad directly" 2019-05-23 herb@google.com Start using strike specs in PDF. 2019-05-23 michaelludwig@google.com Track quad type on GrQuad directly Created with: gclient setdep -r src/third_party/skia@0dee19bacc00 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: I047bb590277d7be2638986e221f69077007c7cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662759}
-