GitLab

Also put some extensions #includes behind ENABLE_EXTENSIONS.

Review URL: https://codereview.chromium.org/657643003

Cr-Commit-Position: refs/heads/master@{#300168}

BUG=418690

Review URL: https://codereview.chromium.org/645263002

Cr-Commit-Position: refs/heads/master@{#300167}

There is a bug in Mavericks for applications linked against OSX 10.8 and
earlier. It requires Screens Have Separate Spaces to be enabled, and for the
window to be on a secondary screen. When AppKit Fullscreen is invoked on the
window, its final frame is 22pt too short.

This CL detects when these specific conditions occur so that the window's size
can be fixed.

Note: This is a bug buried in AppKit. Playing with methods like
-[NSWindowDelegate window:willUseFullScreenContentSize:] will not fix the
problem.

BUG=396980

Review URL: https://codereview.chromium.org/655393002

Cr-Commit-Position: refs/heads/master@{#300166}

That's not a polynomial hash. Match base/strings/string_piece.h's hash.

BUG=none

Review URL: https://codereview.chromium.org/604363003

Cr-Commit-Position: refs/heads/master@{#300165}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bd4495c..50e6008

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/667493003

Cr-Commit-Position: refs/heads/master@{#300164}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=424386
TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/662123002

Cr-Commit-Position: refs/heads/master@{#300163}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/662603004

Cr-Commit-Position: refs/heads/master@{#300162}

BUG=424697
TEST=Test added

Review URL: https://codereview.chromium.org/659393003

Cr-Commit-Position: refs/heads/master@{#300161}

The test must be faulty, as I was able to confirm the browser exhibits
the correct behavior in the same checkout/build on my desktop.

BUG=158913
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/645023004

Cr-Commit-Position: refs/heads/master@{#300160}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none
TBR=cpu

Review URL: https://codereview.chromium.org/661833004

Cr-Commit-Position: refs/heads/master@{#300159}

If it's failing to be sent, this would explain some of the cases of the bug.

BUG=407376
TEST=no change

Review URL: https://codereview.chromium.org/648463004

Cr-Commit-Position: refs/heads/master@{#300158}

Before:
* We'd send the message "containing" the message pipe (handle) first.
* Upon receiving it, the other side would create an endpoint (and
  dispatcher, etc.)
* The other side then sent a message back indicating the new ID (and
  telling the first side to run the message pipe.
* Upon receiving that "run" message, the first side would start sending
  messages for that message pipe.

This makes for rather complicated handshaking, which would only get more
complicated if, e.g., the second side wanted to forward the message pipe
handle that it received to someone else (e.g., over another channel).

Now:
* We "remotely allocate" an ID for the other side and send a message
  telling it to create an endpoint with that ID.
* We forward all the messages queued to that message pipe endpoint
  immediately (since we already know the destination ID).
* We send the message "containing" the message pipe (handle).
* The other side then creates a dispatcher and associates it with the
  (already-existing) endpoint.

Still to do:
* We need to track IDs that we've allocated for the remote side more
  carefully (in case of wrap-around, to avoid collisions).
* Convert everything over to the "attach and run" mode of operation (and
  possibly rename "attach and run" to something shorter), and delete the
  various separate "attach" and "run" methods.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/664763002

Cr-Commit-Position: refs/heads/master@{#300157}

BUG=

Review URL: https://codereview.chromium.org/657433002

Cr-Commit-Position: refs/heads/master@{#300156}

Destroy MojoMain's RunLoop before executing tests.
Reuse the shell handle for multiple test app instances.
Add ApplicationImpl::UnbindShell for message pipe reuse.

Add Apptest, a GTEST base class for application testing.

TODO: Support/Exemplify actual command line arg use.

BUG=392646
TEST=mojo_shell 'mojo:mojo_example_apptests <gtest_args>' still works.
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/654103002

Cr-Commit-Position: refs/heads/master@{#300155}

BUG=423621

Review URL: https://codereview.chromium.org/643093003

Cr-Commit-Position: refs/heads/master@{#300154}

BUG=423049
TEST=Start Chrome with an empty user data dir and --enable-new-avatar-menu.
From the avatar menu, click on "Switch Person", and "Browse as Guest" from
the user manager. Without closing any of the profile windows, choose "Exit"
from the Guest profile's hot dog menu. Restart Chrome. It should start up
and reopen the previous non-guest opened profile.

Review URL: https://codereview.chromium.org/661603007

Cr-Commit-Position: refs/heads/master@{#300153}

R=estade@chromium.org
BUG=275265
TEST=open chrome://settings/importData in 2 windows, uncheck all checkboxes => "Import" disabled both places

Review URL: https://codereview.chromium.org/660623002

Cr-Commit-Position: refs/heads/master@{#300152}

Commit c4a3f88c ("TestWebServer needs to
use a free port") has caused TestWebServer to use a random port number
in each invocation.

This does not play well with tests that assume the server will be
running on a specific port (for example, an HTML asset trying to do XHR
whose contents cannot be changed at runtime).

start() and startSsl() can now be passed an optional port number; if it
is being used, the server will fail to start like it did before the
commit mentioned above.

R=hush@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/666513002

Cr-Commit-Position: refs/heads/master@{#300151}

This reverts commit e99bfcb9.

Going forward app_shell specific APIs will go in //extensions/shell

BUG=424651
TEST=compiles

Review URL: https://codereview.chromium.org/662473006

Cr-Commit-Position: refs/heads/master@{#300150}

This pulls in the following Native Client changes:

r13922: (shyamsundarr) cleanup special case compatibility with old validator for avx.
r13923: (mcgrathr) Update nacl_arm_newlib toolchain
r13924: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13925: (shyamsundarr) fix the check_decoder_test.
r13926: (dschuff) Fix build directory for LLVM regression test runner
r13927: (dschuff) Update revision for PNaCl r13918->r13925
r13928: (dyen) Disable flaky IRT extension thread tests on asan mac bots.
r13931: (shyamsundarr) fix lahf feature detection.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/662473004

Cr-Commit-Position: refs/heads/master@{#300149}

TBR=viettrungluu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/658373004

Cr-Commit-Position: refs/heads/master@{#300148}

This telemetry test closely mimics the android acceptance test for power.
It uses the same websites; sits on them for 20 seconds, scrolls down, sits 20 more seconds.

BUG=421569

Review URL: https://codereview.chromium.org/654263005

Cr-Commit-Position: refs/heads/master@{#300147}

BUG=none

Review URL: https://codereview.chromium.org/659313006

Cr-Commit-Position: refs/heads/master@{#300146}

BUG=

Review URL: https://codereview.chromium.org/661163002

Cr-Commit-Position: refs/heads/master@{#300145}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6fedd3a..dc89ca5

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/666543002

Cr-Commit-Position: refs/heads/master@{#300144}

This should stop the NULL dereference reported in the bug referenced below. It only targets the symptom, not the cause, though. The proper fix will hopefully come with a planned refactoring as referenced in the code comment.

BUG=420519
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/666503002

Cr-Commit-Position: refs/heads/master@{#300143}

Version was decreased from 8 to 7 after crrev.com/e8c29d4e. This shouldn't
affect very many people since the 7 -> 8 change was broken and no profiles
would be updated, but it would affect Canary users that created new profiles.
To be safe, keep the new version around but without any database changes.

BUG=423716

Review URL: https://codereview.chromium.org/663813003

Cr-Commit-Position: refs/heads/master@{#300142}

chrome.usb.getUserSelectedDevices allows an app to prompt the user for
one or more USB devices for it to access. This is an alternative to
statically declaring the list of devices an app can access in the
application manifest. This is useful for device classes such as
ADB-enabled Android devices which may have a great number of vendor and
product ID pairs but all match a well-known interface protocol.

If a selected device has a serial number then the app can retain access
to it until explicitly revoked (as is the case for most Android phones)
while access to a device without a serial number is revoked when the app
is unloaded or the device is disconnected.

BUG=346953

Review URL: https://codereview.chromium.org/599303004

Cr-Commit-Position: refs/heads/master@{#300141}

NOTRY=true

Review URL: https://codereview.chromium.org/657313004

Cr-Commit-Position: refs/heads/master@{#300140}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2e49896..bd4495c

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/663853002

Cr-Commit-Position: refs/heads/master@{#300139}

This CL also adds the web::FaviconStatus and web::SSLStatus structs.  These are
//web analogues of the //content structs of the same name.

BUG=422033,423031
TEST=None

Review URL: https://codereview.chromium.org/640253007

Cr-Commit-Position: refs/heads/master@{#300138}

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/637223010

Cr-Commit-Position: refs/heads/master@{#300137}

This changes android to use the target_arch build arg for setting the
target architecture instead of cpu_arch.

Some benefits of this:
non-target toolchains have knowledge of the target architecture
(required for the relocation packer host executable)
allows us to have a default target_arch different from build_cpu_arch

BUG=359249,344767

Review URL: https://codereview.chromium.org/634403004

Cr-Commit-Position: refs/heads/master@{#300136}

BUG=414363

Review URL: https://codereview.chromium.org/660153002

Cr-Commit-Position: refs/heads/master@{#300135}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/656363002

Cr-Commit-Position: refs/heads/master@{#300134}

Non chrome:// URLs don't have WebUI objects.

BUG=423278

Review URL: https://codereview.chromium.org/657173002

Cr-Commit-Position: refs/heads/master@{#300133}

R=cpu@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/665543002

Cr-Commit-Position: refs/heads/master@{#300132}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/644433003

Cr-Commit-Position: refs/heads/master@{#300131}

The overlay cast button had a semi-transparent CSS background color.
Unfortunately the button image is treated in Blink as a background
image, so this modified the image, rather than simply providing
a background for it. As a result the cast button came out as grey
on grey on pale backgrounds.

Fix this by making the CSS background color transparent, and
modifying the icon image itself to make its background semi-transparent.

Since the CSS is in Blink the CSS change is in the Blink CL
https://codereview.chromium.org/658353002

BUG=424180

Review URL: https://codereview.chromium.org/661833005

Cr-Commit-Position: refs/heads/master@{#300130}

Also removes a couple more PassAs() calls.

BUG=423621

Review URL: https://codereview.chromium.org/654263004

Cr-Commit-Position: refs/heads/master@{#300129}