- 01 Feb, 2019 40 commits
-
-
Martin Kreichgauer authored
Cryptotoken used to tolerate challenges and key handles encoded in either regular base64 or base64url, despite the spec only allowing base64url. With the WebAuthenticationProxyCryptotoken feature enabled, this is no longer the case: WebAuthn takes challenges and key handles as raw byte inputs, and re-encodes them to base64url prior to signing. Until now, if cryptotoken failed to base64url-decode a challenge for keyHandle before sending it to WebAuthn, it would send an empty byte sequence instead. Hence, if a non-compliant passed a challenge encoded in regular base64, it would subsequently receive a response, but the challenge field in the response would be empty and signature would be over the empty challenge. This change makes the failure to decode more explicit. If a challenge (or keyHandle) fails to decode, cryptotoken will not forward the request. Rather it will return a BAD_REQUEST error with a descriptive error message. Bug: 925738 Change-Id: I7e1d0bfca55765ccdfaf7b9762c8b79352fb2856 Reviewed-on: https://chromium-review.googlesource.com/c/1450400 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#628508}
-
Khushal authored
The test was disabled because it was flaky on TSAN bots. Unfortunately the logs from these flakes are not available anymore because the test was disabled a while ago. And the failure could not be reproduced locally. Reland the test to verify if the failure on the bots still exists. R=enne@chromium.org Bug: 851231 Change-Id: I5ae4d37f10a3173f1d3b452ab50f229f01dd748f Reviewed-on: https://chromium-review.googlesource.com/c/1450692 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#628507}
-
kylechar authored
InProcessCommandBuffer wasn't checking if exist_on_context_loss GPU workaround was set on context loss. Implement a similar check to the existing one in GpuChannelManager. To reduce code duplication push more of the logic around exiting on context loss up into GpuServiceImpl. Both InProcessCommandBuffer and GpuChannelManager can use the same logic this way through GpuChannelManagerDelegate (which should be renamed). A related change for OOP-D display compositor context creation is to not try to create a context if we are already exiting the process. This matches the logic in GpuChannel. We have to check on the viz compositor thread before starting context creation and also on the GPU thread when starting GPU thread initialization. Bug: 924148 Change-Id: I6eeb016c063063ef26ccdcaa7ad9d2ae3badcdc7 Reviewed-on: https://chromium-review.googlesource.com/c/1448518 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628506}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e13cf694d42b..33cc9c60892a git log e13cf694d42b..33cc9c60892a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 tsepez@chromium.org Add --jitless to recommended v8 flags. Created with: gclient setdep -r src/third_party/pdfium@33cc9c60892a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5a61dba1c3c5f37b3d46c8c6a43e5b48a87e438b Reviewed-on: https://chromium-review.googlesource.com/c/1450633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628505}
-
David Black authored
AssistantOverlays are views which are added to AssistantContainerView's client view. Because they are added at this level of the view hierarchy, they paint to a higher level in the layer tree than direct children of AssistantContainerView. AssistantOverlays are intended to behave as pseudo-children of views in the Assistant view hierarchy that need to paint to a high level, say to draw over top of Assistant cards. This CL adds a flag guarded AssistantNotificationOverlay which behaves as a pseudo-child of AssistantMainView and will be used to support in-Assistant notifications in Assistant. Future overlays will include a shadow that is painted above suggestion chips when the Assistant main stage can be scrolled (b:112669597). Bug: b:118654460 Change-Id: I8e9a2c9748b4ecb0fad51c2f27722890d20d4ff3 Reviewed-on: https://chromium-review.googlesource.com/c/1440906 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#628504}
-
Zhongyi Shi authored
related configurations together. Change-Id: I90cde9e3dd32859da6f95fe35959b7d37e5b1413 Reviewed-on: https://chromium-review.googlesource.com/c/1449000 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#628503}
-
Gabriel Charette authored
Accidently disabled as part of crrev.com/627191 and it caused a ton of regressions (see bugs dupped into crbug.com/927619). So we should probably ship this configuration by default, but as an emergency bandaid I'm reenabling the feature in tests (and this CL will also conveniently let us know of any regressions when reenabling should disabling have improved other metrics..!). R=skyostil@chromium.org TBR=isherman@chromium.org Bug: 927619, 891670, 885371 Change-Id: I9b737a786da5e589ad816827e8d52d439e785204 Reviewed-on: https://chromium-review.googlesource.com/c/1449575Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#628502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/263746b68633..4fa143d003ed Created with: gclient setdep -r src-internal@4fa143d003ed The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib41a4c7232d0f0e53efc829bdc5978e2e4ebd351 Reviewed-on: https://chromium-review.googlesource.com/c/1450467Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628501}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1fe1ad2c..d5b02673 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf4651e11b72322e7cc812b7bef2eda00df4f7de Reviewed-on: https://chromium-review.googlesource.com/c/1450535Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628500}
-
Wez authored
ContextProviderImpl incorrectly assumed that LaunchProcess() would take ownership of the zx::job specified in the LaunchOptions. Fix the provider not let the zx::job handle be closed after launch. To support testing of this fix, add a ScopedDefaultJobForTest helper to //base, to allow the handle returned by base::GetDefaultJob() (which ContextProviderImpl creates a per-Context job under) to be overridden for a given scope. Bug: 927403 Change-Id: I83cc6119657d82fc8d4c7a62081a1c04938a70b5 Reviewed-on: https://chromium-review.googlesource.com/c/1450614 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#628499}
-
Julie Jeongeun Kim authored
This CL removes SigninManager from bookmark_bubble_view_browsertest.cc and uses IdentityManager instead of it. Bug: 927249 Change-Id: Ifea98f39461d900747ce24fec56315489f0608cb Reviewed-on: https://chromium-review.googlesource.com/c/1449440Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628498}
-
Julie Jeongeun Kim authored
This CL removes unused header, device_id_helper.h, from ios_chrome_signin_client.mm. Bug: 927332 Change-Id: I34c9fd2254e1b4170f1030d54517d452cb414f6d Reviewed-on: https://chromium-review.googlesource.com/c/1448008Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#628497}
-
Julie Jeongeun Kim authored
This CL removes unused header, device_id_helper.h, from ios_web_view_signin_client.mm. Bug: 927333 Change-Id: I55fa8ad3a62c89d99cfcf91d9b37427f7dace6c9 Reviewed-on: https://chromium-review.googlesource.com/c/1448090Reviewed-by:
-
Dmitry Gozman authored
It seems like we don't have a session for a particular client when calling ChromeDevToolsManagerDelegate::HandleCommand. This should not be the case, so adding some DCHECKs to verify two possible root causes of such behavior (duplicate clients and wrong ClientDetached notification). Meanwhile, guard against the crash with an if statement. Bug: 927595 Change-Id: Iebbb0360ea96d6b1d4eacbfbc34a72fc5a1b8d7d Reviewed-on: https://chromium-review.googlesource.com/c/1450422 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#628495}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f738c1fe581..a1fbdff17736 git log 4f738c1fe581..a1fbdff17736 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 yuweih@chromium.org Fix filename sorting logic in git_cache.py Created with: gclient setdep -r src/third_party/depot_tools@a1fbdff17736 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:927154 TBR=agable@chromium.org Change-Id: Ie55afac652072ee9a153c60154d4c1dd680a0bd9 Reviewed-on: https://chromium-review.googlesource.com/c/1450632Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ed198faf93a..26ccfcc96f98 git log 3ed198faf93a..26ccfcc96f98 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 brianosman@google.com Remove SkICC::WriteToICC 2019-02-01 bsalomon@google.com Make GrMesh hold regular ref on GrBuffers. 2019-02-01 reed@google.com remove unneeded friends/includes in SkPaint.h 2019-02-01 kjlubick@google.com CMake: distinguish between file and dir copies by presence of '.' in src path Created with: gclient setdep -r src/third_party/skia@26ccfcc96f98 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Icfd1c576ffe0177f6a396f75668e2ebd6ecf284d Reviewed-on: https://chromium-review.googlesource.com/c/1450466Reviewed-by:
-
Caleb Rouleau authored
Looking at logs right now is slow going without this information. It seems to work: https://chromium-swarm.appspot.com/task?id=42c3fb172bd39010&refresh=10&show_raw=1 Bug: chromium:917211 Change-Id: If30ea9075a4275eb7c5aee89521a896d0c82004f Reviewed-on: https://chromium-review.googlesource.com/c/1450020Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628492}
-
Aleks Totic authored
"Disable DAA" CL https://chromium-review.googlesource.com/c/chromium/src/+/1412462 broke many NG tests because they were not rebaselined. This rebaselines NG tests so they work again. Bug: 913223 Change-Id: I96de360ee7572f1446d9a07c3ca5e7c047a2bb5c Reviewed-on: https://chromium-review.googlesource.com/c/1450202Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#628491}
-
Khushal authored
The test was disabled because of a flaky crash which has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1263043. TBR=piman@chromium.org Bug: 880948 Change-Id: I32dc675ba564fdb580840482c375237b59e3a15f Reviewed-on: https://chromium-review.googlesource.com/c/1450615Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#628490}
-
Jeremy Roman authored
Change-Id: Iccdbbe823d3d4ed2554c2527d90da8b7692a2e4e Reviewed-on: https://chromium-review.googlesource.com/c/1450282 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#628489}
-
Ned Nguyen authored
Change-Id: Ie227a7fa799c50db4f874ea2a82d1c0b1bcad5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1448511Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Auto-Submit: Ned Nguyen <nednguyen@google.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628488}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b1908cf0075b..8cd8f2f71e22 git log b1908cf0075b..8cd8f2f71e22 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 pprabhu@chromium.org config: Migrate asuka-release to use Skylab Created with: gclient setdep -r src/third_party/chromite@8cd8f2f71e22 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1db8a4d214337d576443ce84b826d3b860228b82 Reviewed-on: https://chromium-review.googlesource.com/c/1450631Reviewed-by:
-
Kyle Horimoto authored
This test double will be used in my upcoming network-aware scheduler class. Additionally, I wanted to reuse the logic of the FakeDelegate class defined in DeviceSyncPersistentEnrollmentSchedulerTest, so I moved that to a shared location where it will be able to be used from my upcoming CL. Note: I also needed to add a copy constructor for CryptAuthEnrollmentResult since it is copied in this test double. Bug: 899080 Change-Id: If78f716e9f5fa0f39e9d027dccfe6b1cb92ffcf2 Reviewed-on: https://chromium-review.googlesource.com/c/1450463Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#628486}
-
Sylvain Defresne authored
Convert client of the deprecated of PrefValueMap::SetValue taking a std::unique_ptr<base::Value> to the recommended override taking a base::Value directly. The conversion is done using the following rules: - If the value is built inline using std::make_unique<base::Value> then change to just construct a base::Value directly, - If the value is built use base::Value::CreateDeepCopy(), then change to use base::Clone() which returns a base::Value instead of a std::unique_ptr<base::Value>, - If the std::unique_ptr<base::Value> is just forwarded by the caller, dcheck it is not null (the check was present in the old method implementation) and use base::Value::FromUniquePtrValue to convert the std::unique_ptr<base::Value> to a base::Value. This CL fixes uses in src/components/policy. This CL was uploaded by git cl split. Bug: 646113 Change-Id: Ief82c150539f913edd8f44f36caf566baaf39819 Reviewed-on: https://chromium-review.googlesource.com/c/1446360Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#628485}
-
Kristi Park authored
This fixes the issue where background color is not updated when dark mode is toggled. The because background_color was not updated, only the using_dark_mode param. Bug: 926601 Change-Id: I464bb7c926849eba95884bf641262e44e66b4eed Reviewed-on: https://chromium-review.googlesource.com/c/1450217Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#628484}
-
Gabriel Charette authored
This was initially a prereq for logic @ https://chromium-review.googlesource.com/c/chromium/src/+/1232518/23/base/task/sequence_manager/thread_controller_with_message_pump_impl.cc. While that CL adopted a different approach, this still feels worthwhile. A similar attempt was made for TimeBase in https://crrev.com/c/1155264 but was reverted for various concerns. It's also somewhat orthogonal to this CL because it specifically ignored the TimeTicks +/- TimeDelta issue whereas it's all this CL does (that one was about preserving infinity once reached whereas this one is just about obtaining it when adding/subtracting it). One of the concerns in https://crrev.com/c/1155264 was that it should use clamped_math.h instead of rolling its own. This CL doesn't do this specifically because both values are int64_t but we want max int64_t to be "infinity" and thus result in infinity even if added to a negative (non-infinity) TimeTicks. It still makes sense to use clamped math for TimeBase to TimeBase saturated math. R=dcheng@chromium.org Bug: 885371, 869387 Change-Id: I10cb0831d1fbdc489fbeaa5f4a87492831e0d083 Reviewed-on: https://chromium-review.googlesource.com/c/1449323Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#628483}
-
Madeleine Barowsky authored
This fixes a subtle bug in GetDecodedImageForDrawMipUsageChange where the test image was created with a dimension larger than |max_texture_size_| and never went through the GPU upload path. R=ericrk@chromium.org Change-Id: I4c9bbdfa6f8c25bbc75deb34cd37d427fd869a9c Reviewed-on: https://chromium-review.googlesource.com/c/1450231 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
-
Vitaly Buka authored
Bug: 643554 Change-Id: I30b9e73aa3b5f6424b81614c5a9ae8e3466f37f8 Reviewed-on: https://chromium-review.googlesource.com/c/1440701 Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#628481}
-
Emircan Uysaler authored
Since crbug.com/922198 is fixed, we can reenable them. Bug: 921003 Change-Id: I5208c773b8a47ae38858c2f7a2f620fe8f965d97 Reviewed-on: https://chromium-review.googlesource.com/c/1450419Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#628480}
-
Matt Menke authored
Remove the SSLClientSocketPool - use TransportConnectJobs instead. This CL allows TransportClientSocketPools to stack on top of other TransportClientSocketPools, when being used for SSLClientSockets. It also leaves ssl_client_socket_pool_unittests in place, those just use TransportClientSocketPools now, and will be moved in future CLs. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: I473f28136347ce6e2bd17c5da0bcf4d7ac648072 Reviewed-on: https://chromium-review.googlesource.com/c/1446244Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628479}
-
Matt Reynolds authored
This is a reland of 6a235ad7 This reland includes a fix for a use-before-initialization error in HidReportDescriptor that caused devices that do not use report IDs to sometimes report that they did. Original change's description: > Parse HID report descriptor for report info > > The previous HID report descriptor parser was designed to only > extract the maximum size of each type of report and did not preserve > information about the individual fields within a report. This CL > adds a new parser that builds a hierarchical representation of the > reports supported by the HID device. > > BUG=890096 > > Change-Id: I4ac3bf883a843bec00576bfad78958d42f53abc7 > Reviewed-on: https://chromium-review.googlesource.com/c/1257897 > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626816} BUG=890096 Change-Id: I8991162f0bb8c442d4e7cdce5940dd801ab5bfa0 Reviewed-on: https://chromium-review.googlesource.com/c/1446661Reviewed-by:
-
Daniel Rubery authored
When a SBER user triggers an On Focus ping, extract visual features from the login pages and attach them to the PhishGuard ping. Bug: 922226 Change-Id: I4139270f98e717bb977914e5399ba9dec702f878 Reviewed-on: https://chromium-review.googlesource.com/c/1448809 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#628477}
-
Robbie McElrath authored
Bug: 927435 Change-Id: Ic1f17615bc5f4f6f2f2c02d8c3557c9ade7d1bc0 Reviewed-on: https://chromium-review.googlesource.com/c/1450200 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#628476}
-
Azeem Arshad authored
This CL makes AndroidSmsPairingStateTracker observers checked. This will prevent us from notifying destroyed observers. Bug: 926429 Change-Id: I6bffbf3a6fd7eb3e1bd59a640a851a733057e229 Reviewed-on: https://chromium-review.googlesource.com/c/1449170 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#628475}
-
Rebekah Potter authored
This reverts commit 27008de3. Reason for revert: This resulted in all dropdown menus in Print Preview being cut off, see https://crbug.com/927649. This also caused a regression in the settings credit card dialog, may be others that have not been identified yet. Original change's description: > Fix Assistant settings label padding > > - Wrap the sub-label of settings entry. > - md-select items automatically shrink, adding a min-width to it. > (not sure if this is intended?) > > Bug: b/123363474 > Test: Manual Test > Change-Id: Idd47e14a3b9d00dafe792f421660665d636e58b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1439460 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#627996} TBR=stevenjb@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/123363474 Change-Id: I56b0551c822152498f5b8387c954a785c1af94f5 Reviewed-on: https://chromium-review.googlesource.com/c/1450017Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Daniel Libby authored
ui/base/user_activity causes ui/base to have a dependency on ui/events. To remove another instance of this dependency, put user_activity into its own component. Bug: 921723 Change-Id: I8c82bcb82b876386c63fa263937280c48ceb43fb Reviewed-on: https://chromium-review.googlesource.com/c/1448735Reviewed-by:
-
Eric Karl authored
This reverts commit a7b9fce3. Reason for revert: Sorry, need to take more time with this. Original change's description: > Reland "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts" > > This reverts commit 925d0880. > > Reason for revert: Mis-interpreted local results and incorrectly reverted. Undoing. > > Original change's description: > > Revert "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts" > > > > This reverts commit a00335ea. > > > > Reason for revert: Not a bug, but after cleaning up the CL, it doesn't fully address the original issue. Will re-assess. > > > > Original change's description: > > > Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts > > > > > > During teardown of GPU channels, several GLContextVirtuals may be made > > > current and released in a row. This change makes two tweaks to avoid > > > excessive calls to Release/MakeCurrent which were leading to hangs on > > > ARM: > > > > > > - When we call ReleaseCurrent on GLContextVirtual, only release the > > > real GL context if: > > > a) We are releasing a real surface (need to release to clean > > > up surface). > > > b) We are the last virtual owner of the GL context (we need to > > > release before final destruction of real context). > > > > > > - When we call SetCurrent(nullptr) on GLContext, only clear the > > > surface / GL API if we are the real context. During normal > > > operation GLContextVirtual always calls through the real context in > > > ReleaseCurrent. During destruction, both will be called. > > > > > > Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded > > > Reviewed-on: https://chromium-review.googlesource.com/c/1437704 > > > Reviewed-by: Antoine Labour <piman@chromium.org> > > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#628386} > > > > TBR=piman@chromium.org,ericrk@chromium.org > > > > Change-Id: Iaa25787bf8bb133094b6a4c2ab7a1d4438649707 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/1450223 > > Reviewed-by: Eric Karl <ericrk@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#628464} > > TBR=piman@chromium.org,ericrk@chromium.org > > Change-Id: I5caaa51a0b4d7461558dca91cbc3344685dd556e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/1450426 > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628470} TBR=piman@chromium.org,ericrk@chromium.org Change-Id: I3a999d335ed70d2e3e402e89012d11f820c78555 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1450226Reviewed-by:
-
jdoerrie authored
This change prepares //net for the upcoming switch of base::string16 to std::u16string. Bug: 911896 Change-Id: I4e752515a92f81a43154c0f7df856289d2bed2c5 Reviewed-on: https://chromium-review.googlesource.com/c/1450195 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628471}
-
Eric Karl authored
This reverts commit 925d0880. Reason for revert: Mis-interpreted local results and incorrectly reverted. Undoing. Original change's description: > Revert "Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts" > > This reverts commit a00335ea. > > Reason for revert: Not a bug, but after cleaning up the CL, it doesn't fully address the original issue. Will re-assess. > > Original change's description: > > Avoid excess MakeCurrent / ReleaseCurrent for Virtual GL contexts > > > > During teardown of GPU channels, several GLContextVirtuals may be made > > current and released in a row. This change makes two tweaks to avoid > > excessive calls to Release/MakeCurrent which were leading to hangs on > > ARM: > > > > - When we call ReleaseCurrent on GLContextVirtual, only release the > > real GL context if: > > a) We are releasing a real surface (need to release to clean > > up surface). > > b) We are the last virtual owner of the GL context (we need to > > release before final destruction of real context). > > > > - When we call SetCurrent(nullptr) on GLContext, only clear the > > surface / GL API if we are the real context. During normal > > operation GLContextVirtual always calls through the real context in > > ReleaseCurrent. During destruction, both will be called. > > > > Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded > > Reviewed-on: https://chromium-review.googlesource.com/c/1437704 > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#628386} > > TBR=piman@chromium.org,ericrk@chromium.org > > Change-Id: Iaa25787bf8bb133094b6a4c2ab7a1d4438649707 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/1450223 > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628464} TBR=piman@chromium.org,ericrk@chromium.org Change-Id: I5caaa51a0b4d7461558dca91cbc3344685dd556e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1450426Reviewed-by:
-
Malay Keshav authored
This patch fixes one of the reasons for the transparent chrome window bug. We clone the window layer tree after we create a mirror window for overview mode. This does not work well with transferable resource and when to release them. This was resulting in empty resource texture being displayed in cloned + mirrored windows at times. The resource was being released as soon as the original layer was destroyed after cloning. The reason cloning was performed on the mirror window was to purge the texture memory being used by the now minimized window. Recreating the layer tree allowed the ui to delete the old layer tree and thus the old textures. This patch replaces the cloning that happens after a mirror window tree is created while achieving the same goal of purging unneeded texture memory by tricking the compositor into resetting its visibility. mode, solid color layer Bug: 923595 Change-Id: I56c9a201922a4d0f2047b08979fa3f0589789c37 Component: ui layer, delegated frame host, stale content, overview Reviewed-on: https://chromium-review.googlesource.com/c/1448119 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#628469}
-
