GitLab

BUG=142030
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10826254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151423 0039d316-1c4b-4281-b951-d872f2087c98

Tests that explicitly want to test other channels (e.g. test feature X behaves
differently on stable) then they can still enable that explicitly.

Review URL: https://chromiumcodereview.appspot.com/10829312

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132950

Review URL: https://chromiumcodereview.appspot.com/10855015

TBR=koz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10826295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132950

Review URL: https://chromiumcodereview.appspot.com/10855015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151420 0039d316-1c4b-4281-b951-d872f2087c98

The protobuf-based cache was only being read at startup and written at shutdown. (Except that when the cache could not be read at startup the cache would immediately be saved upon private data reconstruction from the History database.) With the new implementation using an SQLite database for the HQP cache the private data will be restored from the cache database at startup and continually updated during normal operation. There is no need to flush or write the cache at shutdown as it is constantly kept up-to-date.

Detailed comments about the changes made in this CL can be found in the document shared separately.

Reviewer suggestions:
  sky: for proper thread usage. Also chrome/browser/ui/ and chrome/browser/visitedlink/.
  pkasting: for whatever you'd like to check over but please look over the design document shared separately.
  shess: please take a look at database usage in chrome/browser/history/in_memory_url_cache_database.h/.cc.

BUG=95686,95876,131668
TEST=New tests added, old tests updated, all tests pass.
To manually verify changes:
NOTE: For tests using chrome://omnibox be sure to check the "Show results per provider" and then look at the results for the HistoryQuickProvider.
1) New visits: Type an URL never visited before. Bring up new tab. Start typing the URL or parts of the page title or both and verify that the page is offered as a suggestion.
2) New visits: Type an URL never visited before. Do search using chrome://omnibox. New visit should show.
3) Delete visit: Visit some pages and verify they have been recorded. Bring up history and delete one of the visits. Check via chrome://omnibox that it was deleted.
4) Clear history: Visit some pages. Clear the visit history. Check via chrome://omnibox that none of the visits are still returned by the HQP.
5) Updated site: Create a local page and visit it. Search using chrome://omnibox by page title and verify it can be found. Change the page title dramatically and revisit the page. Verify via chrome://oomnibox that the page can be found by words from the new title.
Review URL: https://chromiumcodereview.appspot.com/10477018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151419 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug/com/125937
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98

when histogram is created. 

We will back out this change. This is temporary to catch
corruptions as early as possible.

TBR=jar,kaiwang
TEST=base unittests
BUG=140688
Review URL: https://chromiumcodereview.appspot.com/10826293

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151415 0039d316-1c4b-4281-b951-d872f2087c98

This is so it's clear that they depend on content module. In a follow up
patch we will have views_examples_lib and views_examples_exe targets that
does not depend in content/ module to build.

BUG=141187
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138338,141682

Review URL: https://chromiumcodereview.appspot.com/10831273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151405 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142058


Review URL: https://chromiumcodereview.appspot.com/10834298

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151402 0039d316-1c4b-4281-b951-d872f2087c98

BranchUtility was crashing when it tried to fetch the branch numbers for the
dev, beta, and stable channels. There was also a problem using the branch number
where the name should have been used.

ServerInstances are no longer leaked.

BUG=141909

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151386

Review URL: https://chromiumcodereview.appspot.com/10831269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151401 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151400 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to support hidpi for browser/page actions.

BUG=138025,135271
TEST=manually checked that browser and page action buttons are displayed correctly.


Review URL: https://chromiumcodereview.appspot.com/10827191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151399 0039d316-1c4b-4281-b951-d872f2087c98

When user signs out and transit to the login screen, the wallpaper fade in from a white screen. Described in 141563, this Cl fixed it.
Also, after user login, or switch users at login screen. when wallpaper change, the new wallpaper should fade in nicely. There is a regression in recent builds. This fix fixed the regression as well. 

BUG=141563, 141676, 142042

Review URL: https://chromiumcodereview.appspot.com/10827284

TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151398 0039d316-1c4b-4281-b951-d872f2087c98

If we do this, the OMX_FillThisBuffer function will fail, and will put the OMX
class in error mode. Then resource freeing will not happen. This is especially
annoying since this can happen during Destroy and leads to resource leaks.

BUG=chrome-os-partner:12316
TEST=by hand: play a video, look for buffer leaks.

Change-Id: If14311d188f1a2048c11b5bb6186dbf5fc20c1f5


Review URL: https://chromiumcodereview.appspot.com/10837212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151396 0039d316-1c4b-4281-b951-d872f2087c98

DownloadsDOMHandler::download_items_ does not always contain all of the items that it observes, so std::find may return end(). I have no idea what happens when you set *end()=NULL, but it could explain the crash in DownloadsDOMHandler::ClearDownloadItems() on windows, somewhere in "for (OrderedDownloads::iterator it = download_items_.begin(); it != download_items_.end(); ++it)".
BUG=142389

Review URL: https://chromiumcodereview.appspot.com/10855135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151395 0039d316-1c4b-4281-b951-d872f2087c98

When user signs out and transit to the login screen, the wallpaper fade in from a white screen. Described in 141563, this Cl fixed it.
Also, after user login, or switch users at login screen. when wallpaper change, the new wallpaper should fade in nicely. There is a regression in recent builds. This fix fixed the regression as well. 

BUG=141563, 141676, 142042

Review URL: https://chromiumcodereview.appspot.com/10827284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151393 0039d316-1c4b-4281-b951-d872f2087c98

Update unit tests to reflect these changes.

BUG=140732
TEST=

Review URL: https://chromiumcodereview.appspot.com/10806065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151391 0039d316-1c4b-4281-b951-d872f2087c98

Handle some todo's minor performance issues and some corner cases.

BUG=NONE


Review URL: https://chromiumcodereview.appspot.com/10836199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151390 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a series of patches intended to add more types which
behave similarly to Nigori.

These new types will be downloaded early, much like the Nigori node
currently is.  Removing these flags will make it easier to calculate the
appropriate parameters for configure calls during early initialization.

BUG=122825


Review URL: https://chromiumcodereview.appspot.com/10854050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151389 0039d316-1c4b-4281-b951-d872f2087c98

This broke the mono waterfall

BUG=none
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10824282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151388 0039d316-1c4b-4281-b951-d872f2087c98

Creates the WebCompositorOutputSurface, which is the new mechanism for rendering interactions between the compositor and RenderWidgetHost.

As part of this, we plumb vsync information to the compositor.

The new IPC::ForwardingMessageFilter is modified to have route-specific handlers rather than a global handler. This simplifies message routing considerably.

BUG=129674

Review URL: https://chromiumcodereview.appspot.com/10798006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151387 0039d316-1c4b-4281-b951-d872f2087c98

BranchUtility was crashing when it tried to fetch the branch numbers for the
dev, beta, and stable channels. There was also a problem using the branch number
where the name should have been used.

ServerInstances are no longer leaked.

BUG=141909

Review URL: https://chromiumcodereview.appspot.com/10831269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151386 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151385 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829304

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151384 0039d316-1c4b-4281-b951-d872f2087c98

The original code is correct. The fix is a work around for mips gcc 4.3.2.

The constructor of Callback is a template. In the context of the constructor, there are two type named RunType. One is its second template parameter, the other is a typedef inside Callback. The correct compiler will pick the "local" one, i.e. the template parameter. However, gcc 4.3.2 on mips incorrectly uses the typedef. The solution is to rename the template parameter.

After discussing with ajwong, we decide to push the work around up stream as it is cleaner not to shadow names anyways.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10836215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141322


Review URL: https://chromiumcodereview.appspot.com/10855132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151382 0039d316-1c4b-4281-b951-d872f2087c98

Add a unit test which verifies if the resizer sets/resets DisplayController::dont_warp_mouse_ as expected.

BUG=None
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10826240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151381 0039d316-1c4b-4281-b951-d872f2087c98

Converts the old bookmark automation commands.

TEST=PyAuto CONTINUOUS suite
BUG=132794


Review URL: https://chromiumcodereview.appspot.com/10828245

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151380 0039d316-1c4b-4281-b951-d872f2087c98

Previously, WebContents, NavigationController, and RenderViewHost all exposed
APIs that allowed one to retrieve the SessionStorageNamespace associated with
them. This is confusing because there were too many ways to access the object.
After this change, the SessionStorageNamespace is only exposed by the
NavigationController.

Conceptually a SessionStorageNamespace belongs to a WebContents but we store
it in NavigationController because on tab duplication, the
NavigationController becomes the authoritative state of the tab.

Also, to support StoragePartitions, the NavigationController
now maintains a map of partition_id -> SessionStorageNamespace. Someone
requesting a SessionStorageNamespace must either know which StoragePartition
they are coming from, or which child process they are acting on behalf of.

This change also changes the way TabContents and WebContents are created.
1) We now have explicitly separate creation methods for prepopulating
   with SessionStorage and creating with an opener.
2) Some of the WebContentImpl construct has been moved into an Init()
   function to avoid accidental calls to virtual functions by subobjects.

TBR-ing all the directories where I just remove a NULL.

TBR=sky,stevenjb,dominich,brettw,satorux,kalman
BUG=85121

Review URL: https://chromiumcodereview.appspot.com/10831116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98

If it fails, we still want to free the OMX resources.

BUG=chrome-os-partner:12316
TEST=by hand: play a video, look for buffer leaks.

Change-Id: Ifcc4fe4248b72067e4592224b24fdb716ab4b230


Review URL: https://chromiumcodereview.appspot.com/10832263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151376 0039d316-1c4b-4281-b951-d872f2087c98

Instead of creating a fake touch-cancelled event and sending that to the
gesture recognizer, send the raw touch-release event with the status of
the event-processing. Update the gesture recognizer (GestureSequence)
transitions to handle these events correctly instead.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10831295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151375 0039d316-1c4b-4281-b951-d872f2087c98

This page pulls the apps samples from github and constructs a page similar to
the extensions samples page. The links take you to github instead of
downloading zip files.

BUG=140252

Review URL: https://chromiumcodereview.appspot.com/10825067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151373 0039d316-1c4b-4281-b951-d872f2087c98

By the time CloseFileOnUIThread() is called, the feed is already fetched
so there is no need to use GetEntryInfoByPathAsyncOnUIThread() which
initiates the feed loading as needed.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10826288

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151371 0039d316-1c4b-4281-b951-d872f2087c98

Linux/GTK has been using canvas_skia.cc since M21 and
ChromeOS has been using canvas_skia.cc since M19.

BUG=105550
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10830285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151370 0039d316-1c4b-4281-b951-d872f2087c98

The number of callers of FindEntryByPathSync() is reduced from 9 to 7.

BUG=137694, 126634, 139446
TEST=Moving a file to another directory and renaming in the same directory work as before from file manager.

Review URL: https://chromiumcodereview.appspot.com/10832254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151369 0039d316-1c4b-4281-b951-d872f2087c98

TEST=functional/navigation.py navigation.NavigationTest.testTabsCloseOpen
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10854128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151368 0039d316-1c4b-4281-b951-d872f2087c98

Make Notification::ToString() base64 the data member (since it can hold
binary data).

Convert VLOGs to DVLOGs for push_notifications_*.cc.

BUG=141692


Review URL: https://chromiumcodereview.appspot.com/10828264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151367 0039d316-1c4b-4281-b951-d872f2087c98

There was a place where CloseFile() is called with a null callback, but
with the caller fixed, it's safe to make the callback parameter mandatory.

Along the way, removed unused |file_path| parameter from
DataFileSystem::OnGetEntryCompleteForCloseFile()

BUG=126634
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10834295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=151345

Review URL: https://chromiumcodereview.appspot.com/10824285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151365 0039d316-1c4b-4281-b951-d872f2087c98