- 13 Nov, 2017 2 commits
-
-
Miguel Casas-Sanchez authored
This CL cleans up a bit the order of DLOG()s and DCHECK()s, so that debug printouts are before DCHECK()s, and DCHECK()s of the current task runner go before the actual code. This CL also removes the function name from VLOGF()s because those already include it, so it's just duplicated. Also I shortened a condition if (a) return false; return true; into: return !a; TEST=No new code (except the condition simplification). Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I627b3077904a87ecd0da8f0cfbfaa7d70d232c35 Reviewed-on: https://chromium-review.googlesource.com/765109 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#515874}
-
Nicholas Verne authored
initialize PluginInfoPtrs. The crash happens when chrome::mojom::GetPluginInfo fails in sync mode. Then the output PluginInfoPtr is left null. We instead default initialize it with PluginInfo::New() as this is what the subsequent code expects. Bug: 783189 Change-Id: I51e25b127858b8ede79f6762f0f5e870166254d1 Reviewed-on: https://chromium-review.googlesource.com/762848Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515873}
-
- 12 Nov, 2017 15 commits
-
-
Hwanseung Lee authored
merge constructor using optional keyword in CSSTransformValue and CSSTranslation Bug: 545318 Change-Id: I67fe1f7b8db1dd59689d6aa8c49938f48152c5f8 Reviewed-on: https://chromium-review.googlesource.com/763149Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#515872}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/24e4cc7087bc..34922a64225b $ git log 24e4cc708..34922a642 --date=short --no-merges --format='%ad %ae %s' 2017-11-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 3a9090fa0..703671e9f (9 commits) 2017-11-12 brianosman Suppress warning 4577 (noexcept used with no exception handling mechanism specified) Created with: roll-dep src/third_party/skia BUG=735497,675997 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I99d4906375ff3250578415f75c6a3e12ee871eb7 Reviewed-on: https://chromium-review.googlesource.com/765568Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515871}
-
Benjamin Joyce authored
This reverts commit d138e38a. Reason for revert: assessing if cause for https://bugs.chromium.org/p/chromium/issues/detail?id=783010 Original change's description: > Unregister RTCPeerConnectionHandler upon native PC's Close() > > The existing code only unregisters the handler it is destructed. > However, garbage collection might not destroy the object for a while. > > Bug: 780855 > Change-Id: I68d2c1b49cc5042d53464878977400bfd3b75c81 > Reviewed-on: https://chromium-review.googlesource.com/754838 > Commit-Queue: Elad Alon <eladalon@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#514466} TBR=hbos@chromium.org,guidou@chromium.org,terelius@chromium.org,eladalon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780855 Change-Id: I567bfb7f5aa7f2658b1dbee06a3fe5b66f3dec4b Reviewed-on: https://chromium-review.googlesource.com/765147Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Benjamin Joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#515870}
-
Koji Ishii authored
Following bot results are included. 2065 2066 2067 2069 2070 2071 2072 2078 2080 2082 2085 14 lines were removed by consecutive passes since 2057. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I7272d2dc468d7bc968d74f49bd5a2df94ef6ea4c Reviewed-on: https://chromium-review.googlesource.com/765547 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515869}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c207da8d40cc..24e4cc7087bc $ git log c207da8d4..24e4cc708 --date=short --no-merges --format='%ad %ae %s' 2017-11-12 mtklein disable Android-specific SkTypeface test Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I23b62f449604b091a27904ee349167362ec5c477 Reviewed-on: https://chromium-review.googlesource.com/764962Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515868}
-
Philip Rogers authored
These tests had rls-specific expectations that had an inner-editor that is not present in the actual test. These now match non-rls. This is a followup to [1] and should be the last of the inner-editor baselines. [1] https://chromium.googlesource.com/chromium/src/+/ab2050f18161d7df3f0a47efdbb901435c5200f1 Bug: 781419 Change-Id: I54df3c50ca893aeebd581c72c3074c03a9f376e7 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/764440 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#515867}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/dee8a432ac99..c207da8d40cc $ git log dee8a432a..c207da8d4 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 mtklein disable native fonts except on NativeFonts bots Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I266665f7deccbc3474e9d5d17936d5730ec08e06 Reviewed-on: https://chromium-review.googlesource.com/764958Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515866}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7ca90d258085..dee8a432ac99 $ git log 7ca90d258..dee8a432a --date=short --no-merges --format='%ad %ae %s' 2017-11-12 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Id8732648c9be7f3c9daca3dd7bb43f59605b934c Reviewed-on: https://chromium-review.googlesource.com/764957Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515865}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/bb0775da28e3..703671e9fddc $ git log bb0775da2..703671e9f --date=short --no-merges --format='%ad %ae %s' 2017-11-08 oetuaho Unify extension behavior checks Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=None (channel is sheriff)@chromium.org Change-Id: I3f1b9869acf790a32efdc0b629e1c1371b9a1b2f Reviewed-on: https://chromium-review.googlesource.com/765197Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515864}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/485903582c25..bb0775da28e3 $ git log 485903582..bb0775da2 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 oetuaho Add flag for turning off initializing variables with loops Created with: roll-dep src/third_party/angle BUG=735497 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=None (channel is sheriff)@chromium.org Change-Id: Iffdc0bfc7a66f161bfb80d6a4845f9f8834b2978 Reviewed-on: https://chromium-review.googlesource.com/764956Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515863}
-
Vladimir Levin authored
This patch verifies that the SkData we use to deserialize a text blob looks correct (and will not cause an assert in Skia). R=enne@chromium.org Bug: 783808, 783815, 783828 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib07666354827a70dd4a95a589c60ab12b5e61ae7 Reviewed-on: https://chromium-review.googlesource.com/764582 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515862}
-
Jochen Eisinger authored
This was supposed to be a temporary workaround until issue 714866 is fixed, but never got removed. BUG=774176,783916 R=mkwst@chromium.org,haraken@chromium.org Change-Id: I381d0bca04707d0a361d9ce12c96e189b626c389 Reviewed-on: https://chromium-review.googlesource.com/762436 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#515861}
-
Tsuyoshi Horo authored
We will implement this feature behind the flag. BUG=768705 Change-Id: Ie8a75a3db722fefe14c8ea89a6b23378282f4d00 Reviewed-on: https://chromium-review.googlesource.com/761768Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515860}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Id266c280b0e1e305adc5a7162d0c14791a26644c Reviewed-on: https://chromium-review.googlesource.com/764678Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515859}
-
Vasiliy Tsukanov authored
Bug: 748715 Change-Id: I3aed198d5a6ddb0b776f60c2358701953630078c Reviewed-on: https://chromium-review.googlesource.com/725333 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#515858}
-
- 11 Nov, 2017 23 commits
-
-
Charles Harrison authored
This string was landed as linux-only here: https://codereview.chromium.org/155740 It was changed be !OS_MACOSX when OS_LINUX was changed to OS_POSIX. Bug: 566496 Change-Id: I5615ae7e304c51d7f4f8dd37df36a3c4d2e7cfeb Reviewed-on: https://chromium-review.googlesource.com/764607Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#515857}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5b4a6ab25592..7ca90d258085 $ git log 5b4a6ab25..7ca90d258 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 brianosman Use round rather than floor for snapping text vertex positions 2017-11-10 angle-deps-roller Roll skia/third_party/externals/angle2/ 225bfa950..3a9090fa0 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I6b034f85043b5d0a46125498f498864425424fa0 Reviewed-on: https://chromium-review.googlesource.com/764816Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515856}
-
Daniele Castagna authored
NV12 has been supported on CrOS x86 mesa for a while. Mapping an NV12 dmabuf has also been supported and test for a while. This CL simply advertises that NV12 images can be used and that NV12 dmabuffs buffers can be mmaped on the renderer side. In this way, software decoded video frames will be converted to NV12. Bug: 683347 Test: youtube on eve with HW video decoder disabled. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I74e5991ed57acf87d9d0a5ff0c3b6839e8b47b8d Reviewed-on: https://chromium-review.googlesource.com/756217Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#515855}
-
Khushal authored
Use ScopedImageFlags for all flag overrides. This cleans up the playback code and gives a utility class that we can use during both raster and serialization. R=enne@chromium.org, vmpstr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I09f01cf7665acebde786f9e5d9bbbfe85f18d122 Reviewed-on: https://chromium-review.googlesource.com/762391 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515854}
-
Michael Hablich authored
Due to unresolved Canary crashers V8 is rolled back to the last known stable version. Autoroller is closed, please do not revert this CL. TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org NOTREECHECKS=true Bug: 783708 Change-Id: Icf94ac1d53e250007fdaa5e242c8f44b75e47e85 Reviewed-on: https://chromium-review.googlesource.com/765329 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#515853}
-
Rohit Rao authored
This CL introduces new calls to TopPresentedViewController() that will need to be fixed in the future, but it is better to make this dependency explicit for now. BUG=754642 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If67343f6424d3bd043825524d32d2a4f693cc1f6 Reviewed-on: https://chromium-review.googlesource.com/764650Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515852}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/cac94a912493..485903582c25 $ git log cac94a912..485903582 --date=short --no-merges --format='%ad %ae %s' 2017-11-07 jgilbert Remove formatType arg from computeCompressedImageSize. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=None (channel is sheriff)@chromium.org Change-Id: Iaa36001d7b5da2b0241945e4550ccc761479200f Reviewed-on: https://chromium-review.googlesource.com/764814Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515851}
-
Michael Hablich authored
This reverts commit 48567a53. Reason for revert: Needed for the rollback of V8 in https://chromium-review.googlesource.com/c/chromium/src/+/765329 Original change's description: > DevTools: Use new static CpuProfiler::CollectSample API. > > It allows collect the sample in all the running CPU profilers. > > BUG=721099 > > Change-Id: I8c80c9543bb826b67b8f7ddf6b2984cb54d61fbb > Reviewed-on: https://chromium-review.googlesource.com/764793 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515746} TBR=alph@chromium.org,caseq@chromium.org,yangguo@chromium.org Change-Id: I4341a4410f28d8fbb93b35a5e2eb2c447c4296bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721099 Reviewed-on: https://chromium-review.googlesource.com/765448Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#515850}
-
Bernhard Bauer authored
The annotations can be used in conjunction with a newly added test rule to do setup and teardown for tests that use method parameters. The methods will be called iff a test method with the given parameter is executed, with the corresponding parameters. As an example, use @UseMethodParamBefore in HomeSheetUiCaptureTest to set the state of the SigninPromo feature before the activity is started. Also, for moar reusability, extract a MethodParamRule that can be used to build arbitrary rules that are applied to test statements that use method parameters and that have access to the parameter value. Bug: 783820 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If422eef9009c1e8721039d52f4979e5efda98089 Reviewed-on: https://chromium-review.googlesource.com/757356 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#515849}
-
Dmitry Gozman authored
This reverts commit 7c8e8e13. Reason for revert: makes TabCaptureApiTest.ApiTests consistently fail on Linux MSan. See https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/5790 Original change's description: > Reland "Serialize MediaStreamTrack.stop() with getUserMedia()" > > This is a reland of a58c8bd6 > Original change's description: > > Serialize MediaStreamTrack.stop() with getUserMedia() > > > > When multiple getUserMedia and stop() requests are active concurrently, > > getUserMedia() sometimes fails with TrackStartError. > > The reason is that the underlying video capture subsystem does not keep > > a count of how many sources have opened a video device. > > It can happen that a stop request stops video capture while a > > getUserMedia() request is being processed, with the result being that > > the video device is closed before getUserMedia() starts the new video > > track, resulting in an error. > > > > One solution to this problem is to make sure that stop requests and > > getUserMedia() requests cannot run concurrently, which is the approach > > followed by this CL. > > > > This CL basically moves handling of MediaStramTrack.stop() from > > MediaStreamCenter to UserMediaClient, and puts stop() requests in the > > same queue used for getUserMedia() and applyConstraints() requests. > > > > > > Bug: 778039 > > Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 > > Reviewed-on: https://chromium-review.googlesource.com/751981 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#515494} > > TBR=haraken@chromium.org > > Bug: 778039 > Change-Id: I461e3c98f3d6471cc218d48501d22c6c0a8b03e9 > Reviewed-on: https://chromium-review.googlesource.com/763636 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515836} TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org Change-Id: I308ecf1a9a3b031bfa0d2b0f4f22967e7758ad43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778039 Reviewed-on: https://chromium-review.googlesource.com/764632Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#515848}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/23cd4addeadb..cac94a912493 $ git log 23cd4adde..cac94a912 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 jmadill Optimize ShaderVariable::isBuiltIn. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=None (channel is sheriff)@chromium.org Change-Id: Ic4f71662a715ff0fbf3e0c388b6d20c64cd526f8 Reviewed-on: https://chromium-review.googlesource.com/764810Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515847}
-
John Abd-El-Malek authored
TBR=yzshen@chromium.org NOTRY=true Bug: 781565, 752370 Change-Id: Ic14467588e28081173625323dea6dd5dd99a4f0e Reviewed-on: https://chromium-review.googlesource.com/764811Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515846}
-
Fredrik Söderquist authored
Only do an remove-add cycle for the cue when the start or end time is updated. This will avoid changing the cue order for cues which need to make use of the "tie-breaker" (have same 'startTime' and 'endTime'.) It should also make non-time updates to a cue faster. Remove media/track/opera/interfaces/VTTCue/snapToLines.html since it's a duplicate of the WPT test. Bug: 783779 Change-Id: I919b0acdb6ec2e6f0b6e11fb75996e7292168f95 Reviewed-on: https://chromium-review.googlesource.com/763527Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#515845}
-
Mathias Bynens authored
This patch temporarily disables some tests in preparation for shipping RegExp Unicode property escapes in V8. The tests can be re-enabled once that feature’s shipped and the error messages in the test have been updated. BUG=v8:4743 Change-Id: I60e18aae01018b22842e6b24812a9f9bc5afb97b Reviewed-on: https://chromium-review.googlesource.com/765328Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#515844}
-
Magnus Jedvert authored
This CL makes the generate_jar_jni rule behave similarly as generate_jni; it takes a custom jni_generator_include and the generated files are placed in the same folder as for the generate_jni targets. Bug: webrtc:8278 Change-Id: I5317ff1efead452f275a9a3d415793bde0e344d0 Reviewed-on: https://chromium-review.googlesource.com/757377 Commit-Queue: Magnus Jedvert <magjed@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#515843}
-
Jochen Eisinger authored
With browser side navigations, we might cancel parsing because a new navigation started, which in turn might fail. In that case, the original document should be in a defined state BUG=714373 R=japhet@chromium.org Change-Id: Idf09c46a2dde8ce1107d8c8d1d414e5fa06987da Reviewed-on: https://chromium-review.googlesource.com/758998 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#515842}
-
Ian Vollick authored
This reverts commit 119b361e. Reason for revert: not the culprit. Original change's description: > Revert "[vr] Implement controller quiescence" > > This reverts commit 820c5377. > > Reason for revert: Appears to have caused a performance regression. > > Original change's description: > > [vr] Implement controller quiescence > > > > When the controller is inactive, we should fade it out. > > > > Also includes some minor changes in VrShellGl to reuse > > the current time rather than recomputing it. > > > > Bug: 776521 > > Change-Id: I5ce7708b3eddc04b9ad65d176eb544be7446cbca > > Reviewed-on: https://chromium-review.googlesource.com/752344 > > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#513937} > > TBR=vollick@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ibccc146d4af04cffdff14a8af9ba74e34fd19b2c > Reviewed-on: https://chromium-review.googlesource.com/764671 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515829} TBR=vollick@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org Change-Id: I10f5b8a7e32c881f3515052cd8ab2548c6ef5b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/765196Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#515841}
-
Xu Xing authored
Other refinement: Use texture id directly instead of ScopedReadLockGL in ApplyImageFilter. BUG=782044 Change-Id: I0e357a5c5831eaf5709392e852cf4e66ba2d0253 Reviewed-on: https://chromium-review.googlesource.com/749101 Commit-Queue: Xing Xu <xing.xu@intel.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#515840}
-
Nicholas Verne authored
This reverts commit 729f299a. Reason for revert: broken for buildflag WIDEVINE_CDM_AVAILABLE_NOT_COMPONENT Original change's description: > mojo IsInternalPluginAvailableForMimeType > > We can now rename PluginInfoMessageFilter to PluginInfoHostImpl. > > Bug: 577685 > Change-Id: If95632401e048bbf7f756912dd59e6c399f433c3 > Reviewed-on: https://chromium-review.googlesource.com/759621 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515838} TBR=jam@chromium.org,sammc@chromium.org,wfh@chromium.org,nverne@chromium.org Change-Id: I3827db4165faa7d513de11f97235898768d9c629 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 577685 Reviewed-on: https://chromium-review.googlesource.com/765387Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515839}
-
Nicholas Verne authored
We can now rename PluginInfoMessageFilter to PluginInfoHostImpl. Bug: 577685 Change-Id: If95632401e048bbf7f756912dd59e6c399f433c3 Reviewed-on: https://chromium-review.googlesource.com/759621Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#515838}
-
Lei Zhang authored
MTP devices typically have very few storages, and users typically have very few MTP devices attached. Change-Id: I3ef59844f15cc525d3227da979cc39b4bf1ab3f7 Reviewed-on: https://chromium-review.googlesource.com/759226 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515837}
-
Guido Urdaneta authored
This is a reland of a58c8bd6 Original change's description: > Serialize MediaStreamTrack.stop() with getUserMedia() > > When multiple getUserMedia and stop() requests are active concurrently, > getUserMedia() sometimes fails with TrackStartError. > The reason is that the underlying video capture subsystem does not keep > a count of how many sources have opened a video device. > It can happen that a stop request stops video capture while a > getUserMedia() request is being processed, with the result being that > the video device is closed before getUserMedia() starts the new video > track, resulting in an error. > > One solution to this problem is to make sure that stop requests and > getUserMedia() requests cannot run concurrently, which is the approach > followed by this CL. > > This CL basically moves handling of MediaStramTrack.stop() from > MediaStreamCenter to UserMediaClient, and puts stop() requests in the > same queue used for getUserMedia() and applyConstraints() requests. > > > Bug: 778039 > Change-Id: Id7e0ee38e40265fd599dc6dd0712f0b667d2e1a5 > Reviewed-on: https://chromium-review.googlesource.com/751981 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515494} TBR=haraken@chromium.org Bug: 778039 Change-Id: I461e3c98f3d6471cc218d48501d22c6c0a8b03e9 Reviewed-on: https://chromium-review.googlesource.com/763636 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515836}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/336129f66f63..23cd4addeadb $ git log 336129f66..23cd4adde --date=short --no-merges --format='%ad %ae %s' 2017-11-10 thomasanderson Add missing include to stddef.h on arm Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Iaaf13975119103809fb1f6196215b3393e494b19 Reviewed-on: https://chromium-review.googlesource.com/764892Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515835}
-