- 14 May, 2019 40 commits
-
-
Andrew Grieve authored
So that it will be tested by monochrome_apk_checker. Removes some unittests from Android that were relying on pak entries that the whitelist removes (not used on Android). Some adjacent unittests also removed because they also seem to be desktop-specific (see previous patchset bot results for which tests actually failed). Bug: 960881, 961270 Change-Id: I00f571ac9bbffa1a90c8f6414b007b3ad9b4b478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600421Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#659668}
-
David Schinazi authored
Change-Id: Iccb464ea241b504faa07fbf2dfb588fdfbbfb568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612323 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659667}
-
Matthew Mourgos authored
Bug: 943638 Change-Id: I66ca64966dcc2b315e48c2477c8ee66e57f3e7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607158Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#659666}
-
Tetsui Ohkubo authored
This CL adds a new histogram enum GAMEPAD_INTERACTION to Arc.UserInteraction, which will be recorded on the first time a user sends a gamepad event to an ARC++ app window. It resets every time the window is deactivated. This will be used as success metrics of ARC Improved Gamepad project go/arc-improved-gamepad. TEST=manual(Press gamepad buttons when an ARC++ app is active and check chrome://histograms) BUG=b:130597086 Change-Id: I90c4d00399a7227a102ebd9e81861b735bef6001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605667 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#659665}
-
Vladimir Levin authored
This patch skips innerText processing for elements that are either display locked, or are inside a locked subtree. This is due to the fact that display locked subtrees are not painted and so should behave in the same way as visibility hidden (or display none elements). This also ensures that we don't access text nodes when they have not been laid out, which is possible in display locking. This causes CHECKs with LayoutNG. R=chrishtr@chromium.org, rakina@chromium.org, xiaochengh@chromium.org Bug: 962569 Change-Id: I0f286b7ea55e72baada3d9f2c10f4ea693e268d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609666 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659664}
-
Johann authored
Having a local version of clang-format v7.0.1 fails due to differences in chromium/src/.clang_format. This is redundant anyway since it is covered by git cl format at the end of cmake_update.sh Change-Id: I58ae0ab1dcdda3c6c91b83e8402c6bdf05f2e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610430 Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#659663}
-
John Williams authored
Change-Id: I5b06e37fe7f3029a670f917443c688be5be01da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589099 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#659662}
-
Liquan(Max) Gu authored
Currently FCP++ doesn't ignore the text paint in the block stage. The block stage happens when we have font-display:block for a text node and the webfont of the text is not yet loaded. FCP++ should ignore the text because it's not visible to users. The text should be captured only after the text starts to be visible. The block stage is controlled by Font::ShouldSkipDrawing(). When a text node is blocked on web-font, the text would be set to invisible-font. So FCP++ should use this method to tell whether the text would not be drawn due to the invisible font. Bug: 944530 Change-Id: If80a5bdeccce0896d0e4e836c89bfd9aefbd627d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609669 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659661}
-
rnasri authored
Add a bool in layer_tree_debug_state. And update the methods where needed in the cc file. Declare the flag and its definition in content_switches. Finally, add the flag in the render_process_host_impl and use it in the initialization of layer tree settings in render_widget. Bug: 961846 Change-Id: Ia82da07d65dc5ea829824a077e971b7102e754bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603404Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Rasha Nasri <rnasri@google.com> Cr-Commit-Position: refs/heads/master@{#659660}
-
Philip Rogers authored
PaintChunks can be printed using --vmodule=*paint_controller*=2 [1] but the output format is verbose. This change introduces another verbosity level to paint_controller: 1) Paint chunks and display item list in compact form. --vmodule=*paint_controller*=1 2) Paint chunks with detailed display item list. --vmodule=*paint_controller*=2 3) Paint chunks with detailed display item list with paint records. --vmodule=*paint_controller*=3 Sample output from --vmodule=*paint_controller*=1: "chunks": [ { "chunk": "LayoutSVGRoot 0x23d6a28338:LayoutSVGRoot svg class='qr':ClipPaintPhaseForeground:0", "state": "t:0x323d114b10 c:0x323d1c4a10 e:0x323d02c190", "displayItems": [ "0x23d6a38018:LayoutSVGPath path:DrawingPaintPhaseForeground:0" ] }, { "chunk": "InlineTextBox 'Text box' 0x23d6a60190:InlineTextBox 'Text box':DrawingPaintPhaseForeground:0", "state": "t:0x323d114840 c:0x323d1c48d0 e:0x323d02c190", "displayItems": [ "0x23d6a60190:InlineTextBox 'Text box':DrawingPaintPhaseForeground:0", "0x23d6a60090:InlineTextBox 'text':DrawingPaintPhaseForeground:0", "0x23d6a60010:InlineTextBox 'more text':DrawingPaintPhaseForeground:0" ] } ] [1] https://docs.google.com/document/d/1vgQY11pxRQUDAufxSsc2xKyQCKGPftZ5wZnjY2El4w8/edit#heading=h.me4dzticloz0 Change-Id: I87c02c16121d63edca4ba1255b3d5aff348013eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610494 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#659659}
-
Henrique Nakashima authored
ProfileImpl curently has a unique_ptr<ConfigurationPolicyProvider> and a UserCloudPolicyManager* that is points to the same object - when not in Chrome OS. This CL changes the ownership to be the most specific object type: - unique_ptr<ConfigurationPolicyProvider> in Chrome OS - unique_ptr<policy::UserCloudPolicyManager> in other platforms This change is a precursor of https://chromium-review.googlesource.com/c/chromium/src/+/1579768 which will break the Chrome OS options further. Bug: 937770 Change-Id: I9aea3b2f40afbbd0801cca61cd1a64a3e63cc57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606576 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#659658}
-
Maksym Onufriienko authored
This change requires for /ios_internal repository(submit only after this cl) https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1284283 This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. For GREYAsserts, the policy is to take assert- containing-helpers, modify them to return NSError* with localizedDescription containing the assert failure (in the event of a failure), and then assert on the result of the helper on the test side. Bug: 922813 Change-Id: I42086810e5efe23139210fa1e198c14665f903bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606248 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659657}
-
bsheedy authored
Refactors the remaining WMR wrappers that have mock implementations (those in wmr_timestamp.h and wmr_rendering.h) in the same way as https://crrev.com/c/1603748. Bug: 961020 Change-Id: I0a28f981cf705c4950b660058712c9643546a784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611422 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#659656}
-
Mounir Lamouri authored
This is removing the latest IPC for Picture-in-Picture and solves one bug that had the element not notified of the Picture-in-Picture state change if the window was closed after the src was reset and therefore the media player wasn't able to get the IPC. Bug: 919860, 940694 Change-Id: I3f2badd7724fc9037d360bf88fb22adc3b7f14a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611509Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#659655}
-
Matt Mueller authored
Adds a parameter for the |sct_list| in CertVerifyProc::Verify and CertVerifier::RequestParams. This parameter is ignored in the other CertVerifyProc subclasses. Also hooks up the |ocsp_response| in ProofVerifierChromium::VerifyCertChain while we're there. Bug: 953384 Change-Id: I49d036069d448da6f3452b7d75ee0dc375144250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592802 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659654}
-
Mounir Lamouri authored
https://www.chromestatus.com/feature/5730672977117184 Bug: 907952 Change-Id: I4a12d5b1cc5607d462b20e44c69cf842a27e277c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602676 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#659653}
-
Dan Harrington authored
Simplifies the code, and avoids multiple queries to gather the set of pages. Bug: 949162 Change-Id: Ibc4c0d4729b629d93424bc046ecd499b14ac01c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602974 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#659652}
-
Yusuke Sato authored
When a USB memory is plugged, we currently show "Removable device detected" notification with one button, "OPEN FILES APP". This CL adds one more button "OPEN SETTINGS" to the notification when ARC is enabled for the user to allow the user to control ARC apps' USB storage access settings. UI mock: go/filesapp-arc-extdriveaccess (page 10) BUG=936814 TEST=browser_tests --gtest_filter='FileManagerJsTest.DeviceHandlerTest' Change-Id: I027d70a80e678ab86de4c192556f7890dd336d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585382 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#659651}
-
Peter Kotwicz authored
This CL fixes SplashScreen.visible tracing which regressed in https://chromium-review.googlesource.com/c/chromium/src/+/1592829 BUG=817263 Change-Id: I279820ccabfbbb462bd4aa14c33151875c111c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607500 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#659650}
-
Kevin Bailey authored
Under an experiment flag, indent keyword suggestions when fully in keyword mode, to more obviously indicate separate state. Bug: 883901 Change-Id: I9a7b90b6297e25699d1e811b5a7d27a34a338d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602158 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#659649}
-
Tina Wang authored
This bubble will show after the user click on the omnibox share icon. Bug: 958170, 950388 Change-Id: I4f41fae730d3b1724a3bae08b223af9bf8668920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600376 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659648}
-
Yusuke Sato authored
CL:1583420 added a new Chrome pref that controls ARC's storage access. This CL adds a new UI to chrome://settings to update the pref value. UI mock: go/filesapp-arc-extdriveaccess (page 9) BUG=936814 TEST=try Change-Id: I6708456460f40e7c61ddcff573eabbf8f88ede24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583425 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#659647}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d5d210a420f..40748dc575b7 git log 9d5d210a420f..40748dc575b7 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 saklein@chromium.org Build API: Fix FEATURES default. 2019-05-14 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@40748dc575b7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I3a6c654bcdc5af7db614cd220e375081556fedb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659646}
-
Brian Sheedy authored
Updates the VR video test goldens to pick up a slight change to how one of the characters in the timestamp is rendered. Also re-enables the test since it was disabled due to the bad goldens. TBR=alcooper@chromium.org Bug: 962397 Change-Id: I12cb8d187d69a28c5dc0796a5838f5c6ec3a229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610198Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659645}
-
Kelvin Jiang authored
Add metrics for recording how long it takes for the user to accept or cancel an extension installation prompt (2 total). Bug: 952427 Change-Id: Iaa6c9646a280d5e522dd1fa0943bc3573016be51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607340 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#659644}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d56a905e68a2..ddf034cde9e9 Created with: gclient setdep -r src-internal@ddf034cde9e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fergal@google.com,avi@google.com,btolsch@google.com,andypaicu@google.com Change-Id: I0fbcc2a83e3ccd3d9f90c925f1bf185b92d719a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611380Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659643}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/40a6ed8d5cbb..69c37491787a git log 40a6ed8d5cbb..69c37491787a --date=short --no-merges --format='%ad %ae %s' 2019-05-14 bclayton@google.com SpirvShader: Fixes for phis. 2019-05-14 bclayton@google.com SpirvShader: Fixes for complex loops. Created with: gclient setdep -r src/third_party/swiftshader@69c37491787a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271,chromium:b/128527271 TBR=swiftshader-team+autoroll@google.com Change-Id: I22ba4fe3d24ebac93ec63131383577f1a55835ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659642}
-
Victor Costan authored
Our largest SQLite patch, 0001-Virtual-table-supporting-recovery-of-corrupted-datab.patch, contains the implementation of a virtual table extension that contains custom recovery logic. The patch is written in C, and roughly follows SQLite's coding style. This CL reimplements the recover functionality in //sql/recover_module. The new implementation is based on the high-level description of the old one, and does not match its structure. The new implementation passes all the tests that shipped with the patch. Bug: 945204 Change-Id: I04df1edfeb48f907303d9525b1c81486bdc62f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546942 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#659641}
-
John Lee authored
Bug: 962423 Change-Id: I5b55e4f20c8adcf2c65c6efe69e955a4e2c66e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611137 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#659640}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25eb8e4680ac..9f1377b76560 git log 25eb8e4680ac..9f1377b76560 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@9f1377b76560 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie5a5a90a84bda4d9ba56c0e942534637673a04d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659639}
-
Robert Kaplow authored
Remove friends for the UpdateSourceURL method. The usage has already been removed but the friends list wasn't well maintained. Bug: 754895 Change-Id: I13aa7e20b0caa9a7dc5be2b60784fd0ec06ce8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606780Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#659638}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/221ab9bee1be..031ad2bc420a git log 221ab9bee1be..031ad2bc420a --date=short --no-merges --format='%ad %ae %s' 2019-05-14 lalitm@google.com trace_processor: stop hardcoding android.mem as the metric name 2019-05-14 fmayer@google.com Only expose new allocation / frees in table. Created with: gclient setdep -r src/third_party/perfetto@031ad2bc420a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129747127 TBR=perfetto-bugs@google.com Change-Id: Ie326b9ed3e61a2796d0c2303c99947480ccb4d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611379Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659637}
-
Ryan Sturm authored
The flake is due to click happening before layout meaning the click message happens before the onLoad message. This switches the order of a WaitForLayout and RunUntilIdle pair of calls. Bug: None Change-Id: Icc52d88317521ac584d92576be41d9ebfea9a638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611916 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659636}
-
Greg Thompson authored
From time to time, a stray window is left behind on the Windows 10 bots that interferes with interactive_ui_tests (it's usually an OpenWith.exe dialog asking the user to pick an app to open some file/URL protocol). This change augments ShowAndFocusNativeWindow so that it makes up to five attempts to close any window that remains in the foreground despite its best efforts to bring the desired NativeWindow to the foreground. BUG=711256 R=sky@chromium.org Change-Id: Iccb568f34c66b5d0571d6d4dc3648c7b06ac35de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610766 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659635}
-
Gary Bressler authored
This change publishes services to both "public" and "svc" in preparation for the ABI change to "svc". Bug: CF-540 Change-Id: I64cf34316b015c29f86d361958209eb6c15cde00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609593 Commit-Queue: Gary Bressler <geb@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659634}
-
Oskar Sundbom authored
Glitches are detected by comparing the differences between the device clock's position and the performance counter value at which the position was recorded. If the performance counter has moved further than the device position has, then it's treated as a glitch. Initially, I tried detecting when the write position (based on the audio device's clock) moved more than a single buffer's duration ahead between two calls. This did not prove reliable on my machine, as the device clock stopped moving forward unless fed enough data. Bug: 864463 Change-Id: Idb1d6c732964b5c4ca30f98f3521f3dbefe3b937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611919 Commit-Queue: Oskar Sundbom <ossu@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659633}
-
Peter Boström authored
Previously the extensions menu would wait for popups to trigger to rely on being closed due to other widgets appearing. This is more responsive for slow popups that take a while to trigger, but also feels better for extensions that don't have an action and therefore do not close this menu. Bug: chromium:959923 Change-Id: If31ef24ea0caf400486f1002435fb3a1c2be7261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598802 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659632}
-
Xiyuan Xia authored
- Pass local state PrefService to ash directly during init instead of getting it through prefs::ConnectToPrefService. - Simplify DisplayPrefs since local state is passed directly to ash; - Update WallpaperController to handle local state is available before its Init call and remove obsolete IgnoreShowUserWallpaper; Bug: 958237 Change-Id: I981fa3cbd5a2a6ebd2a088c678608b601a1fde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606567 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#659631}
-
Daniel Libby authored
Note: based on crrev.com/1595296 When scroll gestures are injected during the handling of an input on the main thread, we want to dispatch the scroll gesture with the LatencyInfo information from the original input event, but with a different type. This allows the end to end latency metrics to be computed correctly and classified separately as a specific type of scroll (not just, e.g. as mouse latency). Bug: 954007 Change-Id: I725eaa46f21883aff08ab209d73dc5d0398a85db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603342 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659630}
-
Sylvain Defresne authored
This code is there to support migration of a flag that is not used since M-48. According to the histogram, 100% of the user have been converted on Chrome OS and Android (the two platforms that still support child accounts). Bug: 960028 Change-Id: I2ca06df6876c96b6cd8407cab429e32e4751090d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609899Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659629}
-