- 20 Jan, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07344a40..b56d35e2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia499a637a920d32b7846ca0bbbf896bb3201c22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010923Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733381}
-
Yuki Shiino authored
This patch eventually cancels the change in https://crrev.com/c/1989232 because the web_idl/ and bind_gen/ directories have already been following PEP8. Bug: 839389 Change-Id: I6730f41e632f786e1bba6adc20ddc105d43860b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010752Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#733380}
-
Alex Chau authored
Bug: 1043148 Change-Id: I0789a40948bf74123ce50685726034d11ceedbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007764Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#733379}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I5fbed15d8a69cf472a24dcf0f855f617b0b9f62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007814 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733378}
-
Jonathan Ross authored
We recently re-enabled a set of tests we believed were fixed: https://chromium-review.googlesource.com/c/chromium/src/+/2006132 However the media/ tests we enabled apparently still flake, but only on Windows. This patch re-adds them to the flag expectations. TBR=backer@chromium.org TEST=skia_renderer_gl_blink_web_tests Bug: 1026375 Change-Id: I141b6c75a7515f178d8c092c29705d99eb79697a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008255Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#733377}
-
Yuki Shiino authored
posixpath.abspath("d:\\a\\b") doesn't work because posixpath doesn't recognize a drive letter. This patch fixes the issue. Bug: 839389 Change-Id: Ifef644dd1e9b26e6a4e572f485e7cbabf7148871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010751 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Sylvain Defresne authored
The provider are not permitted to have dependency on //ios/chrome, however they were able to forward-declare ChromeBrowserProvider so they ended up with indirect dependency. To allow moving the class to the global namespace, allow them to include the forwarding header since this does not increase the amount of "bad" dependency. Bug: 1042208, 1043657 Change-Id: I838167daa14f16ab65983fd3ebf61267f1a9eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010796 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733375}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2347e02. With Chromium commits locally applied on WPT: 8a985066 "[Trusted Types] Implement require-trusted-types-for" 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" 2012a39c "Update timeout and split slow COOP WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4b19d6c728fffde0ce696b8b011104f009c6f547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010922Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733374}
-
Yuki Shiino authored
- Adds V8DOMConfiguration::InstallMethods - Fixes/adds bindings::V8SetReturnValue - Adds ToImpl/ToImplWithTypeCheck and DomTemplate for backward compatibility - Adds check of argument length - Adds member variable definitions of trampoline functions Bug: 839389 Change-Id: Id15984167f876279fe498631fc83aadf4cdd3040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010593Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I1349bdd47e3b14b023bf292539822cb22a37a0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007287 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 1042208 Change-Id: Iebe7231c7edbd4508ea1b9bd34c08c5f9c1a89eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007583 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#733371}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7ec654fdcab5..85de0bc72ef7 git log 7ec654fdcab5..85de0bc72ef7 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 tvanderlippe@chromium.org Fix typescript compilation with ts_library 2020-01-20 aerotwist@chromium.org Adds Puppeteer types 2020-01-20 bmeurer@chromium.org Roll upstream changes. Created with: gclient setdep -r src/third_party/devtools-frontend/src@85de0bc72ef7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iad3451ad495ca0f936aff89111ff80083e0f1008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733370}
-
Jan Wilken Dörrie authored
This change removes the Password Leak Detection base::Feature and feature flag. The feature has been launched in M79 and is completely rolled out, which is why it is safe to remove this code now. Bug: 986298 Change-Id: If1f07423e7ef3a55415c6849340b178bc6affdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007757Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#733369}
-
Tom McKee authored
During a load of the main frame, both the RenderWidget and its owned LayerTreeHost, need to be told that there was a navigation. It used to be that the RenderFrameImpl would notify the RenderWidget then reach into the RenderWidget for a reference to the owned LayerTreeHost and signal it too. This violates the "tell, don't get" principle; it makes more sense for the RenderWidget to forward its signal to the LayerTreeHost than to require calling code to know to update the LayerTreeHost. This CL changes the RenderWidget to forward the 'DidNavigate' signal to its LayerTreeHost and simplifies the neighbouring interfaces. Change-Id: I6050f70a194e7030041d56556ddce5f92c3e2deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002724Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#733368}
-
chrome://flagsarthursonzogni authored
This is about the chrome flags: - disable-pushstate-throttle - disable-ipc-flooding-protection They have previously been deprecated. This patch remove them. It is still possible to use them with the command line switches. See also: - https://chromium-review.googlesource.com/c/chromium/src/+/1268016 - https://chromium-review.googlesource.com/c/chromium/src/+/1341526 Bug: 882238 Change-Id: I296e863c63070e8a61ed31babc9276a6e6982e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007819Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#733367}
-
Rushan Suleymanov authored
Add sharing_message_specifics proto. Sharing message data type is not ecnryptable and has no local sync. There is no implementation for the datatype yet. Bug: 1034925 Bug: 1034926 Change-Id: I71790d18be609d4795ca435f87fa131942ae2fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997500Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#733366}
-
Dominique Fauteux-Chapleau authored
Bug: 1042319 Change-Id: Ie33e4f358d35bb6ed5314e19035536c4860afbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003349 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#733365}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1a0b3340fc2..cfd2711e575d Created with: gclient setdep -r src-internal@cfd2711e575d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2e6e0ed154deabce8ca68af714476ad93d7da556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008254Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733364}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 1042208 Change-Id: I7b90f7a9896a688b95adf8437677a4b544d791da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007586 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Erik Chen authored
Most other platforms either unconditionally, or are moving towards unconditionally building with custom libcxx. This comment suggests that there was always the intention to move unconditionally to libc++: https://bugs.chromium.org/p/chromium/issues/detail?id=554841#c3 And this bug suggests that we're already paying most of the engineering cost for making this config work: https://bugs.chromium.org/p/chromium/issues/detail?id=996754 Change-Id: I030f65b5921c4f5572fafcaf975eff24e804f3ed Bug: 1043560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010226 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#733362}
-
Mikhail Khokhlov authored
TBMv3 now works on all platforms, so we can enable this. Bug: 990304 Change-Id: I56ab4022dc54d4b332e8fd748cb7e601f3f506ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007724Reviewed-by:
Deepanjan Roy <dproy@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#733361}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: Ia8cd48c698de345bd39027eb33a3afdfbabae735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008343Reviewed-by:
-
Findit authored
This reverts commit 2012a39c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 733332 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjAxMmEzOWNjNzA0OWY0MGE4YWU3MjQ0NDdjMWIxNzVkZjQxNjZhMQw Sample Failed Build: https://ci.chromium.org/b/8890739069265843424 Sample Failed Step: webkit_layout_tests Sample Flaky Test: external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html Original change's description: > Update timeout and split slow COOP WPTs > > This updates the timeout to long and splits into smaller tests the > flaky COOP web-platform tests. > > Bug: 1042199, 1043401 > Change-Id: I6295496a43b713efc4ba689d3cac01f8ae989262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003172 > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Arthur Hemery <ahemery@chromium.org> > Reviewed-by: Arthur Hemery <ahemery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733332} Change-Id: I596d059f9e31012e051bc71539ba37a371fa2efc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042199, 1043401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010168 Cr-Commit-Position: refs/heads/master@{#733359}
-
Ewann authored
- Updates the position of the connection security icon(s) horizontally relative to the origin label and separated by 2pts - Updates the position of the origin label to be vertically centered within the omnibox with a -1pt offset. - Updates the position of the origin label to be horizontally centered within the omnibox with an 8pt constant offset. Bug: 1035850 Change-Id: I41967b67acbacb93473ebe0ba7868eac34cd6d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007392 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733358}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I56c1cefb14ba115720b0d802c31e7453fa6bf865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007761 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I33c047057a8341b6d7ea7faf6c166025175b1b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008344Reviewed-by:
-
Simon Zünd authored
This reverts commit d4f52942. Reason for revert: Tests become flaky after this CL. Reverting for a more in-depth investigation. Original change's description: > Reland "Remove event races in two breakpoint decoration tests" > > This is a reland of 61f91381 > > Tentative reland of the CL as-is because: > - in the same time there was a general issue with crashing layout tests > (especially on Mac) > - the issue is not re-producible locally > > Original change's description: > > Remove event races in two breakpoint decoration tests > > > > This CL changes two layout tests to follow the pattern of: > > 1. Install an instrumentation promise > > 2. Run and await an async action > > 3. Await that the instrumentation is called > > 4. Dump breakpoint information > > > > This CL is also in preparation for asyncification of source mapping, > > hence making the "action" async. > > > > Drive-by: Re-baseline one of the layout tests that seems to be fixed > > now. > > > > Bug: chromium:1032016 > > Change-Id: Ibad4160fe9ab32aa3f818cdd4937112c3f4e6f08 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000023 > > Commit-Queue: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#731171} > > Bug: chromium:1032016 > Change-Id: I34ec151749a56a1820330546cd0214b0c22c9eaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007458 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733313} TBR=sigurds@chromium.org,szuend@chromium.org Change-Id: Ic5fcf5a58fe1ff4a49bc2f34195989e2babd1589 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1032016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010844 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#733355}
-
Yuki Shiino authored
The BUILD setting of generated union is missing a header file and it's making some of builds unstable. Adds the missing header. Change-Id: Ie49c820dccc7357dd4227096ea0ff234ac6ee7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010594 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Simon Que authored
The ci.star counterparts of these builders have been migrated to Goma RBE. R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org Bug: 947436 Change-Id: I1d1c6a33f0ee27723c02b9547ef9c826dcfcea8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010467Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#733353}
-
Victor-Gabriel Savu authored
FreeDiskSpaceTotalTime currently has 44% of values greater than the maximum. Create a new histogram with a maximum of 1 minute to track the duration of disk space cleanup. Used by crrev.com/c/1955412 BUG=None TEST=manual Change-Id: I92ce7d854c4c80b5c9f8ec82c4f0596531dcc029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958132Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#733352}
-
Denis Kuznetsov authored
In Polymer v2 the observers/computing functions may be called with undefined parameters: https://polymer-library.polymer-project.org/2.0/docs/about_20#observer-changes Bug: 955194 Change-Id: Ia7ace3901aff929ff474aa16e92a4dfece8d04df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955559 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733351}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bcf142a3e122..7ec654fdcab5 git log bcf142a3e122..7ec654fdcab5 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 sigurds@chromium.org [coverage] Add coverage delta update handler 2020-01-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@7ec654fdcab5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042927 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I60ed9664bac46e40faf38f3d73e33781d68458b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008342Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I66eec2bebef6f80951c0537bb067d38ff75cac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007815 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733349}
-
Shahbaz Youssefi authored
Bug: angleproject:3394 Tbr: thakis@chromium.org Change-Id: I761f6e821f7918294654f789e332eb7220da4545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008303Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733348}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1608370012b..d1a0b3340fc2 Created with: gclient setdep -r src-internal@d1a0b3340fc2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I900d00efbe96a7c591f1ad738b78d043bb4623ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009832Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=javierrobles@chromium.org Bug: 1042208 Change-Id: I1db4504e14331d11f750b765b1a8e3412ae9430d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007759 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/73387823a715..f5c1f79a282d git log 73387823a715..f5c1f79a282d --date=short --first-parent --format='%ad %ae %s' 2020-01-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 201c5e60..f777073e (733179:733282) Created with: gclient setdep -r src/third_party/webrtc@f5c1f79a282d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5daa6384906c66c3183d71ee83188a61a07dc44b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009833Reviewed-by:
-
Ian Kilpatrick authored
Previously if we synthesized the min/max sizes by performing a layout on the orthogonal subtree - we could end up in a situation where the "DCHECK(!constraint_space.IsIntermediateLayout() || box_->NeedsLayout())" was hit. This was caused by a legacy layout fieldset needing a preferred widths recalc. This is an indirect fix for the below DCHECK bug. Removing the IsIntermediateLayout flags means that we now perform a copy back when we are in this (relatively rare) phase. The IsIntermediateLayout was initially introduced as a performance optimization - however it could also hurt performance if we perform a correct layout of a subtree with a fixed size. (we'd need to layout that sub-tree twice, getting exactly the same layout result). Bug: 1039241 Change-Id: I468a9c8e26b5e7855a72ddb2b1f2614538cedd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007422Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#733344}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/abd1a0fc..07344a40 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I994b1b8b46a21ad8c2a50c1c091f0e042d4b11d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010319Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 1021 1022 1023 1029 1030 1031 1032 1040 1041 1048 1049 1050 1051 1052 1054 1056 1058 1059 1061 9 lines were removed and 75 lines were deflaked by consecutive results since 1029. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I4d54ae0146447e1fe2052bee226721d24c92ff55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007325Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#733342}
-
