- 04 Jul, 2018 40 commits
-
-
Makoto Shimazu authored
TBR=sky@chromium.org NOTRY=true Bug: 860111 Change-Id: Ida98cb932b4caf9ffb60622a293dfd2da6b5c29d Reviewed-on: https://chromium-review.googlesource.com/1125540Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572451}
-
Yuichiro Hanada authored
An extension id of many system IMEs were updated as we merged three system IME extensions into one. This CL updates the enum values of InputMethod.ID2 to new values. Bug: 764240 Change-Id: I6fa61733f26a90b534b6ddc971cff96c2bedec15 Reviewed-on: https://chromium-review.googlesource.com/1124212Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#572450}
-
Dominic Farolino authored
By working around a bug in the IDL compiler when generating RequestInit with said compiler, a regression was introduced that stopped TypeErrors from being thrown when RequestInit's signal member does not implement the AbortSignal interface. This CL fixes that regression and adds tests for it. R=kinuko@chromium.org, yoav@yoav.ws Bug: 836873 Change-Id: I6ab7be2ee8356eb7a997b904d121a7061986096a Reviewed-on: https://chromium-review.googlesource.com/1123771Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#572449}
-
Evan Stade authored
This relands da08ce6d Single tab mode makes the frame the same color as a tab. There's no change from the original patchset, which was reverted to make it easier to revert the actual culprit 5f93deb6 TBR=msw@chromium.org Bug: 854704 Change-Id: I1fb8eeb5ae736501f79676668b146d1c8ac32193 Reviewed-on: https://chromium-review.googlesource.com/1125512Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#572448}
-
Mounir Lamouri authored
Bug: None Change-Id: I962397a6c916b176970a451093bcef82bea83258 Reviewed-on: https://chromium-review.googlesource.com/1125403Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#572447}
-
Alexei Filippov authored
It turned out the std::unordered_set does not support concurrent access even to distinct items in the container. Here's the custom implementation of a hash set with keys of void* type. It supports lock-free concurrent access to Insert, Remove, and Contains operations. The latter made as fast as possible since it is on the hot path of the memory allocation hooks. BUG=854399 Change-Id: Ia53eeff08bafc363df2aef8ac5cdd5212f124452 Reviewed-on: https://chromium-review.googlesource.com/1121101Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572446}
-
Alexei Filippov authored
TBR=dgozman@chromium.org Change-Id: I7ae3a232b69b77061e456ea49d224408bf7c540e Reviewed-on: https://chromium-review.googlesource.com/1125351Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#572445}
-
Clark DuVall authored
Cookies will now be stored encrypted by default in the network service. Tested that crbug.com/848361 is fixed with this change. Bug: 789632, 848361, 789644 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8 Reviewed-on: https://chromium-review.googlesource.com/1104791 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#572444}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/502c3ffce8eb..6784ffa78e70 git log 502c3ffce8eb..6784ffa78e70 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 jvanverth@google.com Add some new PolyUtils tests. Created with: gclient setdep -r src/third_party/skia@6784ffa78e70 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ia397b3205df508664a61805b623d6a79a591aca7 Reviewed-on: https://chromium-review.googlesource.com/1125421Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572443}
-
Alexis Hetu authored
This cl's switches cc_unittests and viz_unittests from OSMesa to SwiftShader and fixes other issues related to that change. Bug chromium:848035 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1b58e02d4df4a687ef7be57284c06097bdeca94 Reviewed-on: https://chromium-review.googlesource.com/1070490Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#572442}
-
Dongjing He authored
Bug: 828216 Change-Id: I9913d26070b69d3d52e35d6f9763e674e7fb9ea6 Reviewed-on: https://chromium-review.googlesource.com/1103394Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#572441}
-
Victor Costan authored
Intent to experiment: https://groups.google.com/a/chromium.org/d/topic/blink-dev/pdxkBoURmaA/discussion Notification on experimentation-dev: https://groups.google.com/a/chromium.org/d/topic/experimentation-dev/xwL0PmF3rq4/discussion Bug: 729800 Change-Id: I88aa295f164c68b0700713a143821300724d081f Reviewed-on: https://chromium-review.googlesource.com/1123411 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#572440}
-
yiyix authored
DrawInterval assume that the browser is at 60 fps, but browser has slower fps rate comparing to Renderer. So spikes in this metrics doesn't mean regression in system. Bug: 673598 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a8afb1fb9f2ba2f627df18e2b7c95d6561a5247 Reviewed-on: https://chromium-review.googlesource.com/1119648 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#572439}
-
Mathieu Perreault authored
- The close button is the now the only button showing if there is a permanent error or a network failure. - State is reset appropriately between dialog shows. - Layout is called on the whole widget when buttons change. Bug: 850571 Change-Id: I1dfe792b49102d8a002d9bcf984e8c6c0844cc58 Reviewed-on: https://chromium-review.googlesource.com/1119164 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572438}
-
Aleks Totic authored
Bug: 859787 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03e64594a44c3b7d4ab2fa757f21320df58838f1 Reviewed-on: https://chromium-review.googlesource.com/1125404Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#572437}
-
Alexei Filippov authored
The OnBufferUsage is called through double async chain and by that time the tracing can already be stopped. Do not report usage in this case. The bug caused several tests to flake, e.g. http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js BUG=846920 Change-Id: I94259e38e49e35f21974faf9aef69f96d118c36b Reviewed-on: https://chromium-review.googlesource.com/1125213 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#572436}
-
Marc-Antoine Ruel authored
This is a reland of 3bcc71d8 Original change's description: > Add luci-go tool to be fetched via CIPD > > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes > need to be updated. > > Change analyze to not ignore changes to isolate. > > R=tandrii@chromium.org > > Bug: 851596 > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5 > Reviewed-on: https://chromium-review.googlesource.com/1097623 > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569688} Bug: 851596 Change-Id: I27382d97370376dcca8110c9225c16dada182256 Reviewed-on: https://chromium-review.googlesource.com/1125000Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572435}
-
Oliver Chang authored
--file-url-path-alias=/alias=/replacements will result in all file:// URLs with root paths beginning with /alias to be replaced with /replacement. For IPC fuzzer builds, this is automatically populated with /gen=BUILD_DIR/gen. Bug: 839228 Change-Id: I935278d8b11369efc9b98281a5a8056cee8e579d Reviewed-on: https://chromium-review.googlesource.com/1119727 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572434}
-
Makoto Shimazu authored
TBR=chenwilliam@chromium.org NOTRY=true Bug: 860101 Change-Id: Ia4c9179dc2c287123c6781c57d6db7c1b4da6393 Reviewed-on: https://chromium-review.googlesource.com/1124734Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572433}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3eb704babdf7..20c83a81a0e6 git log 3eb704babdf7..20c83a81a0e6 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 dtu@chromium.org [pinpoint] Increase test timeout from 2 to 4 hours. Created with: gclient setdep -r src/third_party/catapult@20c83a81a0e6 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I073da08e756233f1440a3af97ce51a106d6bc452 Reviewed-on: https://chromium-review.googlesource.com/1125379Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572432}
-
Qiyu Hu authored
This is a reland of cdafb2ec Original change's description: > arc: bluetooth: Implement sending indications in GATT server > > - Ensure that CCCD is added such that we can report the value change in > CCCD to Android in OnNotificationStart/Stop() > - Implement SendIndication() such that Android can call it > > Bug: b:78593133 > Test: Pass Android CtsVerifier test on server sending indication/notification > Change-Id: I8b1a4be6596555003d6d447b4518f37632a45370 > Reviewed-on: https://chromium-review.googlesource.com/1119079 > Commit-Queue: Qiyu Hu <qiyuh@google.com> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572291} Bug: b:78593133 Test: Build w/ is_debug = true Change-Id: I4bd27b7c9bdf4b7c16f14e2d67a2a6647dc14ad6 Reviewed-on: https://chromium-review.googlesource.com/1125359Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#572431}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d000b0a32ee7..57900cb93360 git log d000b0a32ee7..57900cb93360 --date=short --no-merges --format='%ad %ae %s' 2018-07-03 buildbot@webrtc.org Roll chromium_revision 6df2efa5..79cbcdf6 (572277:572378) 2018-07-03 shampson@webrtc.org Adding shampson (me) as an owner to pc/ & api/. 2018-07-03 henrik.lundin@webrtc.org NetEq: Handle nested RED packets 2018-07-03 shampson@webrtc.org Adding ICE configurations to the PC perf test. 2018-07-03 buildbot@webrtc.org Roll chromium_revision ce19c6d8..6df2efa5 (572160:572277) 2018-07-03 srte@webrtc.org Adds debug printing for congestion controllers. Created with: gclient setdep -r src/third_party/webrtc@57900cb93360 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:851662,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id33803de30fd9ae7b5196b0337c6740324a3a3ad Reviewed-on: https://chromium-review.googlesource.com/1125419Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572430}
-
Fady Samuel authored
This CL implements two types of tracing flows: 1. Embed Flow: The flow from allocating a LocalSurfaceId to embedding it in a SurfaceLayer and SurfaceLayerImpl for the first time until a reference is added for the first time to a parent CompositorFrame. 2. Submission Flow: The flow from allocating a LocalSurfaceId to passing it to the child to use to submit CompositorFrames. These flows let us debug surface synchronization performance regressions and lets one visually see the parallelism achieved with surface synchronization. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I02b7baec283e60528faa24dffdca74b641135d2e Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1124976 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#572429}
-
Chris Harrelson authored
For such PaintLayers, the CompositingContainer is the parent, not the containing stacking context. This is because such stacking contexts paint during the normal-flow of the ancestor layout object. This also allows us to enable subsequence caching; the previous attempt last week was still suffering from the under-invalidation reported in issue 859520. The testcases that crash on ASAN from the referenced bugs are fixed; one such example is included in this CL. Bug:859294,719835,723076,859520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ab5271d70bd834482c22b89f09b93907788ed0c Reviewed-on: https://chromium-review.googlesource.com/1125269 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572428}
-
Kyle Horimoto authored
Original CL (uploaded as patchset 1): https://chromium-review.googlesource.com/c/chromium/src/+/1119466 Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1125479 The CL failed on some bots due to trying to set an invalid response code for a proto (the test was trying to test an invalid response code). I've removed that test in patchset 2. Original CL description below: This class represents an operation for completing the verification step for the current host device. A HostVerifierOperation instance is meant to be used for a single verification attempt; if verification needs to be retried, a new instance should be created for the next attempt. This class completes the following steps to verify a device: (1) Call FindEligibleDevices(). This step sends a message to the host device, which in turn enables background advertising. (2) Creates a connection to the device using the BLE listener role. (3) Sends an EnableBetterTogetherRequest message to the host device. (4) Waits for an EnableBetterTogetherResponse messages to be returned by the host device. Bug: 824568 Change-Id: Iee9084763e0f3163baed06f36cc2e357e6313f64 Reviewed-on: https://chromium-review.googlesource.com/1125500Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#572427}
-
Sergey Ulanov authored
Previously ScopedServiceBinding was using fidl::Binding instead of BindingSet, which didn't allow multiple bindings. Also added some new unittests for ServiceDirectory to validate cases that were not handled previously. That required an update in ComponentContext class: it now can handle the case when the target directory is gone. Change-Id: I7975275bebfba716d97c3f41d13046172385aff7 Reviewed-on: https://chromium-review.googlesource.com/1125308Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572426}
-
Aleks Totic authored
Bug: 726520 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic57d3c897a711b58572303f1dca1ba1f4ca31fc2 Reviewed-on: https://chromium-review.googlesource.com/1125401 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#572425}
-
Owen Rodley authored
We currently need to work around ninja writing to stdout in the codesearch builders by using a wrapper script. If we're to use this script instead, we may as well bake this in here and remove the need for a wrapper. Bug: 396230 Change-Id: If161310d2b93c4fed2ee2de1c4b3fba8b9aa2313 Reviewed-on: https://chromium-review.googlesource.com/1124124 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572424}
-
Andrew Grieve authored
* Use assert statements * Reduce visibility of methods where possible * Create singleton during class initialization Change-Id: I60c2da7d8cdb1065eba47c45a3369b8ba0e34780 Reviewed-on: https://chromium-review.googlesource.com/1116281Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#572423}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I5d70f28869551ffae4a16431dec01cc5101820be Reviewed-on: https://chromium-review.googlesource.com/1125339Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#572422}
-
Makoto Shimazu authored
crrev.com/c/1124729 marks a few tests as flaky on Mac, but this replaces it to Mac10.10, which is more restrictive. TBR=pdr@chromium.org NOTRY=true Bug: 857501 Change-Id: Ibca47cd41a2ec17b95372ea115081f08312217ba Reviewed-on: https://chromium-review.googlesource.com/1124731Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572421}
-
Christopher Cameron authored
Bookmark folders using Views are very janky (~5 fps, with the CPU at 100%). Calls to RenderTextHarfBuzz::ShapeRunWithFont account for almost all of this time. Many of the calls to ShapeRunWithFont are done with the same arguments every frame. To alleviate some of this jank, add a cache the results of this function call. Refactor RenderTextHarfBuzz::ShapeRunWithFont to be stateless, and add structures ShapeRunWithFontInput and ShapeRunWithFontOutput for the arguments and output of the function. Use ShapeRunWithFontInput as a cache key. Bug: 826265 Change-Id: Ic6726c1152c44dc5cb0eccddf1ff3adcd060d8e7 Reviewed-on: https://chromium-review.googlesource.com/1123456 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572420}
-
Philip Rogers authored
This was generated using: https://chromium-coverage.appspot.com/reports/572002/linux/chromium/src/third_party/blink/renderer/core/frame/local_frame_view.cc.html BUG=823365 Change-Id: I136ba88950e2d042fd330cedb88614562af2e264 Reviewed-on: https://chromium-review.googlesource.com/1125309Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572419}
-
Xianzhu Wang authored
Previously we always sequentially matched old and new display items. The algorithm was efficient for sequential matching, but was O(n^2) in the worst case that the new chunk reversed the order of display items of the old chunk. Now add an index for matching out-of-order old display items. Sequential match is done only in a single pass. It's the same method that we are using in PaintController. When display item raster invalidation was in PaintController, we also used the same index for raster invalidation. Bug: 859940 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I86ee7f4a324f710daaad03f29d00b17db0f11cb7 Reviewed-on: https://chromium-review.googlesource.com/1125300Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572418}
-
Ahmed Fakhry authored
Rather than toggling Night Light on or off, clicking the label should take the user to the display settings page where Night Light can be adjusted. BUG=859848 TEST=Manually Change-Id: Ic1f15c6c953bfc8a38f94a7015dc7a3b877c404b Reviewed-on: https://chromium-review.googlesource.com/1125338 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572417}
-
Sara Kato authored
Currently, when ctrl+search+m is used to toggle the magnifier, this is not reflected in chrome://settings. However, the other accelerators (docked magnifier and high contrast) are reflected in settings. Bug: 853104 Test: Manual Change-Id: Ia70b868eb89598ba90b79e2e5da482bd0bb6a916 Reviewed-on: https://chromium-review.googlesource.com/1114524 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572416}
-
Tarun Bansal authored
Change-Id: I34426ea80d26a23bbb3252b91cb24ad9b3e79ca5 Bug: 827256 Reviewed-on: https://chromium-review.googlesource.com/1125306 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#572415}
-
Mike Wasserman authored
Attempting to use this example crashes otherwise: [233814:233814:0703/151833.248652:FATAL:native_widget_aura.cc(151)] Check failed: params.parent || params.context. #0 0x7f45424a2f7c base::debug::StackTrace::StackTrace() #1 0x7f45423f23bb logging::LogMessage::~LogMessage() #2 0x7f453db8604b views::NativeWidgetAura::InitNativeWidget() #3 0x7f453db68157 views::Widget::Init() #4 0x0000004e76bd ash::TestChildModalParent::TestChildModalParent() #5 0x0000004e74ee ash::TestChildModalParent::Create() #6 0x7f453daefbed views::Button::OnMouseReleased() Bug: NONE Test: No ash_shell_with_content crash showing child modal window. Change-Id: Ic6a2382676d54ea47fd1a6a70b0209c26fd3d87f Reviewed-on: https://chromium-review.googlesource.com/1125294Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#572414}
-
Owen Rodley authored
This is required if this is to replace the codesearch generate_compilation_database method, as mentioned in https://crrev.com/c/1114413. Bug: 396230 Change-Id: I61122bae15bed27463e5b770623fdf8106836aac Reviewed-on: https://chromium-review.googlesource.com/1124077 Commit-Queue: Owen Rodley <orodley@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#572413}
-
spqchan authored
Disabling: http/tests/devtools/tracing/timeline-js/timeline-script-tag-1.js TBR=dgozman@chromium.org Bug: 859629 Change-Id: I8e5bb8aef555d24f38fa7e386d315d05d147df7e Reviewed-on: https://chromium-review.googlesource.com/1125358 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#572412}
-