- 08 Dec, 2020 7 commits
-
-
Daniel Libby authored
Add support for recording selection bounds at paint time for CAP implementation of composited selection. Composited selection today runs after the compositing assignments lifecycle phase, and queries the selection bounds relative to the layers in which the selection lives. In CAP, we don't have this information available to do the same operations. Instead, when we are painting the selection endpoints, we will record the bounds on the paint chunk. When updating cc layers, convert these bounds into the cc::LayerSelectionBound to set on the LayerTreeHost. This is just the initial implementation for NG text selection. There remain a number of follow ups: - Since not everything has been converted to NG, this will have to be done for non-NG as well. - Selection on replaced elements - Selection on SVG text - Caret (empty selection) also needs to be represented This change turns on CAP for a few browser tests that exercise this codepath and currently pass. Eventually all such tests should be converted to run in both modes (once caret is implemented). Bug: 1065049 Change-Id: I418ff5f9c5d7d89a7500e9353594bf1a7263934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568694Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834468}
-
Joshua Peraza authored
Change-Id: I6743453668b1db418d7e6c043bcc3c48d6fe865d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575721 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834467}
-
Trent Begin authored
This arrow icon is used to indicate that there is additional information inside the routine group if clicked out. The arrow toggles when the routine group is expanded to show it can be closed again. Screenshot: https://screenshot.googleplex.com/5rk7VW6yFE4brfW Bug: chromium:1142857 Change-Id: Ifc6163a2a5f394d2692911046a7ac38399e9f040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577722 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#834466}
-
Collin Baker authored
Adds interface BackgroundThumbnailCapturer for capturing background tabs. The current video capture logic is moved to implementation BackgroundThumbnailVideoCapturer. This will allow experimenting with different capture techniques. Bug: 1090038 Change-Id: I6204f767be6c8bf42aebf79ca0f9e24606d91f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561466Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#834465}
-
Yoichi Osato authored
This is needed to show the events Waterfall. I will implement the front end side later on. Devtools for WebTransport design doc:https://bit.ly/3ig8BLi Bug: 1152290 Change-Id: I7913c46961f911b0a3f9e8bab44c7e023b4abbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576862Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#834464}
-
Mitsuru Oshima authored
Explicitly skip EndDrag if the end reason is "window is being destroyed". Bug: 1151072 Test: covered by unittest Change-Id: I4310f21993d938ee560d13f7a51755a41c375824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570315 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#834463}
-
Andrew Xu authored
Bug: 1156167 Change-Id: I994ebc40f7080ba2ee683d6248266cebd3c6b6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576780Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834462}
-
- 07 Dec, 2020 33 commits
-
-
Piotr Bialecki authored
Add depth samples to proposals' index.html, add diagnostic information (leveraging DOM overlay) to communicate why nothing is rendered (either pose data or depth data may be missing). Bug: 1151431 Change-Id: I3ada6936a663ee2cb488a2ff749883a714a07ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578040 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#834461}
-
Jarryd authored
Based on an abandoned CL owned by astavrakos@: https://chromium-review.googlesource.com/c/chromium/src/+/2335494 This change wires up QuotaManager to connect to the QuotaChange event dispatch flow. It also moves the debouncing logic from QuotaManager, into QuotaChangeDispatcher, which should be responsible for all heuristics related to dispatching. A new command line switch was added, quota-change-event-interval so that developers can override the debounce interval with a smaller value to help them test. This also allows us to override the debounce interval for unit and browser tests. This change adds a QuotaManager unit test, a new unit test suite for QuotaChangeDispatcher, and a browser test for the full event flow. Bug: 1088004, 1096549 Change-Id: Ib3786758f77f099cbd9d88fee130a3d3d11370de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499363 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834460}
-
W. James MacLean authored
Disabling on M-89 dues to recent spike. Bug: 1148542 Change-Id: I83b62f75d8e8b034d58f44fe64ab5bae055abeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576430Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#834459}
-
Curt Clemens authored
Add "How your device appears to others" help text underneath the device name input on the onboarding page. Adjust layout. Expand input to 50% width, accounting for margin. Baseline of input centered vertically. Image centered vertically. Margins adjusted to spec. Screenshot: https://screenshot.googleplex.com/AapmoYP4m5Jhwrv.png Bug: b/163036847 Change-Id: I258c7be50e497d981a677b3d6c9bb196529afaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575211 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#834458}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3efbe10ffd42..3bf980426002 2020-12-07 marcinoc@google.com Rewrite android_sysui_cuj.sql to create intermediate tables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161781469 Tbr: perfetto-bugs@google.com Change-Id: Ic614d73832735bc2d88c7b4f13a37f426e62dbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574971Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834457}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a10d694e914e..dea86294537c 2020-12-07 jdarpinian@chromium.org iOS build support 2020-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 142cb87f803d to dd69df7f3dac (17 revisions) 2020-12-07 jie.a.chen@intel.com Enable some tests on Intel Windows Vulkan 2020-12-07 paulthomson@google.com Tests: add WhatsApp trace 2020-12-07 jmadill@chromium.org Fix separable Geometry shaders. 2020-12-07 jmadill@chromium.org Geometry Shaders: Don't require 'flat' for integer varyings. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: angle_perftests --gtest_filter="*whatsapp*" Change-Id: I8868514ea5957779c9201437f5eed0d98c7870ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577802Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a377bcb..1c9380eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia71ff3f2442dc955998c27c427cf974d4501079c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577860Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834455}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/55e9ddf21994..3b055d329e60 2020-12-07 vapier@chromium.org repo: use str(Path) for Python 3.5 a little longer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie26d42adbcc78fba88f0089c251a02aae79ee908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577807Reviewed-by:
-
Jimmy Gong authored
Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/97d2fdaa8a77f2ca60b7059fbd5997de0ba3cbe9?authuser=0 Bug: 1155244 Change-Id: I2c5d902a7a3c8bd5e61c7b3fd4914d852ad8828b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575205 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Dave Tapuska authored
This implementation can move into blink. Previously the implementation looked for all elements with the video tag. BUG=561879 Change-Id: I8890198bf5ba66d7685b37377d2130ad09939547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570121 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834452}
-
Emircan Uysaler authored
This CL skips these calls until there are overlays present to avoid marking the primary plane as white in startup. Bug: 1155736 Change-Id: I4d9f6fce135cf11b70505e045d481531e874834d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575261Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834451}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser. Bug: 1113033 Change-Id: I56d2c3738c82c7f968b0bb2fe02ae3a1c593ec1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577861Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#834450}
-
Liquan (Max) Gu authored
Context: Since SettingsAutofillAndPaymentsObserver is autofill logic and PaymentUiService is in charge of the autofill service, the observer class should go into PaymentUiService. Changes: Moved SettingsAutofillAndPaymentsObserver from: * CPRService#notifyPaymentUiOfPendingApps to PUiService#setPaymentApps * CPRService#close to PUiService#close Bug: 1025619 Change-Id: I224cf06276b26857775c26d2a030fd5fcc7d3295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574602Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834449}
-
Jeroen Dhollander authored
UX has decided to pivot in another direction, and Bloom will not be released as a stand-alone feature. Bug: b/175052039 Test: Compiled Change-Id: Ib4ba7e2376be58a5bb54408c6504045ea8cb762f Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577897Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834448}
-
Wan-Teh Chang authored
I just followed the instructions in this page and ran into this error message. The URL in the error message was different. Change-Id: Iba5be503a8d1bf8050435471a1de7f8323adffbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577881Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834447}
-
Nico Weber authored
This mostly doesn't work, so also add some documentation that tells people not to use it. (The documentation also has some other information.) No behavior change for regular builds. Bug: 1149587 Change-Id: I03f4f5b65a0d010636a499b043bfcf31b0cd34b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574601Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834446}
-
Tom Anderson authored
No behavior changes. This CL mostly moves code around. * Move all xcb_* calls to connection.cc * Move FutureBase into Connection and rename to FutureImpl * Future now uses composition instead of inheritance for FutureImpl * Move Future to future.h, which requires adding the header everywhere R=sky Bug: 739898 Change-Id: I396e985b67881b9cfd3536cd01629f5573b293aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575938Reviewed-by:
-
Shimi Zhang authored
This reverts commit fc868f17. Reason for revert: Please refer to crbug.com/1156244 Original change's description: > Batch CriticalPersistedTabData tests > > Apply batching to CriticalPersistedTabData tests so that they run > faster. > > Bug: 1152295 > Change-Id: I655e4ffe2f79a8549311b32a1f7ff760f3dda34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556453 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: David Maunder <davidjm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833794} TBR=yusufo@chromium.org,wychen@chromium.org,davidjm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152295, 1156244 Change-Id: Ib206dd5cf731a64493b505374ca03d622f519498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577611 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834444}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/816ffa4d4ef7..fa2c56d16d1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141111 Tbr: ellyjones@google.com,avi@google.com Change-Id: I22b1e845da848ac7decba0fcc105b81d5038835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574972Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834443}
-
Wez authored
Bug: 1154829 Change-Id: Icd469fee4847b04787096d14f366b0f84b4832c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577466 Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834442}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e79095f5335b..57c86890de5f 2020-12-07 leese@chromium.org Clean up type definition for RawLocation 2020-12-07 andoli@chromium.org Hides horizontal scrollbar in elements style panes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I64583c3abf4ea57aaba9d823ddbd5aaebbb3271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577532Reviewed-by:
-
Darren Shen authored
SendKeyEvent has an extra code parameter that is used when there is no keycode. However, we can just implement that logic upstream so that there is always a keycode and we can remove the `code` parameter. Bug: b/174612548 Change-Id: I98bb1be1c62fe141ed74f7243b8ac645f9a51963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566868Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834440}
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. This change stores the aliases (which are already being extracted) in a new field of type std::vector<std::string> in net::AddressList called `dns_aliases_`. The first entry of this vector, if it exists, will be the canonical name, and so this change also removes the previous `canonical_name_` field and renames the canonical name getters and setters with camel case, making them no longer inline, as now they have compound logic. This CL moreover provides the ability to merge lists of aliases to the net::HostCache::Entry class, as well as some additional unit tests and updates to existing ones. Relevant tests: net:net_unittests --gtest_filter=*GetCanonicalNameWhenUnset* --gtest_filter=*DnsAliases* --gtest_filter=*CnameChain*TypeA* --gtest_filter=*MergeEntries* Bug: 1151047 Change-Id: Ie45cb4284df33053db36b364ea982cbfe3d6a618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561274 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b9d9529da93a..963b0a6bd915 2020-12-07 jophba@chromium.org Add presubmit check for unnecessary is_value checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I6d089d59b7ff366bae28016ba9ab9706f3b53a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577698Reviewed-by:
-
adamta authored
Doubled offset for Discover feed scroll-to-load trigger. Used to trigger at the ~9th article, will now trigger at the ~7th (depending on card sizes). Bug: 1156297 Change-Id: I13c836b4b504b55b64bc123d8a183ece58524ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577958Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#834437}
-
Anupam Snigdha authored
This patch adds some traces in the APIs that are called when the IME on Windows tries to position the candidate window and start a new composition. These traces would be really useful while trying to debug IME related issues which are also hard to debug in a debugger as they are sensitive to timings and focus loss. Bug: 1152893, 1151301 Change-Id: I1f0e36d4f9524190efb6b3404d0eb96ee5c85679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572800 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834436}
-
Brian Sheedy authored
Cleans up the unused and fully passing pixel test expectations based off the output of the unexpected pass finder script. Bug: 1155766, 653538, 1136742, 624256, 690277 Bug: 648369, 660461, 857578, 744658, 840394 Bug: 868596, 1068620, 997313, 1019462, 1028975 Bug: 1069339, 1033982, 1082769, 1097735 Change-Id: Ie559cebda155a6ea80065386e35c447ff1fa3db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575433 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#834435}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for some directories under //third_party. Bug: 1113033 Change-Id: I8d194fbc92282d01d7d1f7031d450587a743fd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577615 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: I5d1e0c4e07ff5bf3c5133a3330b7495c5c713677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578118Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834433}
-
Takuto Ikuta authored
-raw-cmd is no-op now. Bug: 1142713 Change-Id: Ib89afe7ffbfbdc1e303eb3b49da9bfd4ab8e4597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575779 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1502e7972cb..48b2aad780bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie1328bf85db56dc8283979cc69640d55232e8a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577723Reviewed-by:
-
Becca Hughes authored
Adds a method which will get newly discovered Media Feeds which will then be displayed to the user. When the user gives their consent then this will be stored. Change-Id: I70cc391e394d7c21334c3722526a33e30cf9c45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568290Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#834430}
-
Felipe Andrade authored
Add new HTML/JS files for the new Kerberos OS settings sections. Also, update BUILD files to include the new section. This new section is still behind the KerberosSettingsSection flag. The actual content for this section will be added in the future, reusing code from the OS people section. Bug: 983041 Change-Id: I21d1a2ad7be93c284d017492ee487d9c574f9fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558400Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
