- 27 May, 2020 25 commits
-
-
Anastasia Helfinstein authored
In an effort to better share test infrastructure, the first step is to move the currently shared files into a shared directory. AX-Relnotes: n/a. Bug: 1078119 Change-Id: I68240eea961dd6ca733cca483332dbd6caaa230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209673 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772050}
-
Nate Chapin authored
Bug: 1086668 Test: images/enable-images-then-detach-crash.html Change-Id: Id685d3fe1283efa2d3695a81c4154031f860b601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216792 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772049}
-
Andres Pico authored
In the past, we've checked for the presence of the kNoSandbox switch when initializing sandbox_info, and if a child process was unsandboxed we would avoid initializing sandbox_info at all. However, the kNoSandbox switch is only meant to be used as a browser level flag for testing purposes only. There exist other ways to denote an unsandboxed process too, as in the case of the unsandboxed utility process which uses the switch service-sandbox-type=none instead of --no-sandbox. Similarly, there's also an unsandboxed GPU process which makes use of the --disable-gpu-sandbox switch instead of the --no-sandbox switch. This has resulted in having unsandboxed processes initializing their sandbox_info as if they were brokers, and as a consequence, having the same process mitigations applied to them. This last behavior is certainly an unintended side-effect that could manifest as a bug eventually. In this CL, we're updating the way in which we check whether a process is unsandboxed to ensure that no unsandboxed processes have their sandbox_info initialized as brokers, and to prevent applying the same process mitigations accidentally. Bug: 1066258 Change-Id: Ifdc14b0e29f9505edeec93417bd9cc7ab73e94c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208189 Auto-Submit: Andres Pico <anpico@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772048}
-
Anastasia Helfinstein authored
This is the (hopefully) penultimate change in the process of changing to a views-based menu for Switch Access, as part of implementing the visual specification. This change rewrites the menu manager to use the new menu, rather than the old menu. A clean-up change (to remove code for the old menu) will follow this. AX-Relnotes: n/a Bug: 973719 Change-Id: I596d47a8f976a531e545bc56555f9f8da80efbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176611 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772047}
-
Pete Williamson authored
As part of a three sided change, remove the old version of the API now that it is no longer in use. Bug: 1080884 Change-Id: If344fbbedadad6c5c807baad3443a3811860cdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199981Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#772046}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates the print dialog navigation test that previously didn't expect a change of RenderFrameHosts etc. on same-site navigations - we're now changing the test to do a same document navigation (which is what GMail is doing). For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: Ifeb972f92f86d45385545f84d27d53784d7abe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212287 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#772045}
-
Yue Li authored
Check the enrollment status before calling stop enrollment call. Also restore a JS method that was removed accidentally recently. Bug: 1084388, b/157268233 Test: Manual Test Change-Id: I86826951ee2185ca0b1635278ef5b2a84358ac35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213241Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#772044}
-
Greg Thompson authored
When loading a .pak file, allow other entities on the machine to open the file for deleting but not for writing. This is closer to the way an executable is mapped into memory for process creation. With any luck, this will reduce startup crashes resulting from an inability to map in the locale's pak file. This change also adds DataPack.Load to the Chromium metrics description files (it has historically been in the Google internal one). BUG=1076423 R=asvitkine@chromium.org Change-Id: I3039922d0edab047e48cf03699f93bcb2c2f0673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215241 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772043}
-
Fabrice de Gans-Riberi authored
* Add a WebEngineRenderFrameObserver object whose lifespan is bound to the RenderFrame. This class owns other objects whose lifespand is also bound to the RenderFrame and that need to be accessed through WebEngineRenderContentClient. * This is a preliminary refactor to add more objects to this class, particularly for the Cast Streaming Receiver. Bug: 1042501 Change-Id: I1b8ba1de47be717e1ce28a3fcd40ebccb7a2f4e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209752 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772042}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I32807d7e13c9347b9c214eac7168649e4a8bbd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212115Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772041}
-
Victor Hugo Vianna Silva authored
This CL adds an integration test that checks that, if the user clicks "Save" on the bubble introduced in crrev.com/c/2112360, the unsynced credentials get saved in the profile store. Bug: 1060132 Change-Id: I014515112abfaf1d3955c06a1d1567cd6e9d6fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207228 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772040}
-
Rouslan Solomakhin authored
Before this patch, desktop was the only platform that stored the Payment Request data from the renderer in a payment_request_spec.cc class and all C++ payment app implementations depended on it. This complicated using the C++ payment app implementations from Android. This patch adds a JNI wrapper for payment_request_spec.cc, which is used on Android and is passed into native. After this patch, it's possible to pass the C++ payment_request_spec.cc into the native service_worker_payment_app.cc when it's created on Android. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: Ic78488ac8d565c9fe6a8f892b56d20c0666386c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212387 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772039}
-
Aaron Colwell authored
The original code created the CPSPI::Handle in response to RegisterHost() calls on the AppCacheBackendImpl. These calls can arrive after the process has been destroyed which is what was causing the invalid handles to get created. This change creates the Handle when the AppCacheBackendImpl is created and then duplicates this Handle when the RegisterHost() calls occur. Creating the Handle earlier allows the security state for the process to be kept alive beyond the process lifetime so it can be used by the RegisterHost() calls and the resulting AppCacheHost. This should prevent the invalid handle crashes reports that we have been receiving. Bug: 977169, 1086306 Change-Id: I987b8b22ce2c5e0db2fe9a42b5b329b487bed73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216913 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#772038}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/30298dc25394..9dac86c9c458 2020-05-26 gbiv@chromium.org gen_proc_table: generate `const` tables 2020-05-26 kbr@chromium.org Remove requirement of OES_texture_half_float for EXT_color_buffer_half_float. 2020-05-26 kbr@chromium.org Emulate GL_EXT_sRGB on ES 3.0 devices without native support. 2020-05-26 jmadill@chromium.org Vulkan: Fix bad delete of swapchain. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1079475,chromium:1084580 Tbr: ynovikov@google.com Change-Id: Iefc12e81d2178e0ba9c3c30ebcda9bb1efaf60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216761Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772037}
-
Mustafa Emre Acer authored
This CL observers the creation of JavaScript dialogs. When it detects one, it immediately shows the delayed SafeBrowsing warning which also cancels the dialog. A new histogram bin is also added to record this event (kWarningShownOnJavaScriptDialog). Bug: 1081314 Change-Id: I7f8bcf1fc94f62007d8fc4e2170dadb613b7038a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216382 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772036}
-
Lukasz Anforowicz authored
Bug: 1085629 Change-Id: I9f4b25a064f523b30208405b17f33b1b0596f7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212999Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#772035}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/79156e7a..c3f19085 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icd6b8b876b7b0d0b7e4875f81ebafd7a64ef62af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772034}
-
Kurt Horimoto authored
This CL tests that the location bar state is set correctly when an HTTP authentication dialog finishes its dismissal when the active WebState is null. Bug: 1085676 Change-Id: I8ca8951b5782b8e239b5c2940ced10a6887924a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216639 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#772033}
-
Anders Hartvoll Ruud authored
There is currently some code in FontBuilder that tweaks the specified font size if the current generic font family changes to or from monospace. This code assumes that the FontDescription stored on the ComputedStyle pre-CreateFont is the inherited FontDescription, but this is no longer (always) true. This means that declarations like font-size:1em can be applied (and subjected to CreateFont) twice, which means that the second call to CheckForGenericFamilyChange won't detect a change in the monospace-ness, hence the specified size will fail to adjust. This CL fixes this by propagating the actual parent style to CheckForGenericFamilyChange. Bug: 1086082, 1086680 Change-Id: Ia61a2327890f27497e4ea5f41dec00a5e0a450d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216511Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772032}
-
Tsuyoshi Horo authored
FrameNavigationEntry's |web_bundle_navigation_info_| is used for history navigations inside a web bundle. But it is set in NavigationControllerImpl::RendererDidNavigateToNewPage() only when the navigation type is NAVIGATION_TYPE_NEW_PAGE. It must be updated for other navigation types. So currently history navigations of iframe inside web bundle are broken. To fix this problem, this CL changes NavigationControllerImpl to update the |web_bundle_navigation_info_| of the FrameNavigationEntry for other navigation types. And also, this CL changes NavigationRequest::CommitNavigation() not to pass |web_bundle_handle_| to |render_frame_host_| when the navigation was not served from a web bundle. This is intended not to keep the |web_bundle_handle_| in RenderFrameHostImpl when the page is not served from the web bundle and to make RenderFrameHostImpl:: MaybeCreateWebBundleHandleTracker() checks the parent frame's |web_bundle_handle_| even after navigating the iframe out of web bundle. (ex: WebBundleNetworkBrowserTest.IframeOutOfBundleNavigation) Unfortunately remote iframe navigations can't load pages from parent frame's web bundle (ex: IframeParentInitiatedOutOfBundleNavigation of WebBundleFileBrowserTest and WebBundleTrustableFileBrowserTest). We need to change NavigationControllerImpl::NavigateFromFrameProxy() to correctly handle the WebBundleHandleTracker. But this CL keeps this problem as TODO. Bug: 1040800 Change-Id: Id416155502582e7f075cf7ceeb8dfa1bc2caac1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014625 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772031}
-
Wez authored
This fixes local-sdk.py SDK builds to match Fuchsia's 'terminal' SDK images. Bug: fuchsia:50751 Change-Id: I49bbd26eb94f438029f62f971ee823eb40e1435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215329 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#772030}
-
Mounir Lamouri authored
This removes the duality between PictureInPictureServiceImpl and PictureInPictureWindowControllerImpl that made handling the PictureInPictureSession object more complicated than it should. Now, the service is simply a shell passing the requests to the controller which then handles the current session at the WebContents level. This CL also introduces a content_browsertest test in order to allow for integration tests that do not include the //chrome layer. Follow-ups may include moving some browser_tests to it as they tend to be flaky and they are not testing the actual UI. Also adds a check for surface_id being null when the session creation is requested. Bug: 1067152, 1069858 FIXES: 1067152, 1069858 Change-Id: I1c389c513cc227e6d0f9d5e447926186600cdc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197996 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#772029}
-
Wez authored
Negative |Popen.returncode| values indicate that the process was terminated by a signal (e.g. SIGSEGV) under POSIX systems. Check for -ve |returncode| values and report them with a different message text, to make it clearer when things are crashing. Change-Id: I84a3e30d5babea9d630347e10fbd5b21df5f0706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213539 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#772028}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d $ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s' 2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket. no functional change, not flag protected. 2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl 2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight. protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi. 2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-05-21 dschinazi Rename some transport parameters Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Roll src/net/third_party/quiche/src/ 8aff71f6f..517beaa47 (5 commits) https://quiche.googlesource.com/quiche.git/+log/8aff71f6f3e1..517beaa4782d $ git log 8aff71f6f..517beaa47 --date=short --no-merges --format='%ad %ae %s' 2020-05-26 ianswett Check has_handshake in quicpacketcreator::consumedata rather than delegate to shouldgeneratepacket. no functional change, not flag protected. 2020-05-26 quiche-dev Fix errors found by Clang warning -Wdangling-gsl 2020-05-25 ianswett Add a new 'b2hi' connection option which limits the reduction of inflight_hi based on cwnd instead of target inflight. protected by gfe2_reloadable_flag_quic_bbr2_limit_inflight_hi. 2020-05-22 wub In quic loss detection tuner, do not give feedback if a connection 1) has no packets lost, 2) would still have no packets lost if the reordering_shift increased by one. protected by existing flag --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-05-21 dschinazi Rename some transport parameters Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I4ea2e5add772e4c619f8acf87d197e96862163a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216638Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772027}
-
Mounir Lamouri authored
The flag is now enabled by default. Bug: None Change-Id: Iab273e0d44c0e511c9e2efd1dfaa37d9dafa5a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018089 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#772026}
-
- 26 May, 2020 15 commits
-
-
Nigel Tao authored
Bug: 1070409 Change-Id: I37e8de608a75dbbfc1fcb576cab0b0db3e50c2e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212230Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772025}
-
Xiaohan Wang authored
Currently LOG(WARNING) is used which shows a long list of warning during browser startup. Use VLOG(1) so that it does not show up by default perstyleguide at src/styleguide/c++/c++.md#logging R=atwilson@chromium.org Change-Id: Ia32bcfc012583535d028a51165f4aa779ef12954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208018Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772024}
-
Bettina authored
The reason for this is due to changes in the Finch files which means that Finch may not be able to connect to a user which would cause the changes to not take into effect. Bug: 1068525 Change-Id: Ib8e318d4b2cd3f0c2fb863ee94ce11a594295be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197518 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772023}
-
Regan Hsu authored
* URL search param synced to search input text field. * Adds a 'search' param to routes navigated to via the search box with the search query encoded. * If the internet detail subpage is navigated to via the search box, do not focus the internet detail disconnect button. Instead, defer to default subpage behavior of focusing the back button. * Modifies OsSettingsSearchBoxTest to account for a 'search-result' URL param if navigated via settings search box. Bug: 1071284 Change-Id: I045257914bd12933b3e8a7d28a4770db522b7972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212803 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772022}
-
Ken Rockot authored
Implements a test for backward-compatibility between any two versions of a mojom struct or union definition. Bug: 1070663 Change-Id: I1d4a8db2722dc3b66435495b77c79db348cdbb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216042 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#772021}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f203902ee8b7..24f3a385a38c 2020-05-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-05-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9f720dd5b204be8a04386a9e51683b7ee452b93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772020}
-
Kramer Ge authored
Software compositing is not supported on ChromeOS so they're skipped. And suppress Pixel_WebGLSadCanvas, and Pixel_PrecisionRoundedCorner. Bug: 1084796, 1086687, 1086690 Change-Id: I0a2500a0cddaef4eb0dbad0a345286541fa942b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212930 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772019}
-
Rachel Wong authored
We are planning to refactor PrivacyInfoView so that it can be used by both the Assistant and Suggested Content notices. This CL moves privacy_info_view first in order to make the main refactor CL (https://chromium-review.googlesource.com/c/chromium/src/+/2198848) easy to read. Bug: 1079169 Change-Id: I84bd1033cb84e6779225445f8b6992af8d9cacd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200559Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#772018}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b41316cd4c22..0d4647dffe2f 2020-05-26 tommi@webrtc.org Remove send_crit_, bitrate_crit_ and last_bandwidth_bps_crit_ locks. 2020-05-26 handellm@webrtc.org P2PTransportChannel::OnCandidateResolved: fix resolver leak. 2020-05-26 handellm@webrtc.org PhysicalSocketServer: remove heap-based epoll_event handling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:905542 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I68db2898fbd250bb1d1a718a1dbb7ed4ce00aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772017}
-
Kurt Horimoto authored
This selector is triggered by overlay UI dismissal, which may occur after the active WebState is set to nullptr. Bug: 1085676 Change-Id: I62cde04911b19ae95b34e26e554c9c53dbed8260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213736 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#772016}
-
Ender authored
This reverts commit 8097a7d7. Reason for revert: we're now ready to enable this feature by default. Original change's description: > Revert "Enable Local-history ZPS for signed-out users by default." > > This reverts commit 43b20143. > > Reason for revert: we will be doing staged rollout and this cl would go live May 19 > > Original change's description: > > Enable Local-history ZPS for signed-out users by default. > > > > This change enables on-device history ZPS suggestions for users > > who are not signed in to Chrome on Android. > > > > Bug: 956837 > > Change-Id: I689960538b1087eac9355ba0b20da7310f5e3daa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132864 > > Commit-Queue: Ender <ender@google.com> > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755854} > > TBR=tommycli@chromium.org,ender@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 956837 > Change-Id: I5c199dd5fb814eb58a09b3dc20f5df23da17616b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176651 > Reviewed-by: Ender <ender@google.com> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Ender <ender@google.com> > Cr-Commit-Position: refs/heads/master@{#764864} TBR=tommycli@chromium.org,jdonnelly@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 956837 Change-Id: I5711f95e7c28fe978626e919c52eb6f2d0b98c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215454Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#772015}
-
Alexey Baskakov authored
We should commit ScopedRegistryUpdate before calling the notification. Bug: 1069605 Change-Id: I161fa70218531b194a49c8c344a87bfd2f1005e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215396 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#772014}
-
Sammie Quon authored
When dragging a snapped / maximized window to a new display, and then snapping / maximizing it there, the restore bounds need to be parented to the new display. When snapping a window, we could have just converted the existing screen bounds to parent bounds, but it seemed better to just use parent bounds for the drag details data (screen is not required) and WindowState::SetRestoreBoundsInParent does conversion for us. Test: ash_unittests WorkspaceWindowResizerTest.MultiDisplayRestoreBounds Bug: 1084728 Change-Id: I631aa25b1b15d9c0141784f3469eb18cf8e59ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212972 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#772013}
-
Oriol Brufau authored
It used to be the case that setting 'grid-template-columns: inherit' and 'grid-template-rows: inherit' would also inherit 'grid-template-areas'. This got fixed as a side-effect of r747669, adding a test now. Bug: 966090, 1085853 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-009.html Change-Id: I27865cd8e0533f2ba4380c94c0a51e2ef0decea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215858Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#772012}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a33a68071b63..934b9996ee4d 2020-05-26 reed@google.com try drawing underline with rect instead of line/path 2020-05-26 csmartdalton@google.com Don't test GPU configs on hittestpath 2020-05-26 johnstiles@google.com Improve doc comments for SkTArray. 2020-05-26 herb@google.com Make callback std::function 2020-05-26 nifong@google.com Wide color gamut support and working example. 2020-05-26 herb@google.com Revert "generate vertex data in onPrepare" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ib3a75f49bc9894b970e63291f18814b7eda23f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772011}
-