- 12 May, 2018 40 commits
-
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: Ife1c1ccc84b3d25f469da93d69bd334145b8f4b8 Reviewed-on: https://chromium-review.googlesource.com/1055370 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558116}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Tbr: fukino Bug: 836254 Change-Id: I7b6553cf460ee330e50b8dc8a4fa666369affeab Reviewed-on: https://chromium-review.googlesource.com/1055036Reviewed-by:
-
sczs authored
- Deletes BookmarkContextBar files and usage from BookmarkHomeVC. - Uses BookmarkHomeVC navigationController UIToolbar instead. - Creates accessibilityIdentifiers for toolbar buttons. - Changes the BookmarkTableCell margins since these were giving the effect of shrinking row height. Screenshots Old: https://drive.google.com/open?id=1v3GQRiiPiIzJNZ7Lxd-pgpaaqP15b0PR New: https://drive.google.com/open?id=1z5mOT3p1NBj62EaMKfR2P5WSD2irQmyX Bug: 839435 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I155365b6f9520010153ce97187ef1f6a2a8514f7 Reviewed-on: https://chromium-review.googlesource.com/1054123 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#558114}
-
David Jacobo authored
Automatically close tabs after the user is authenticated and redirected to an ARC app. ArcWebContentsData can be removed via ArcExternalProtocolDialog as well as in AppsNavigationThrottle, with this we try to reduce the scope of the flag as much as possible while still allowing the user to bypass the UI and automatically close tabs left behind in the process. Bug: 838294 Test: Build, unit_tests still works Change-Id: Ifb812a3fab2fe7f49f07b4fbaee754ac96ea158f Reviewed-on: https://chromium-review.googlesource.com/1026870 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558113}
-
Han Leon authored
Some code pathes aquire a service worker object info but do not send it immediately, the service worker object info holds a SWObjectAssociatedRequest whose corresponding SWObjectAssociatedPtr is held by a SWHandle, but during the period the SWHandle may call StateChanged() on this SWObjectAssociatedPtr, because the SWObjectAssociatedRequest has not been sent over Mojo yet, this will lead to a crash. This CL fixes such scenarios by enabling those code pathes to create/handle the (SWObjectAssociatedPtrInfo,SWObjectAssociatedRequest) pair on their own terms whenever they need to send the object info over Mojo, they will send SWObjectAssociatedRequest over Mojo first and then pass SWObjectAssociatedPtrInfo back to SWHandle to make calls safely there. Details: SWHandle::CreateIncompleteObjectInfo() does not bind the SWObjectAssociatedPtr and just returns an object info without a valid SWObjectAssociatedRequest. Callers will create (SWObjectAssociatedPtrInfo,SWObjectAssociatedRequest) by themselves later at any time when they want to send the object info over Mojo, after the SWObjectAssociatedRequest was sent they can call SWHandle::AddRemoteObjectPtr() to pass the SWObjectAssociatedPtrInfo back to SWHandle. BUG=838397 Change-Id: If2ed45cef1fe2a25bb9760a66a1ecc4c432ad8d3 Reviewed-on: https://chromium-review.googlesource.com/1036498 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558112}
-
https://chromium.googlesource.com/angle/angle.git/+log/422f2ce24c5b..18e323ab2cff $ git log 422f2ce24..18e323ab2 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 jmadill D3D11: Fix out-of-range access with robust access. Created with: roll-dep src/third_party/angle BUG=chromium:842028 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Id5f71c374ee3cd238fc2b2965cc3751184b33279 Reviewed-on: https://chromium-review.googlesource.com/1056489Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558111}
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Re-land. Was reverted on crrev.com/558004. Actual problem was an ASAN flake [1] and every subsequent run of this test was green on the ASAN bots before the revert landed (see image crbug.com/836254#c43). [1] ASAN flake crbug.com/837950 Tbr: slangley, fukino Bug: 836254 Change-Id: I1f1e60ad80130c5f2d7d92131fe21257f4ffa001 Reviewed-on: https://chromium-review.googlesource.com/1056507Reviewed-by:
-
Johannes Henkel authored
This change will make it easier to finish https://chromium-review.googlesource.com/c/chromium/src/+/1035091: - The "other" blocked reason, that is, an unspecified blocked reason, is now the default which we'll assume for the 0 value. - There's a 1:1 correspondence with the enum in browser_protocol.pdl, so we no longer need to conflate kNone and kOther. - The base::nullopt value for base::Optional<...> is more appropriate because in the inspector's protocol it will correspond to the absence of a string value (e.g. in a JSON message), as opposed to the string "none" or "other" (both misleading). Would like to land this first since it's easier to review / test it this way, as opposed to mixing it into a larger PR. Bug: 838291 Change-Id: I66da523495b38a297d22289ae7c32367a66bd6bb Reviewed-on: https://chromium-review.googlesource.com/1056030 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558109}
-
David Tseng authored
When lines in the midst of editing operations are invalid, output the current line rather than attempting to make intra line diffs. type 'abc' within a textarea. Press enter. Verify we do not trigger intra line state machine changes and output 'abc deleted'. Rather, ensure we trigger output of the entire new line 'new line'. Test: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b1252687e1463ca29f237bc4c86a87f0f5bb781 Reviewed-on: https://chromium-review.googlesource.com/1054698 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558108}
-
dpapad authored
The negative margin was used because the buttons did not have a border or background, and wanted to align the end of the button's text with the other items on adjacent lines. Bug: 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d1368c839e5732dd88cbc3bb453846ecb289509 Reviewed-on: https://chromium-review.googlesource.com/1055817 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558107}
-
David Jacobo authored
ArcWebContentsData is used to mark tabs that were generated via ChromeShellDelegate by ARC request. This flag was introduced so we could offer a smoother authentication process, more specifically so the user doesn't have to deal with the intent picker UI nor leave tabs opened in the browser in the process. However since this flag allows the user to exit Chrome's context we need to remove the flag when no longer needed, in case the tab itself survives the authentication process. (e.g. maybe the user didn't complete the login process, or reused this tab to start a new query via the omnibox) In this CL we propose a way to get rid of such flag as soon as the user: - crosses the same origin boundary (this boils down to changing either the domain, port or scheme). - press the forward/back button. - types a url directly in the omnibox. TBR=sky@chromium.org Bug: 838288 Test: Build Change-Id: I7ba30d7874d5384d8ce4e3a9317d827198c23acd Reviewed-on: https://chromium-review.googlesource.com/1034027 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#558106}
-
Lei Zhang authored
Change-Id: Id883d962d14233db330a28d972c500fc8a502c06 Reviewed-on: https://chromium-review.googlesource.com/1056317Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558105}
-
Jeremy Roman authored
Bug: 841751 Change-Id: I965b442ef21d0f199574d8d4ff04fc03af7158b9 Reviewed-on: https://chromium-review.googlesource.com/1054248Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558104}
-
xlai authored
Over code changes, the comment has been shifted to wrong places. Bug: 651456 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5b9cbe92d55a68bdd9547a000398d53fc58c3958 Reviewed-on: https://chromium-review.googlesource.com/1055892Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558103}
-
Xiaohan Wang authored
Change-Id: Idda24d4e408e257fe1da332e7869b0b708f80a7f Reviewed-on: https://chromium-review.googlesource.com/1056209 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558102}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I8edc2fffd92bf1fa4ec493ea760bab8fe5fe94ce Reviewed-on: https://chromium-review.googlesource.com/1056113Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558101}
-
Leszek Swirski authored
Add a null check for document.GetScriptableDocumentParser() when getting an inline cache handler. Bug: chromium:841651 Change-Id: Ie34c23a49c5725766ddf75e5667eb1b2dc7c0baf Reviewed-on: https://chromium-review.googlesource.com/1052698 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#558100}
-
Dmitry Gozman authored
This patch updates the readme to align with recent conversations about what platform/, core/ and modules/ are and what they should be. Change-Id: I2f4f0b50711cc2cd3cd455ad78c2fc5c96f53e1e Reviewed-on: https://chromium-review.googlesource.com/1054190 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#558099}
-
Esmael El-Moslimany authored
Bug: 842002 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id343156de4540c33d1db130c9260e9b3fc861ddc Reviewed-on: https://chromium-review.googlesource.com/1055818Reviewed-by:
-
Joel Einbinder authored
This should make the suggest box obscure eager eval less often. Change-Id: I60573ed142947daa005f648c13d1c3a32f8d492b Reviewed-on: https://chromium-review.googlesource.com/1048025 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
Nick Harper authored
Change-Id: Iabe9977651ec3e38f43d2495e790af508a43e0e5 Reviewed-on: https://chromium-review.googlesource.com/1055676 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558096}
-
Scott Violet authored
Aura-mus now only targets kMash. This means any conditional logic based on kMash can be removed (the true branch is all that is needed now). BUG=842365 TEST=none Change-Id: I01e444a3e04a3bf02123005ec793d112520aad00 Reviewed-on: https://chromium-review.googlesource.com/1055933Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#558095}
-
Ryan Hamilton authored
Update QUIC flags. https://chromium-review.googlesource.com/c/chromium/src/+/1055888 QUIC will use the deframer from third_party/http2 instead of third_party/quic/http. Protected by FLAGS_quic_reloadable_flag_quic_enable_h2_deframer Merge internal change: 195542213 https://chromium-review.googlesource.com/c/chromium/src/+/1055866 Deprecate FLAGS_quic_reloadable_flag_quic_reset_stream_is_not_zombie. Merge internal change: 195434554 https://chromium-review.googlesource.com/c/chromium/src/+/1055863 Deprecate FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data_acked Merge internal change: 195434484 https://chromium-review.googlesource.com/c/chromium/src/+/1055862 Deprecate FLAGS_quic_reloadable_flag_quic_free_mem_slice_out_of_order. Merge internal change: 195420377 https://chromium-review.googlesource.com/c/chromium/src/+/1055861 Only slow down the QUIC pacing rate to 1.5 * MaxBW in STARTUP if there is at least one non app-limited sample. Protected by FLAGS_quic_reloadable_flag_quic_bbr_slower_startup2. Merge internal change: 195416663 https://chromium-review.googlesource.com/c/chromium/src/+/1055858 Change-Id: Ia8de82366f55bdc61f8ef93b5331769eb9d772c9 Reviewed-on: https://chromium-review.googlesource.com/1055868Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558094}
-
David Valleau authored
Previously, when a user provided an invalid PPD file the 'SAVE' button in the edit printer dialog would be disabled. This would prevent users from editing other fields in the dialog and saving the changes unless the closed the dialog and reopened it again. Since there is already an error message surfaced to the user indicating that the PPD they provided is invalid, it should be okay to leave the button enabled. BUG=chromium:830527 R=skau@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iec26a0c9473ce920f3337521ecaebfb8a2ffe5fe Reviewed-on: https://chromium-review.googlesource.com/1028005Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#558093}
-
https://chromium.googlesource.com/angle/angle.git/+log/586620825ed1..422f2ce24c5b $ git log 586620825..422f2ce24 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 geofflang GL: Refactor ShaderGL to not hold renderer objects. 2018-05-11 geofflang Request EGL_DONT_CARE version instead of 0 on GL NULL configs. 2018-04-23 lfy GLES1: Renderer (minimal) 2018-05-09 ynovikov Update dEQP GLES2 expectations for Android Vulkan backend 2018-05-04 lucferron Vulkan: Incomplete textures support Created with: roll-dep src/third_party/angle BUG=chromium:839893 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ia034b1c82429d878831a8292a9f18c6faeadb61d Reviewed-on: https://chromium-review.googlesource.com/1056191Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/103d6f616b40..3202ac4d24de $ git log 103d6f616..3202ac4d2 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 reed Revert "Revert "reject large paths to avoid potential float overflows"" 2018-05-11 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 0641aebe3..5fd1cfaae (1 commit) 2018-05-11 bungeman Don't limit glyph mask format for path effect. 2018-05-11 angle-skia-autoroll Roll third_party/externals/angle2/ 8073a9511..a69099212 (5 commits) 2018-05-11 ethannicholas fixed incorrect index in SPIR-V matrix construction 2018-05-11 bsalomon Include SkUnPremultiply.h in GrContext.h to fix Android compile 2018-05-09 halcanary SkPDF: scale entire canvas for non-standard rasterDpi 2018-05-11 bungeman Roll clang for Windows to chromium's current. 2018-05-11 reed Revert "reject large paths to avoid potential float overflows" 2018-05-10 bungeman Avoid possible memory leak with inner blurs. 2018-05-11 reed reject large paths to avoid potential float overflows Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Ief63361159090b250e2af7ed87951ab8dcf4bc9b Reviewed-on: https://chromium-review.googlesource.com/1056196Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558091}
-
Stephan Stross authored
It is necessary to change the target type of net_perftests because certain build artifacts for fuchsia are only generated for test targets (such as runner scripts) and they are needed for crrev.com/c/1031294 Change-Id: Ibd6b88fc1d4098b61a8e91cbdca66613383c2c79 Bug: 841072, 594965 Reviewed-on: https://chromium-review.googlesource.com/1050888 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#558090}
-
Ryan Sleevi authored
While at it, also rename the method to ArrayToCustomEnumRanges and close out an old TODO. TBR=hubbe@chromium.org, kbr@chromium.org BUG=837308 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I56464a852707550dd625a1da30186aaaa9fdef38 Reviewed-on: https://chromium-review.googlesource.com/1055947 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558089}
-
Jiaquan He authored
This commit: - fixes missing logic of clicking search result context menu; - moves search results into SearchController. Bug: 733662 Change-Id: Ia9b2c142c6bbaf20e4772661ddebbe156d8e139d Reviewed-on: https://chromium-review.googlesource.com/1051528 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558088}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7657336de212..348b95b14ab7 $ git log 7657336de..348b95b14 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 gmeinke reverse dependencies temp file include board name Created with: roll-dep src/third_party/chromite BUG=chromium:842247 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1189b9f8600563f262dc0ed88bb666cecc97b966 Reviewed-on: https://chromium-review.googlesource.com/1056090Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558087}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for Cast. By clicking on the button, it will show Cast detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling The button is shown only when the device is available and no cast is actually running. The feature when cast is running will be implemented as a notification. TEST=SystemTrayTrayCastMediaRouterChromeOSTest BUG=821671 Change-Id: If411617e2ea0f1f1ac39aa207308e07b330f3b19 Reviewed-on: https://chromium-review.googlesource.com/1051550 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#558086}
-
Eugene Ostroukhov authored
1. Focus the prompt when the view is focused. 2. Do not hide the query while waiting for the results. 3. Show query in history if it does not produce results (e.g. DELETE ... FROM) Bug: 798785 Change-Id: I7cc86301256e0370f03282e044bb59fef0a26dbe Reviewed-on: https://chromium-review.googlesource.com/1056072Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558085}
-
Tom Anderson authored
On Android, cxa_demangle_stub.cc provides __cxa_demangle. We use this to prevent pulling in libc++abi's large demangler. However, regular c++ code expects __cxa_demangle to be available simply by linking against a c++ standard library. Therefore, we move the stub into libc++abi so other targets don't need to explicitly specify cxa_demangle_stub.cc as a dependency. This CL also includes a buildtools roll which includes 4 revisions: https://chromium.googlesource.com/chromium/buildtools/+log/0b71401b977fba99eb0c7bb01bdb3338f45bd911..a9e946f166b73f9dc170129f6586a1e68efb0ab3 BUG=767901 R=thakis Change-Id: I627833b1379ba938c07b3ab6645a775220a7aeb0 Reviewed-on: https://chromium-review.googlesource.com/1054198 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558084}
-
Devlin Cronin authored
Refactor PermissionsData::PolicyDelegate::CanExecuteScriptOnPage to no longer rely on being passed an extension. Instead, rename it to IsRestrictedUrl(), and call it from the method of the same name in PermissionsData. PermissionsData::IsRestrictedUrl() already checks if the extension can execute script everywhere, so the check is no longer necessary in the policy delegate. Additionally, this is ensures that places checking if an url is restricted also check with the delegate. Bug: 842270 Change-Id: Ica4c086d1315f9512cc908542841bf8dee2bedee Reviewed-on: https://chromium-review.googlesource.com/1055930Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558083}
-
Khushal authored
Also remove default ctors for Serialize and DeserializeOptions. Makes it easier to ensure everything is plumbed through. TBR=ericrk@chromium.org R=enne@chromium.org Bug: 839275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia1dede6c7b87b77613dd778f67595fb7b5a8edab Reviewed-on: https://chromium-review.googlesource.com/1049052 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558082}
-
Nick Harper authored
Previously, disabling this feature lead to crashes in various parts of Chrome because the URLRequestContext provided a null ChannelIDService. See crbug.com/841685 and crbug.com/841730 for the bugs from trying to land this as crrev.com/c/1041139 and crrev.com/c/1050976. In crrev.com/c/1055678, URLRequestContext will continue to have a ChannelIDService; features::kChannelID now only controls whether the net stack sends Channel ID on a connection. This should avoid the issues previously experienced when landing this change. Change-Id: Ib983249781b62d331bb065f7ee4a907928d9441f Reviewed-on: https://chromium-review.googlesource.com/1055865Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65c09667..e8221d09 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I01349561c3b14fb57284600451fca299ccac4251 Reviewed-on: https://chromium-review.googlesource.com/1056110Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558080}
-
Devlin Cronin authored
Change the default behavior of the kRuntimeHostPermissions feature to allow extensions to have origin access, rather than defaulting to withholding permission. In the first stage of click-to-script, we don't want to change any defaults. Bug: 841099 Change-Id: Ibdcbfb0fd9ecc535af73a1bd9048e196eab135e1 Reviewed-on: https://chromium-review.googlesource.com/1052684 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Gang Wu authored
Bug:807364 Change-Id: I9890811bc55169435d14b5b5c35e6014c2bbaa99 Reviewed-on: https://chromium-review.googlesource.com/1047505 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#558078}
-
James West authored
Allow individual Cast web applications to set command-line switches for the render process. Bug: internal b/67735190 Bug: internal b/77323820 Test: cast_shell_browsertests, cast_shell_unittests Change-Id: I2fdeca54e9f4a46f6299c58482e9934ebffe8b69 Reviewed-on: https://chromium-review.googlesource.com/1018205 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558077}
-
