GitLab

Review URL: https://chromiumcodereview.appspot.com/10843068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140357

Review URL: https://chromiumcodereview.appspot.com/10837084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150365 0039d316-1c4b-4281-b951-d872f2087c98

MainMenu.xib changes: Add submenu "Speech" with items "Start Speaking" and
"Stop Speaking" to the Edit menu (with localized ids for names).

This is a followup to http://crrev.com/126602, which implemented speech
support in the context menu. This changes also updates the context menu
implementation to go through the new one in the render view.

Also fixes some warnings found by 'gcl lint'.

BUG=31107, 46153
TEST=Select some text on a web page and go to Edit -> Speech -> Start Speaking. The
selected text should be spoken. While some text is being spoken, go to Edit -> Speech
-> Stop Speaking. The speech should stop. When no text is being spoken, Edit -> Speech
-> Stop Speaking should be disabled. Try the same steps as above but with selected
text in the omnibox. It should also work.

Review URL: https://chromiumcodereview.appspot.com/10820062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150364 0039d316-1c4b-4281-b951-d872f2087c98

When running Chrome in RTL mode, the new tab button is mirrored, but the theme background shouldn't be.

Bug=None
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/10808051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150363 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/10739002/.

R=ygorshenin@chromium.org
BUG=136797
TEST=no compilation errors

Review URL: https://chromiumcodereview.appspot.com/10783029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141132

Review URL: https://chromiumcodereview.appspot.com/10830199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150361 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/10834183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150360 0039d316-1c4b-4281-b951-d872f2087c98

1. Move the code that checks whether FCM and/or ThreadedCompositing is enabled to a separate file (compositor_utils) that can be accessed from all the spots that need the info.
2. Cache results results for checks so that we don't have to check them every frame (string compares were actually showing up in profile results)
3. Some cosmetic changes to variable names to keep them consistent.
4. Re-arranged to code that decides what trials run in which channels.

This CL also enables FCM on beta/stable by default but keeps the previous 1/3 experiment running on the other channels.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10824168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150359 0039d316-1c4b-4281-b951-d872f2087c98

... so that we don't have to disturb chrome/OWNERS for translate changes.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10829208

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150358 0039d316-1c4b-4281-b951-d872f2087c98

The mac_build.gypi is used to build Mac targets via ninja. The template runs gyp_chromium to generate a ninja project file, then gyp target that includes the template should include an action to run ninja for the desired targets.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10826169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150357 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10834206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150356 0039d316-1c4b-4281-b951-d872f2087c98

Currently third_party/zlib/zlib.gyp uses the system libz if:
  os_posix == 1 and OS != "mac" and OS != "ios" and OS != "openbsd"

I'm assuming that Android sets os_posix==1 and therefore this change is
a no-op. But it consolidates control of this variable in a single
location.

BUG=none

https://chromiumcodereview.appspot.com/10837100/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150355 0039d316-1c4b-4281-b951-d872f2087c98

Fixes missing 5 pixel inset for inactive tab theme background and theme background for new tab button in Ash.
The theme background is correctly inset by 5 pixels. In frame_painter.cc
Added GetThemeBackgroundXInset such that the x inset can be queried.

BUG=137090

TEST=Inactive tab theme background lines up for "Kate Spades", "Quilt", and "Wooded Chrome Theme by Everplex" with  theme background for toolbar.

In particular, "Wooded Chrome Theme By Everplex" should behave the same way it does on Mac and Windows. So, the theme should NOT line up with the NTP image.

Review URL: https://chromiumcodereview.appspot.com/10816004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=


Review URL: https://chromiumcodereview.appspot.com/10827017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150353 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150352 0039d316-1c4b-4281-b951-d872f2087c98

The revert actually didn't solve the problem.

BUG=None
TBR=alexeypa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150351 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140037

Review URL: https://chromiumcodereview.appspot.com/10828154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150350 0039d316-1c4b-4281-b951-d872f2087c98

tightly coupled with, and only used by, the autofill feature.  The
only other usage is from TabContents, which initializes and owns an
instance and provides an accessor, but we should be able to remove
this soon.

TBR=ben@chromium.org
BUG=140037

Review URL: https://chromiumcodereview.appspot.com/10843067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138014

Review URL: https://chromiumcodereview.appspot.com/10825222

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150348 0039d316-1c4b-4281-b951-d872f2087c98

This file needs to be added separately from the original CL since CQ does not handle new binaries.

R=jhawkins@chromium.org
BUG=140357

Review URL: https://chromiumcodereview.appspot.com/10855025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150347 0039d316-1c4b-4281-b951-d872f2087c98

bookmark_index_unittest.cc:
Summary: Function parameter 'expected_titles' should be passed by reference.
Message: Parameter 'expected_titles' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++.

bookmark_model_unittest.cc:
Summary: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor.
Message: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor.

R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150346 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=builds,manual

With this change, the IPC-based PPAPI proxy builds and runs the tumbler example.
Review URL: https://chromiumcodereview.appspot.com/10796038

TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150345 0039d316-1c4b-4281-b951-d872f2087c98

The API returns 503 errors if we try to download photos too
quickly.  This change adds cheesy rate-limiting so we don't
request more than 10 photos per second (which appears to be
the undocumented limit) and also makes us retry when we get
a 503.

I'm also making GDataContactsService report success even
when we got 404 errors for some photos, as I see this happen
with my personal account. :-/

BUG=128805
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10823182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=builds,manual

With this change, the IPC-based PPAPI proxy builds and runs the tumbler example.
Review URL: https://chromiumcodereview.appspot.com/10796038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138955


Review URL: https://chromiumcodereview.appspot.com/10832080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10836127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=gab@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10827174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150340 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134600
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10700079


Review URL: https://chromiumcodereview.appspot.com/10832177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150339 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150338 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150337 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the unnecessary RemoteDebuggingcontroller java class and associated
c++ code. Also devtools_server.* is moved from content/ to chrome/ so that the
code to access profiles, version etc. can be handled here to make DevToolsServer
a self contained class in chrome/ layer handling devtools for android. The code
making use of this class is not yet ready to be upstreamed due to dependencies
and will land in future.

Also added shell_devtools_delegate_android.cc to enable devtools for content_shell
on android. This class and chrome/browser/android/devtools_server.cc need a
common place to put the IsUserAllowedToConnect method that ensures only adb is
allowed to access devtools on android (via the abstract unix socket, for security
purposes) hence that method is placed in DevToolsHttpHandler in content/

BUG=136682,136318
TEST=manual. Run android content shell, execute "adb forward tcp:9222 localabstract:content_shell_devtools_remote" and open "localhost:9222" on the host machine to use devtools.

Review URL: https://chromiumcodereview.appspot.com/10832112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150336 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10823186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150335 0039d316-1c4b-4281-b951-d872f2087c98

Turns out that reverting the change breaks Win clobbers since the
remoting stuff meanwhile depends on the gyp roll.

BUG=chromium:140324
TBR=alexeypa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150334 0039d316-1c4b-4281-b951-d872f2087c98

The current situation of boolean policy switches either enabling or
disabling something is pretty arbitrary (although tending to be the
inverse of the browser default). It's much easier to reason about
XYZEnabled-style settings, so we prefer those going forward.

BUG=chromium:85687
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10829197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150333 0039d316-1c4b-4281-b951-d872f2087c98

Disable the Website Settings UI on Windows by default. It can be enabled by using the flag --enable-website-settings


BUG=141062

Review URL: https://chromiumcodereview.appspot.com/10834134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150332 0039d316-1c4b-4281-b951-d872f2087c98

Causes compile failures on the official builders.

BUG=None
TBR=glider@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140877


Review URL: https://chromiumcodereview.appspot.com/10827196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150330 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150329 0039d316-1c4b-4281-b951-d872f2087c98

These paths either no longer exist on any platform, or don't cause license
errors.

BUG=138921


Review URL: https://chromiumcodereview.appspot.com/10843069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150328 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dimich@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150327 0039d316-1c4b-4281-b951-d872f2087c98