- 27 Jul, 2020 40 commits
-
-
Jit Yao Yap authored
This CL implements the RemoteApps PublisherBase and RemoteAppsManager which are used to manage Remote Apps. Remote Apps are items which are added to the launcher but are not backed by an app/extension/web app. Instead, the item is managed by an extension via an API. The extension is able to add multiple items and folders to the launcher and observe when the items are launched. The extension can then decide on how to handle the launch event. Currently RemoteApps are only available to Managed Guest Sessions. RemoteAppsManager is the KeyedService which handles the adding and deleting of Remote Apps and folders. RemoteAppsManager also implements RemoteApps::Delegate and is used by RemoteApps to handle the LaunchApp(), GetIcon() and GetMenuModel() methods. RemoteAppsManager is not initialized as a KeyedService so this CL does not change any existing behavior. Bug: 1101208 Change-Id: I664469fa0284c6e65288e59ba7a5d1271b081a04 DD: go/cros-remote-apps Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299226 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791788}
-
Jan Wilken Dörrie authored
This change adds support for multiple projections to util::ranges by improving the capabilities of the ProjectedBinaryPredicate. The resulting object will now consider several permutations of the provided projections, and choose an appropriate one. This change required the introduction of a few internal helpers. Bug: 1071094 Change-Id: I46b05e1e0ddf0b15b0ed1518fb6de263bb23b8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310533 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#791787}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5505fa8a8ca..cec3e4fd4e86 2020-07-27 janscheffler@chromium.org Migrate `front_end/worker_service` to `devtools_entrypoint` 2020-07-27 mathias@chromium.org Revert "De-obfuscate X-Client-Data header values in Network tab" 2020-07-27 jacktfranklin@chromium.org Component bridges: Support nested interfaces/types in unions 2020-07-27 janscheffler@chromium.org Migrate `front_end/workspace_diff` to `devtools_entrypoint` 2020-07-27 jacktfranklin@chromium.org Add support for `type X =` to component bridges 2020-07-27 jacktfranklin@chromium.org Add support for type aliases to component bridges generation 2020-07-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1103854 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I47ba1c85d97520bae3dcd7957ec13695ca1dcd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320045Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791786}
-
Gauthier Ambard authored
When the page is preloaded, a session restoration is done. But the "visible" page isn't loaded as it would in a normal session restoration. This CL makes sure that this page gets the correct UA. Bug: 1100852 Change-Id: Ia666dd17e512c8d9c7e84e750722dae90f56ca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279757 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#791785}
-
Roman Sorokin authored
TBR=afakhry@chromium.org Bug: 1106036 Change-Id: I03a33991b8956ea702ef85fd6b5e3f481c2e9096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320166Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791784}
-
Mario Sanchez Prada authored
This CL moves this message out of view_messages.h and adds a new method in blink::mojom::RemoteMainFrameHost to allow notifying a renderer, via the browser process, that the window of its main frame needs to be closed when the request got originated in a different process. For requests originated in the same renderer process than the one hosting the main frame whose window needs to be closed, this CL simply delegates on WebWidgetClient::CloseWidgetSoon(). Last, this CL adds a new helper FakeRemoteMainFrameHost helper class to allow migrating one WebFrameTest that was currently relying on the WebViewClient::CloseWindowSoon() method, which no longer exists, to test that a remote window has been correctly instructed to close. Bug: 1102449 Change-Id: Iaefc432a71bba50be0e00e9e1c98170d2759c529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309704Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#791783}
-
Marc Treib authored
When PasswordModelTypeController was updated to support the account-scoped password storage, a condition was added to its GetPreconditionState() method to make sure Password Sync only runs if either Sync-the-feature is enabled, or the user has opted in to the account-scoped storage. However, for the case of local Sync, Sync-the-feature is *not* considered enabled (and of course no account-storage-opt-in exists). So this broke local Sync for Passwords. Bug: 1108609 Change-Id: I2bb2edb7247d3b2e95dba306718488352329840b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316214 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791782}
-
Maksim Sisov authored
Removes unnecessary case for surface handle (non-Ozone X11 and Ozone has the same type of AcceleratedWidget now), chooses correct path based on OzonePlatform feature usage. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I3f82aa08d02e8daa58ab39831b67ddb91d25913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315026Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791781}
-
Roman Sorokin authored
Flaky on Windows. TBR=minggang.wang@intel.com Bug: 1104847 Change-Id: Idbed763741b2fdf2fe3e8697b2465633bf14f007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317884Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/374acd70..f23e4df5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id8ca62422f4797c66cb734a627a75453889a91f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320107Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791779}
-
Nohemi Fernandez authored
It was difficult to understand the current constraint layout of the "Turn on Sync" page due to the inconsistencies in the view manipulation. This patch attempts to make the layout and styling of the views and buttons more straightforward. Bug: 1105853 Change-Id: I0c0bca5aa1be5200d3be414804976efc8ed7ef22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312556 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791778}
-
Olesia Marukhno authored
Bug: 1104264 Change-Id: I535e5a6abdcc17726d0e55fd4d405b2cce08c7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292526 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#791777}
-
Alexey Baskakov authored
We still need it: the title can be empty in some scenarios. Looks like we need to generate some icon based on url to show this icon for a user in web app install dialog, where user should enter a non-empty title. 1) WebAppInstallTask::OnIconsRetrievedShowDialog() 2) FilterAndResizeIconsGenerateMissing() 3) Show dialog with the generated icon, `title` is still empty here. This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2312056 The title populating code is left there in unit tests. Bug: 1109540, 1103570 Change-Id: Ia281397d3483ad08d02ae4a9f0e2ca60bd34e859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319493Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#791776}
-
Roman Sorokin authored
Due to flakiness TBR=stkhapugin@chromium.org Bug: 1107877 Change-Id: I134760ea3b31c9e5e93319e3180a760de4c15c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317882Reviewed-by:
-
Marc Treib authored
Bug: 1079297 Change-Id: I071760c7bae8a6648b1c6d7f6047702af56f7002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316199 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#791774}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/befe11cae7c1..ec788be8b577 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from df5ed61ddbca to 3f851efa2adc (5 revisions) 2020-07-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6a8a74986c35 to 3b2cd31c7400 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Test: Test: Test: KHR-GLES31.core.shader_storage_buffer_object.basic-syntaxSSOTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-bindingUpdateTest: Test: KHR-GLES31.core.vertex_attrib_binding.advanced-largeStrideAndOffsetsNewAndLegacyAPITest: Test: Manual script execution and building in AOSP Change-Id: Ibbaaa2cf381fc4a4792d4b500510eee5e313998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319971Reviewed-by:
-
Maksim Sisov authored
Disables/enables tests for Ozone/Linux or non-Ozone/X11 ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I48797083cecf61929e10381d740590fc4584137d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315027 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791772}
-
Andrey Zaytsev authored
The 10 minute timeout logic follows: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit?ts=5ef0c30f#slide=id.g8a1bab3ac0_6_125 Bug: 1070620 Change-Id: I876c0b2981321d278747ad3eaaca09890a80cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317228 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#791771}
-
David Jean authored
Bug: 1109663 Change-Id: I6e61cb1d71e654ff359bf9a1d429719a2a920ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317877 Commit-Queue: David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#791770}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/browsing_data. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=dullweber@chromium.org Bug: 1106699 Change-Id: Idea748f489836737cfd60e5e8c4ad98662103680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315354 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#791769}
-
arthursonzogni authored
There are 4 tests with the reporting installed in the opener window. The expectation was wrong, because we expected the url to be the openee URL. Bug: chromium:1090273 Change-Id: I7b217d7548c8f5a2d41e5f879d11447c4a25f5fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317211 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791768}
-
Andrey Zaytsev authored
Tested manually, including updates by hardcoding the Chrome app id values. Bug: 1070620, 1107387 Change-Id: I0631df830ff20c000c57235eab1dbd300645db24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307330 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Wei Lee authored
This CL abstracts the file system entry so that we can have two kinds of implementation: 1. Implementation which is used by chrome.filesystem and File and Directories API 2. Implementation which is used by NativeFileSystem API Bug: 980846 Test: Check CCA works normally as a Chrome app Change-Id: I87d1c121951152e0975f10d8b43787f6a279f186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237545 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#791766}
-
Daniil Lunev authored
Adds the purpose of the device Corresponds to the following platform CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2241226 BUG=b:151176984 TEST=unittest Change-Id: I55dc88271c3c90cf4bf85db3d0b9c7fe4f641e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298759 Commit-Queue: Daniil Lunev <dlunev@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#791765}
-
Yuki Shiino authored
Improves the progress print so that the intention will be a little clearer; when the bindings code generation finishes, leave the last message on the console. When https://crrev.com/c/2081633 will land, the bindings code generation will be very long (a few minutes). It could make Chromium developers wonder if a build completely stops. Hope that printing the progress would prevent such a concern. Bug: 839389, 1108111 Change-Id: If556010d2d3469c5e0ded6d9b96fa6a5ffc26764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313816Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791764}
-
Antonio Sartori authored
This CL implements the check of whether a string is a valid 'csp' attribute according to https://w3c.github.io/webappsec-cspee/#iframe-csp-valid-attribute-value in the network CSP parser. The check is still incomplete, since it relies on the Subsume algorithm that will be implemented in future CLs. This function will be used by the AncestorThrottle. Bug: 1094909 Change-Id: Id325b203ba4269e542fd7b9b144da55c3e4e52d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315683 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791763}
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of frame.h by 6.61MB. - frame.h should use user_activation_notification_type.mojom-blink-forward.h instead of frame.mojom-blink.h. - user_activation_state.h, which is included from frame.h, should use user_activation_notification_type.mojom-forward.h instead of user_activation_notification_type.mojom-shared.h. This CL has no behavior changes. Bug: 242216 Change-Id: Iae968c3a820a3d327ff46bf017dbd72dc77c3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319496Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#791762}
-
Adrienne Walker authored
It is too fiddly to try to estimate the sizes of idb keys and values and try to hope that they are the same size that mojo will use when serializing. However, even if getAll is not recommended, it is not spec complaint to throw an error when getAll is trying to return too much data. By chunking the results from getAll across multiple mojo messages, we can always have getAll succeed for any size and not have to try to explain this edge case to users or try to guess how big sizes are. Bug: 1103849 Change-Id: Ic187b0bbfaefda15e9a50a845ba9bcf34f111faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305003 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#791761}
-
David Jean authored
Bug: 1109644 Change-Id: Idc8fa6d46d7b147d1c5704546a66b812ee85900c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317953 Commit-Queue: David Jean <djean@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
-
Ewann authored
This Cl makes the bottom toolbar visible when initiating a drag down to close a modal setting view. Bug: 1106665 Change-Id: I2011d4e8f07c197c7c876bfc1dbbc40226d25f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308713 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Jonathan Mengedoht authored
Add lookup logic for ChangePasswordUrlService, implement Callback for the gstatic fetch and test the url lookup logic. Bug: 1086141 Change-Id: I6992cc891d2e43f9e0091f82c53b624f8f277ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285125 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#791758}
-
Roman Sorokin authored
Flaky test TBR=apotapchuk@chromium.org Bug: 1109651 Change-Id: I751e66813be2200ada35d9c600c4b03b40822b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317955 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Monica Basta authored
The profile color will be used by different screens (Sign in promo, local profile customization, may be sync promo) that belong to the profile creation flow. This CL provides the pipeline to request the new profile color from native and passing it to the sign in promo component. A smarter profile color picking will be implemented in the future. Bug: 1063856 Change-Id: I7f066656897ff1da6292414bba53e34613368dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310671 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791756}
-
Ewann authored
based on: https://crrev.com/c/2300383 This CL updates the link label used to display the TOS string to an UITextView. A sublcass is needed to override the |canBecomeFirstResponder| method. On iOS 13,we can't override |canBecomeFirstResponder| or the whole string will responds to a tap. On iOS 12, the whole string responds to a tap if we use this current implementation. Bug: 1102996 Change-Id: Id9c9e3089d07a056c365043e1d60b1b558586ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302900 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#791755}
-
Friedrich Horschig authored
Instead of using the factory directly in the fragment, the parent activity will now check whether the newly attached fragment has a known component and creates it using the factory. The functionality and visible behavior is unchanged. Bug: 1101256, 1092444 Change-Id: If430d33d9c895eeed1503253ff5a279cfeae394c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315149 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Theodore Olsauskas-Warren authored
Bug: 1105386 Change-Id: I90e63a857b9f2fb3f4be7ea339fd168f71125a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317226Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#791753}
-
Rainhard Findling authored
* This CL aligns the Chrome cleaner child element behavior in the 'safe' states with the latest mocks. Bug: 1087263 Change-Id: Ie4c36cf6d45c80f421b191758aeadadab8d04280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282401Reviewed-by:
-
Hirokazu Honda authored
GpumemoryBuffer based VideoFrames are input to VideoEncodeAccelerator in ARC++ and also Zero-Copy case. This adds a test case where the input VideoFrames is GpuMemoryBuffer based one and its pixel format is NV12. Note that our product code strongly assumes the pixel format is NV12 in Zero-Copy path. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: Ifb894b39c40a2229209c3dd5884a16d7b033e428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260133 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#791751}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib6c3a73c6edec1a92d0b7d7c71fe4aba3bb8d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319973Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0b2923dc9d6..f4f0170b8694 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: I2697459f26ffe030be08da4f206d27515d49b496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319970Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791749}
-
