- 12 Nov, 2020 29 commits
-
-
Ben Joyce authored
Don't need third party review as source is source from already added android_x libraries with same license. https://chromium.googlesource.com/chromium/src/+/master/third_party/android_deps/README.md "This is not necessary if you are only upgrading existing package s or adding packages from the same source and license (e.g. gms)" "Adding for AnimatorTestRule which would basically time increment like CompositorAnimator." Bug: 1147198 Change-Id: If9dcea302dcd49c823e55a784e0c0bb34365c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528122Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#826578}
-
Nina Satragno authored
Remove some code that was unused. Replace the single use of one of these classes by a hardcoded vector instead. Fixed: 1148047 Change-Id: I33d5ada65570f5802b6a7c6edae7bfc23ac52912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533420Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#826577}
-
danakj authored
We assumed that giving an image to decode would result in an N32 pixel format reply, but it seems not. So convert to N32 on receipt of the reply from the renderer. R=rsesek@chromium.org Bug: 1148012, 1144462 Change-Id: I7ae2924f6450cb4d0261d6780861f85bf5ed15a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533519Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826576}
-
spdonghao authored
Add a Start surface check for ChromeTabbedActivity#prepareToShowStartPagePreNative. Bug: 1139055, 1140406 Change-Id: I351359fde6af17af4f9fbac05ea50f8a8bdd774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528623Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#826575}
-
Kent Tamura authored
* Add MainThreadScrollingReasonsTest::GetScrollableArea() and RootScrollerTest::GetScrollableArea() to reduce the number of casts to LayoutBoxModelObject. This CL has no behavior changes. Bug: 891908 Change-Id: I10d52bff1b228d54f67b7585b0e6c8ff3ba7a51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531800 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826574}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7dc6f19b6fa2d8bce6b6fffd1d411d74ec0f08f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533797Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826573}
-
Tom Anderson authored
This is a reland of 2ed82a41 Original change's description: > Set Xlib error handler after GTK X11 initialization > > The default GTK error handler exits the process, which we don't want. > We used to reset the error handler at some point after GTK > initialization, but this became lost after r815319. > > Also refactor the XlibLoader instance to be global so it doesn't have > to be created multiple times for each connection. > > R=sky > > Bug: 1145929 > Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825585} Bug: 1145929 Change-Id: Ib65f3add91181b3bf82dd71f7b9b87a9a681a53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533199 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#826572}
-
Jesse Schettler authored
Sort the resolutions in descending order and correctly select the default option. Bug: 1059779 Change-Id: If971e961b8174aec7d538cd21ca5ef0eada0f2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533395Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826571}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bdea@chromium.org Bug: 1145565 Change-Id: I852404bcc8df54aaa7273fd69ec47b80b0b44235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533155 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#826570}
-
David Black authored
The holding space model may already be attached when the holding space tray is creating, such as if the user connects an external monitor after login. When this occurs, we need to make sure to handle the already attached model. Bug: 1148044, 1147261 Change-Id: I842555a7cc27fd5e0bcd256179c202298baf8e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533291 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826569}
-
Akihiro Ota authored
This change immediately shows a lesson if it is the only one in its curriculum. For example, if I'm on the main menu of the tutorial and choose 'Resources' (which only has one lesson), then we should show the lesson instead of the 'All lessons' page. This change also adds a test to confirm behavior and visibility of relevant buttons. This change is motivated by UXR feedback. Fixed: 1142051 AX-Relnotes: N/A Change-Id: Ie074a9e8597d4143edc9bee08ee1b6c03a15360d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527346 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826568}
-
Scott Little authored
The enum value 19 corresponds to INITIATION_STATUS_SHOW_UI_PREDEFINED_TARGET_LANGUAGE in the code, but before this CL it was incorrectly labelled as "Aborted by CLD and HTML/content language conflict". This CL fixes this label. Change-Id: I05751f98b35760005339eb2115c8a78544300837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532020 Commit-Queue: Scott Little <sclittle@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826567}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1145565 Change-Id: Id8d8c10f96b678c33a07d9526a3dc495db69f356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532721 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#826566}
-
Emily Stark authored
This CL fixes a bug where the delayed warnings Safety Tip feature caused non-blocklisted lookalike sites to show "Suspicious site" Safety Tips instead of "Did you mean..." Safety Tips. This was due to passing |web_contents| as the |has_delayed_warning| parameter to GetReputationStatusWithEngagedSites. As a follow-up, it would be good to parameterize all the Safety Tips tests to run with the delayed warnings Safety Tips feature enabled, but I'm not doing that now because lookalike Safety Tips tests are currently disabled due to flakiness. Bug: 1146471 Change-Id: I369cf4570cade19ab81a921299025b755b0cc6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531119Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be42c94ff748..3390f9e7fe5d 2020-11-11 jalyn@microsoft.com Settings: Improve display of keyboard shortcuts 2020-11-11 jalyn@microsoft.com Settings: Display category of conflicting shortcuts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idce1ffdd59b976c8aabe397319ac5f1155398203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533796Reviewed-by:
-
Tim Judkins authored
This CL changes over the json schema to use the new returns_async format to define callbacks, enabling promise support on those APIs. Note: browserAction.setIcon and browserAction.openPopus do not yet support promises. setIcon uses a custom hook and openPopup uses a custom callback, which will have promise support added at a later time. Bug: 328932 Change-Id: Ie51b28bfe18f3bf5e427a59a1e5e2d04ee5116f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515139Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#826563}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/7b6396aaef5b..d3ffc411d154 2020-11-11 mfoltz@chromium.org [Open Screen] Fix noexcept usage. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I9ca52eb146d88919fa71afd112f1206f80fc8a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533794Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=chrisha@chromium.org Bug: 1145565 Change-Id: Ib6367ca00891ceb30f937f01977cc98895fc942d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532720 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#826561}
-
Pavol Marko authored
This CL removes the encryption migration modes START_MINIMAL_MIGRATION and RESUME_MINIMAL_MIGRATION. These could only be triggered by enterprise policy which was removed in CL:2513205. Bug: 832127 Change-Id: I59be83b162a49c7437aeab321f895b80bd8de7f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512892 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826560}
-
Christopher Cameron authored
This structure should have originally been put in ui/gfx (with the rest of the gfx::ColorSpace stuff) instead of ui/gl. Bug: 1147537 Change-Id: I987c6fae136eb1c3d24dc1f5e953e14096e82d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531070Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826559}
-
Ian Wells authored
This depends on the L8 determinism fix: https://chromium-review.googlesource.com/c/chromium/src/+/2519098 Enables JDK library desugaring only for the "default" channel for now. It can be enabled globally after M88 branch. This is a reland of 8699ff59 Original change's description: > Enable JDK library desugaring by default > > Bug: 1056751 > Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817575} Bug: 1056751 Change-Id: Ib281d063b814ee629a3633868eb1efe70a153379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519888 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#826558}
-
Nina Satragno authored
Bump ServiceWorker.NotificationCloseEvent.Time histogram to M90. Fixed: 1125765 Change-Id: Ic49c555f5c96b040e0d3bb9c3055d90d16feff87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533360 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826557}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90a57536..b3e24ac9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cf7bafe09a9d4ab63a595e030cbb27d5c41590f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533633Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826556}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: Ib7b522020be7c198e405c9561376faa898e6a493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532579 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#826555}
-
Zach Trudo authored
Users want to utilize a single ReportQueue in order to send messages of varying priority. In order to support this Enqueue has been updated to receive a Priority, and Priority has been removed from ReportQueueConfiguration Bug: chromium:1146242 Change-Id: I64ebabe4fb6bb953196ec287e6ea0a5bdd05e2e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522194Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#826554}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c360709829e1..15d5965d77c5 2020-11-11 m.maiya@samsung.com Vulkan: Support VK_KHR_image_format_list for PbufferSurfaces 2020-11-11 timvp@google.com Suppress RenderbufferBlitFramebufferTest 2020-11-11 timvp@google.com Suppress VulkanPerformanceCounterTest::DepthStencilTextureClearAndLoad 2020-11-11 jmadill@chromium.org Improve stack backtraces on Linux. 2020-11-11 jmadill@chromium.org Vulkan: Enable async feature in end2end_tests. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: MultisampledRenderToTextureES3Test.RenderbufferBlitFramebufferTestTest: Test: PbufferTest.ClearAndBindTexImageSrgb*VulkanTest: Test: VulkanPerformanceCounterTest.DepthStencilTextureClearAndLoad Change-Id: Idc3ce9110dc5e309e43f85d0d7169878d62f2cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533536Reviewed-by:
-
Angela Yoeurng authored
This CL refreshes the default search engine list using data gathered in November of 2020 Bug: 888125 Change-Id: I95ea3c3701d0587f4893bc311c661c591125206b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533404Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#826552}
-
Sophie Chang authored
Change-Id: I985b9706318daf29b0d030666294d2d464046989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533733Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#826551}
-
Anne Lim authored
This reverts commit cd50c565. Reason for revert: Relanding with tests removed, as discussed offline Original change's description: > Revert "Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar"" > > This reverts commit 6e85e7a4. > > Reason for revert: crbug.com/1147678 > > Original change's description: > > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > > > This is a reland of ba7d8814. Two changes were made: > > 1) A null pointer check is added to AutofillSaveCardInfoBar.java, and > > 2) In AutofillUpstreamTest.java, startMainActivityWithURL() is replaced with loadUrl(). > > > > Original change's description: > > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > > > Screenshot with feature enabled in light mode: > > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > > > Screenshot with feature enabled in dark mode: > > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > > > Bug: 1135847, 1146186 > > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > > Commit-Queue: Anne Lim <annelim@google.com> > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > > Reviewed-by: Jared Saul <jsaul@google.com> > > > Cr-Commit-Position: refs/heads/master@{#823710} > > > > Bug: 1135847 > > Change-Id: Ifd9d514234a3af82330686373578f54ffd3427c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522219 > > Commit-Queue: Anne Lim <annelim@google.com> > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825853} > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com > > Change-Id: I09677d00d3c73763eb0c95ba56fee01bedbb149a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1135847, 1147678 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531084 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826176} TBR=treib@chromium.org,mdjones@chromium.org,wychen@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com # Not skipping CQ checks because this is a reland. Bug: 1135847 Bug: 1147678 Change-Id: I0277fa6869b760612b960b47eca7ba6114efeef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533277Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#826550}
-
- 11 Nov, 2020 11 commits
-
-
Will Harris authored
A CFG performance bug in Windows previously prevented this from being enabled, but now the bots have all been updated to a more recent version that contains a fix, this exclusion can now be removed. BUG=950923,584575 Change-Id: I8e7dcef9135991c0e5daadc4cd99bc5a062ee290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530321Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826549}
-
Tal Pressman authored
For now the listener map is only used for obtaining a RouteProvider (with a fallback to the process/thread). In the future it will also be used for routing incoming IPCs for the ASG's listeners. Bug: 1111231 Change-Id: I0a82f5681767b48751407ecbe8be7e7b6ecf506d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513958 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#826548}
-
Regan Hsu authored
* Turns strings translatable. * Adds illustrations. * Stylizations to match specs at [1]. Screenshots: * On opening dialog: https://screenshot.googleplex.com/3kHAcMC6HVcq6ZD * Connecting to phone: https://screenshot.googleplex.com/Zioip6YRZAxYVi2 * Success: https://screenshot.googleplex.com/4jasVrDUPLuXd3R * Connection lost: https://screenshot.googleplex.com/An5gNVetbDZas24 * Couldn't connect: https://screenshot.googleplex.com/75oxtiPcfRBtCCF [1] https://www.figma.com/file/HzmUezr2z1D2G63WJD9uwV/Phone-Hub-playbook?node-id=2176%3A15 Fixed: 1142971 Bug: 1106937 Change-Id: Id23fa7eb16d3d5897c244c67214c3b8d5f022503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523364 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826547}
-
Melissa Zhang authored
This CL adds grey separators to SharesheetBubbleView to align with mocks. Screenshot included in bug. Bug: 1147724 Change-Id: I50e0a2eb058ddfe2c8c1ca1b4df079d4d1aba4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532536 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#826546}
-
Tommy Li authored
In the new world where we are no longer uniquifying keywords, and instead tolerating multiple engines with the same keyword (we pretty much have to), it's more convenient for us to use an std::multimap to map keywords to engines rather than use std::map. This is to unblock a few ideas I have: - Currently, to detect conflicts between engines, we traverse through the whole list of TemplateURLs during Add() and Update(). During startup and Sync, when we are adding a bunch of these engines, that makes the whole process O(n^2). I'd like to use this multimap to remove those loops (in a future CL). - Although it SEEMS like we may no longer need to detect conflicts in the new world of tolerating conflicts, that's not true. We still want to remove replaceable conflicting engines, and so we still want to detect them. - I also hope the multimap will enable me to unify and simplify the currently complicated logic that does the removal of replaceable conflicting engines. - Finally, I think the multimap won't be expensive to retrieve the "best" engine for any given keyword, since the typical number of values we linearly go through per keyword is going to be one to three... definitely single digits. Multimaps don't sort on value. These things are going to be in followup CLs that are enabled by the multimap. See also: https://chromium-review.googlesource.com/c/chromium/src/+/2519775 Bug: 1022775 Change-Id: I631ea6c3cf442736273e23fcda15f72095dca28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530801 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Michael Bai authored
Rename EnabledOnFileMetrics to EnabledOnFileMetrics to match the finch configuration. Bug: 1076549 Change-Id: Icabaaec29c29966416bd405a21d9a8de17221bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529235 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
-
Zhaoyang Li authored
The APIs were updated to use output path but the calls were not updated and causing folder not found warnings. Update the call to fix. Added a unit test to ensure correct argument is passed in. Bug: None Change-Id: I7e8405bdf4ac61d47e78a968a25587dac28e09e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529239Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#826543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff5d8700b3a7..b776a105e531 2020-11-11 jlavrova@google.com Some testing images in Google3 look slightly different with this change. Need to change them, too. 2020-11-11 brianosman@google.com GM to test (almost) all SkSL Angle/Trigonometric intrinsics 2020-11-11 reed@google.com make quickReject treat empty rects and paths the same 2020-11-11 herb@google.com remove unused getAdvance from SkScalerContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: If7cbfba2f36aba1b5f85fc6f65cd4eb54081e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533441Reviewed-by:
-
Jinsuk Kim authored
This CL removes the dependency on ActivityTab{Provider/TabObserver} in toolbar/ package. They are replaced with a new CurrentTabObserver that works as a stop-gap solution. Bug: 1127732 Change-Id: I69e4272d38e26e70e62c31a6400859832dd70a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505297 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#826541}
-
Liquan (Max) Gu authored
Before the CL, the method "updateDetailsOnPaymentRequestUI" took "details", "rawTotal" and "rawLineItems". However, "rawTotal" and "rawLineItems" can be extracted from "details" directly. So this CL changes the method to provide only details. Also, these variables were provided by PaymentRequestSpec#getRawLineItems(), PaymentRequestSpec#getRawTotal(), and PaymentRequestSpec#getPaymentDetails() which are all expensive computation. This CL can help reducing the usage. Change-Id: I742e8493f1a3cb9b746882ff561badc656b4318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533143 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826540}
-
Kent Tamura authored
This is a reland of c0d846b5 Differences from the original CL: * The original CL had a wrong expectation file for Win7 because of win7-blink-rel bot outage. This CL removed it because 'Win' expectation is enough. Original change's description: > input[type=file]: Ignore the 'overflow' property > > For a historical reason, some form controls always clip the content, > and should ignore the 'overflow' property. File upload control NG had > a regression that it accepts overflow:visible. This CL disables it > again. The new behavior is compatible with Safari and Firefox. > > Bug: 1139629 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled > Change-Id: I6b0b5a715a2c859f195bbf2473ead67cd22bd14d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528812 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825813} Bug: 1139629 Change-Id: I9969d7263873ddf08ddcb45b3e1566e75e042924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532478 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826539}
-
