- 09 Apr, 2015 5 commits
-
-
maxbogue authored
TEST=For a manual test to exercise this code, see comment #2 in the bug. BUG=469890 Review URL: https://codereview.chromium.org/1025403002 Cr-Commit-Position: refs/heads/master@{#324316}
-
nednguyen authored
BUG=475090 Review URL: https://codereview.chromium.org/1072443004 Cr-Commit-Position: refs/heads/master@{#324315}
-
jrummell authored
BUG=353324 TEST=existing EME tests pass Review URL: https://codereview.chromium.org/1068823003 Cr-Commit-Position: refs/heads/master@{#324314}
-
majidvp authored
Wait for 'polymer-ready' event instead of hard-coded 2 seconds. Pay selector cost once to ensure iterations are only capturing the cost of hit-testing. Note that this CL is expected to reduce thread times on the dashboard. BUG=472632 Review URL: https://codereview.chromium.org/1066983002 Cr-Commit-Position: refs/heads/master@{#324313}
-
dpranke authored
This fixes a number of small issues I found while actually testing things to get it ready to run on the bots. In particular, 'mb analyze' didn't work right for GN. Tests were added. TBR=brettw@chromium.org BUG=466436 Review URL: https://codereview.chromium.org/1074583002 Cr-Commit-Position: refs/heads/master@{#324312}
-
- 08 Apr, 2015 35 commits
-
-
alexmos authored
This CLs fixes a few places in layout test code that were assuming that the top-level frame is local, which was causing renderer crashes when running a layout test containing a cross-site frame with --site-per-process. For example, most tests under http/tests/security/postMessage/ ran into this. BUG=474792 TEST=http/tests/security/postMessage/* tests don't crash with --site-per-process Review URL: https://codereview.chromium.org/1073533002 Cr-Commit-Position: refs/heads/master@{#324311}
-
reveman authored
BUG= Review URL: https://codereview.chromium.org/1068133002 Cr-Commit-Position: refs/heads/master@{#324310}
-
tfarina authored
Instead of creating it under VideoContextProvider, which makes refactoring this code harder, create it outside and pass it through parameter. This should help ease the transition of https://codereview.chromium.org/920443003. Tested on Android (with Nexus 5 device) with the following command lines: $ ./build/gyp_chromium -DOS=android -Goutput_dir=out_android $ ninja -C out_android/Debug content_unittests content_unittests_apk $ export CHROMIUM_OUT_DIR=out_android $ build/android/test_runner.py gtest -s content_unittests --debug AndroidWebView tests: $ ninja -C out_android/Debug android_webview_apk android_webview_test_apk $ build/android/adb_install_apk.py --apk=AndroidWebView.apk --debug $ build/android/test_runner.py instrumentation --test-apk=AndroidWebViewTest --test_data webview:android_webview/test/data/device_files --debug BUG=338338 TEST=see above R=boliu@chromium.org Review URL: https://codereview.chromium.org/1064263002 Cr-Commit-Position: refs/heads/master@{#324309}
-
morrita authored
ChannelMojo has ScopedIPCSupport, but it is instantiated only in in-process mode. This CL lets it always instantiate to make it clear that ChannelInfo is protected by the ScopedIPCSupport. It simplifies the relationship between the support object and the channel, and makes the lifecycle invariant reasonable. With this change, we no longer need to protect ChannelMojo with ScopedIPCSupport on its client side. Now it's built-in. Note that this is a speculative fix of fuzzer generated crash, where Mojo channel related globals are gone before when channel mojo is being destroyed. BUG=473438 R=viettrungluu@chromium.org, rockot@chromium.org Review URL: https://codereview.chromium.org/1054253005 Cr-Commit-Position: refs/heads/master@{#324308}
-
pdr authored
This is a reland of the memory perf test. R=chrishtr BUG=474768 Review URL: https://codereview.chromium.org/1066223002 Cr-Commit-Position: refs/heads/master@{#324307}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/b7133be..a0219f1 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1068343002 Cr-Commit-Position: refs/heads/master@{#324306}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/80027f9..5b9a14f TBR=cbiesinger@chromium.org,keishi@chromium.org Review URL: https://codereview.chromium.org/1073603002 Cr-Commit-Position: refs/heads/master@{#324305}
-
reillyg authored
Make these extension permission warning strings "Internet of Things" friendly be replacing the word "computer" with "device." Review URL: https://codereview.chromium.org/1063313002 Cr-Commit-Position: refs/heads/master@{#324304}
-
tengs authored
Classes now implement interfaces, so it is easier to fake/mock them. BUG=420316 TEST=unit tests pass Review URL: https://codereview.chromium.org/1066453002 Cr-Commit-Position: refs/heads/master@{#324303}
-
felt authored
A DownloadPermissionRequest may outlive its |host_|. If GetRequestingHostname is called after the |host_| is gone, it still needs to return a valid URL. This CL creates a |request_url_| member variable for DownloadPermissionRequest, so that the URL doesn't die when |host_| dies. BUG=461752 Review URL: https://codereview.chromium.org/1052273005 Cr-Commit-Position: refs/heads/master@{#324302}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c817f698..ca9f7433 Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1067163004 Cr-Commit-Position: refs/heads/master@{#324301}
-
miu authored
Removed pwestin@ and mikhal@ from OWNERS files, since they have been off the project for over a year. Review URL: https://codereview.chromium.org/1074573002 Cr-Commit-Position: refs/heads/master@{#324300}
-
oshima authored
I believe there is no good reason to allow nullptr observer, and the bug seems to be hitting this. This is to catch such bug early. BUG=471649 Review URL: https://codereview.chromium.org/1059383003 Cr-Commit-Position: refs/heads/master@{#324299}
-
jbudorick authored
BUG= Review URL: https://codereview.chromium.org/1060943002 Cr-Commit-Position: refs/heads/master@{#324298}
-
sievers authored
Instead of logging an error. Split out from https://codereview.chromium.org/1052133002 TBR=jdduke@chromium.org,michaelbai@chromium.org BUG=457406 Review URL: https://codereview.chromium.org/1068363002 Cr-Commit-Position: refs/heads/master@{#324297}
-
mbarbella authored
R=inferno@chromium.org BUG=450268 Review URL: https://codereview.chromium.org/1076453003 Cr-Commit-Position: refs/heads/master@{#324296}
-
oshima authored
BUG=475172 TBR=orenb@chromium.org Review URL: https://codereview.chromium.org/1064413004 Cr-Commit-Position: refs/heads/master@{#324295}
-
junov authored
BUG=475106 Review URL: https://codereview.chromium.org/1065353002 Cr-Commit-Position: refs/heads/master@{#324294}
-
fmeawad authored
To disable battery updates, we disable updates from usb only. But N6 devices can also charge from ac (which they do). This CL disables battery updates from ac as well. BUG=474701 Review URL: https://codereview.chromium.org/1066253003 Cr-Commit-Position: refs/heads/master@{#324293}
-
davidben authored
The old session cache assumed session IDs were unique and called into BoringSSL internals in the tests. Instead separate it into: - The session cache proper which just implements the keyed map of SSL_SESSIONs with expiration checks and size limits. This can be unit tested without using OpenSSL internals. - SSLClientSocketOpenSSL which hooks into SSL_CTX and SSL as appropriate and looks up or caches sessions. Add additional tests in SSLClientSocket tests to ensure test coverage for the latter. Note: this removes the session removal logic via SSL_CTX_set_sess_remove_cb. It was never called anyway (see https://crbug.com/466352). With that removed, the SSL_SESSION* pointer-keyed map is unnecessary and the cache can just be a base::MRUCache (which is what the original was based on anyway). BUG=454044 Review URL: https://codereview.chromium.org/994263002 Cr-Commit-Position: refs/heads/master@{#324292}
-
dpranke authored
Revert of Get gn_all/gyp_remaining working for Windows. (patchset #2 id:20001 of https://codereview.chromium.org/1064333002/) Reason for revert: Seems to have broken the Win x64 debug builder: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)/builds/7600 Original issue's description: > Get gn_all/gyp_remaining working for Windows. > > This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before. > > A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL. > > R=brettw@chromium.org > BUG=354261 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg > > Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c > Cr-Commit-Position: refs/heads/master@{#324285} TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=354261 Review URL: https://codereview.chromium.org/1071603005 Cr-Commit-Position: refs/heads/master@{#324291}
-
vmpstr authored
This patch changes the way the tiling set eviction iterators work. It mostly restructures how each phase is processed in order to allow easier changes in the future. High level summary of changes: - Create helper iterators that can process individual phases - Preprocess the order in which tilings are processed - Define explicit enums for combinations of phases, instead of an enum + flags R=enne, danakj Review URL: https://codereview.chromium.org/1038793002 Cr-Commit-Position: refs/heads/master@{#324290}
-
davidben authored
Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/40acdae..ef4962f BUG=none Review URL: https://codereview.chromium.org/1067373003 Cr-Commit-Position: refs/heads/master@{#324289}
-
jdduke authored
The browser will drop GestureFlingCancel events when it believes the renderer has no active fling animations. However, this filtering would report the event as "consumed", inadverently triggering tap suppression logic for the subsequent tap. Instead, report "no consumer exists" for the filtered GestureFlingCancel events, avoiding spurious tap suppression. BUG=474882 Review URL: https://codereview.chromium.org/1074553002 Cr-Commit-Position: refs/heads/master@{#324288}
-
rdevlin.cronin authored
The availability warning for enums isn't really that helpful, since if an enum is added somewhere, the availability warning will be on wherever it is used. BUG=474980 Review URL: https://codereview.chromium.org/1070873002 Cr-Commit-Position: refs/heads/master@{#324287}
-
dcheng authored
BUG=424436,467287 Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b Cr-Commit-Position: refs/heads/master@{#324089} Committed: https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97 Cr-Commit-Position: refs/heads/master@{#324164} Review URL: https://codereview.chromium.org/1068603002 Cr-Commit-Position: refs/heads/master@{#324286}
-
dpranke authored
This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before. A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL. R=brettw@chromium.org BUG=354261 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1064333002 Cr-Commit-Position: refs/heads/master@{#324285}
-
dmazzoni authored
The start and end callback logs were from a long time ago when those were new and not as stable. Get rid of them now. BUG=none Review URL: https://codereview.chromium.org/1062203002 Cr-Commit-Position: refs/heads/master@{#324284}
-
justincohen authored
iOS builds now default to 64-bit (codereview.chromium.org/1021513002). Bump default device to iPhone 5s, which supports 64-bit binaries. BUG=None TEST=iossim works without passing any device flags. Review URL: https://codereview.chromium.org/1070753004 Cr-Commit-Position: refs/heads/master@{#324283}
-
kelvinp authored
This CL implements remoting.MessageBox, a helper class for showing a modal dialog using remoting.setMode() and updates the corresponding call sites to use it. This enables us to show the Me2Me finish dialog from within remoting.Me2MeActivity instead of the global event handlers. In this way, we can move the reconnect after finish logic from remoting.SessionConnector into remoting.Me2MeActivity in a future CL. BUG=474840 NOTRY=true TESTS=All Remoting Webapp Unittests passes and all Chromoting integration test passes https://chromium-swarm.appspot.com/user/task/26b396ab62998910 Review URL: https://codereview.chromium.org/1066283002 Cr-Commit-Position: refs/heads/master@{#324282}
-
dcastagna authored
GpuMemoryBuffer::Format::R_8 should be used to represent textures with only one channel, the associated image should have GL_R8/GL_R8_EXT as internal format. With this CL the only implementation of GpuMemoryBuffer that supports R_8 is GLImageMemory, it expects a 4 bytes row alignment (4 is the default value for GL_PACK_ALIGNMENT). BUG= Review URL: https://codereview.chromium.org/1051503003 Cr-Commit-Position: refs/heads/master@{#324281}
-
thakis authored
BUG=none Review URL: https://codereview.chromium.org/1062363002 Cr-Commit-Position: refs/heads/master@{#324280}
-
jrummell authored
BUG=474674 Review URL: https://codereview.chromium.org/1072583002 Cr-Commit-Position: refs/heads/master@{#324279}
-
danakj authored
It's possible that DelegatedRendererLayerImpl decides to not append a quad if it's not valid. In that case it could crash trying to validate the non-existant quad. R=piman@chromium.org BUG=475099 Review URL: https://codereview.chromium.org/1072563002 Cr-Commit-Position: refs/heads/master@{#324278}
-
johannkoenig authored
Update to final v1.4.0 release https://codereview.chromium.org/1067873002 Remove webview conditional https://codereview.chromium.org/1069353002 R=tomfinegan@chromium.org Review URL: https://codereview.chromium.org/1068113002 Cr-Commit-Position: refs/heads/master@{#324277}
-